1 2012-03-20 Chong Yidong <cyd@gnu.org>
3 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4 to reflect default non-nil value of redisplay-dont-pause.
6 2012-03-19 Kenichi Handa <handa@m17n.org>
8 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
9 it fit in a valid range (Bug#11003).
11 2012-03-18 Eli Zaretskii <eliz@gnu.org>
13 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
14 that is not from display property, accept the row as a "cursor
15 row" if one of the string's character has a non-nil `cursor'
16 property. Fixes cursor positioning when there are newlines in
17 overlay strings, e.g. in icomplete.el. (Bug#11035)
19 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
21 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
23 2012-03-12 Chong Yidong <cyd@gnu.org>
25 * eval.c (inhibit_lisp_code): Rename from
26 inhibit_window_configuration_change_hook; move from window.c.
28 * xfns.c (unwind_create_frame_1, Fx_create_frame):
29 * window.c (run_window_configuration_change_hook)
30 (syms_of_window): Callers changed.
32 2012-03-11 Chong Yidong <cyd@gnu.org>
34 * keymap.c (Fkey_description): Doc fix (Bug#9700).
36 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
38 2012-03-10 Chong Yidong <cyd@gnu.org>
40 * frame.c (other_visible_frames): Don't assume the selected frame
41 is visible (Bug#10955).
43 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
45 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
47 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
49 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
50 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
53 2012-03-03 Glenn Morris <rgm@gnu.org>
55 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
57 2012-03-02 Eli Zaretskii <eliz@gnu.org>
59 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
60 position past the first glyph_row that ends at ZV. (Bug#10902)
61 (redisplay_window, next_element_from_string): Fix typos in
63 (redisplay_window): Pass to move_it_vertically the margin in
64 pixels, not in screen lines.
66 2012-03-02 Glenn Morris <rgm@gnu.org>
68 * buffer.c (buffer-list-update-hook): Doc fix.
70 2012-02-29 Eli Zaretskii <eliz@gnu.org>
72 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
73 push_it before setting up the iterator for the first overlay
74 string, even if we have an empty string loaded.
75 (next_overlay_string): If there's an empty string on the iterator
76 stack, pop the stack. (Bug#10903)
78 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
80 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
81 Suggested by Stefan Monnier in
82 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
83 * alloc.c (widen_to_Lisp_Object): New static function.
84 (mark_memory): Also mark Lisp_Objects by fetching pointer words
85 and widening them to Lisp_Objects. This would work even if
86 USE_LSB_TAG is defined and wide integers are used, which might
87 happen in a future version of Emacs.
89 2012-02-25 Chong Yidong <cyd@gnu.org>
91 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
94 * xselect.c (Fx_selection_exists_p): Doc fix.
95 (x_clipboard_manager_save_all): Print an informative message
96 before saving to clipboard manager.
98 2012-02-24 Chong Yidong <cyd@gnu.org>
100 * keyboard.c (process_special_events): Handle all X selection
101 requests in kbd_buffer, not just the next one (Bug#8869).
103 2012-02-23 Chong Yidong <cyd@gnu.org>
105 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
106 call when setting menu-bar-lines and tool-bar-lines parameters.
107 (unwind_create_frame_1): New helper function.
109 * window.c (inhibit_window_configuration_change_hook): New var.
110 (run_window_configuration_change_hook): Obey it.
111 (syms_of_window): Initialize it.
113 2012-02-22 Chong Yidong <cyd@gnu.org>
115 * xterm.c (x_draw_image_relief): Add missing type check for
116 Vtool_bar_button_margin (Bug#10743).
118 2012-02-21 Chong Yidong <cyd@gnu.org>
120 * fileio.c (Vfile_name_handler_alist): Doc fix.
122 * buffer.c (Fget_file_buffer): Protect against invalid file
123 handler return value.
125 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
127 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
128 when computing $valmask.
130 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
131 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
132 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
133 It's useless in that case, and it can cause problems on hosts
134 that allocate halves of EMACS_INT values separately.
135 Reported by Dan Horák. Diagnosed by Andreas Schwab in
136 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
137 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
138 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
139 it avoids undefined behavior on hosts where shifting right by more
140 than the word width has undefined behavior.
142 2012-02-19 Chong Yidong <cyd@gnu.org>
144 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
145 (Funhandled_file_name_directory, Ffile_name_as_directory)
146 (Fdirectory_file_name, Fexpand_file_name)
147 (Fsubstitute_in_file_name): Protect against invalid file handler
148 return values (Bug#10845).
150 2012-02-18 Eli Zaretskii <eliz@gnu.org>
152 * .gdbinit (pitx): Fix incorrect references to fields of the
155 2012-02-17 Chong Yidong <cyd@gnu.org>
157 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
159 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
161 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
162 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
164 2012-02-15 Chong Yidong <cyd@gnu.org>
166 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
167 marked as special. Also, starting docstrings with * is obsolete.
169 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
171 * gnutls.c (emacs_gnutls_write): Fix last change.
173 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
175 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
178 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
180 * keymap.c (Fsingle_key_description): Handle char ranges.
182 2012-02-12 Chong Yidong <cyd@gnu.org>
184 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
185 as that creates a dangerous corner case.
187 * window.c (Fdelete_window_internal): Invalidate the mouse
188 highlight (Bug#9904).
190 2012-02-12 Glenn Morris <rgm@gnu.org>
192 * xselect.c (Fx_own_selection_internal)
193 (Fx_get_selection_internal, Fx_disown_selection_internal)
194 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
195 * nsselect.m (Fx_own_selection_internal)
196 (Fx_disown_selection_internal, Fx_selection_exists_p)
197 (Fx_selection_owner_p, Fx_get_selection_internal):
198 Sync docs and argument specs with the xselect.c versions.
200 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
202 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
204 2012-02-11 Eli Zaretskii <eliz@gnu.org>
206 * w32select.c (Fx_selection_exists_p): Sync doc string and
207 argument list with xselect.c. (Bug#10783)
209 * w16select.c (Fx_selection_exists_p): Sync doc string and
210 argument list with xselect.c. (Bug#10783)
212 2012-02-10 Glenn Morris <rgm@gnu.org>
214 * fns.c (Fsecure_hash): Doc fix.
216 2012-02-09 Kenichi Handa <handa@m17n.org>
218 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
220 2012-02-07 Chong Yidong <cyd@gnu.org>
222 * buffer.c (Fbuffer_local_variables)
223 (buffer_lisp_local_variables): Handle unbound vars correctly;
224 don't let Qunbound leak into Lisp.
226 2012-02-07 Glenn Morris <rgm@gnu.org>
228 * image.c (Fimagemagick_types): Doc fix.
230 * image.c (imagemagick-render-type): Change it from a lisp object
231 to an integer. Move the doc here from the lisp manual.
232 Treat all values not equal to 0 the same.
234 2012-02-06 Chong Yidong <cyd@gnu.org>
236 * doc.c (store_function_docstring): Avoid applying docstring of
237 alias to base function (Bug#2603).
239 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
241 * .gdbinit (pp1, pv1): Remove redundant defines.
244 2012-02-04 Chong Yidong <cyd@gnu.org>
246 * nsterm.m: Declare a global (Bug#10694).
248 2012-02-04 Eli Zaretskii <eliz@gnu.org>
250 * w32.c (get_emacs_configuration_options):
251 Include --enable-checking, if specified, in the return value.
253 2012-02-04 Martin Rudalics <rudalics@gmx.at>
255 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
256 after rounding frame sizes. (Bug#9723)
258 2012-02-04 Eli Zaretskii <eliz@gnu.org>
260 * keyboard.c (adjust_point_for_property): Don't position point
261 before BEGV. (Bug#10696)
263 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
265 Handle overflow when computing char display width (Bug#9496).
266 * character.c (char_width): Return EMACS_INT, not int.
267 (char_width, c_string_width): Check for overflow when
268 computing the width; this is possible now that individual
269 characters can have unbounded width. Problem introduced
270 by merge from Emacs 23 on 2012-01-19.
272 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
274 * dbusbind.c (Fdbus_register_method): Mention the return value
275 :ignore in the docstring.
277 2012-02-02 Glenn Morris <rgm@gnu.org>
279 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
281 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
282 Unconditionally set to t. (Bug#10673)
283 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
284 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
285 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
287 2012-02-02 Kenichi Handa <handa@m17n.org>
289 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
290 0, do not call append_composite_glyph.
292 2012-02-02 Kenichi Handa <handa@m17n.org>
294 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
296 (x_produce_glyphs): If the component of a composition is a null
297 string, set it->pixel_width to 1 to avoid zero-width glyph.
299 2012-02-01 Eli Zaretskii <eliz@gnu.org>
301 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
302 first 2 arguments are identical. This makes inserting large
303 output from a subprocess an order of magnitude faster on
304 MS-Windows, where all sbrk'ed memory is always contiguous.
306 2012-01-31 Glenn Morris <rgm@gnu.org>
308 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
309 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
310 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
312 2012-01-29 Glenn Morris <rgm@gnu.org>
314 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
316 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
318 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
320 2012-01-28 Chong Yidong <cyd@gnu.org>
322 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
324 2012-01-26 Chong Yidong <cyd@gnu.org>
326 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
328 * search.c (Fsearch_forward, Fsearch_backward): Document negative
329 repeat counts (Bug#10507).
331 2012-01-26 Glenn Morris <rgm@gnu.org>
333 * lread.c (syms_of_lread): Doc fix.
335 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
337 * coding.c (encode_designation_at_bol): Change return value to
340 2012-01-25 Chong Yidong <cyd@gnu.org>
342 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
344 2012-01-21 Chong Yidong <cyd@gnu.org>
346 * floatfns.c (Fcopysign): Make the second argument non-optional,
347 since nil is not allowed anyway.
349 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
351 * process.c (read_process_output): Use p instead of XPROCESS (proc).
352 (send_process): Likewise.
354 2012-01-19 Martin Rudalics <rudalics@gmx.at>
356 * window.c (save_window_save, Fcurrent_window_configuration)
357 (Vwindow_persistent_parameters): Do not use Qstate.
360 2012-01-19 Kenichi Handa <handa@m17n.org>
362 * character.c (char_width): New function.
363 (Fchar_width, c_string_width, lisp_string_width):
364 Use char_width (Bug#9496).
366 2012-01-16 Martin Rudalics <rudalics@gmx.at>
368 * window.c (Vwindow_persistent_parameters): New variable.
369 (Fset_window_configuration, save_window_save): Handle persistent
372 2012-01-14 Eli Zaretskii <eliz@gnu.org>
374 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
375 thrashing the stack of the thread. (Bug#9087)
377 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
379 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
381 2012-01-11 Eli Zaretskii <eliz@gnu.org>
383 * xdisp.c (rows_from_pos_range): Handle the case where the
384 highlight ends on a newline. (Bug#10464)
385 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
386 he end column for display of highlight that ends on a newline
389 2012-01-11 Glenn Morris <rgm@gnu.org>
391 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
392 from load-path also when installation-directory is nil. (Bug#10208)
394 2012-01-10 Glenn Morris <rgm@gnu.org>
396 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
398 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
399 Update template values to be closer to their typical values these days.
401 2012-01-09 Eli Zaretskii <eliz@gnu.org>
403 * xdisp.c (rows_from_pos_range): Accept additional argument
404 DISP_STRING, and accept any glyph in a row whose object is that
405 string as eligible for mouse highlight. Fixes mouse highlight of
406 display strings from overlays. (Bug#10464)
408 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
410 emacs: fix an auto-save permissions race condition (Bug#10400)
411 * fileio.c (auto_saving_dir_umask): New static var.
412 (Fmake_directory_internal): Use it.
413 (do_auto_save_make_dir): Set it, instead of invoking chmod after
414 creating the directory. The old code temporarily assigns
415 too-generous permissions to the directory.
416 (do_auto_save_eh): Clear it.
417 (Fdo_auto_save): Catch all errors, not just file errors, so
418 that the var is always cleared.
420 2012-01-07 Eli Zaretskii <eliz@gnu.org>
422 * search.c (scan_buffer): Pass character positions to
423 know_region_cache, not byte positions. (Bug#6540)
425 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
427 * w32.c (sys_rename): Report EXDEV when rename of a directory
428 fails because the target is on another logical disk. (Bug#10284)
430 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
432 * xterm.c (x_embed_request_focus): New function.
434 * xterm.h: Add prototype.
436 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
438 2012-01-05 Glenn Morris <rgm@gnu.org>
440 * emacs.c (emacs_copyright): Update short copyright year to 2012.
442 2012-01-01 Eli Zaretskii <eliz@gnu.org>
444 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
445 Load gnutls_transport_set_lowat only if GnuTLS version is below
447 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
448 GnuTLS versions below 2.11.1.
450 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
452 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
453 to the doc string advising against its use for altering the way
454 windows are scrolled.
456 2011-12-28 Kenichi Handa <handa@m17n.org>
458 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
459 coding-system ASCII compatible only when it does not produce BOM
460 on encoding (Bug#10383).
462 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
464 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
466 (create_and_show_popup_menu): Always use menu_position_func for
469 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
471 * callint.c (Fcall_interactively): Don't truncate prompt string.
473 2011-12-23 Eli Zaretskii <eliz@gnu.org>
475 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
476 property that ends at ZV, so that the bidi iteration could be
477 resumed from there (after widening). (Bug#10360)
479 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
481 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
483 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
485 * nsterm.m (x_free_frame_resources):
486 Release f->output_data.ns->miniimage.
487 (ns_index_color): Fix indentation. Do not retain
488 color_table->colors[i].
490 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
493 * nsfns.m (x_set_background_color): Assign return value from
494 ns_index_color to face-background instead of NSColor*.
495 (ns_implicitly_set_icon_type): Fix indentation.
496 Change assignment in for loop to comparison.
498 * emacs.c (ns_pool): New variable.
499 (main): Assign ns_pool.
500 (Fkill_emacs): Call ns_release_autorelease_pool.
502 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
503 autorelease fdesc, release fdAttrs and tdict.
504 (ns_get_covering_families): Release charset.
505 (ns_findfonts): Release NSFontDescriptor created with new.
506 (ns_uni_to_glyphs): Fix indentation.
507 (setString): Release attrStr before assigning new value.
509 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
511 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
513 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
514 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
516 2011-12-18 David Reitter <reitter@cmu.edu>
518 * nsterm.m (ns_term_init): Subscribe for notifications
519 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
520 to method trackingNotification in EmacsMenu.
522 * nsmenu.m (trackingMenu): New variable.
523 (trackingNotification): New method (from Aquamacs).
524 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
525 from Aquamacs (Bug#7030).
527 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
529 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
530 (symbol_to_nsstring): Fix indentation.
531 (ns_symbol_to_pb): New function.
532 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
533 (Fns_rotate_cut_buffers_internal): Remove.
534 (Fns_store_selection_internal): Rename from
535 Fns_store_cut_buffer_internal.
536 (ns_get_foreign_selection, Fx_own_selection_internal)
537 (Fx_disown_selection_internal, Fx_selection_exists_p)
538 (Fns_get_selection_internal, Fns_store_selection_internal):
539 Use ns_symbol_to_pb and check if return value is nil.
540 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
541 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
542 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
543 renamed to Sns_store_selection_internal.
544 (ns_handle_selection_request): Move code to Fx_own_selection_internal
545 and remove this function.
546 (ns_handle_selection_clear): Remove, never used.
547 (Fx_own_selection_internal): Move code from ns_handle_selection_request
550 2011-12-17 Ken Brown <kbrown@cornell.edu>
552 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
553 GID is unknown (Bug#10257).
555 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
557 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
558 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
559 which caused a build failure on GNU/Linux IA-64. This problem was
560 introduced by my 2011-10-07 patch.
562 2011-12-15 Juri Linkov <juri@jurta.org>
564 * image.c (imagemagick_error): New function. (Bug#10112)
565 (imagemagick_load_image): Comment out `MagickSetResolution' call.
566 Use `imagemagick_error' where ImageMagick functions return
568 (Fimagemagick_types): Add `Fnreverse' to return the list in the
571 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
573 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
574 fill background (Bug#8992).
576 2011-12-13 Martin Rudalics <rudalics@gmx.at>
578 * window.c (Vwindow_combination_resize)
579 (Vwindow_combination_limit): Use t instead of non-nil in
581 (Vrecenter_redisplay): Add first sentence of doc-string on
583 (Frecenter): Fix doc-string typo.
585 2011-12-11 Kenichi Handa <handa@m17n.org>
587 * coding.c (Funencodable_char_position): Pay attention to the
588 buffer text relocation (Bug#9389).
590 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
592 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
593 gtk_init (Bug#10100).
595 2011-12-10 Eli Zaretskii <eliz@gnu.org>
597 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
598 IT->string is nil. (Bug#10263)
600 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
602 * nsterm.h (x_free_frame_resources): Declare.
604 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
605 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
607 * nsterm.h (ns_get_defaults_value): Declare.
609 * nsterm.m (ns_default): Call ns_get_defaults_value.
611 2011-12-09 Eli Zaretskii <eliz@gnu.org>
613 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
616 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
618 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
619 that where the value of an _OBJC_* symbol points to is in the .bss
622 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
624 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
625 after the loop to call ccl_driver at least once (Bug#8619).
627 2011-12-08 Kenichi Handa <handa@m17n.org>
629 * ftfont.c (get_adstyle_property): Fix previous change
632 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
634 * w32.c (init_environment): If no_site_lisp, remove site-lisp
635 dirs from the default value of EMACSLOADPATH (bug#10208).
637 2011-12-07 Glenn Morris <rgm@gnu.org>
639 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
640 installation and source directories as well. (Bug#10208)
642 2011-12-06 Chong Yidong <cyd@gnu.org>
644 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
646 2011-12-06 Glenn Morris <rgm@gnu.org>
648 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
649 as an error, not just -1. (Bug#10217)
651 2011-12-05 Chong Yidong <cyd@gnu.org>
653 * keyboard.c (process_special_events): New function.
654 (swallow_events, Finput_pending_p): Use it (Bug#10195).
656 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
658 * coding.c (encode_designation_at_bol): Don't use uninitialized
659 local variable (Bug#9318).
661 2011-12-05 Kenichi Handa <handa@m17n.org>
663 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
664 return Qnil (Bug#8046, Bug#10193).
666 2011-12-05 Kenichi Handa <handa@m17n.org>
668 * coding.c (encode_designation_at_bol): New args charbuf_end and
669 dst. Return the number of produced bytes. Callers changed.
670 (coding_set_source): Return how many bytes coding->source was
672 (coding_set_destination): Return how many bytes
673 coding->destination was relocated.
674 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
675 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
677 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
679 * coding.c (CODING_CHAR_CHARSET_P): New macro.
680 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
683 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
685 The following changes are to fix Bug#9318.
687 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
688 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
689 (encode_coding_iso_2022, encode_coding_sjis)
690 (encode_coding_big5, encode_coding_charset): Use the above macros.
692 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
694 * lisp.h (process_quit_flag): Fix external declaration.
696 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
698 Don't macro-inline non-performance-critical code.
699 * eval.c (process_quit_flag): New function.
700 * lisp.h (QUIT): Use it.
702 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
704 * nsfns.m (get_geometry_from_preferences): New function.
705 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
707 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
709 * emacs.c (Qkill_emacs): Define.
710 (syms_of_emacs): Initialize it.
711 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
712 Qquit_flag to `kill-emacs' instead.
713 (quit_throw_to_read_char): Add parameter `from_signal'.
714 All callers changed. Call Fkill_emacs if requested and safe.
715 * lisp.h (QUIT): Call Fkill_emacs if requested.
717 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
719 * widget.c (update_wm_hints): Return if wmshell is null.
720 (widget_update_wm_size_hints): New function.
722 * widget.h (widget_update_wm_size_hints): Declare.
724 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
725 widget_update_wm_size_hints (Bug#10104).
727 2011-12-03 Eli Zaretskii <eliz@gnu.org>
729 * xdisp.c (handle_invisible_prop): If the invisible text ends just
730 before a newline, prepare the bidi iterator for consuming the
731 newline, and keep the current paragraph direction. (Bug#10183)
732 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
734 2011-12-02 Juri Linkov <juri@jurta.org>
736 * search.c (Fword_search_regexp): New Lisp function created from
737 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
738 (Fword_search_backward, Fword_search_forward)
739 (Fword_search_backward_lax, Fword_search_forward_lax):
740 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
741 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
743 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
745 * fileio.c (Finsert_file_contents): Move after-change-function call
746 to before the "handled:" label, since all "goto handled" appear in
747 cases where the *-change-functions have already been properly called
750 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
752 * keyboard.c (interrupt_signal): Don't call kill-emacs when
753 waiting for input. (Bug#10169)
755 2011-11-30 Eli Zaretskii <eliz@gnu.org>
757 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
758 verifies glyph row's hash code--we have just reallocated the
759 glyphs, so their contents can be complete garbage. (Bug#10164)
761 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
763 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
765 2011-11-30 Eli Zaretskii <eliz@gnu.org>
767 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
768 attributes are tested _before_ calling verify_row_hash, to protect
769 against GCC re-ordering of the tests. (Bug#10164)
771 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
773 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
775 * xterm.c (handle_one_xevent): Only set async_visible and friends
776 if net_wm_state_hidden_seen is non-zero (Bug#10002)
777 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
778 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
780 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
782 Remove GCPRO-related macros that exist only to avoid shadowing locals.
783 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
784 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
785 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
786 All uses changed to use GCPRO1 etc.
787 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
788 Revert to old implementation (i.e., before 2011-03-11).
790 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
792 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
793 of scroll runs so as to avoid assigning disabled bogus rows and
794 unnecessary graphics copy operations.
796 2011-11-27 Eli Zaretskii <eliz@gnu.org>
798 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
799 (snprintf) [_MSC_VER]: Redirect to _snprintf.
800 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
801 (malloc, free, realloc, calloc): Redirect to e_* only when
804 * lisp.h (GCTYPEBITS): Move before first use.
805 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
806 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
807 this macro definition.
809 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
812 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
814 * gtkutil.c (xg_create_frame_widgets):
815 Call gtk_window_set_has_resize_grip (FALSE) if that function is
816 present with Gtk+ 2.0.
818 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
820 * fileio.c (Finsert_file_contents): Undo previous change; see
821 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
823 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
825 Rename locals to avoid shadowing.
826 * fileio.c (Finsert_file_contents):
827 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
828 * process.c (wait_reading_process_output):
829 Rename inner 'proc' to 'p' to avoid shadowing.
830 Indent for consistency with usual Emacs style.
832 2011-11-25 Eli Zaretskii <eliz@gnu.org>
834 * xdisp.c (redisplay_window): If cursor row is not fully visible
835 after recentering, and scroll-conservatively is set to a large
836 number, scroll window by a few more lines to make the cursor fully
837 visible and out of scroll-margin. (Bug#10105)
838 (start_display): Don't move to the next line if the display should
839 start at a newline that is part of a display vector or an overlay
842 2011-11-24 Juri Linkov <juri@jurta.org>
844 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
845 after the `MagickPingImage' call. (Bug#10112)
847 2011-11-23 Chong Yidong <cyd@gnu.org>
849 * window.c (Fcoordinates_in_window_p): Accept only live windows.
851 2011-11-23 Martin Rudalics <rudalics@gmx.at>
853 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
854 making another buffer current. (Bug#10114)
856 2011-11-23 Glenn Morris <rgm@gnu.org>
858 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
860 2011-11-23 Chong Yidong <cyd@gnu.org>
862 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
865 2011-11-22 Eli Zaretskii <eliz@gnu.org>
867 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
868 and header-lines, as they don't have one computed for them.
871 * .gdbinit (prow): Make displayed values more self-explaining.
874 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
876 * process.c (wait_reading_process_output): Fix asynchrounous
877 GnuTLS socket handling on some versions of the GnuTLS library.
878 (wait_reading_process_output): Add comment and URL.
880 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
882 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
884 2011-11-21 Chong Yidong <cyd@gnu.org>
886 * window.c (Fnext_window, Fprevious_window): Doc fix.
888 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
890 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
892 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
894 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
896 2011-11-20 Martin Rudalics <rudalics@gmx.at>
898 * window.c (Fset_window_combination_limit): Rename argument
900 (Vwindow_combination_limit): Remove "status" from doc-string.
902 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
904 * m/ibms390.h: Remove.
905 * m/ibms390x.h: Don't include "ibms390.h".
907 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
909 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
910 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
912 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
914 * casetab.c (Fset_case_table):
915 * charset.c (Fcharset_after): Fix typos.
917 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
919 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
920 Otherwise, valgrind does not work on some platforms.
921 Problem reported by Andreas Schwab in
922 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
923 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
924 is set, removing the need for VIRT_ADDRESS_VARIES.
925 (PURE_P): Use a more-efficient implementation that needs just one
926 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
927 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
928 to 4 (xorl, subq, cmpq, setbe).
929 * alloc.c (pure): Always extern now, since that's the
930 VIRT_ADDR_VARIES behavior.
931 (PURE_POINTER_P): Use a single comparison, not two, for
932 consistency with the new puresize.h.
933 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
934 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
935 Remove VIRT_ADDR_VARIES no longer needed.
937 2011-11-19 Eli Zaretskii <eliz@gnu.org>
939 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
940 (erase_phys_cursor, update_window_cursor, show_mouse_face)
941 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
942 behave as if the cursor position were at the window margin.
944 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
945 and the cursor position is out of bounds, behave as if the cursor
946 position were at the window margin. (Bug#10075)
948 2011-11-18 Chong Yidong <cyd@gnu.org>
950 * window.c (Fwindow_combination_limit): Make first argument
951 non-optional, since it is meaningless for live windows like the
954 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
956 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
958 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
960 * intervals.c: Fix grafting over the whole buffer (bug#10071).
961 (graft_intervals_into_buffer): Simplify.
963 2011-11-18 Eli Zaretskii <eliz@gnu.org>
965 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
966 hash values of the two rows.
967 (copy_row_except_pointers): Preserve the used[] arrays and the
968 hash values of the two rows. (Bug#10035)
969 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
971 * xdisp.c (row_hash): New function, body extracted from
972 compute_line_metrics.
973 (compute_line_metrics): Call row_hash, instead of computing the
976 * dispnew.c (verify_row_hash): Call row_hash for computing the
977 hash code of a row, instead of duplicating code from xdisp.c.
979 * dispextern.h (row_hash): Add prototype.
981 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
983 * frame.c (delete_frame): Don't delete the terminal when the last
984 X frame is closed if emacs is built with GTK toolkit.
986 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
988 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
990 2011-11-17 Martin Rudalics <rudalics@gmx.at>
992 * window.c (Vwindow_splits): Rename to
993 Vwindow_combination_resize. Suggested by Juri Linkov.
994 (Fsplit_window_internal): Use Vwindow_combination_resize instead
997 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
999 * nsfns.m (Fns_font_name):
1000 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1002 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1004 * window.h (window): Rename slot "nest" to "combination_limit".
1005 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1006 (Fset_window_nest): Rename to Fset_window_combination_limit.
1007 (Vwindow_nest): Rename to Vwindow_combination_limit.
1008 (recombine_windows, make_parent_window, make_window)
1009 (Fsplit_window_internal, saved_window)
1010 (Fset_window_configuration, save_window_save): Rename all
1011 occurrences of window_nest to window_combination_limit.
1013 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1015 * image.c (imagemagick_load_image): Fix typo.
1017 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1019 * xdisp.c (display_line): Move the call to
1020 highlight_trailing_whitespace before the call to
1021 compute_line_metrics, since the latter needs to see the final
1022 faces of all the glyphs to compute ROW's hash value.
1023 Fixes assertion violations in row_equal_p. (Bug#10035)
1025 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1027 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1028 just return (bug#10044).
1030 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1032 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1033 with user-defined heap size. Bump the default size of the temacs
1034 heap to 27MB, to avoid memory warning when running temacs.
1035 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1037 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1038 current_matrix and desired_matrix. (Bug#9990)
1039 (verify_row_hash) [XASSERTS]: New function.
1040 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1041 that the hash value of glyph rows is correct.
1043 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1045 * window.h (window): Remove splits slot.
1046 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1047 (Fdelete_other_windows_internal, make_parent_window)
1048 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1049 (Fset_window_configuration, save_window_save): Don't deal with
1050 split status of windows.
1051 (saved_window): Remove splits slot.
1052 (Vwindow_splits): Rewrite doc-string.
1054 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1056 * xfns.c (unwind_create_frame):
1057 * nsfns.m (unwind_create_frame):
1058 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1059 Vframe_list (Bug#9999).
1061 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1063 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1065 2011-11-11 Kenichi Handa <handa@m17n.org>
1067 * callproc.c (Fcall_process): Set the member dst_multibyte of
1070 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1072 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1073 avoid a crash (bug#9496).
1075 2011-11-09 Chong Yidong <cyd@gnu.org>
1077 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1078 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1080 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1082 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1084 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1086 Avoid some portability problems by eschewing 'extern inline' functions.
1087 The trivial performance wins aren't worth the portability hassles; see
1088 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1090 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1091 (window_box_width, window_box_left, window_box_left_offset)
1092 (window_box_right, window_box_right_offset): Undo previous change,
1093 by removing the "extern"s.
1094 * intervals.c (adjust_intervals_for_insertion)
1095 (adjust_intervals_for_deletion): Undo previous change,
1096 making these static again.
1097 (offset_intervals, temp_set_point_both, temp_set_point)
1098 (copy_intervals_to_string): No longer inline.
1099 * xdisp.c (window_text_bottom_y, window_box_width)
1100 (window_box_height, window_box_left_offset)
1101 (window_box_right_offset, window_box_left, window_box_right)
1102 (window_box): No longer inline.
1104 2011-11-08 Chong Yidong <cyd@gnu.org>
1106 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1107 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1108 Signal an error if not a live window.
1109 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1110 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1112 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1114 * lisp.h (syms_of_abbrev): Remove declaration.
1115 Reported by CHENG Gao <chenggao@royau.me>.
1117 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1119 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1120 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1121 of temacs in GUI mode.
1123 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1125 * window.h: Declare delete_all_child_windows instead of
1126 delete_all_subwindows.
1127 * window.c (Fwindow_nest, Fset_window_nest)
1128 (Fset_window_new_total, Fset_window_new_normal)
1129 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1130 (delete_all_subwindows): Rename to delete_all_child_windows.
1131 (Fdelete_other_windows_internal, Fset_window_configuration):
1132 Call delete_all_child_windows instead of delete_all_subwindows.
1133 * frame.c (delete_frame): Call delete_all_child_windows instead
1134 of delete_all_subwindows.
1136 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1138 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1139 This is also needed for porting to any host where GC_MARK_STACK is
1140 not GC_MAKE_GCPROS_NOOPS.
1141 (which_symbols): Use it.
1143 2011-11-07 Kenichi Handa <handa@m17n.org>
1145 * coding.c (coding_set_destination): Check coding->src_pos only
1146 when coding->src_object is a buffer (bug#9910).
1148 * process.c (send_process): Set the member src_multibyte of coding
1149 to 0 (bug#9911) when sending a unibyte text.
1151 * callproc.c (Fcall_process): Set the member src_multibyte of
1152 process_coding to 0 (bug#9912).
1154 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1156 * xmenu.c (cleanup_widget_value_tree): New function.
1157 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1158 calling free_menubar_widget_value_tree directly (Bug#9830).
1160 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1162 Fix some portability problems with 'inline'.
1163 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1164 (window_box_width, window_box_left, window_box_left_offset)
1165 (window_box_right, window_box_right_offset): Declare extern.
1166 Otherwise, these inline functions do not conform to C99 and
1167 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1168 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1169 * intervals.c (adjust_intervals_for_insertion)
1170 (adjust_intervals_for_deletion): Now extern, because otherwise the
1171 extern inline functions 'offset_intervals' couldn't refer to it.
1172 (static_offset_intervals): Remove.
1173 (offset_intervals): Rewrite using the old contents of
1174 static_offset_intervals. The old version didn't conform to C99
1175 because an extern inline function contained a reference to an
1176 identifier with static linkage.
1178 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1180 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1183 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1185 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1186 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1187 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1188 return Qleft_to_right.
1190 2011-11-06 Chong Yidong <cyd@gnu.org>
1192 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1193 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1194 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1195 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1196 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1197 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1198 (Fwindow_vscroll): Doc fix.
1199 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1200 argument, since it makes no sense to pass a live window and for
1201 consistency with window-child.
1203 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1205 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1208 2011-11-05 Jason Rumney <jasonr@gnu.org>
1210 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1211 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1213 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1214 bitwise arithmetic preventing use of unicode-sip and non-truetype
1217 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1219 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1222 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1223 initialization code to keep similarity to xfns.c after changes
1226 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1228 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1229 (unwind_create_frame): New function (Bug#9943).
1230 (Fx_create_frame): Restructure code to be more similar to the one in
1231 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1232 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1233 Move terminal->reference_count++ just before making the frame official
1236 * nsterm.m (x_free_frame_resources): New function.
1237 (x_destroy_window): Move code to x_free_frame_resources.
1239 * xfns.c (unwind_create_frame): Fix comment.
1240 (Fx_create_frame, x_create_tip_frame):
1241 Move terminal->reference_count++ just before making the frame
1242 official. Move initialization of image_cache_refcount and
1243 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1245 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1247 Support MSVC build with newer versions of Visual Studio.
1248 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1249 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1252 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1253 which are not supported by MSVC.
1254 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1255 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1257 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1259 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1261 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1263 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1265 Support MSVC build with newer versions of Visual Studio.
1266 * w32.c: Don't include w32api.h for MSVC.
1267 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1269 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1270 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1271 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1272 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1274 (alloca) [_MSC_VER]: Define to _alloca.
1276 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1278 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1280 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1282 * xdisp.c (note_mouse_highlight): If either of
1283 previous/next-single-property-change returns nil, treat that as
1284 the beginning or the end of the buffer. (Bug#9955)
1286 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1288 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1289 label is not null (Bug#9951).
1290 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1293 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1295 * window.c (Fwindow_body_size): Mention in the doc string that the
1296 return value is in frame's canonical units. (Bug#9949)
1298 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1300 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1302 * w32fns.c (unwind_create_frame): If needed, free the glyph
1303 matrices of the partially constructed frame. (Bug#9943)
1304 * xfns.c (unwind_create_frame): Likewise.
1306 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1308 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1309 Don't stop backward scan on the continuation glyph, even though
1310 its CHARPOS is positive.
1311 (mouse_face_from_buffer_pos, note_mouse_highlight):
1312 Rename cover_string to disp_string.
1314 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1316 * window.c (temp_output_buffer_show): Don't use
1317 Vtemp_buffer_show_specifiers.
1318 (Vtemp_buffer_show_specifiers): Remove unused variable.
1320 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1322 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1323 past the beginning of the current glyph matrix.
1325 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1327 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1328 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1329 HAVE_GTK3 (Bug#9869).
1331 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1332 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1334 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1336 * xterm.c: Declare x_handle_net_wm_state to return int.
1337 (handle_one_xevent): Check if we are iconified but don't have
1338 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1339 (get_current_wm_state): Return non-zero if not hidden,
1340 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1341 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1342 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1343 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1345 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1347 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1348 so that this new function doesn't get optimized away by a
1349 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1351 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1353 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1355 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1357 Fix the `xbytecode' command.
1358 * .gdbinit (xprintbytestr): New command.
1359 (xwhichsymbols): Rename from `which'; all callers changed.
1360 (xbytecode): Print the byte-code string as well.
1362 2011-10-29 Kim Storm <storm@cua.dk>
1364 * alloc.c (which_symbols): New function.
1366 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1368 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1371 2011-10-29 Glenn Morris <rgm@gnu.org>
1373 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1374 Not clear what it was for, and it causes various bugs. (Bug#9839)
1376 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1378 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1379 possible random value that matches one of those tested as
1380 condition to clear the mouse face.
1382 2011-10-28 Chong Yidong <cyd@gnu.org>
1384 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1386 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1388 * window.c (make_window): Initialize phys_cursor_on_p.
1390 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1392 * lisp.h (struct Lisp_Symbol): Update comments.
1394 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1396 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1398 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1400 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1401 <oslsachem@gmail.com> for helping to debug this.
1403 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1404 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1405 (g_b_init_get_glyph_outline_w): New static variables.
1406 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1407 (GetGlyphOutlineW_Proc): New typedefs.
1408 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1409 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1411 (w32font_open_internal, compute_metrics):
1412 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1413 instead of calling the "wide" APIs directly.
1415 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1417 * w32.h (syms_of_w32font): Add prototype.
1419 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1421 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1422 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1423 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1424 (Fmove_to_window_line): Doc fix.
1426 2011-10-27 Chong Yidong <cyd@gnu.org>
1428 * process.c (make_process): Set gnutls_state to NULL.
1430 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1431 non-NULL, regardless of GNUTLS_INITSTAGE.
1432 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1433 an error. Set process slots as soon as we allocate them.
1435 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1437 2011-10-27 Chong Yidong <cyd@gnu.org>
1439 * gnutls.c (emacs_gnutls_deinit): New function.
1440 Deallocate credentials structures as well as calling gnutls_deinit.
1441 (Fgnutls_deinit, Fgnutls_boot): Use it.
1443 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1444 (deactivate_process): Call emacs_gnutls_deinit.
1446 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1448 * image.c (x_create_x_image_and_pixmap):
1449 * w32.c (sys_rename, w32_delayed_load):
1450 * w32font.c (fill_in_logfont):
1451 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1453 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1455 * w32fns.c (w32_default_color_map): New function,
1456 extracted from Fw32_default_color_map.
1457 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1459 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1461 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1463 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1465 * keyboard.c (test_undefined): New function (bug#9751).
1466 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1468 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1470 * sysdep.c (init_sys_modes): Fix the check for the controlling
1471 terminal (Bug#6649).
1473 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1475 * dispextern.h (struct bidi_it): New member next_en_type.
1477 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1478 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1479 current character, check also for next_en_type being WEAK_EN.
1480 (bidi_resolve_weak): Don't enter the expensive loop if the current
1481 position is before next_en_pos. Record the bidi type of the first
1482 non-ET, non-BN character we find, in addition to its position.
1483 (bidi_level_of_next_char): Invalidate next_en_type when
1484 next_en_pos is over-stepped.
1486 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1488 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1489 * editfns.c: Rewrite current-time-zone so that it invokes
1490 the equivalent of (format-time-string "%Z") to get the time zone name.
1491 This fixes a bug when the time zone name contains characters that
1492 need converting from the system time locale to Emacs internal format.
1493 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1494 that patch fixed format-time-string to do the conversion, but
1495 I forgot to fix current-time-zone.
1496 (format_time_string): New function, containing most of
1497 what Fformat_time_string used to contain.
1498 (Fformat_time_string): Rewrite in terms of format_time_string.
1499 This doesn't change this function's behavior.
1500 (current-time-zone): Rewrite to use format_time_string.
1501 This fixes the bug reported by Michael Schierl in
1502 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1503 Jason Rumney's 2007-06-07 change worked around this bug, but
1505 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1507 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1509 * xdisp.c (start_display): If the character at POS is displayed
1510 via a display vector, reset IT->current.dpvec_index to zero.
1511 (try_window_reusing_current_matrix): If a line ends in a display
1512 vector or the next line starts in a display vector, continue
1513 redrawing the window even though the character position of
1514 start_row was reached.
1517 2011-10-18 Chong Yidong <cyd@gnu.org>
1519 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1520 with nobreak-char-display too.
1522 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1524 Fix part 3 of bug#9771.
1525 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1526 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1527 non-neutral characters if the current character is a paragraph
1528 separator (a.k.a. Newline). This avoids running the same
1529 expensive loop twice, once when we consume the preceding newline
1530 and the other time when the line actually needs to be displayed.
1531 Avoid the loop when we see neutrals on the base embedding level
1532 following a character whose directionality is the same as the
1533 paragraph's. This avoids running the expensive loop when a line
1534 ends in a long sequence of neutrals, like control characters.
1535 Add assertion against STRONG_AL type. Slightly rearrange code
1536 that determines the type of a neutral given the first non-neutral
1538 (bidi_level_of_next_char): Set next_en_pos to zero when
1539 invalidating its info.
1541 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1543 * xdisp.c (push_display_prop): Determine whether to record string
1544 or buffer position by IT->string, not by IT->method. Allow
1545 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1546 (move_it_vertically_backward): Don't look for character position
1547 immediately after the newline when in a continuation line.
1550 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1552 * window.c (coordinates_in_window): Rewrite and delabelize
1553 vertical border check. (Bug#5357) (Bug#9618)
1555 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1557 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1558 errors in XSetWindowBorder (bug#9310).
1560 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1562 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1563 avoid crash when xmalloc overrun checking is enabled.
1565 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1567 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1568 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1569 cursor motion with <left> and <right> arrow keys.
1571 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1572 some callers set that themselves.
1574 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1576 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1577 display string and the previous row comes from the same string and
1578 is empty. (Bug#9739) (Bug#9738)
1580 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1582 * doc.c (get_doc_string): Encode file name (bug#9735).
1584 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1586 * bidi.c (bidi_level_of_next_char):
1587 * xdisp.c (get_visually_first_element): Remove old incorrect
1588 comments regarding the Unicode Line Separator character.
1590 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1592 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1594 * alloc.c (Fgc_status): Do not access beyond zombies array
1595 boundary if nzombies > MAX_ZOMBIES.
1596 * alloc.c (dump_zombies): Add missing format specifier.
1598 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1600 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1601 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1603 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1604 Some packages use them to denote characters with modifiers.
1606 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1608 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1609 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1610 matching a pp-number. Rename parameter var to var1.
1612 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1614 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1616 2011-10-08 Glenn Morris <rgm@gnu.org>
1618 * callint.c (Fcall_interactively): Give a more explicit error for the
1619 'c' case with a non-character input. (Bug#8479)
1621 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1623 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1625 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1626 lines that are hscrolled on the left.
1628 * dispnew.c (buffer_posn_from_coords): Account for a possible
1629 presence of header-line. (Bug#4426)
1631 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1633 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1634 Don't advertise functionality which we discourage or doesn't work.
1636 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1638 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1639 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1640 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1641 this makes Emacs dump core during garbage collection on rare
1642 occasions. sizeof is obviously inferior to offsetof here, so
1643 stick with offsetof.
1644 (GC_POINTER_ALIGNMENT): New macro.
1645 (mark_memory): Omit 3rd (offset) arg; caller changed.
1646 Don't assume EMACS_INT alignment is the same as pointer alignment.
1648 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1650 * keyboard.c (read_key_sequence_remapped): New var.
1651 (read_key_sequence): Compute remapping in the right buffer.
1652 (command_loop_1): Use read_key_sequence's remapping directly.
1654 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1656 * dired.c (file_name_completion): Don't expand file name.
1657 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1658 before checking file name handler.
1660 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1661 they've been requested explicitly (bug#9591).
1663 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1665 * keymap.c (Fsingle_key_description): Use make_specified_string
1666 instead of build_string to build string from push_key_description.
1669 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1671 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1672 This fixes a Y2038 bug on 64-bit hosts.
1673 * buffer.c (reset_buffer):
1674 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1675 (Fclear_buffer_auto_save_failure):
1676 Use 0, not -1, to represent an unset failure time, since time_t
1677 might not be signed.
1679 Remove dependency on glibc malloc internals.
1680 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1681 Move back here from lisp.h, but with their new implementations.
1682 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1683 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1684 * charset.c (charset_table_init): New static var.
1685 (syms_of_charset): Use it instead of xmalloc. This removes a
1686 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1687 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1688 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1689 Move back to alloc.c.
1690 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1691 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1693 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1695 * nsterm.m (windowDidResize): Call x_set_window_size only when
1696 ns_in_resize is true. Otherwise set pixelwidth/height and
1697 call change_frame_size (Bug#9628).
1699 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1701 Port --enable-checking=all to Fedora 14 x86-64.
1702 * charset.c (syms_of_charset): Also account for glibc malloc's
1703 internal overhead when calculating the initial malloc maximum.
1705 Port --enable-checking=all to Fedora 14 x86.
1706 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1708 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1709 (overrun_check_realloc, overrun_check_free):
1710 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1711 That way, xmalloc returns a properly-aligned pointer even if
1712 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1713 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1714 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1715 into account when calculating the initial malloc maximum.
1716 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1717 Move here from alloc.c, so that charset.c can use it too.
1718 Properly align; the old code wasn't right for common 32-bit hosts
1719 when configured with --enable-checking=all.
1720 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1721 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1723 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1725 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1728 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1730 * xdisp.c (compute_display_string_end): If there's no display
1731 string at CHARPOS, return -1.
1733 * bidi.c (bidi_fetch_char): When compute_display_string_end
1734 returns a negative value, treat the character as a normal
1735 character not covered by a display string. (Bug#9624)
1737 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1739 * lread.c (Fread_from_string): Fix typo in docstring.
1741 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1743 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1744 newline, reseat the iterator instead of bidi-iterating there one
1745 character at a time. (Bug#9610)
1746 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1747 TO_CHARPOS if the bidi iterator is at base embedding level.
1749 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1751 * lread.c (readevalloop): Use correct code for NBSP.
1752 (read1): Likewise. (Bug#9608)
1754 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1756 * dbusbind.c (Fdbus_register_signal): When service is not
1757 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1759 2011-09-25 Glenn Morris <rgm@gnu.org>
1761 * buffer.c (truncate-lines): Doc fix.
1763 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1765 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1766 (Fset_window_next_buffers): Doc fix.
1768 2011-09-24 Glenn Morris <rgm@gnu.org>
1770 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1772 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1774 Fix minor problems found by static checking.
1775 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1776 * indent.c (Fvertical_motion): Fix == vs = typo.
1778 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1780 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1781 Default value is now t. Doc fix.
1783 * indent.c (Fvertical_motion): Compute and apply the overshoot
1784 logic when moving up, not only when moving down. Fix the
1785 confusing name and values of the it_overshoot_expected variable;
1786 logic changes accordingly. (Bug#9254) (Bug#9549)
1788 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1789 CHARPOS is covered by a display string which includes newlines.
1790 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1791 is covered by a display string with embedded newlines.
1793 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1795 * dbusbind.c (Fdbus_register_signal): Add match rule to
1796 Vdbus_registered_objects_table. (Bug#9581)
1797 (Fdbus_register_method, Vdbus_registered_objects_table):
1800 2011-09-24 Jim Meyering <meyering@redhat.com>
1802 do not ignore write error for any output size
1803 The previous change was incomplete.
1804 While it makes emacs --batch detect the vast majority of stdout
1805 write failures, errors were still ignored whenever the output size is
1806 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1807 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1808 && echo FAIL: ignored write error
1809 FAIL: ignored write error
1810 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1811 && echo FAIL: ignored write error
1812 FAIL: ignored write error
1813 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1815 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1817 * emacs.c (Fkill_emacs): In noninteractive mode exit
1818 non-successfully if a write error occurred on stdout. (Bug#9574)
1820 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1822 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1825 * dispextern.h (struct it): Update the comment documenting what
1828 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1830 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1831 a display string, extend search for cursor position to end of row.
1832 (find_row_edges): If the row ends in a newline from a display
1833 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1834 Handle the case of a display string with multiple newlines.
1835 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1836 non-empty line. Fixes confusing cursor motion with arrow keys at
1837 the beginning of a line that starts with whitespace.
1839 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1841 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1844 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1846 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1849 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1851 * xdisp.c (display_line): Record maximum and minimum buffer
1852 positions even if no glyphs were produced (e.g., by a zero-width
1853 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1854 buffer positions that will be removed from the glyph row because
1856 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1857 column is beyond frame width: don't subtract 1 "pixel" when
1858 computing width of the stretch.
1859 (reseat_at_next_visible_line_start): Undo the change made on
1860 2011-09-17 that saved paragraph information and restored it after
1861 the call to `reseat'. (Bug#9545)
1863 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1865 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1866 and turn window cursor on if cleared (Bug#9415).
1868 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1870 * search.c (boyer_moore): Take unibyte characters from pattern
1871 literally. (Bug#9458)
1873 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1875 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1877 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1879 Fix minor problem found by static checking.
1880 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1881 initialized, to pacify gcc -Wuninitialized.
1883 * fileio.c: Report proper errno when syscall falls.
1884 (Finsert_file_contents): Save and restore errno,
1885 so that report_file_error outputs the correct diagnostic.
1886 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1888 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1890 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1892 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1894 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1895 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1897 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1899 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1900 about the current paragraph and restore it after the call to reseat.
1902 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1903 (bidi_find_paragraph_start): Search back for paragraph beginning
1904 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1905 (bidi_move_to_visually_next): Only trigger paragraph-related
1906 computations when the last character is a newline or at EOB, not
1907 just any NEUTRAL_B. (Bug#9470)
1909 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1910 truncated lines if point is covered by a display string. (Bug#9524)
1912 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1914 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1915 (cons_to_x_long): New function.
1916 (lisp_data_to_selection_data): Use it. Correct the test for
1917 short-versus-long data; it was negated. Break out of vector
1918 loop, for efficiency, when a long datum is discovered.
1920 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1922 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1924 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1926 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1927 GCC PR/17406) by declaring this function with external scope.
1929 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1931 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1932 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1934 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1936 * editfns.c (Fformat): Correctly handle text properties on "%%".
1938 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1940 * xterm.c (x_draw_composite_glyph_string_foreground):
1941 * w32term.c (x_draw_composite_glyph_string_foreground):
1942 * term.c (encode_terminal_code):
1943 * composite.c (composition_update_it, get_composition_id):
1944 * xdisp.c (get_next_display_element)
1945 (fill_composite_glyph_string): Add comments about special meaning
1946 of TAB characters in a composition.
1948 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1950 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1951 This occurs when processing a multibyte format.
1952 Problem reported by Wolfgang Jenker.
1954 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1956 * xdisp.c (try_cursor_movement): Only check for exact match if
1957 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1959 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1961 Remove unused external symbols.
1962 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1963 * xdisp.c (calc_pixel_width_or_height): Now static.
1964 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1965 * indent.c (check_display_width):
1966 * w32term.c: Fix comment to match code.
1967 * xterm.c, xterm.h (x_catching_errors): Remove.
1969 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1971 * xselect.c: Use signed conversions more consistently (Bug#9498).
1972 (selection_data_to_lisp_data): Assume incoming selection data are
1973 signed integers, not unsigned. This is to be consistent with
1974 outgoing selection data, which was modified to use signed integers
1975 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1976 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1977 expects long, not unsigned long.
1979 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1981 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1982 computation of loop end. Reported by Johan Bockgård
1985 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1987 * frame.c (Fother_visible_frames_p): Function deleted.
1989 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1991 * indent.c (compute_motion): Process display vector front to back
1992 rather than the other way around. (Bug#2496)
1994 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1996 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1998 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2000 * minibuf.c (Fread_from_minibuffer): Doc fix.
2002 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2004 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2005 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2007 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2009 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2010 value for non-existent files.
2012 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2014 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2015 set its "size" to -1. This will set the modtime_size field of
2016 the corresponding buffer to -1, which is what
2017 verify-visited-file-modtime expects for files that do not exist.
2020 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2022 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2024 * lisp.h: ... from here. push_key_description is no longer
2025 defined in keyboard.c, so its declaration should not be in
2026 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2027 logically belongs with push_key_description.
2029 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2031 * buffer.h: Include <sys/types.h> instead of <time.h>.
2032 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2033 Problem reported by Herbert J. Skuhra.
2035 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2037 * xml.c (parse_region): Make the parsing work for
2038 non-comment-starting XML files again (bug#9144).
2040 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2042 * image.c (gif_load): Fix calculation of bottom and right corner.
2045 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2047 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2048 redisplay in small windows.
2050 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2052 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2054 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2056 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2057 Operate on live windows only.
2059 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2061 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2063 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2065 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2066 only under bidi iteration.
2068 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2070 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2072 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2074 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2075 Without this fix, the command to link temacs failed due to an
2076 undefined symbol __builtin_isnan. This is because
2077 /usr/include/iso/math_c99.h #defines isnan(x) to
2078 __builtin_isnan(x), but the bundled gcc, which identifies itself
2079 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2081 * floatfns.c (isnan): #undef, and then #define to a clone of
2083 (Fisnan): Always define, since it's always available now.
2084 (syms_of_floatfns): Always define isnan at the Lisp level.
2086 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2088 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2090 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2092 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2093 The previous code assumed that file offsets (off_t values) fit in
2094 EMACS_INT variables, which is not true on typical 32-bit hosts.
2095 The code messed up by falsely reporting buffer overflow in cases
2096 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2097 when "big" contains more than 2**29 bytes, even though this
2098 inserts just one byte and does not overflow the buffer.
2099 (Finsert_file_contents): Store file offsets as off_t
2100 values, not as EMACS_INT values. Check for overflow when
2101 converting between EMACS_INT and off_t. When checking for
2102 buffer overflow or for overlap, take the offsets into account.
2103 Don't use EMACS_INT for small values where int suffices.
2104 When checking for overlap, fix a typo: ZV was used where
2105 ZV_BYTE was intended.
2106 (Fwrite_region): Don't assume off_t fits into 'long'.
2107 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2109 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2111 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2113 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2115 sprintf-related integer and memory overflow issues (Bug#9412).
2117 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2118 (esprintf, exprintf, evxprintf): New functions.
2119 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2120 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2121 (modify_event_symbol): Do not assume that the length of
2122 name_alist_or_stem is safe to alloca and fits in int.
2123 (Fexecute_extended_command): Likewise for function name and binding.
2124 (Frecursion_depth): Wrap around reliably on integer overflow.
2125 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2126 since some callers pass EMACS_INT values.
2127 (Fsingle_key_description): Don't crash if symbol name contains more
2128 than MAX_ALLOCA bytes.
2129 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2130 (get_minibuffer): Arg is now EMACS_INT, not int.
2131 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2132 (esprintf, exprintf, evxprintf): New decls.
2133 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2135 * dbusbind.c (signature_cat): New function.
2136 (xd_signature, Fdbus_register_signal):
2137 Do not overrun buffer; instead, report string overflow.
2139 * dispnew.c (add_window_display_history): Don't overrun buffer.
2140 Truncate instead; this is OK since it's just a log.
2142 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2143 even if the time zone offset is outlandishly large.
2144 Don't mishandle offset == INT_MIN.
2146 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2147 when creating daemon; the previous buffer-overflow check was incorrect.
2149 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2150 which has the guts of the old verror function.
2152 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2153 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2155 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2156 (font_unparse_xlfd): Don't blindly alloca long strings.
2157 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2158 fits in int, when using sprintf. Use single snprintf to count
2159 length of string rather than counting it via multiple sprintfs;
2160 that's simpler and more reliable.
2161 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2162 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2163 sprintf, in case result does not fit in int.
2165 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2166 (fontset_from_font): Print it.
2168 * frame.c (tty_frame_count): Now printmax_t, not int.
2169 (make_terminal_frame, set_term_frame_name): Print it.
2170 (x_report_frame_params): In X, window IDs are unsigned long,
2171 not signed long, so print them as unsigned.
2172 (validate_x_resource_name): Check for implausibly long names,
2173 and don't assume name length fits in 'int'.
2174 (x_get_resource_string): Don't blindly alloca invocation name;
2175 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2178 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2179 (xg_check_special_colors, xg_set_geometry):
2180 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2182 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2183 Use esprintf, not sprintf, in case result does not fit in int.
2185 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2186 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2187 it as a large positive number.
2188 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2189 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2191 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2192 in case result does not fit in int.
2194 * print.c (float_to_string): Detect width overflow more reliably.
2195 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2196 buffer overrun. Don't assume list length fits in 'int'. Treat
2197 print length of 0 as 0, not as infinity; to be consistent with other
2198 uses of print length in this function. Don't overflow print length
2199 index. Don't assume hash table size fits in 'long', or that
2200 vectorlike size fits in 'unsigned long'.
2202 * process.c (make_process): Use printmax_t, not int, to format
2203 process-name gensyms.
2205 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2207 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2208 to avoid potential buffer overrun.
2210 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2211 if X resource line is longer than 512 bytes.
2213 * xfns.c (x_window): Make sprintf buffer a bit bigger
2214 to avoid potential buffer overrun.
2216 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2218 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2220 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2222 Integer overflow fixes for scrolling, etc.
2223 Without these, Emacs silently mishandles large integers sometimes.
2224 For example, "C-u 4294967297 M-x recenter" was treated as if
2225 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2227 * xdisp.c (try_window_id): Check Emacs fixnum range before
2228 converting to 'int'.
2230 * window.c (window_scroll_line_based, Frecenter):
2231 Check that an Emacs fixnum is in range before assigning it to 'int'.
2232 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2233 values converted from Emacs fixnums.
2234 (Frecenter): Don't wrap around a line count if it is out of 'int'
2235 range; instead, treat it as an extreme value.
2236 (Fset_window_configuration, compare_window_configurations):
2237 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2239 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2240 that can exceed INT_MAX. Check that EMACS_INT value is in range
2241 before assigning it to the (possibly-narrower) index.
2242 (match_limit): Don't assume that a fixnum can fit in 'int'.
2244 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2247 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2248 (Fvertical_motion): Don't wrap around LINES values that don't fit
2249 in 'int'. Instead, treat them as extreme values. This is good
2250 enough for windows, which can't have more than INT_MAX lines anyway.
2252 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2254 * Require libxml/parser.h to avoid compilation warning.
2256 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2258 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2259 since this reportedly can destroy thread storage.
2261 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2263 * syntax.c (find_defun_start): Update all cache variables if
2264 exiting early (Bug#9401).
2266 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2268 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2270 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2271 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2272 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2274 * term.c (tty_append_glyph): New function.
2275 (produce_stretch_glyph): Static function and its prototype deleted.
2277 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2280 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2282 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2283 when checking :margin (Bug#9390).
2284 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2285 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2286 so that the name doesn't mislead. All uses changed.
2288 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2290 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2293 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2295 * xdisp.c (move_it_to): Don't bail out early when reaching
2296 position beyond to_charpos, if we are scanning backwards.
2297 (move_it_vertically_backward): When DY == 0, make sure we get to
2298 the first character in the line after the newline.
2300 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2302 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2303 (ccl_driver): Do not generate an out-of-range pointer.
2304 (Fccl_execute_on_string): Remove unnecessary check for
2305 integer overflow, noted by Stefan Monnier in
2306 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2307 Remove a FIXME that didn't need fixing.
2308 Simplify the newly-introduced buffer reallocation code.
2310 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2312 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2314 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2316 Integer and memory overflow issues (Bug#9196).
2318 * doc.c (get_doc_string): Rework so that
2319 get_doc_string_buffer_size is the actual buffer size, rather than
2320 being 1 less than the actual buffer size; this makes xpalloc more
2323 * image.c (x_allocate_bitmap_record, cache_image):
2324 * xselect.c (Fx_register_dnd_atom):
2325 Simplify previous changes by using xpalloc.
2327 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2328 since either will do and ptrdiff_t is convenient with xpalloc.
2330 * charset.c (charset_table_size)
2331 (struct charset_sort_data.priority): Now ptrdiff_t.
2332 (charset_compare): Don't overflow if priorities differ greatly.
2333 (Fsort_charsets): Don't assume list length fits in int.
2334 Check for size-calculation overflow when allocating sort data.
2335 (syms_of_charset): Allocate an initial charset table that is
2336 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2338 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2340 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2341 The actual value is always <= INT_MAX, and leaving it unsigned made
2342 overflow checking harder.
2344 * dispextern.h (struct glyph_matrix.rows_allocated)
2345 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2346 with xpalloc. The values are still always <= INT_MAX.
2348 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2350 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2351 (SAFE_NALLOCA): New macro.
2353 * region-cache.c (struct boundary.pos, find_cache_boundary)
2354 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2355 (set_cache_region, invalidate_region_cache)
2356 (revalidate_region_cache, know_region_cache, region_cache_forward)
2357 (region_cache_backward, pp_cache):
2358 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2359 so that ptrdiff_t * can be passed to xpalloc.
2360 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2361 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2362 (pp_cache): Don't assume cache_len fits in int.
2363 * region-cache.h: Adjust extern decls to match.
2365 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2366 EMACS_INT, since either will do, for xpalloc.
2368 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2369 (xnmalloc, xnrealloc, xpalloc): New functions.
2371 * bidi.c (bidi_shelve_header_size): New constant.
2372 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2373 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2375 * bidi.c (bidi_cache_shrink):
2376 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2378 Don't update size of array until after memory allocation succeeds,
2379 because xmalloc/xrealloc may not return.
2380 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2381 now that we have proper integer overflow checking.
2382 (record_overlay_string, overlay_strings): Catch overflows when
2383 calculating size of overlay_str_buf.
2385 * callproc.c (Fcall_process): Check for size overflow when
2386 calculating size of args2.
2387 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2388 Normally we prefer signed values, but sticking with ptrdiff_t would
2389 require adding more-complicated checks.
2391 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2392 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2393 Redo buffer-overflow calculations to avoid integer overflow.
2394 Add a FIXME comment where memory seems to be over-allocated.
2396 * character.c (Fstring): Check for size-calculation overflow.
2398 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2399 unnecessary integer overflow. Check for size overflow.
2400 (encode_coding_object): Don't update size until xmalloc succeeds.
2402 * composite.c (get_composition_id): Check for overflow in glyph
2403 length calculations.
2405 Integer and memory overflow fixes for display code.
2406 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2407 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2408 (scrolling_window): Check for overflow in size calculations.
2409 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2410 Don't assume glyph table len fits in int.
2411 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2412 (row_table_size): Now ptrdiff_t, not int.
2413 (scrolling_window): Avoid overflow in size calculations.
2414 Don't update size until allocation succeeds.
2415 * fns.c (concat): Check for overflow in size calculations.
2416 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2417 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2418 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2420 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2421 (get_doc_string): Check for size calculation overflow.
2422 Don't update size until allocation succeeds.
2423 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2424 EMACS_INT, where ptrdiff_t will do.
2425 (Fsubstitute_command_keys): Check for string overflow.
2427 * editfns.c (set_time_zone_rule): Don't assume environment length
2429 (message_length): Now ptrdiff_t, not int.
2430 (Fmessage_box): Don't update size until allocation succeeds.
2431 Don't assume message length fits in int.
2432 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2434 * emacs.c (main): Do not reallocate argv, since there is a null at
2435 the end that can be overwritten, and this way there's no need to
2436 worry about size-calculation overflow.
2437 (sort_args): Check for size-calculation overflow.
2439 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2441 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2443 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2444 (x_set_scroll_bar_width, x_figure_window_size):
2445 Check for integer overflow.
2446 (x_set_alpha): Do not assume XINT fits in int.
2448 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2449 This is for the members text_lines, text_cols, total_lines, total_cols,
2450 where the system imposes an 'int' limit.
2452 * fringe.c (Fdefine_fringe_bitmap):
2453 Don't update size until alloc works.
2455 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2456 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2458 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2459 Check for size-calculation overflow.
2460 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2461 do, as we prefer signed integers.
2462 (id_to_widget.max_size, id_to_widget.used)
2463 (xg_store_widget_in_map, xg_remove_widget_from_map)
2464 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2465 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2466 Use and return ptrdiff_t, not int.
2467 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2468 * gtkutil.h: Change prototypes to match the above.
2470 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2471 are duplicate now that they've been promoted to lisp.h.
2472 (x_allocate_bitmap_record, x_alloc_image_color)
2473 (make_image_cache, cache_image, xpm_load):
2474 Don't update size until alloc is done.
2475 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2477 Check for size calculation overflow.
2478 (ct_colors_allocated_max): New constant.
2479 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2482 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2483 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2484 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2485 Use ptrdiff_t, not int, to count maps.
2486 (read_char_minibuf_menu_prompt): Check for overflow in size
2487 calculations. Don't update size until allocation succeeds.
2488 Redo calculations to avoid overflow.
2489 * keyboard.h: Change prototypes to match the above.
2491 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2493 (current_minor_maps): Check for size calculation overflow.
2494 * keymap.h: Change prototypes to match the above.
2496 * lread.c (read1, init_obarray): Don't update size until alloc done.
2498 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2499 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2501 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2502 Now ptrdiff_t, not int.
2503 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2504 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2506 * process.c (Fnetwork_interface_list): Check for overflow
2507 in size calculation.
2509 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2511 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2512 overflow. Don't bother calling xmalloc when xrealloc will do.
2514 * search.c (Freplace_match): Check for size calculation overflow.
2515 (Fset_match_data): Don't assume list lengths fit in 'int'.
2517 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2518 for command line length. Do not attempt to address one before the
2519 beginning of an array, as that's not portable.
2521 * term.c (max_frame_lines): Remove; unused.
2522 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2524 (encode_terminal_code, calculate_costs): Check for size
2525 calculation overflow.
2526 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2527 table lengths and related sizes. Don't update size until alloc
2528 done. Redo calculations to avoid overflow.
2529 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2531 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2532 subtracting pointers.
2533 (gobble_line): Check for overflow more carefully. Don't update size
2536 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2537 Don't update size until alloc done.
2538 Redo size calculations to avoid overflow.
2539 Check for size calculation overflow.
2540 (main) [DEBUG]: Fix typo in invoking tparam1.
2542 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2543 Use ptrdiff_t, not int, for sizes.
2544 (store_mode_line_noprop_char): Don't update size until alloc done.
2546 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2547 Use ptrdiff_t, not int, for sizes.
2548 (Finternal_make_lisp_face, cache_face):
2549 Check for size calculation overflow.
2550 (cache_face): Treat size calculation overflows as if they were
2551 memory exhaustion (the usual treatment), rather than aborting.
2553 * xfns.c (x_encode_text, x_set_name_internal)
2554 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2555 sizes, since they can exceed INT_MAX in size. Check for size
2556 calculation overflow.
2558 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2559 (xg_select): Check for size calculation overflow.
2560 Don't update size until alloc done.
2562 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2563 as sprintf is limited to int lengths.
2565 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2566 (X_LONG_MIN): New macros.
2567 Use them to make the following changes clearer.
2568 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2569 This change doesn't affect the value now, but it may help remind
2570 future maintainers not to raise the value too much later.
2571 (SELECTION_QUANTUM): Remove, replacing with ...
2572 (selection_quantum): ... new function, which avoids overflow.
2574 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2575 assumption that selection length fits in 'int'.
2576 (x_reply_selection_request, x_handle_selection_request)
2577 (x_get_window_property, receive_incremental_selection)
2578 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2579 (lisp_data_to_selection_data, clean_local_selection_data):
2580 Use ptrdiff_t, not int, to record length of selection.
2581 (x_reply_selection_request, x_get_window_property)
2582 (receive_incremental_selection, x_property_data_to_lisp):
2583 Redo calculations to avoid overflow.
2584 (x_reply_selection_request): When sending hint, ceiling it at
2585 X_LONG_MAX rather than relying on wraparound overflow to send
2587 (x_get_window_property, receive_incremental_selection)
2588 (lisp_data_to_selection_data, x_property_data_to_lisp):
2589 Check for size-calculation overflow.
2590 (x_get_window_property, receive_incremental_selection)
2591 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2592 Don't store size until memory allocation succeeds.
2593 (x_get_window_property): Plug memory leak on memory exhaustion.
2594 Don't double-block input; malloc is safe here. Don't assume 2**34
2595 - 4 fits in unsigned long. Add an xassert to check
2596 XGetWindowProperty overflow. Be more careful about overflow
2597 calculations, and distinguish size from memory overflow better.
2598 (receive_incremental_selection): When tracing, don't assume
2599 unsigned int is less than INT_MAX.
2600 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2601 harmful) conversions of unsigned short to int.
2602 (lisp_data_to_selection_data): Don't assume that integers
2603 in the range -65535 through -1 fit in an X unsigned short.
2604 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2605 result parameters unless successful. Rely on cons_to_unsigned
2606 to report problems with elements; the old code wasn't right anyway.
2607 (x_check_property_data): Check for int overflow; we cannot use
2608 a wider type due to X limits.
2609 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2611 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2613 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2614 (x_term_init): Check for size calculation overflow.
2615 (x_color_cells): Don't store size until memory allocation succeeds.
2616 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2617 Don't assume alloca size is less than MAX_ALLOCA.
2618 (x_term_init): Don't assume length fits in int (sprintf is limited
2621 Use ptrdiff_t for composition IDs.
2622 * character.c (lisp_string_width):
2623 * composite.c (composition_table_size, n_compositions)
2624 (get_composition_id, composition_gstring_from_id):
2625 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2626 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2627 * window.c (Frecenter):
2628 Use ptrdiff_t, not int, for composition IDs.
2629 * composite.c (get_composition_id): Check for integer overflow.
2630 * composite.h: Adjust prototypes to match the above changes.
2632 Use ptrdiff_t for hash table indexes.
2633 * category.c (hash_get_category_set):
2634 * ccl.c (ccl_driver):
2635 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2636 * coding.c (coding_system_charset_list, detect_coding_system):
2637 * coding.h (struct coding_system.id):
2638 * composite.c (get_composition_id, gstring_lookup_cache):
2639 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2640 * image.c (xpm_get_color_table_h):
2641 * lisp.h (hash_lookup, hash_put):
2642 * minibuf.c (Ftest_completion):
2643 Use ptrdiff_t for hash table indexes, not int (which is too
2644 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2645 32-bit --with-wide-int hosts).
2647 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2648 Add a FIXME comment about memory leaks.
2649 (syms_of_charset): Don't assume xmalloc returns.
2651 Don't assume that stated character widths fit in int.
2652 * character.c (Fchar_width, c_string_width, lisp_string_width):
2653 * character.h (CHAR_WIDTH):
2654 * indent.c (MULTIBYTE_BYTES_WIDTH):
2655 Use sanitize_char_width to avoid undefined and/or bad behavior
2656 with outlandish widths.
2657 * character.h (sanitize_tab_width): Rename from sanitize_width,
2658 now that we have two such functions. All uses changed.
2659 (sanitize_char_width): New inline function.
2661 Don't assume that tab-width fits in int.
2662 * character.h (sanitize_width): New inline function.
2663 (SANE_TAB_WIDTH): New macro.
2664 (ASCII_CHAR_WIDTH): Use it.
2665 * indent.c (sane_tab_width): Remove. All uses replaced by
2666 SANE_TAB_WIDTH (current_buffer).
2667 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2669 * fileio.c: Integer overflow issues with file modes.
2670 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2672 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2673 Remove unreachable code.
2674 (read_hex, load_charset_map_from_file): Check for integer overflow.
2676 * xterm.c: Don't go over XClientMessageEvent limit.
2677 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2678 (x_send_scroll_bar_event): Likewise. Check that the size does not
2679 exceed limits imposed by XClientMessageEvent, as well as the usual
2680 ptrdiff_t and size_t limits.
2682 * keyboard.c: Overflow, signedness and related fixes.
2683 (make_lispy_movement): Use same integer type in forward decl
2684 that is used in the definition.
2685 (read_key_sequence, keyremap_step):
2686 Change bufsize argument back to int, undoing my 2011-03-30 change.
2687 We prefer signed types, and int is wide enough here.
2688 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2689 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2690 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2691 length, not size_t. Use ptrdiff_t for index, not int.
2692 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2693 possibility of integer overflow.
2695 Overflow, signedness and related fixes for images.
2697 * dispextern.h (struct it.stack[0].u.image.image_id)
2698 (struct_it.image_id, struct image.id, struct image_cache.size)
2699 (struct image_cache.used, struct image_cache.ref_count):
2700 * gtkutil.c (update_frame_tool_bar):
2701 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2702 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2703 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2704 * nsmenu.m (update_frame_tool_bar):
2705 * xdisp.c (calc_pixel_width_or_height):
2706 * xfns.c (image_cache_refcount):
2707 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2708 on typical 64-bit hosts.
2710 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2711 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2712 Omit unnecessary casts to int.
2713 (parse_image_spec): Check that integers fall into 'int' range
2714 when the callers expect that.
2715 (image_ascent): Redo ascent calculation to avoid int overflow.
2716 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2717 (lookup_image): Remove unnecessary tests.
2718 (xbm_image_p): Locals are now of int, not EMACS_INT,
2719 since parse_image_check makes sure they fit into int.
2720 (png_load, gif_load, svg_load_image):
2721 Prefer int to unsigned where either will do.
2722 (tiff_handler): New function, combining the cores of the
2723 old tiff_error_handler and tiff_warning_handler.
2724 This function is rewritten to use vsnprintf and thereby avoid
2725 stack buffer overflows. It uses only the features of vsnprintf
2726 that are common to both POSIX and native Microsoft.
2727 (tiff_error_handler, tiff_warning_handler): Use it.
2728 (tiff_load, gif_load, imagemagick_load_image):
2729 Don't assume :index value fits in 'int'.
2730 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2731 (imagemagick_load_image): Check that crop parameters fit into
2732 the integer types that MagickCropImage accepts. Don't assume
2733 Vimagemagick_render_type has a nonnegative value. Don't assume
2734 size_t fits in 'long'.
2735 (gs_load): Use printmax_t to print the widest integers possible.
2736 Check for integer overflow when computing image height and width.
2738 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2740 * xdisp.c (redisplay_window): Don't force window start if point
2741 will be invisible in the resulting window. (Bug#9324)
2743 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2745 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2746 the display spec is of the form `(space ...)'.
2747 (handle_display_spec): Return the value returned by
2748 handle_single_display_spec, not just 1 or zero.
2749 (handle_single_display_spec): If the display spec is of the form
2750 `(space ...)', and specifies display in the text area, return 2
2752 (try_cursor_movement): Check for the need to scroll more
2753 accurately, and prefer exact match for point under bidi.
2754 Don't advance `row' beyond the last row of the window.
2756 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2757 into disp_prop; all users changed.
2759 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2760 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2761 for the text covered by the display property.
2763 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2765 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2766 Change return value to nil.
2767 (Frecord_buffer): Delete unused function.
2769 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2771 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2772 buffers, return left-to-right.
2773 (set_cursor_from_row): Consider candidate row a win if its glyph
2774 represents a newline and point is on that newline. Fixes cursor
2775 positioning on the newline at EOL of R2L text within L2R
2776 paragraph, and vice versa.
2777 (try_cursor_movement): Check continued rows, in addition to
2778 continuation rows. Fixes unwarranted scroll when point enters a
2779 continued line of R2L text within an L2R paragraph, or vice versa.
2780 (cursor_row_p): Consider the case of point being equal to
2781 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2782 from the end of a short line to the beginning of a continued line
2783 of R2L text within L2R paragraph.
2784 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2785 composed characters.
2787 * bidi.c (bidi_check_type): Use xassert.
2788 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2791 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2793 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2796 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2798 * nsfont.m (ns_otf_to_script): Fix typo.
2800 2011-08-22 Kenichi Handa <handa@m17n.org>
2802 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2803 extra slot even if the purpose is char-code-property-table.
2805 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2807 * xdisp.c (redisplay_window): When computing centering_position,
2808 account for the height of the header line. (Bug#8874)
2810 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2811 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2812 candidate is selected by the mouse, and that candidate has a
2813 composed character under the mouse.
2815 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2816 coordinates reported by pos-visible-in-window-p for a composed
2817 character in column zero.
2819 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2821 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2823 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2825 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2826 consider it a hit if to_charpos is anywhere in the range of the
2827 composed buffer positions.
2829 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2831 * image.c (gif_load): Don't assume that each subimage has the same
2832 dimensions as the base image. Handle disposal method that is
2833 "undefined" by the gif spec (Bug#9335).
2835 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2837 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2838 (Fcondition_case): Document `debug' symbol in error handler.
2840 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2842 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2843 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2844 from an Org mode buffer to a Speedbar frame.
2846 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2847 a composition, take its buffer position from IT->cmp_it.charpos.
2848 Fixes cursor positioning at the beginning of a line that begins
2849 with a composed character.
2851 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2853 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2854 character bidirectional type, use STRONG_L instead. Fixes crashes
2855 in a buffer produced by `describe-categories'.
2857 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2858 members before the level stack, so they would be saved and
2859 restored when copying iterator state. Fixes incorrect reordering
2860 around TABs covered by display properties.
2862 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2864 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2866 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2868 * eval.c (internal_condition_case, internal_condition_case_1)
2869 (internal_condition_case_2, internal_condition_case_n):
2870 Remove unnecessary aborts (Bug#9081).
2872 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2874 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2875 has no `load' handler, try opening the file locally. (Bug#9311)
2877 2011-08-16 Ken Brown <kbrown@cornell.edu>
2879 * gmalloc.c: Expand comment.
2881 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2883 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2884 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2886 2011-08-16 Ken Brown <kbrown@cornell.edu>
2888 Fix memory allocation problems in Cygwin build (Bug#9273).
2890 * unexcw.c ( __malloc_initialized): Declare external variable.
2891 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2893 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2895 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2897 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2899 [CYGWIN] (special_realloc): New function.
2900 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2901 requests to realloc storage in the static heap.
2903 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2905 * bidi.c (bidi_initialize): Remove unused local.
2907 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2910 * biditype.h: Remove file.
2911 * makefile.w32-in ($(BLD)/bidi.$(O)):
2912 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2914 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2916 * chartab.c: Improve commentary for the uniprop_table API.
2918 * bidi.c (bidi_paragraph_init): Support zero value of
2919 bidi_ignore_explicit_marks_for_paragraph_level.
2920 (bidi_initialize): Use uniprop_table instead of including
2921 biditype.h and bidimirror.h.
2923 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2924 coordinates of the iterator when restoring from ppos_it.
2927 2011-08-14 Kenichi Handa <handa@m17n.org>
2929 * process.c (create_process): Call setup_process_coding_systems
2930 after the pid of the process is set to -1 (Bug#8162).
2932 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2934 * xdisp.c (move_it_in_display_line_to): Don't invoke
2935 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2936 ppos_it. Fixes vertical cursor motion when line beginning is
2937 covered by an image. (Bug#9296)
2939 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2941 * nsterm.h (ns_run_ascript): Declare.
2942 (NSAPP_DATA2_RUNASSCRIPT): Define.
2944 * nsfns.m (as_script, as_result, as_status): New static variables.
2945 (ns_run_ascript): New function.
2946 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2947 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2948 the event loop. Get status from as_status (Bug#7276).
2950 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2951 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2952 the event loop (Bug#7276).
2954 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2956 * gnutls.c (QCgnutls_bootprop_priority)
2957 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2958 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2959 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2960 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2961 (QCgnutls_bootprop_verify_hostname_error)
2962 (QCgnutls_bootprop_callbacks_verify): Rename from
2963 Qgnutls_bootprop_..., all uses changed.
2965 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2968 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2970 * xfaces.c (Qframe_set_background_mode): Now static.
2971 * dispextern.h (Qframe_set_background_mode): Remove decl.
2973 * process.c (Fnetwork_interface_info): Declare local only if needed.
2975 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2977 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2978 (Fnetwork_interface_list): Allocate in increments of bytes instead
2979 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2980 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2982 (struct ifflag_def): notrailers is smart on OSX.
2983 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2984 Get hardware address with getifaddrs if available.
2986 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2988 * xdisp.c (iterate_out_of_display_property): xassert that
2989 IT->position is set to within IT->object's boundaries. Break from
2990 the loop as soon as EOB is reached; avoids infloops in redisplay
2991 when IT->position is set up wrongly due to some bug.
2992 Set IT->current to match the bidi iterator unconditionally.
2993 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2994 entry. Force push_it to save on the stack the current
2995 buffer/string position, to be restored by pop_it. Fix flags in
2996 the iterator structure wrt the object coming from a display
2997 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2998 properties. (Bug#9284)
3000 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3002 * fontset.c (fontset_get_font_group): Add proper type checks.
3005 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3007 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3008 and LC_VERSION_MIN_MACOSX.
3009 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3010 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3012 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3014 * xdisp.c (forward_to_next_line_start): Allow to use the
3015 no-display-properties-and-no-overlays under bidi display.
3016 Set disp_pos in the bidi iterator to avoid searches for display
3017 properties and overlays.
3019 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3021 * editfns.c (Fset_time_zone_rule): Document relationship with the
3024 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3025 the font entity extracted from the cache (Bug#8109).
3027 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3029 * composite.c (autocmp_chars): Don't reset point. That is done by
3030 restore_point_unwind (Bug#5984).
3032 2011-08-07 Juri Linkov <juri@jurta.org>
3034 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3035 to show the arg `TIME' instead of `TIMEVAL'.
3037 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3039 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3040 display property strides EOL and includes a newline, as in
3041 longlines-mode. (Bug#9254)
3042 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3043 word-wrap under bidirectional display. (Bug#9224)
3045 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3046 is non-zero, even if the data buffer is NULL. Fixes a crash in
3047 vertical-motion with longlines-mode. (Bug#9254)
3049 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3051 * bidi.c <bidi_cache_total_alloc>: Now static.
3052 (bidi_initialize): Initialize bidi_cache_total_alloc.
3054 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3057 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3058 amount allocated this far in `bidi_cache_total_alloc'.
3059 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3060 non-zero, only free the data buffer without restoring the cache
3061 contents. All callers changed.
3063 * dispextern.h (bidi_unshelve_cache): Update prototype.
3065 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3066 (move_it_in_display_line, move_it_to)
3067 (move_it_vertically_backward, move_it_by_lines): Replace the call
3068 to xfree to an equivalent call to bidi_unshelve_cache.
3069 (move_it_in_display_line_to): Fix logic of returning
3070 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3072 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3074 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3075 came from a string character with a `cursor' property. (Bug#9229)
3077 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3079 * Makefile.in (LIB_PTHREAD): New variable.
3080 (LIBES): Add LIB_PTHREAD (Bug#9216).
3082 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3083 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3085 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3087 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3089 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3091 * xterm.c (x_find_topmost_parent): New function.
3092 (x_set_frame_alpha): Find topmost parent window with
3093 x_find_topmost_parent and set the property there also (bug#9181).
3094 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3096 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3098 * callproc.c (Fcall_process): Avoid vfork clobbering
3099 the local vars buffer, coding_systems, current_dir.
3101 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3103 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3105 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3107 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3108 so that it is not optimized away.
3110 * xdisp.c (compute_display_string_pos): Remove unused local.
3112 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3114 Fix slow cursor motion and scrolling in large buffers with
3115 selective display, like Org Mode buffers. (Bug#9218)
3117 * dispextern.h (struct bidi_it): New member disp_prop_p.
3119 * xdisp.c: Remove one-slot cache of display string positions.
3120 (compute_display_string_pos): Accept an additional argument
3121 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3122 for a display string or property. If found, set DISP_PROP_P
3125 * bidi.c (bidi_fetch_char): Accept an additional argument
3126 DISP_PROP_P, and pass it to compute_display_string_pos.
3127 Only handle text covered by a display string if DISP_PROP_P is returned
3128 non-zero. All callers of bidi_fetch_char changed.
3130 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3132 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3134 2010-12-03 Don March <don@ohspite.net>
3136 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3137 last character M-[char] is translated to ESC [char] (bug#7541).
3139 2011-08-02 Kenichi Handa <handa@m17n.org>
3141 * lisp.h (uniprop_table): Extern it.
3143 * chartab.c (uniprop_table): Make it non-static.
3145 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3147 * xdisp.c (forward_to_next_line_start): Accept additional argument
3148 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3150 (reseat_at_next_visible_line_start): Use the bidi iterator state
3151 returned by forward_to_next_line_start to restore the state of
3152 it->bidi_it after backing up to previous newline. (Bug#9212)
3154 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3156 * regex.c (re_comp): Protoize.
3157 (re_exec): Fix return type.
3158 (regexec): Fix type of `ret'. (Bug#9203)
3160 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3162 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3163 This is needed if max-image-size is a floating-point number.
3165 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3167 * print.c (print_object): Print empty symbol as ##.
3169 * lread.c (read1): Read ## as empty symbol.
3171 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3173 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3174 setting frame foreground color (Bug#9175).
3175 (x_set_background_color): Likewise.
3177 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3178 contents (Bug#9176).
3179 (EmacsTooltip -init): Remove bezels and add shadows to
3182 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3183 or scroll bar (Bug#8470).
3185 * nsfont.m (nsfont_open): Remove assignment to voffset and
3186 unnecessary vars hshink, expand, hd, full_height, min_height.
3187 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3189 * nsterm.h (nsfont_info): Remove voffset field.
3191 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3193 Implement strike-through and overline on NextStep (Bug#8863).
3195 * nsfont.m (nsfont_open): Use underline position provided by font,
3196 instead of hard-coded value of 2.
3197 (nsfont_draw): Call ns_draw_text_decoration instead.
3199 * nsterm.h: Add declaration for ns_draw_text_decoration.
3201 * nsterm.m (ns_draw_text_decoration): New function for drawing
3202 underline, overline, and strike-through.
3203 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3204 ns_draw_text_decoration. Change treatment of cursor drawing to
3205 accommodate underlining, etc.
3207 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3209 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3212 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3214 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3215 Without this fix, if a signal arrives just after memory fills up,
3216 'malloc' might be invoked reentrantly.
3218 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3219 In other words, assume that every image size is allowed, on non-X
3220 hosts. This assumption is probably wrong, but it lets Emacs compile.
3222 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3224 * regex.c (re_iswctype): Convert return values to boolean.
3226 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3228 * xdisp.c (compute_display_string_pos): Don't use cached display
3229 string position if the buffer had its restriction changed.
3232 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3234 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3236 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3238 Integer signedness and overflow and related fixes. (Bug#9079)
3240 * bidi.c: Integer size and overflow fixes.
3241 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3242 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3243 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3244 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3245 (bidi_find_other_level_edge):
3246 Use ptrdiff_t instead of EMACS_INT where either will do.
3247 This works better on 32-bit hosts configured --with-wide-int.
3248 (bidi_cache_ensure_space): Check for size-calculation overflow.
3249 Use % rather than repeated addition, for better worst-case speed.
3250 Don't set bidi_cache_size until after xrealloc returns, because it
3252 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3253 (bidi_cache_ensure_space): Also check that the bidi cache size
3254 does not exceed that of the largest Lisp string or buffer. See Eli
3255 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3257 * alloc.c (__malloc_size_t): Remove.
3258 All uses replaced by size_t. See Andreas Schwab's note
3259 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3261 * image.c: Improve checking for integer overflow.
3262 (check_image_size): Assume that f is nonnull, since
3263 it is always nonnull in practice. This is one less thing to
3264 worry about when checking for integer overflow later.
3265 (x_check_image_size): New function, which checks for integer
3266 overflow issues inside X.
3267 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3268 This removes the need for a memory_full check.
3269 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3270 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3271 (xbm_read_bitmap_data): Change locals back to 'int', since
3272 their values must fit in 'int'.
3273 (xpm_load_image, png_load, tiff_load):
3274 Invoke x_create_x_image_and_pixmap earlier,
3275 to avoid much needless work if the image is too large.
3276 (tiff_load): Treat overly large images as if
3277 x_create_x_image_and_pixmap failed, not as malloc failures.
3278 (gs_load): Use x_check_image_size.
3280 * gtkutil.c: Omit integer casts.
3281 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3282 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3284 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3286 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3287 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3288 would wrongly return t on a 64-bit host.
3290 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3291 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3292 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3293 and therefore cause GCC to emit a bogus diagnostic in some cases.
3295 * image.c: Integer signedness and overflow and related fixes.
3296 This is not an exhaustive set of fixes, but it's time to
3297 record what I've got.
3298 (lookup_pixel_color, check_image_size): Remove redundant decls.
3299 (check_image_size): Don't assume that arbitrary EMACS_INT values
3300 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3301 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3302 (tiff_load, imagemagick_load_image):
3303 Check for overflow in size calculations.
3304 (x_create_x_image_and_pixmap): Remove unnecessary test for
3305 xmalloc returning NULL; that can't happen.
3306 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3307 (xpm_color_bucket): Use better integer hashing function.
3308 (xpm_cache_color): Don't possibly over-allocate memory.
3309 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3310 (gif_memory_source):
3311 Use ptrdiff_t, not int or size_t, to record sizes.
3312 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3313 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3314 either works, as we prefer signed integers.
3315 (tiff_read_from_memory, tiff_write_from_memory):
3316 Return tsize_t, not size_t, since that's what the TIFF API wants.
3317 (tiff_read_from_memory): Don't fail simply because the read would
3318 go past EOF; instead, return a short read.
3319 (tiff_load): Omit no-longer-needed casts.
3320 (Fimagemagick_types): Don't assume size fits into 'int'.
3322 Improve hashing quality when configured --with-wide-int.
3323 * fns.c (hash_string): New function, taken from sxhash_string.
3324 Do not discard information about ASCII character case; this
3325 discarding is no longer needed.
3326 (sxhash-string): Use it. Change sig to match it. Caller changed.
3327 * lisp.h: Declare it.
3328 * lread.c (hash_string): Remove, since we now use fns.c's version.
3329 The fns.c version returns a wider integer if --with-wide-int is
3330 specified, so this should help the quality of the hashing a bit.
3332 * emacs.c: Integer overflow minor fix.
3333 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3334 Define only if GNU_LINUX.
3335 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3337 * dispnew.c: Integer signedness and overflow fixes.
3338 Remove unnecessary forward decls, that were a maintenance hassle.
3339 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3341 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3342 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3343 (prepare_desired_row, line_draw_cost):
3344 Use int, not unsigned, where either works.
3345 (save_current_matrix, restore_current_matrix):
3346 Use ptrdiff_t, not size_t, where either works.
3347 (init_display): Check for overflow more accurately, and without
3348 relying on undefined behavior.
3350 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3351 Remove, replacing with the new symbols in lisp.h. All uses changed.
3352 * fileio.c (make_temp_name):
3353 * filelock.c (lock_file_1, lock_file):
3354 * xdisp.c (message_dolog):
3355 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3356 Use pMd etc. instead.
3357 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3358 replacing the pWIDE etc. symbols removed from editfns.c.
3360 * keyboard.h (num_input_events): Now uintmax_t.
3361 This is (very slightly) less likely to mess up due to wraparound.
3364 * buffer.c: Integer signedness fixes.
3365 (alloc_buffer_text, enlarge_buffer_text):
3366 Use ptrdiff_t rather than size_t when either will do, as we prefer
3369 * alloc.c: Integer signedness and overflow fixes.
3370 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3371 (__malloc_size_t): Default to size_t, not to int.
3372 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3373 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3374 Prefer ptrdiff_t to size_t when either would do, as we prefer
3376 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3377 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3378 Now const. Initialize with values that are in range even if char
3380 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3381 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3382 These functions do the right thing with sizes > 2**32.
3383 (check_depth): Now ptrdiff_t, not int.
3384 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3385 Adjust to new way of storing sizes. Check for size overflow bugs
3387 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3388 slightly wrong anyway, as it missed one instance of
3389 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3390 (refill_memory_reserve): Omit needless cast to size_t.
3391 (mark_object_loop_halt): Mark as externally visible.
3393 * xselect.c: Integer signedness and overflow fixes.
3394 (Fx_register_dnd_atom, x_handle_dnd_message):
3395 Use ptrdiff_t, not size_t, since we prefer signed.
3396 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3397 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3398 x_dnd_atoms_size and x_dnd_atoms_length.
3400 * doprnt.c: Prefer signed to unsigned when either works.
3402 * doprnt.c (doprnt):
3404 * xdisp.c (vmessage):
3405 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3406 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3407 prefer signed arithmetic to avoid comparison confusion.
3408 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3409 but is a bit tricky.
3411 Assume freestanding C89 headers, string.h, stdlib.h.
3412 * data.c, doprnt.c, floatfns.c, print.c:
3413 Include float.h unconditionally.
3414 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3415 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3416 * regex.c: Likewise for stddef.h, string.h.
3417 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3418 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3419 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3420 (STDC_HEADERS): Remove obsolete defines.
3421 * sysdep.c: Include limits.h unconditionally.
3423 Assume support for memcmp, memcpy, memmove, memset.
3424 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3425 * regex.c (memcmp, memcpy):
3426 Remove; we assume C89 now.
3428 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3429 (__malloc_safe_bcopy): Remove; no longer needed.
3431 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3432 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3433 well either way, and we prefer signed to unsigned.
3435 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3437 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3438 closes the connection while we're reading (bug#9182).
3440 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3442 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3443 are specified (Bug#9168).
3445 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3447 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3448 Found by GCC static checking and --with-wide-int on a 32-bit host.
3450 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3452 * xdisp.c (compute_display_string_pos): Fix logic of caching
3453 previous display string position. Initialize cached_prev_pos to
3454 -1. Fixes slow-down at the beginning of a buffer.
3456 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3458 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3459 for attrs[LFACE_FONTSET_INDEX].
3461 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3463 * xml.c (parse_region): Remove unused local
3464 that was recently introduced.
3466 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3468 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3469 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3471 * xdisp.c (move_it_in_display_line_to): Record the best matching
3472 position for TO_CHARPOS while scanning the line, and restore it on
3473 exit if none of the characters scanned was an exact match.
3474 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3475 when exact match is impossible due to invisible text, and the
3476 lines are truncated.
3478 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3480 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3483 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3485 Fix a significant slow-down of cursor motion with C-n, C-p,
3486 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3487 auto-repeat under bidi redisplay in fontified buffers.
3488 * xdisp.c (compute_stop_pos_backwards): New function.
3489 (next_element_from_buffer): Call compute_stop_pos_backwards to
3490 find a suitable prev_stop when we find ourselves before
3492 (reseat): Don't look for prev_stop, as that could mean a very long
3494 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3495 <cached_disp_overlay_modiff>: Cache for last found display string
3497 (compute_display_string_pos): Return the cached position if asked
3498 about the same buffer in the same area of character positions, and
3499 the buffer wasn't changed since the time the display string
3500 position was cached.
3502 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3504 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3505 is an integer, which is important for empty lines. (Bug#9149)
3507 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3509 * frame.c (Fmodify_frame_parameters): In tty case, update the
3510 default face if necessary (Bug#4238).
3512 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3514 * editfns.c (Fstring_to_char): No need to explain what a character
3515 is in the docstring (Bug#6576).
3517 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3519 * xml.c (parse_region): Make sure we always return a tree.
3521 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3523 * xml.c (parse_region): If a document contains only comments,
3526 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3528 * xml.c (make_dom): Return comments, too.
3530 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3533 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3534 and the surrounding thread.
3535 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3536 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3537 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3539 * s/openbsd.h (BROKEN_SIGIO): Define.
3540 * unexelf.c (unexec) [__OpenBSD__]:
3541 Don't update the .mdebug section of the Alpha COFF symbol table.
3543 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3545 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3548 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3550 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3551 This fixes some race conditions on the permissions of any newly
3554 * alloc.c (valid_pointer_p): Use pipe, not open.
3555 This fixes some permissions issues when debugging.
3557 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3558 If fchown fails to set both uid and gid, try to set just gid,
3559 as that is sometimes allowed. Adjust the file's mode to eliminate
3560 setuid or setgid bits that are inappropriate if fchown fails.
3562 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3564 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3565 to compare Lisp_Objects.
3566 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3567 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3568 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3570 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3572 * lread.c (read_integer): Unread even EOF character.
3573 (read1): Likewise. Properly record start position of symbol.
3575 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3576 symbol character follows.
3578 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3580 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3581 This works around a problem with the previous change to Fcopy_file.
3582 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3583 and without this change, GCC might complain about discarding
3584 fchown's return value.
3586 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3588 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3590 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3592 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3594 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3596 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3597 it's used from the C level.
3599 * process.c: Use the same condition for POLL_FOR_INPUT in both
3600 keyboard.c and process.c (bug#1858).
3602 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3604 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3605 (Fgnutls_boot): Use it.
3607 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3609 * doc.c (Fsubstitute_command_keys): Revert last change.
3611 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3613 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3614 quotes the next character, and doesn't affect other longer
3615 sequences (bug#8935).
3617 * lread.c (syms_of_lread): Clarify that is isn't only
3618 `eval-buffer' and `eval-defun' that's affected by
3619 `lexical-binding' (bug#8460).
3621 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3623 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3624 bidi redisplay when a line includes both an image and is truncated.
3626 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3628 Fix minor problems found by static checking.
3629 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3630 (elsz): Now a signed constant, not a size_t var. We prefer signed
3631 types to unsigned, to avoid integer comparison confusion. Without
3632 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3633 "cannot optimize loop, the loop counter may overflow", a symptom
3635 * indent.c (Fvertical_motion): Mark locals as initialized.
3636 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3638 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3640 * search.c (Fre_search_backward): Mention `case-fold-search' in
3641 all the re_search_* functions (bug#8138).
3643 * keyboard.c (Fopen_dribble_file): Document when the file is
3646 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3648 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3651 Support bidi reordering of display and overlay strings.
3652 * xdisp.c (compute_display_string_pos)
3653 (compute_display_string_end): Accept additional argument STRING.
3654 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3655 (reseat_to_string): Initialize bidi_it->string.s and
3656 bidi_it->string.schars.
3657 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3658 NULL (avoids a crash in bidi_paragraph_init).
3659 Initialize itb.string.lstring.
3660 (init_iterator): Call bidi_init_it only of a valid
3661 buffer position was specified. Initialize paragraph_embedding to
3663 (reseat_to_string): Initialize the bidi iterator.
3664 (display_string): If we need to ignore text properties of
3665 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3666 original value of -1 will not work with bidi.)
3667 (compute_display_string_pos): First arg is now struct
3668 `text_pos *'; all callers changed. Support display properties on
3670 (compute_display_string_end): Support display properties on Lisp
3672 (init_iterator, reseat_1, reseat_to_string): Initialize the
3673 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3674 when iterating on a string not from display properties).
3675 (compute_display_string_pos, compute_display_string_end):
3676 Fix calculation of the object to scan. Fixes an error when using
3678 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3679 base_level_stop; instead, set base_level_stop to BEGV.
3680 Fixes crashes in vertical-motion.
3681 (next_element_from_buffer): Improve commentary for when
3682 the iterator is before prev_stop.
3683 (init_iterator): Initialize bidi_p from the default value of
3684 bidi-display-reordering, not from buffer-local value. Use the
3685 buffer-local value only if initializing for buffer iteration.
3686 (handle_invisible_prop): Support invisible properties on strings
3687 that are being bidi-reordered.
3688 (set_iterator_to_next): Support bidi reordering of C strings and
3690 (next_element_from_string): Support bidi reordering of Lisp
3692 (handle_stop_backwards): Support Lisp strings as well.
3693 (display_string): Support display of R2L glyph rows.
3694 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3695 (init_iterator): Don't initialize it->bidi_p for strings
3697 (reseat_to_string): Initialize it->bidi_p for strings here.
3698 (next_element_from_string, next_element_from_c_string)
3699 (next_element_from_buffer): Add xassert's for correspondence
3700 between IT's object being iterated and it->bidi_it.string
3702 (face_before_or_after_it_pos): Support bidi iteration.
3703 (next_element_from_c_string): Handle the case of the first string
3704 character that is not the first one in the visual order.
3705 (get_visually_first_element): New function, refactored from common
3706 parts of next_element_from_buffer, next_element_from_string, and
3707 next_element_from_c_string.
3708 (tool_bar_lines_needed, redisplay_tool_bar)
3709 (display_menu_bar): Force left-to-right direction. Add a FIXME
3710 comment for making that be controlled by a user option.
3711 (push_it, pop_it): Save and restore the state of the
3712 bidi iterator. Save and restore the bidi_p flag.
3713 (pop_it): Iterate out of display property for string iteration as
3715 (iterate_out_of_display_property): Support iteration over strings.
3716 (handle_single_display_spec): Set up it->bidi_it for iteration
3717 over a display string, and call bidi_init_it.
3718 (handle_single_display_spec, next_overlay_string)
3719 (get_overlay_strings_1, push_display_prop): Set up the bidi
3720 iterator for displaying display or overlay strings.
3721 (forward_to_next_line_start): Don't use the shortcut if
3723 (back_to_previous_visible_line_start): If handle_display_prop
3724 pushed the iterator stack, restore the internal state of the bidi
3725 iterator by calling bidi_pop_it same number of times.
3726 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3727 and we are bidi-iterating, don't decrement the iterator position;
3728 instead, set the first_elt flag in the bidi iterator, to produce
3730 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3731 (push_display_prop): xassert that we are iterating a buffer.
3732 (push_it, pop_it): Save and restore paragraph_embedding member.
3733 (handle_single_display_spec, next_overlay_string)
3734 (get_overlay_strings_1, reseat_1, reseat_to_string)
3735 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3736 correctly. Don't assume unibyte strings are not bidi-reordered.
3737 (compute_display_string_pos)
3738 (compute_display_string_end): Fix handling the case of C string.
3739 (push_it, pop_it): Save and restore from_disp_prop_p.
3740 (handle_single_display_spec, push_display_prop): Set the
3741 from_disp_prop_p flag.
3742 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3743 (pop_it): Call iterate_out_of_display_property only if we are
3744 popping after iteration over a string that came from a display
3745 property. Fix a typo in popping stretch info. Add an assertion
3746 for verifying that the iterator position is in sync with the bidi
3748 (handle_single_display_spec, get_overlay_strings_1)
3749 (push_display_prop): Fix initialization of paragraph direction for
3750 string when that of the parent object is not yet determined.
3751 (reseat_1): Call bidi_init_it to resync the bidi
3752 iterator with IT's position. (Bug#7616)
3753 (find_row_edges): If ROW->start.pos gives position
3754 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3755 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3756 Reset the from_disp_prop_p flag.
3757 (SAVE_IT, RESTORE_IT): New macros.
3758 (pos_visible_p, face_before_or_after_it_pos)
3759 (back_to_previous_visible_line_start)
3760 (move_it_in_display_line_to, move_it_in_display_line)
3761 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3762 (try_scrolling, redisplay_window, display_line): Use them when
3763 saving a temporary copy of the iterator and restoring it back.
3764 (back_to_previous_visible_line_start, reseat_1)
3765 (init_iterator): Empty the bidi cache "stack".
3766 (move_it_in_display_line_to): If iterator ended up at
3767 EOL, but we never saw any buffer positions smaller than
3768 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3769 motion in bidi-reordered lines.
3770 (move_it_in_display_line_to): Record prev_method and prev_pos
3771 immediately before the call to set_iterator_to_next. Fixes cursor
3772 motion in bidi-reordered lines with stretch glyphs and strings
3773 displayed in margins. (Bug#8133) (Bug#8867)
3774 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3776 (pos_visible_p): Support positions in bidi-reordered lines.
3777 Save and restore bidi cache.
3779 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3780 (bidi_paragraph_info): Delete unused struct.
3781 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3782 (bidi_cache_start): New variable.
3783 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3785 (bidi_cache_fetch_state, bidi_cache_search)
3786 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3787 (bidi_cache_find, bidi_peek_at_next_level)
3788 (bidi_level_of_next_char, bidi_find_other_level_edge)
3789 (bidi_move_to_visually_next): Compare cache index with
3790 bidi_cache_start rather than with zero.
3791 (bidi_fetch_char): Accept new argument STRING; all callers
3792 changed. Support iteration over a string. Support strings with
3793 display properties. Support unibyte strings. Fix the type of
3794 `len' according to what STRING_CHAR_AND_LENGTH expects.
3795 (bidi_paragraph_init, bidi_resolve_explicit_1)
3796 (bidi_resolve_explicit, bidi_resolve_weak)
3797 (bidi_level_of_next_char, bidi_move_to_visually_next):
3798 Support iteration over a string.
3799 (bidi_set_sor_type, bidi_resolve_explicit_1)
3800 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3801 can now be zero (for strings); special values 0 and -1 were
3802 changed to -1 and -2, respectively.
3803 (bidi_char_at_pos): New function.
3804 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3805 Call it instead of FETCH_MULTIBYTE_CHAR.
3806 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3807 initialized to valid values.
3808 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3810 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3811 the test for valid cached positions. Fix the logic for looking up
3812 the sentinel state in the cache. GCPRO the Lisp string we are
3814 (bidi_push_it, bidi_pop_it): New functions.
3815 (bidi_initialize): Initialize the bidi cache start stack pointer.
3816 (bidi_cache_ensure_space): New function, refactored from part of
3817 bidi_cache_iterator_state. Don't assume the required size is just
3818 one BIDI_CACHE_CHUNK away.
3819 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3820 (bidi_count_bytes, bidi_char_at_pos): New functions.
3821 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3822 always valid if bidi_cache_idx is valid.
3823 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3824 is valid if it's going to be used.
3825 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3826 (bidi_cache_fetch_state, bidi_cache_search)
3827 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3828 (bidi_cache_iterator_state, bidi_cache_find)
3829 (bidi_find_other_level_edge, bidi_cache_start_stack):
3830 All variables related to cache indices are now EMACS_INT.
3832 * dispextern.h (struct bidi_string_data): New structure.
3833 (struct bidi_it): New member `string'. Make flag members be 1-bit
3834 fields, and put them last in the struct.
3835 (compute_display_string_pos, compute_display_string_end):
3837 (bidi_push_it, bidi_pop_it): Add prototypes.
3838 (struct iterator_stack_entry): New members bidi_p,
3839 paragraph_embedding, and from_disp_prop_p.
3840 (struct it): Member bidi_p is now a bit field 1 bit wide.
3841 (bidi_shelve_cache, bidi_unshelve_cache):
3844 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3845 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3846 and vector-like objects.
3848 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3849 cache around display iteration.
3851 * window.c (Fwindow_end, window_scroll_pixel_based)
3852 (displayed_window_lines, Frecenter): Save and restore the bidi
3853 cache around display iteration.
3855 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3857 * editfns.c (Fdelete_region): Clarify the use of the named
3858 parameters (bug#6788).
3860 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3862 * indent.c (Fvertical_motion): Set and restore w->pointm when
3863 saving and restoring the window's buffer (Bug#9006).
3865 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3867 * editfns.c (Fstring_to_char): Clarify just what is returned
3868 (bug#6576). Text by Eli Zaretskii.
3870 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3872 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3874 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3876 * buffer.c (mmap_find): Fix a typo.
3878 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3880 Fix execution of x selection hooks.
3881 * xselect.c (Qx_lost_selection_functions)
3882 (Qx_sent_selection_functions): New vars.
3883 (syms_of_xselect): DEFSYM them.
3884 (x_handle_selection_request): Pass Qx_sent_selection_functions
3885 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3886 (x_handle_selection_clear,x_clear_frame_selections):
3887 Pass Qx_lost_selection_functions rather than
3888 Vx_lost_selection_functions to Frun_hook_with_args.
3890 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3892 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3893 The old code sometimes used this field without initializing it.
3895 * alloc.c (gc_sweep): Don't read past end of array.
3896 In theory, the old code could also have corrupted Emacs internals,
3897 though it'd be very unlikely.
3899 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3901 * character.c (Fcharacterp): Don't advertise optional ignored
3902 argument. (Bug#4026)
3904 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3906 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3909 * window.c (Fset_window_start): Doc fix (bug#4199).
3910 (Fset_window_hscroll): Ditto.
3912 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3914 Fix minor new problems caught by GCC 4.6.1.
3915 * term.c (init_tty): Remove unused local.
3916 * xsettings.c (store_monospaced_changed): Define this function only
3917 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3920 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3922 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3924 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3926 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3927 are the mini-buffer and the echo area (bug#3320).
3929 * term.c (init_tty): Remove support for supdup, c10 and perq
3930 terminals, which are no longer supported (bug#1482).
3932 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3934 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3936 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3938 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3939 for non-popups (Bug#3642).
3941 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3943 * alloc.c (reset_malloc_hooks): Protoize.
3944 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3945 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3946 * cm.c (losecursor): Likewise.
3947 * data.c (fmod): Likewise.
3948 * dispnew.c (swap_glyphs_in_rows): Likewise.
3949 * emacs.c (memory_warning_signal): Likewise.
3950 * floatfns.c (float_error): Likewise.
3951 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3952 (otf_open, font_otf_capability, generate_otf_features)
3953 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3955 * image.c (pbm_read_file): Likewise.
3956 * indent.c (string_display_width): Likewise.
3957 * intervals.c (check_for_interval, search_for_interval)
3958 (inc_interval_count, count_intervals, root_interval)
3959 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3960 * lread.c (defalias): Likewise.
3961 * ralloc.c (r_alloc_check): Likewise.
3962 * regex.c (set_image_of_range_1, set_image_of_range)
3963 (regex_grow_registers): Likewise.
3964 * sysdep.c (strerror): Likewise.
3965 * termcap.c (valid_filename_p, tprint, main): Likewise.
3966 * tparam.c (main): Likewise.
3967 * unexhp9k800.c (run_time_remap, save_data_space)
3968 (update_file_ptrs, read_header, write_header, calculate_checksum)
3969 (copy_file, copy_rest, display_header): Likewise.
3970 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3972 * xdisp.c (check_it): Likewise.
3973 * xfaces.c (register_color, unregister_color, unregister_colors):
3975 * xfns.c (print_fontset_result): Likewise.
3976 * xrdb.c (member, fatal, main): Likewise.
3978 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3980 Fix minor problems found by static checking (Bug#9031).
3981 * chartab.c (char_table_set_range, map_sub_char_table):
3982 Remove unused locals.
3983 (uniprop_table): Now static.
3984 * composite.c (_work_char): Remove unused static var.
3986 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3988 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3990 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3992 * gtkutil.c (qttip_cb): Remove code without function.
3994 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3996 * w32.c (pthread_sigmask): New stub.
3998 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4000 Use pthread_sigmask, not sigprocmask (Bug#9010).
4001 sigprocmask is portable only for single-threaded applications, and
4002 Emacs can be multi-threaded when it uses GTK.
4003 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4005 * callproc.c (Fcall_process):
4006 * process.c (create_process):
4007 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4008 Use pthread_sigmask, not sigprocmask.
4010 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4012 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4013 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4016 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4018 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4019 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4020 (xg_hide_tooltip): Fix comment.
4022 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4023 in registerServicesMenuSendTypes.
4024 (validRequestorForSendType): Don't check ns_return_types.
4026 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4029 2011-07-08 Jason Rumney <jasonr@gnu.org>
4031 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4032 SH_SHOW for hidden windows (Bug#5482).
4034 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4035 frame struct members of non-existent frames (Bug#6284).
4037 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4039 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4040 variable firstTime not needed on OSX >= 10.6.
4041 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4042 >= 10.5. Use setKnobProportion, setDoubleValue.
4044 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4045 (MAC_OS_X_VERSION_10_5): Define if not defined.
4046 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4047 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4048 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4050 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4051 cString and lossyCString on OSX >= 10.4
4053 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4054 sizeToFit on OSX >= 10.2.
4056 * nsimage.m (allocInitFromFile): Don't use deprecated method
4057 bestRepresentationForDevice on OSX >= 10.6.
4059 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4062 * emacs.c: Declare unexec_init_emacs_zone.
4064 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4066 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4068 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4069 on svcsMenu (Bug#8842).
4071 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4073 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4075 * nsterm.m (QUTF8_STRING): Declare.
4076 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4077 (validRequestorForSendType): Return type is (id).
4078 Change indexOfObjectIdenticalTo to indexOfObject.
4079 Check if we have local selection before returning self (Bug#8842).
4080 (writeSelectionToPasteboard): Put local selection into paste board
4081 if we have a local selection (Bug#8842).
4082 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4084 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4085 (ns_get_local_selection): Declare.
4087 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4089 * keymap.c (describe_map_tree): Don't insert a double newline at
4090 the end of the buffer (bug#1169) and return whether we inserted
4093 * callint.c (Fcall_interactively): Change "reading args" to
4094 "providing args" to try to clarify what it does (bug#1010).
4096 2011-07-07 Kenichi Handa <handa@m17n.org>
4098 * composite.c (composition_compute_stop_pos): Ignore a static
4099 composition starting before CHARPOS (Bug#8915).
4101 * xdisp.c (handle_composition_prop): Likewise.
4103 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4105 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4108 2011-07-07 Kenichi Handa <handa@m17n.org>
4110 * character.h (unicode_category_t): New enum type.
4112 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4113 (Qchar_code_property_table): New variable.
4114 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4115 (UNIPROP_COMPRESSED_FORM_P): New macros.
4116 (char_table_ascii): Uncompress the compressed values.
4117 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4118 Uncompress the compressed values.
4119 (sub_char_table_ref_and_range): Likewise.
4120 (char_table_ref_and_range): Uncompress the compressed values.
4121 (sub_char_table_set): New arg is_uniprop. Callers changed.
4122 Uncompress the compressed values.
4123 (sub_char_table_set_range): Args changed. Callers changed.
4124 (char_table_set_range): Adjuted for the above change.
4125 (map_sub_char_table): Delete args default_val and parent. Add arg
4126 top. Give decoded values to a Lisp function.
4127 (map_char_table): Adjust for the above change. Give decoded
4128 values to a Lisp function. Gcpro more variables.
4129 (uniprop_table_uncompress)
4130 (uniprop_decode_value_run_length): New functions.
4131 (uniprop_decoder, uniprop_decoder_count): New variables.
4132 (uniprop_get_decoder, uniprop_encode_value_character)
4133 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4135 (uniprop_encoder, uniprop_encoder_count): New variables.
4136 (uniprop_get_encoder, uniprop_table)
4137 (Funicode_property_table_internal, Fget_unicode_property_internal)
4138 (Fput_unicode_property_internal): New functions.
4139 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4140 Sunicode_property_table_internal, Sget_unicode_property_internal,
4141 and Sput_unicode_property_internal. Defvar_lisp
4142 char-code-property-alist.
4144 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4145 Vunicode_category_table.
4147 * font.c (font_range): Adjust for the change of
4148 Vunicode_category_table.
4150 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4152 * m/iris4d.h: Remove file, move contents ...
4153 * s/irix6-5.h: ... here.
4155 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4157 Remove unportable assumption about struct layout (Bug#8884).
4158 * alloc.c (mark_buffer):
4159 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4160 (clone_per_buffer_values): Don't assume that
4161 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4162 This isn't true in general, and it's particularly not true
4163 if Emacs is configured with --with-wide-int.
4164 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4165 New macros, used in the buffer.c change.
4167 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4169 * xsettings.c: Use both GConf and GSettings if both are available.
4170 (store_config_changed_event): Add comment.
4171 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4172 (store_tool_bar_style_changed): New functions.
4173 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4174 (struct xsettings): Move font inside HAVE_XFT.
4175 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4176 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4177 Move inside HAVE_XFT.
4178 (something_changed_gsettingsCB): Rename from something_changedCB.
4179 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4181 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4182 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4183 (something_changed_gconfCB): Rename from something_changedCB.
4184 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4185 (parse_settings): Move check for font inside HAVE_XFT.
4186 (read_settings, apply_xft_settings): Add comment.
4187 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4188 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4189 call store_font_name_changed.
4190 (xft_settings_event): Add comment.
4191 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4192 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4193 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4194 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4195 (xsettings_initialize): Call init_gsettings last.
4196 (xsettings_get_system_font, xsettings_get_system_normal_font):
4199 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4201 Random fixes. E.g., (random) never returned negative values.
4202 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4203 subseconds part to the entropy, as that's a bit more random.
4204 Prefer signed to unsigned, since the signedness doesn't matter and
4205 in general we prefer signed. When given a limit, use a
4206 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4207 latter isn't right if USE_2_TAGS_FOR_INTS.
4208 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4209 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4211 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4213 * textprop.c (text_property_stickiness):
4214 Obey Vtext_property_default_nonsticky.
4215 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4216 * w32fns.c (syms_of_w32fns):
4217 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4219 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4221 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4222 This is more efficient than Ffile_directory_p and avoids a minor race.
4224 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4226 * buffer.c (Foverlay_put): Say what the return value is
4229 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4230 is a directory before asking whether to use the file name
4232 (barf_or_query_if_file_exists): Make the "File is a directory"
4233 error be more correct.
4235 * fns.c (Frequire): Remove the mention of the .gz files, since
4236 that's installation-specific, but keep the mention of
4237 `get-load-suffixes'.
4239 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4241 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4242 Report string overflow if the output is too long.
4244 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4246 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4247 (syms_of_gnutls): Remove duplicate DEFSYM for
4248 Qgnutls_bootprop_verify_hostname_error, an error for
4249 Qgnutls_bootprop_verify_error (which is no longer used).
4251 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4252 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4253 Also (re)move comments that are misplaced or no longer relevant.
4255 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4257 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4259 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4261 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4262 and background color parameters if they have been changed.
4264 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4266 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4268 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4270 * xsettings.c (SYSTEM_FONT): Define only when used.
4271 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4273 * keymap.c (access_keymap_1): Now static.
4275 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4277 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4278 leave any prefix arg for the up event (Bug#1586).
4280 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4282 * lread.c (syms_of_lread): Mention single symbols defined by
4283 `defvar' or `defconst' (bug#7154).
4285 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4286 (Frequire): Mention get-load-suffixes.
4288 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4290 * window.h (window): Remove clone_number slot.
4291 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4293 (make_parent_window, make_window, saved_window)
4294 (Fset_window_configuration, save_window_save): Don't deal with
4296 * buffer.c (Qclone_number): Remove declaration.
4297 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4299 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4301 Add multiple inheritance to keymaps.
4302 * keymap.c (Fmake_composed_keymap): New function.
4303 (Fset_keymap_parent): Simplify.
4304 (fix_submap_inheritance): Remove.
4305 (access_keymap_1): New function extracted from access_keymap to handle
4306 embedded parents and handle lists of maps.
4307 (access_keymap): Use it.
4308 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4309 (Fcopy_keymap): Handle embedded parents.
4310 (Fcommand_remapping, define_as_prefix): Simplify.
4311 (Fkey_binding): Simplify.
4312 (syms_of_keymap): Move minibuffer-local-completion-map,
4313 minibuffer-local-filename-completion-map,
4314 minibuffer-local-must-match-map, and
4315 minibuffer-local-filename-must-match-map to Elisp.
4316 (syms_of_keymap): Defsubr make-composed-keymap.
4317 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4318 (parse_menu_item): Trivial simplification.
4320 2011-07-01 Glenn Morris <rgm@gnu.org>
4322 * Makefile.in (SETTINGS_LIBS): Fix typo.
4324 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4326 * coding.c (Fencode_coding_string): Record the last coding system
4327 used, as the function doc string says (bug#8738).
4329 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4331 * xsettings.c (store_monospaced_changed): Take new font as arg and
4332 check for change against current_mono_font.
4333 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4334 (emacs_settings_constructor, emacs_settings_get_property)
4335 (emacs_settings_set_property, emacs_settings_class_init)
4336 (emacs_settings_init, gsettings_obj): Remove.
4337 (something_changedCB): New function for HAVE_GSETTINGS.
4338 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4339 with value as argument.
4340 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4341 g_settings_new (Bug#8967). Do not create gsettings_obj.
4342 Remove calls to g_settings_bind. Connect something_changedCB to
4345 * xgselect.c: Add defined (HAVE_GSETTINGS).
4346 (xgselect_initialize): Ditto.
4348 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4349 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4352 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4354 * eval.c (struct backtrace): Simplify and port the data structure.
4355 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4356 signed bit field, as this assumption is not portable and it makes
4357 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4358 "char debug_on_exit : 1" as this is not portable either; instead,
4359 use the portable "unsigned int debug_on_exit : 1". Remove unused
4360 member evalargs. Remove obsolete comments about cc bombing out.
4362 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4364 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4365 Let HAVE_GSETTINGS override HAVE_GCONF.
4366 (store_monospaced_changed): New function.
4367 (EMACS_SETTINGS): A new type derived from GObject to handle
4368 GSettings notifications.
4369 (emacs_settings_constructor, emacs_settings_get_property)
4370 (emacs_settings_set_property, emacs_settings_class_init):
4372 (gsettings_client, gsettings_obj): New variables.
4373 (GSETTINGS_SCHEMA): New define.
4374 (something_changedCB): Call store_monospaced_changed.
4375 (init_gsettings): New function.
4376 (xsettings_initialize): Call init_gsettings.
4377 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4380 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4383 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4385 * window.c (resize_root_window, grow_mini_window)
4386 (shrink_mini_window): Rename Qresize_root_window to
4387 Qwindow_resize_root_window and Qresize_root_window_vertically to
4388 Qwindow_resize_root_window_vertically.
4390 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4392 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4394 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4396 * makefile.w32-in: Redesign dependencies so they reflect more
4397 clearly which files are directly included by each source file,
4398 and not through other includes.
4400 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4402 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4403 (sort_overlays, overlay_strings): When an overlay's clone number
4404 matches the window's clone number process the overlay even if
4405 the overlay's window property doesn't match the current window.
4407 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4408 (Fwindow_hchild): Rename to Fwindow_left_child.
4409 (Fwindow_next): Rename to Fwindow_next_sibling.
4410 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4411 (resize_window_check): Rename to window_resize_check.
4412 (resize_window_apply): Rename to window_resize_apply.
4413 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4414 (Fdelete_other_windows_internal, resize_frame_windows)
4415 (Fsplit_window_internal, Fdelete_window_internal)
4416 (grow_mini_window, shrink_mini_window)
4417 (Fresize_mini_window_internal): Fix callers accordingly.
4419 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4421 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4422 (emacs_fixed_set_min_size): Remove.
4423 (emacs_fixed_new): Take frame as argument.
4425 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4426 (_EmacsFixedPrivate): Remove minwidth/height.
4427 Add struct frame *f.
4428 (emacs_fixed_init): Initialize priv->f.
4429 (get_parent_class, emacs_fixed_set_min_size): Remove.
4430 (emacs_fixed_new): Set priv->f to argument.
4431 (emacs_fixed_get_preferred_width)
4432 (emacs_fixed_get_preferred_height): Use min_width/height from
4433 frames size_hint to set minimum and natural (Bug#8919).
4434 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4435 and use min_width/height from frames size_hint to set
4436 min_width/height (Bug#8919).
4438 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4439 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4442 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4444 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4445 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4448 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4450 * process.c (wait_reading_process_output): Bypass select if
4451 waiting for a cell while ignoring keyboard input, and input is
4452 pending. Suggested by Jan Djärv (Bug#8869).
4454 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4456 Use gnulib's dup2 module instead of rolling our own.
4457 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4459 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4461 * dispnew.c (scrolling_window): Before scrolling, turn off a
4462 mouse-highlight in the window being scrolled.
4464 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4466 Move DEFSYM to lisp.h and use everywhere.
4468 * character.h (DEFSYM): Move declaration...
4469 * lisp.h (DEFSYM): ...here.
4475 * w32select.c: Don't include character.h.
4477 * alloc.c (syms_of_alloc):
4478 * buffer.c (syms_of_buffer):
4479 * bytecode.c (syms_of_bytecode):
4480 * callint.c (syms_of_callint):
4481 * casefiddle.c (syms_of_casefiddle):
4482 * casetab.c (init_casetab_once):
4483 * category.c (init_category_once, syms_of_category):
4484 * ccl.c (syms_of_ccl):
4485 * cmds.c (syms_of_cmds):
4486 * composite.c (syms_of_composite):
4487 * dbusbind.c (syms_of_dbusbind):
4488 * dired.c (syms_of_dired):
4489 * dispnew.c (syms_of_display):
4490 * doc.c (syms_of_doc):
4491 * editfns.c (syms_of_editfns):
4492 * emacs.c (syms_of_emacs):
4493 * eval.c (syms_of_eval):
4494 * fileio.c (syms_of_fileio):
4495 * fns.c (syms_of_fns):
4496 * frame.c (syms_of_frame):
4497 * fringe.c (syms_of_fringe):
4498 * insdel.c (syms_of_insdel):
4499 * keymap.c (syms_of_keymap):
4500 * lread.c (init_obarray, syms_of_lread):
4501 * macros.c (syms_of_macros):
4502 * msdos.c (syms_of_msdos):
4503 * print.c (syms_of_print):
4504 * process.c (syms_of_process):
4505 * search.c (syms_of_search):
4506 * sound.c (syms_of_sound):
4507 * syntax.c (init_syntax_once, syms_of_syntax):
4508 * terminal.c (syms_of_terminal):
4509 * textprop.c (syms_of_textprop):
4510 * undo.c (syms_of_undo):
4511 * w32.c (globals_of_w32):
4512 * window.c (syms_of_window):
4513 * xdisp.c (syms_of_xdisp):
4514 * xfaces.c (syms_of_xfaces):
4515 * xfns.c (syms_of_xfns):
4516 * xmenu.c (syms_of_xmenu):
4517 * xsettings.c (syms_of_xsettings):
4518 * xterm.c (syms_of_xterm): Use DEFSYM.
4520 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4522 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4524 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4526 Integer and buffer overflow fixes (Bug#8873).
4528 * print.c (printchar, strout): Check for string overflow.
4529 (PRINTPREPARE, printchar, strout):
4530 Don't set size unless allocation succeeds.
4532 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4533 for sizes. Check for string overflow more accurately.
4534 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4536 * macros.c: Integer and buffer overflow fixes.
4537 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4538 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4539 Use ptrdiff_t, not int, for sizes.
4540 Don't increment bufsize until after realloc succeeds.
4541 Check for size-calculation overflow.
4542 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4544 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4546 * lread.c: Integer overflow fixes.
4547 (read_integer): Radix is now EMACS_INT, not int,
4548 to improve quality of diagnostics for out-of-range radices.
4549 Calculate buffer size correctly for out-of-range radices.
4550 (read1): Check for integer overflow in radices, and in
4551 read-circle numbers.
4552 (read_escape): Avoid int overflow.
4553 (Fload, openp, read_buffer_size, read1)
4554 (substitute_object_recurse, read_vector, read_list, map_obarray):
4555 Use ptrdiff_t, not int, for sizes.
4556 (read1): Use EMACS_INT, not int, for sizes.
4557 Check for size overflow.
4559 * image.c (cache_image): Check for size arithmetic overflow.
4561 * lread.c: Integer overflow issues.
4562 (saved_doc_string_size, saved_doc_string_length)
4563 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4564 Now ptrdiff_t, not int.
4565 (read1): Don't assume doc string length fits in int. Check for
4566 out-of-range doc string lengths.
4567 (read_list): Don't assume file position fits in int.
4568 (read_escape): Check for hex character overflow.
4570 2011-06-22 Leo Liu <sdl.web@gmail.com>
4572 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4573 Move to minibuffer.el.
4575 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4577 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4578 The following patches are for when GLYPH_DEBUG && !XASSERT.
4579 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4580 * dispnew.c (flush_stdout):
4581 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4582 Mark as externally visible.
4583 * dispnew.c (check_window_matrix_pointers): Now static.
4584 * dispnew.c (window_to_frame_vpos):
4585 * xfns.c (unwind_create_frame):
4586 * xterm.c (x_check_font): Remove unused local.
4587 * scroll.c (CHECK_BOUNDS):
4588 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4589 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4590 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4591 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4592 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4594 (debug_method_add): Use va_list and vsprintf rather than relying
4595 on undefined behavior with wrong number of arguments.
4596 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4597 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4598 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4599 since we're not interested in debugging glyphs with old libraries.
4600 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4601 GCC 4.6.0's static checking.
4603 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4605 Integer overflow and signedness fixes (Bug#8873).
4606 A few related buffer overrun fixes, too.
4608 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4610 * dispextern.h (struct face.stipple):
4611 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4612 (x_bitmap_mask, x_allocate_bitmap_record)
4613 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4614 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4615 (x_create_bitmap_from_xpm_data):
4616 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4617 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4619 * xfaces.c (load_pixmap):
4620 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4621 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4622 (.bitmaps_last, struct x_output.icon_bitmap):
4623 Use ptrdiff_t, not int, for bitmap indexes.
4624 (x_allocate_bitmap_record): Check for size overflow.
4625 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4627 Use ptrdiff_t, not int, for overlay counts.
4628 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4629 * editfns.c (overlays_around, get_pos_property):
4630 * textprop.c (get_char_property_and_overlay):
4631 * xdisp.c (next_overlay_change, note_mouse_highlight):
4632 * xfaces.c (face_at_buffer_position):
4633 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4634 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4635 (Fnext_overlay_change, Fprevious_overlay_change)
4636 (mouse_face_overlay_overlaps, Foverlays_in):
4637 Use ptrdiff_t, not int, for sizes.
4638 (overlays_at, overlays_in): Check for size-calculation overflow.
4640 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4642 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4643 (x_session_initialize): Do not assume string length fits in int.
4645 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4646 This is unlikely, but can occur if DPI is outlandish.
4648 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4649 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4651 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4652 * xrdb.c (magic_file_p, search_magic_path):
4653 Omit last arg SUFFIX; it was always 0. All callers changed.
4654 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4656 * xfont.c (xfont_match): Avoid need for strlen.
4658 * xfns.c: Don't assume strlen fits in int.
4659 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4661 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4662 not unsigned long, as we prefer signed integers. All callers changed.
4663 Detect integer overflow in repeat count.
4664 (message_dolog): Don't assume print length fits in 39 bytes.
4665 (display_mode_element): Don't assume strlen fits in int.
4667 * termcap.c: Don't assume sizes fit in int and never overflow.
4668 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4669 (gobble_line): Check for size-calculation overflow.
4671 * minibuf.c (Fread_buffer):
4672 * lread.c (intern, intern_c_string):
4673 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4674 Don't assume string length fits in int.
4676 * keyboard.c (parse_tool_bar_item):
4677 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4679 * font.c: Don't assume string length fits in int.
4680 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4681 Use ptrdiff_t, not int.
4682 (font_intern_prop): Don't assume string length fits in int.
4683 Don't assume integer property fits in fixnum.
4684 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4686 * filelock.c: Fix some buffer overrun and integer overflow issues.
4687 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4688 Reformulate so as not to need the command string.
4689 Invoke gzip -cd rather than gunzip, as it's more portable.
4690 (lock_info_type, lock_file_1, lock_file):
4691 Don't assume pid_t and time_t fit in unsigned long.
4692 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4693 (current_lock_owner): Prefer signed type for sizes.
4694 Use memcpy, not strncpy, where memcpy is what is really wanted.
4695 Don't assume (via atoi) that time_t and pid_t fit in int.
4696 Check for time_t and/or pid_t out of range, e.g., via a network share.
4697 Don't alloca where an auto var works fine.
4699 * fileio.c: Fix some integer overflow issues.
4700 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4701 Don't assume string length fits in int.
4702 (directory_file_name): Don't assume string length fits in long.
4703 (make_temp_name): Don't assume pid fits in int, or that its print
4704 length is less than 20.
4706 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4708 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4710 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4712 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4713 We prefer signed integers, even for size calculations.
4715 * emacs.c: Don't assume string length fits in 'int'.
4716 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4717 (main): Don't invoke strlen when not needed.
4719 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4720 (XD_DEBUG_MESSAGE): Don't waste a byte.
4722 * callproc.c (getenv_internal_1, getenv_internal)
4724 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4726 * lread.c (invalid_syntax): Omit length argument.
4727 All uses changed. This doesn't fix a bug, but it simplifies the
4728 code away from its former Hollerith-constant appearance, and it's
4729 one less 'int' to worry about when looking at integer-overflow issues.
4730 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4732 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4733 This didn't break anything, but it didn't help either.
4734 It's confusing to put a bogus integer in a place where the actual
4735 value does not matter.
4736 (LIST_END_P): Remove unused macro and its bogus comment.
4737 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4739 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4740 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4742 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4743 We prefer signed types, and the value cannot exceed the EMACS_INT
4744 range anyway (because otherwise the length would not be representable).
4745 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4746 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4747 This avoids a GCC warning when WIDE_EMACS_INT.
4749 * indent.c (sane_tab_width): New function.
4750 (current_column, scan_for_column, Findent_to, position_indentation)
4751 (compute_motion): Use it. This is just for clarity.
4752 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4754 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4756 * lisp.h (lint_assume): New macro.
4757 * composite.c (composition_gstring_put_cache):
4758 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4760 * editfns.c, insdel.c:
4761 Omit unnecessary forward decls, to simplify future changes.
4763 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4765 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4767 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4768 Use much-faster test for byte-length change.
4769 Don't assume string byte-length fits in 'int'.
4770 Check that character arg fits in 'int'.
4771 (mapcar1): Declare byte as byte, for clarity.
4773 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4775 * fns.c (concat): Catch string overflow earlier.
4776 Do not rely on integer wraparound.
4778 * dispextern.h (struct it.overlay_strings_charpos)
4779 (struct it.selective): Now EMACS_INT, not int.
4780 * xdisp.c (forward_to_next_line_start)
4781 (back_to_previous_visible_line_start)
4782 (reseat_at_next_visible_line_start, next_element_from_buffer):
4783 Don't arbitrarily truncate the value of 'selective' to int.
4785 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4787 * composite.c: Don't truncate sizes to 'int'.
4788 (composition_gstring_p, composition_reseat_it)
4789 (composition_adjust_point): Use EMACS_INT, not int.
4790 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4791 not EMACS_UINT, for indexes.
4793 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4795 * buffer.c: Include <verify.h>.
4796 (struct sortvec.priority, struct sortstr.priority):
4797 Now EMACS_INT, not int.
4798 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4799 (struct sortstr.size, record_overlay_string)
4800 (struct sortstrlist.size, struct sortlist.used):
4801 Don't truncate size to int.
4802 (record_overlay_string): Check for size-calculation overflow.
4803 (init_buffer_once): Check at compile-time, not run-time.
4805 2011-06-22 Jim Meyering <meyering@redhat.com>
4807 Don't leak an XBM-image-sized buffer
4808 * image.c (xbm_load): Free the image buffer after using it.
4810 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4813 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4814 that Sun C diagnosed.
4815 * fns.c (secure_hash): Fix pointer signedness issue.
4816 * intervals.c (static_offset_intervals): New function.
4817 (offset_intervals): Use it.
4819 2011-06-21 Leo Liu <sdl.web@gmail.com>
4822 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4825 * fns.c (secure_hash): Rename from crypto_hash_function and change
4826 the first arg to accept symbols.
4827 (Fsecure_hash): New primitive.
4828 (syms_of_fns): New symbols.
4830 2011-06-20 Deniz Dogan <deniz@dogan.se>
4832 * process.c (Fset_process_buffer): Clarify return value in
4835 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4837 * dispnew.c (add_window_display_history): Use BVAR.
4839 * xdisp.c (debug_method_add): Use BVAR.
4840 (check_window_end, dump_glyph_matrix, dump_glyph)
4841 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4843 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4846 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4847 check till after the cache is created in init_frame_faces.
4849 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4851 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4853 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4855 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4856 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4857 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4859 Improve buffer-overflow checking (Bug#8873).
4860 * fileio.c (Finsert_file_contents):
4861 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4862 Remove the old (too-loose) buffer overflow checks.
4863 They weren't needed, since make_gap checks for buffer overflow.
4864 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4865 The old code merely checked for Emacs fixnum overflow, and relied
4866 on undefined (wraparound) behavior. The new code avoids undefined
4867 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4869 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4870 Tune. Don't use wider integers than needed. Don't use alloca.
4871 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4873 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4875 * insdel.c, lisp.h (buffer_overflow): New function.
4876 (insert_from_buffer_1, replace_range, replace_range_2):
4877 * insdel.c (make_gap_larger):
4878 * editfns.c (Finsert_char):
4879 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4881 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4883 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4885 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4887 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4888 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4890 * fileio.c: Don't assume EMACS_INT fits in off_t.
4891 (emacs_lseek): New static function.
4892 (Finsert_file_contents, Fwrite_region): Use it.
4893 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4895 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4897 * fns.c: Don't overflow int when computing a list length.
4898 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4899 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4900 truncation on 64-bit hosts. Check for QUIT every
4901 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4902 faster and is responsive enough.
4903 (Flength): Report an error instead of overflowing an integer.
4904 (Fsafe_length): Return a float if the value is not representable
4905 as a fixnum. This shouldn't happen except in contrived situations.
4906 (Fnthcdr, Fsort): Don't assume list length fits in int.
4907 (Fcopy_sequence): Don't assume vector length fits in int.
4909 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4910 (header_size, word_size): New constants.
4911 (allocate_vectorlike): Don't check size overflow here.
4912 (allocate_vector): Check it here instead, since this is the only
4913 caller of allocate_vectorlike that could cause overflow.
4914 Check that the new vector's length is representable as a fixnum.
4916 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4917 The previous code was bogus. For example, next_almost_prime (32)
4918 returned 39, which is undesirable as it is a multiple of 3; and
4919 next_almost_prime (24) returned 25, which is a multiple of 5 so
4920 why was the code bothering to check for multiples of 7?
4922 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4924 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4926 Variadic C functions now count arguments with ptrdiff_t.
4927 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4928 Back then I didn't know that the Emacs coding style prefers signed int.
4929 Also, in the meantime I found a few more instances where arguments
4930 were being counted with int, which may truncate counts on 64-bit
4931 machines, or EMACS_INT, which may be unnecessarily wide.
4932 * lisp.h (struct Lisp_Subr.function.aMANY)
4933 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4934 Arg counts are now ptrdiff_t, not size_t.
4935 All variadic functions and their callers changed accordingly.
4936 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4937 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4938 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4939 * callint.c (Fcall_interactively): Check arg count for overflow,
4940 to avoid potential buffer overrun. Use signed char, not 'int',
4941 for 'varies' array, so that we needn't bother to check its size
4942 calculation for overflow.
4943 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4944 * eval.c (apply_lambda):
4945 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4946 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4947 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4949 * callint.c (Fcall_interactively): Don't use index var as event count.
4951 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4952 * mem-limits.h (SIZE): Remove; no longer used.
4954 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4956 Remove unnecessary casts.
4957 * xterm.c (x_term_init):
4958 * xfns.c (x_set_border_pixel):
4959 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4960 These aren't needed now that we assume ANSI C.
4962 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4963 It's more likely to cause problems (due to unsigned overflow)
4966 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4968 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4970 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4972 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4974 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4976 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4978 GLYPH_CODE_FACE returns EMACS_INT, not int.
4979 * dispextern.h (merge_faces):
4980 * xfaces.c (merge_faces):
4981 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4982 Don't assume EMACS_INT fits in int.
4984 * character.h (CHAR_VALID_P): Remove unused parameter.
4985 * fontset.c, lisp.h, xdisp.c: All uses changed.
4987 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4989 * fns.c (concat): Minor tuning based on overflow analysis.
4990 This doesn't fix any bugs. Use int to hold character, instead
4991 of constantly refetching from Emacs object. Use XFASTINT, not
4992 XINT, for value known to be a character. Don't bother comparing
4993 a single byte to 0400, as it's always less.
4995 * floatfns.c (Fexpt):
4996 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4998 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5001 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5003 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5004 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5005 incorrectly succeed when S was a string, because 4294967386 was
5006 truncated before it was used.
5008 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5009 Otherwise, an out-of-range integer could cause undefined behavior
5012 * composite.c: Use int, not EMACS_INT, for characters.
5013 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5014 EMACS_INT, for values that are known to be in character range.
5015 This doesn't fix any bugs but is the usual style inside Emacs and
5016 may generate better code on 32-bit machines.
5018 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5019 This is for reasons similar to the recent CHAR_STRING fix.
5020 * charset.c (Fencode_char): Check that character arg is actually
5021 a character. Pass an int to ENCODE_CHAR.
5022 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5023 wider than 'int', as a compile-time check to prevent future regressions
5026 * character.c (char_string): Remove unnecessary casts.
5028 Make sure a 64-bit char is never passed to CHAR_STRING.
5029 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5030 by silently ignoring the top 32 bits, allowing some values
5031 that were far too large to be valid characters.
5032 * character.h: Include <verify.h>.
5033 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5034 arguments are no wider than unsigned, as a compile-time check
5035 to prevent future regressions in this area.
5037 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5038 (Fsubst_char_in_region):
5040 * xdisp.c (decode_mode_spec_coding):
5041 Adjust to CHAR_STRING's new requirement.
5042 * editfns.c (Finsert_char, Fsubst_char_in_region):
5043 * fns.c (concat): Check that character args are actually
5044 characters. Without this test, these functions did the wrong
5045 thing with wildly out-of-range values on 64-bit hosts.
5047 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5048 These casts should not be needed on 32-bit hosts, either.
5049 * keyboard.c (read_char):
5050 * lread.c (Fload): Remove casts to unsigned.
5052 * lisp.h (UNSIGNED_CMP): New macro.
5053 This fixes comparison bugs on 64-bit hosts.
5054 (ASCII_CHAR_P): Use it.
5055 * casefiddle.c (casify_object):
5056 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5057 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5058 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5059 * dispextern.h (FACE_FROM_ID):
5060 * keyboard.c (read_char): Use UNSIGNED_CMP.
5062 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5063 not to EMACS_INT, to avoid GCC warning.
5065 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5067 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5068 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5069 isn't needed on 32-bit machines.
5071 * buffer.c (Fgenerate_new_buffer_name):
5072 Use EMACS_INT for count, not int.
5073 (advance_to_char_boundary): Return EMACS_INT, not int.
5075 * data.c (Qcompiled_function): Now static.
5077 * window.c (window_body_lines): Now static.
5079 * image.c (gif_load): Rename local to avoid shadowing.
5081 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5082 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5083 * alloc.c (make_save_value): Integer argument is now of type
5085 (mark_object): Use ptrdiff_t, not int.
5086 * lisp.h (pD): New macro.
5087 * print.c (print_object): Use it.
5089 * alloc.c: Use EMACS_INT, not int, to count objects.
5090 (total_conses, total_markers, total_symbols, total_vector_size)
5091 (total_free_conses, total_free_markers, total_free_symbols)
5092 (total_free_floats, total_floats, total_free_intervals)
5093 (total_intervals, total_strings, total_free_strings):
5094 Now EMACS_INT, not int. All uses changed.
5095 (Fgarbage_collect): Compute overall total using a double, so that
5096 integer overflow is less likely to be a problem. Check for overflow
5097 when converting back to an integer.
5098 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5099 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5100 These were 'int' variables that could overflow on 64-bit hosts;
5101 they were never used, so remove them instead of repairing them.
5102 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5103 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5104 Previously, this ceilinged at INT_MAX, but that doesn't work on
5106 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5108 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5109 (allocate_vectorlike): Check for ptrdiff_t overflow.
5110 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5111 when a (possibly-narrower) signed value would do just as well.
5112 We prefer using signed arithmetic, to avoid comparison confusion.
5114 * alloc.c: Catch some string size overflows that we were missing.
5115 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5116 for convenience in STRING_BYTES_MAX.
5117 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5118 The definition here is exact; the one in lisp.h was approximate.
5119 (allocate_string_data): Check for string overflow. This catches
5120 some instances we weren't catching before. Also, it catches
5121 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5122 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5123 and ptrdiff_t and EMACS_INT are both 64 bits.
5125 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5126 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5127 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5129 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5131 * alloc.c (Fmake_string): Check for out-of-range init.
5133 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5135 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5137 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5139 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5140 xg_get_default_scrollbar_width.
5142 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5143 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5144 (style_changed_cb): Call update_theme_scrollbar_width and call
5145 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5146 all frames (Bug#8505).
5147 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5148 Call gtk_window_set_resizable if HAVE_GTK3.
5149 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5150 and height if HAVE_GTK3 (Bug#8505).
5151 (scroll_bar_width_for_theme): New variable.
5152 (update_theme_scrollbar_width): New function.
5153 (xg_get_default_scrollbar_width): Move code to
5154 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5155 (xg_initialize): Call update_theme_scrollbar_width.
5157 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5159 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5161 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5163 * frame.c (make_frame): Call other_buffer_safely instead of
5166 * window.c (temp_output_buffer_show): Call display_buffer with
5167 second argument Vtemp_buffer_show_specifiers and reset latter
5168 immediately after the call.
5169 (Vtemp_buffer_show_specifiers): New variable.
5170 (auto_window_vscroll_p, next_screen_context_lines)
5171 (Vscroll_preserve_screen_position): Remove leading asterisks from
5174 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5176 Fix minor problems found by GCC 4.6.0 static checking.
5177 * buffer.c (Qclone_number): Remove for now, as it's unused.
5178 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5179 (record_buffer): Remove unused local.
5180 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5181 (set_frame_buffer_list): Remove; unused.
5182 * frame.h (other_visible_frames): Remove decl.
5183 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5184 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5185 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5187 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5188 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5189 Define only if HAVE_GPM.
5190 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5191 (update_hints_inhibit): Remove; never set. All uses removed.
5192 * widgetprv.h (emacsFrameClassRec): Remove decl.
5193 * window.c (delete_deletable_window): Now returns void, since it
5194 wasn't returning anything.
5195 (compare_window_configurations): Remove unused locals.
5196 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5197 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5198 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5199 the same widths as pointers. This follows up on the 2011-05-06 patch.
5200 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5201 * xterm.h: Likewise.
5202 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5204 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5206 * makefile.w32-in: Update dependencies.
5207 (LISP_H): Add lib/intprops.h.
5209 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5211 * image.c (gif_load): Add animation frame delay to the metadata.
5212 (syms_of_image): Use DEFSYM. New symbol `delay'.
5214 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5216 * window.c (delete_deletable_window): Re-add.
5217 (Fset_window_configuration): Rewrite to handle dead buffers and
5218 consequently deletable windows.
5219 (window_tree, Fwindow_tree): Remove. Supply functionality in
5221 (compare_window_configurations): Simplify code.
5223 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5225 * image.c (imagemagick_load_image): Fix type mismatch.
5226 (Fimagemagick_types): Likewise.
5228 * window.h (replace_buffer_in_windows): Declare.
5230 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5232 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5233 Qclone_number. Remove external declaration of Qdelete_window.
5234 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5236 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5237 Run Qbuffer_list_update_hook if allowed.
5238 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5239 buffer list implementation.
5240 (other_buffer_safely): New function.
5241 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5242 calls to replace_buffer_in_windows and
5243 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5245 (record_buffer): Inhibit quitting and rewrite using quittable
5246 functions. Run Qbuffer_list_update_hook if allowed.
5247 (Frecord_buffer, Funrecord_buffer): New functions.
5248 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5249 Move switch-to-buffer to window.el.
5250 (bury-buffer): Move to window.el.
5251 (Vbuffer_list_update_hook): New variable.
5253 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5256 * window.h (resize_frame_windows): Move up in code.
5257 (Fwindow_frame): Remove EXFUN.
5258 (replace_buffer_in_all_windows): Remove prototype.
5259 (replace_buffer_in_windows_safely): Add prototype.
5261 * window.c: Declare Qdelete_window static again. Move down
5262 declaration of select_count.
5263 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5264 (Fother_window): Move to window.el.
5265 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5266 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5267 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5269 (replace_buffer_in_windows): Implement by calling
5270 Qreplace_buffer_in_windows.
5271 (replace_buffer_in_all_windows): Remove with some functionality
5272 moved into replace_buffer_in_windows_safely.
5273 (replace_buffer_in_windows_safely): New function.
5274 (select_window_norecord, select_frame_norecord): Move in front
5275 of run_window_configuration_change_hook. Remove now obsolete
5277 (Fset_window_buffer): Rewrite doc-string.
5278 Call Qrecord_window_buffer.
5279 (keys_of_window): Move binding for other-window to window.el.
5281 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5283 * dispextern.h (struct image): Replace data member, whose int_val
5284 and ptr_val fields were not used by anything, with a single
5287 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5288 (gif_clear_image, gif_load, imagemagick_load_image)
5289 (gs_clear_image, gs_load): Callers changed.
5291 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5293 * buffer.h: Include <time.h>, for time_t.
5294 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5296 Fix minor problems found by static checking.
5298 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5300 Make identifiers static if they are not used in other modules.
5301 * data.c (Qcompiled_function, Qframe, Qvector):
5302 * image.c (QimageMagick, Qsvg):
5303 * minibuf.c (Qmetadata):
5304 * window.c (resize_window_check, resize_root_window): Now static.
5305 * window.h (resize_window_check, resize_root_window): Remove decls.
5307 * window.c (window_deletion_count, delete_deletable_window):
5309 (window_body_lines): Now static.
5310 (Fdelete_other_windows_internal): Mark vars as initialized.
5311 Make sure 'resize_failed' is initialized.
5312 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5313 (resize_window_apply): Remove unused local.
5314 * window.h (delete_deletable_window): Remove decl.
5316 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5317 (imagemagick_load_image): Fix pointer signedness problem by changing
5318 last arg from unsigned char * to char *. All uses changed.
5319 Also, fix a local for similar reasons.
5320 Remove unused locals. Remove locals to avoid shadowing.
5321 (fn_rsvg_handle_free): Remove; unused.
5322 (svg_load, svg_load_image): Fix pointer signedness problem.
5323 (imagemagick_load_image): Don't use garbage pointer image_wand.
5325 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5327 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5329 * image.c (gif_load): Fix omitted cast error introduced by
5332 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5334 * window.h (resize_proportionally, orig_total_lines)
5335 (orig_top_line): Remove from window structure.
5336 (set_window_height, set_window_width, change_window_heights)
5337 (Fdelete_window): Remove prototypes.
5338 (resize_frame_windows): Remove duplicate declaration.
5340 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5342 * window.h (resize_frame_windows, resize_window_check)
5343 (delete_deletable_window, resize_root_window)
5344 (resize_frame_windows): Declare prototypes.
5346 * window.c (resize_window_apply): Make definition be "static" to
5347 match the prototype.
5349 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5351 * window.c: Remove declarations of Qwindow_size_fixed,
5352 window_min_size_1, window_min_size_2, window_min_size,
5353 size_window, window_fixed_size_p, enlarge_window, delete_window.
5354 Remove static from declaration of Qdelete_window, it's
5355 temporarily needed by Fbury_buffer.
5356 (replace_window): Don't assign orig_top_line and
5358 (Fdelete_window, delete_window): Remove. Window deletion is
5359 handled by window.el.
5360 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5361 Replace Fdelete_window calls with calls to Qdelete_window.
5362 (Fdelete_other_windows): Remove. Deleting other windows is
5363 handled by window.el.
5364 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5365 handled in window.el.
5366 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5367 Window minimum sizes are handled in window.el.
5368 (shrink_windows, size_window, set_window_height)
5369 (set_window_width, change_window_heights, window_height)
5370 (window_width, CURBEG, CURSIZE, enlarge_window)
5371 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5372 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5373 handled in window.el.
5374 (make_dummy_parent): Rename to make_parent_window and give it a
5375 second argument horflag.
5376 (make_window): Don't set resize_proportionally any more.
5377 (Fsplit_window): Remove. Windows are split in window.el.
5378 (save_restore_action, save_restore_orig_size)
5379 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5380 Resize mini windows in window.el.
5381 (grow_mini_window, shrink_mini_window): Implement by calling
5382 Qresize_root_window_vertically, resize_window_check and
5383 resize_window_apply.
5384 (saved_window, Fset_window_configuration, save_window_save):
5385 Do not handle orig_top_line, orig_total_lines, and
5386 resize_proportionally.
5387 (window_min_height, window_min_width): Move to window.el.
5388 (keys_of_window): Move bindings for delete-other-windows,
5389 split-window, delete-window and enlarge-window to window.el.
5391 * buffer.c: Temporarily extern Qdelete_window.
5392 (Fbury_buffer): Temporarily call Qdelete_window instead of
5393 Fdelete_window (Fbury_buffer will move to window.el soon).
5395 * frame.c (set_menu_bar_lines_1): Remove code handling
5396 orig_top_line and orig_total_lines.
5398 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5399 set_window_height but set heights directly.
5400 (change_frame_size_1): Use resize_frame_windows.
5402 * xdisp.c (init_xdisp): Don't use set_window_height but set
5405 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5406 Use resize_frame_windows instead of change_window_heights and run
5407 run_window_configuration_change_hook.
5409 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5410 instead of change_window_heights and run
5411 run_window_configuration_change_hook.
5413 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5415 * window.c (replace_window): Rename second argument REPLACEMENT to
5416 NEW. New third argument SETFLAG. Rewrite.
5417 (delete_window, make_dummy_parent): Call replace_window with
5419 (window_list_1): Move down in code.
5420 (run_window_configuration_change_hook): Move set_buffer part
5421 before select_frame_norecord part in order to unwind correctly.
5422 Rename count1 to count.
5423 (recombine_windows, delete_deletable_window, resize_root_window)
5424 (Fdelete_other_windows_internal)
5425 (Frun_window_configuration_change_hook, make_parent_window)
5426 (resize_window_check, resize_window_apply, Fresize_window_apply)
5427 (resize_frame_windows, Fsplit_window_internal)
5428 (Fdelete_window_internal, Fresize_mini_window_internal):
5430 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5432 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5434 * window.h (window): Add some new members to window structure -
5435 normal_lines, normal_cols, new_total, new_normal, clone_number,
5436 splits, nest, prev_buffers, next_buffers.
5437 (WINDOW_TOTAL_SIZE): Move here from window.c.
5438 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5440 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5442 (make_dummy_parent): Set new members of windows structure.
5443 (make_window): Move down in code. Handle new members of window
5445 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5446 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5447 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5448 (Fset_window_prev_buffers, Fwindow_next_buffers)
5449 (Fset_window_next_buffers, Fset_window_clone_number):
5451 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5452 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5454 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5455 Argument WINDOW can be now internal window too.
5456 (Fwindow_use_time): Move up in code.
5457 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5459 (Fset_window_configuration, saved_window)
5460 (Fcurrent_window_configuration, save_window_save): Handle new
5461 members of window structure.
5462 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5463 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5464 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5465 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5466 Qget_mru_window, Qresize_root_window,
5467 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5468 Qauto_buffer_name; staticpro them.
5470 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5472 * window.c (Fwindow_total_size, Fwindow_left_column)
5473 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5474 (Fwindow_list_1): New functions.
5475 (window_box_text_cols): Replace with window_body_cols.
5476 (Fwindow_width, Fscroll_left, Fscroll_right):
5477 Use window_body_cols instead of window_box_text_cols.
5478 (delete_window, Fset_window_configuration):
5479 Call delete_all_subwindows with window as argument.
5480 (delete_all_subwindows): Take a window as argument and not a
5482 (window_loop): Remove handling of GET_LRU_WINDOW and
5484 (Fget_lru_window, Fget_largest_window): Move to window.el.
5486 * window.h: Extern window_body_cols instead of
5487 window_box_text_cols. delete_all_subwindows now takes a
5488 Lisp_Object as argument.
5490 * indent.c (compute_motion, Fcompute_motion):
5491 Use window_body_cols instead of window_box_text_cols.
5493 * frame.c (delete_frame): Call delete_all_subwindows with root
5496 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5498 * fns.c (Fputhash): Document return value.
5500 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5502 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5504 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5506 Cons<->int and similar integer overflow fixes (Bug#8794).
5508 Check for overflow when converting integer to cons and back.
5509 * charset.c (Fdefine_charset_internal, Fdecode_char):
5510 Use cons_to_unsigned to catch overflow.
5511 (Fencode_char): Use INTEGER_TO_CONS.
5512 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5513 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5514 * data.c (long_to_cons, cons_to_long): Remove.
5515 (cons_to_unsigned, cons_to_signed): New functions.
5516 These signal an error for invalid or out-of-range values.
5517 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5518 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5519 * font.c (Ffont_variation_glyphs):
5520 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5521 * lisp.h: Include <intprops.h>.
5522 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5523 (cons_to_signed, cons_to_unsigned): New decls.
5524 (long_to_cons, cons_to_long): Remove decls.
5525 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5526 (Fprimitive_undo): Use CONS_TO_INTEGER.
5527 * xfns.c (Fx_window_property): Likewise.
5528 * xselect.c: Include <limits.h>.
5529 (x_own_selection, selection_data_to_lisp_data):
5530 Use INTEGER_TO_CONS.
5531 (x_handle_selection_request, x_handle_selection_clear)
5532 (x_get_foreign_selection, Fx_disown_selection_internal)
5533 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5534 (lisp_data_to_selection_data): Use cons_to_unsigned.
5535 (x_fill_property_data): Use cons_to_signed.
5536 Report values out of range.
5538 Check for buffer and string overflow more precisely.
5539 * buffer.h (BUF_BYTES_MAX): New macro.
5540 * lisp.h (STRING_BYTES_MAX): New macro.
5541 * alloc.c (Fmake_string):
5542 * character.c (string_escape_byte8):
5543 * coding.c (coding_alloc_by_realloc):
5544 * doprnt.c (doprnt):
5545 * editfns.c (Fformat):
5547 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5548 since they may not be the same number.
5549 * editfns.c (Finsert_char):
5550 * fileio.c (Finsert_file_contents):
5551 Likewise for BUF_BYTES_MAX.
5553 * image.c: Use ptrdiff_t, not int, for sizes.
5554 (slurp_file): Switch from int to ptrdiff_t.
5556 (slurp_file): Check that file size fits in both size_t (for
5557 malloc) and ptrdiff_t (for sanity and safety).
5559 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5560 if b->modtime has its maximal value.
5562 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5564 Don't assume time_t can fit into int.
5565 * buffer.h (struct buffer.modtime): Now time_t, not int.
5566 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5567 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5569 Minor fixes for signed vs unsigned integers.
5570 * character.h (MAYBE_UNIFY_CHAR):
5571 * charset.c (maybe_unify_char):
5572 * keyboard.c (read_char, reorder_modifiers):
5573 XINT -> XFASTINT, since the integer must be nonnegative.
5574 * ftfont.c (ftfont_spec_pattern):
5575 * keymap.c (access_keymap, silly_event_symbol_error):
5576 XUINT -> XFASTINT, since the integer must be nonnegative.
5577 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5578 since it makes no difference and we prefer signed.
5579 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5580 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5583 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5585 * window.h (Fwindow_frame): Declare.
5587 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5589 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5590 (SPARE_MEMORY): Always define.
5591 (LARGE_REQUEST): Remove.
5592 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5594 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5596 * lisp.h: Move EXFUNS for Fframe_root_window,
5597 Fframe_first_window and Fset_frame_selected_window to window.h.
5599 * window.h: Move EXFUNS for Fframe_root_window,
5600 Fframe_first_window and Fset_frame_selected_window here from
5603 * frame.c (Fwindow_frame, Fframe_first_window)
5604 (Fframe_root_window, Fframe_selected_window)
5605 (Fset_frame_selected_window): Move to window.c.
5606 (Factive_minibuffer_window): Move to minibuf.c.
5607 (Fother_visible_frames_p): New function.
5609 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5611 * window.c (decode_window, decode_any_window): Move up in code.
5612 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5613 (inhibit_frame_unsplittable): Remove unused variable.
5614 (Fwindow_buffer): Move up and rewrite doc-string.
5615 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5616 (Fwindow_prev): New functions.
5617 (Fwindow_frame): Move here from frame.c. Accept any window as
5619 (Fframe_root_window, Fframe_first_window)
5620 (Fframe_selected_window): Move here from frame.c. Accept frame
5621 or arbitrary window as argument. Update doc-strings.
5622 (Fminibuffer_window): Move up in code.
5623 (Fwindow_minibuffer_p): Move up in code and simplify.
5624 (Fset_frame_selected_window): Move here from frame.c.
5626 (Fselected_window, select_window, Fselect_window): Move up in
5627 code. Minor doc-string fixes.
5629 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5631 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5632 Do not assume that spare memory exists; that assumption is valid
5633 only if SYSTEM_MALLOC.
5634 (LARGE_REQUEST): New macro, so that the issue of large requests
5635 is separated from the issue of spare memory.
5637 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5639 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5642 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5644 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5647 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5649 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5651 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5653 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5654 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5656 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5658 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5660 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5662 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5663 (x_clipboard_manager_save): Add return value.
5664 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5666 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5667 Obey Vx_select_enable_clipboard_manager. Catch errors in
5668 x_clipboard_manager_save (Bug#8779).
5669 (Vx_select_enable_clipboard_manager): New variable.
5670 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5672 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5674 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5676 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5678 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5679 in the current matrix if keep_current_p is non-zero.
5681 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5683 * bidi.c (bidi_level_of_next_char): Fix last change.
5685 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5687 Support bidi reordering of text covered by display properties.
5689 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5690 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5691 (bidi_cache_search, bidi_cache_iterator_state)
5692 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5693 (bidi_level_of_next_char, bidi_move_to_visually_next):
5694 Support character positions inside a run of characters covered by a
5696 (bidi_paragraph_init, bidi_resolve_explicit_1)
5697 (bidi_level_of_next_char): Call bidi_fetch_char and
5698 bidi_fetch_char_advance instead of FETCH_CHAR and
5700 (bidi_init_it): Initialize new members.
5701 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5703 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5704 instead of using explicit *_CHAR codes.
5705 (bidi_resolve_explicit, bidi_resolve_weak):
5706 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5707 bidirectional text is supported only in multibyte buffers.
5708 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5709 it to initialize the frame_window_p member of struct bidi_it.
5710 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5711 (bidi_resolve_explicit, bidi_resolve_weak)
5712 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5713 bidi_it->nchars is non-positive.
5714 (bidi_level_of_next_char): Don't try to lookup the cache for the
5715 next/previous character if nothing is cached there yet, or if we
5716 were just reseat()'ed to a new position.
5718 * xdisp.c (set_cursor_from_row): Set start and stop points
5719 according to the row's direction when priming the loop that looks
5720 for the glyph on which to display cursor.
5721 (single_display_spec_intangible_p): Function deleted.
5722 (display_prop_intangible_p): Reimplement to call
5723 handle_display_spec instead of single_display_spec_intangible_p.
5724 Accept 3 additional arguments needed by handle_display_spec.
5725 This fixes incorrect cursor motion across display property with complex
5726 values: lists, `(when COND...)' forms, etc.
5727 (single_display_spec_string_p): Support property values that are
5728 lists with the argument STRING its top-level element.
5729 (display_prop_string_p): Fix the condition for processing a
5730 property that is a list to be consistent with handle_display_spec.
5731 (handle_display_spec): New function, refactored from the
5732 last portion of handle_display_prop.
5733 (compute_display_string_pos): Accept additional argument
5734 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5735 value of a `display' property is a "replacing spec".
5736 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5737 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5738 the display property, but just return a value indicating whether
5739 the display property will replace the characters it covers.
5740 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5741 frame_window_p members of struct bidi_it.
5742 (compute_display_string_pos, compute_display_string_end):
5744 (push_it): Accept second argument POSITION, where pop_it should
5745 jump to continue iteration.
5746 (reseat_1): Initialize bidi_it.disp_pos.
5748 * keyboard.c (adjust_point_for_property): Adjust the call to
5749 display_prop_intangible_p to its new signature.
5751 * dispextern.h (struct bidi_it): New member frame_window_p.
5752 (bidi_init_it): Update prototypes.
5753 (display_prop_intangible_p): Update prototype.
5754 (compute_display_string_pos, compute_display_string_end):
5756 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5759 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5761 Malloc failure behavior now depends on size of allocation.
5762 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5763 * lisp.h: Change signatures accordingly.
5764 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5765 All callers changed. (Bug#8762)
5767 * gnutls.c: Use Emacs's memory allocators.
5768 Without this change, the gnutls library would invoke malloc etc.
5769 directly, which causes problems on non-SYNC_INPUT hosts, and which
5770 runs afoul of improving memory_full behavior. (Bug#8761)
5771 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5772 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5773 xfree instead of the default malloc, realloc, free.
5774 (Fgnutls_boot): No need to check for memory allocation failure,
5775 since xmalloc does that for us.
5777 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5778 * category.c (hash_get_category_set):
5779 * ccl.c (ccl_driver):
5780 * charset.c (Fdefine_charset_internal):
5781 * charset.h (struct charset.hash_index):
5782 * composite.c (get_composition_id, gstring_lookup_cache)
5783 (composition_gstring_put_cache):
5784 * composite.h (struct composition.hash_index):
5785 * dispextern.h (struct image.hash):
5786 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5787 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5788 (hashfn_equal, hashfn_user_defined, make_hash_table)
5789 (maybe_resize_hash_table, hash_lookup, hash_put)
5790 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5791 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5792 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5793 * image.c (make_image, search_image_cache, lookup_image)
5794 (xpm_put_color_table_h):
5795 * lisp.h (struct Lisp_Hash_Table):
5796 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5797 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5798 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5799 * alloc.c (allocate_vectorlike):
5800 Check for overflow in vector size calculations.
5801 * ccl.c (ccl_driver):
5802 Check for overflow when converting EMACS_INT to int.
5803 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5804 need to be updated by these changes.
5805 * fns.c (make_hash_table, maybe_resize_hash_table):
5806 Check for integer overflow with large hash tables.
5807 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5808 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5809 (SXHASH_REDUCE): New macro.
5810 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5811 Use it instead of discarding useful hash info with large hash values.
5812 (sxhash_float): New function.
5813 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5814 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5815 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5816 Rewrite to use FIXNUM_BITS, as this simplifies things.
5817 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5818 Adjust signatures to match updated version of code.
5819 (consing_since_gc): Now EMACS_INT, since a single hash table can
5820 use more than INT_MAX bytes.
5822 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5824 Make it possible to build with GCC-4.6+ -O2 -flto.
5826 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5828 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5830 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5831 Call minibuffer-inactive-mode.
5833 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5835 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5836 Update dependencies.
5838 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5840 * data.c (init_data): Remove code for UTS, this system is not
5843 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5845 Don't force ./temacs to start in terminal mode.
5847 * frame.c (make_initial_frame): Initialize faces in all cases, not
5848 only when CANNOT_DUMP is defined.
5849 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5851 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5853 * dispnew.c (add_window_display_history): Use const for the string
5854 pointer. Remove declaration, not needed.
5856 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5858 Use 'inline', not 'INLINE'.
5859 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5860 * alloc.c, fontset.c (INLINE): Remove.
5861 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5862 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5863 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5864 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5865 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5867 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5869 Make it possible to run ./temacs.
5871 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5872 syms_of_callproc does the same thing. Remove test for
5873 "initialized", do it in the caller.
5874 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5876 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5878 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5879 (read_minibuf): Use get_minibuffer.
5880 (syms_of_minibuf): Use DEFSYM.
5881 (Qmetadata): New var.
5882 * data.c (Qbuffer): Don't make it static.
5883 (syms_of_data): Use DEFSYM.
5885 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5887 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5888 (CCL_CODE_MIN): New macro.
5890 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5892 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5894 * eval.c (Qdebug): Now static.
5895 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5896 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5897 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5899 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5901 * image.c: Various fixes to ImageMagick code comments.
5902 (Fimagemagick_types): Doc fix.
5904 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5906 Minor fixes prompted by GCC 4.6.0 warnings.
5908 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5910 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5911 (x_clipboard_manager_save_all): Move extern decl to ...
5912 * xterm.h: ... here, so that it can be checked for consistency.
5914 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5916 * xselect.c (x_clipboard_manager_save_frame)
5917 (x_clipboard_manager_save_all): New functions.
5918 (Fx_clipboard_manager_save): Lisp function deleted.
5920 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5921 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5923 * xterm.h: Update prototype.
5925 2011-05-28 William Xu <william.xwl@gmail.com>
5927 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5930 2011-05-28 Jim Meyering <meyering@redhat.com>
5932 Avoid a sign-extension bug in crypto_hash_function.
5933 * fns.c (to_uchar): Define.
5934 (crypto_hash_function): Use it to convert some newly-signed
5935 variables to unsigned, to avoid sign-extension bugs. For example,
5936 without this change, (md5 "truc") would evaluate to
5937 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5938 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5939 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5941 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5943 Integer overflow fixes.
5945 * dbusbind.c: Serial number integer overflow fixes.
5946 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5947 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5948 to hold a serial number that is too large for a fixnum.
5949 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5950 Check for serial numbers out of range. Decode any serial number
5951 that was so large that it became a float. (Bug#8722)
5953 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5954 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5955 Use XFASTINT rather than XUINT when numbers are nonnegative.
5956 (xd_append_arg, Fdbus_method_return_internal):
5957 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5958 arguments, check that Lisp number is nonnegative, rather than
5959 silently wrapping negative numbers around. (Bug#8722)
5960 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5963 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5965 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5967 ccl: Add integer overflow checks.
5968 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5969 (IN_INT_RANGE): New macros.
5970 (ccl_driver): Use them to check for integer overflow when
5971 decoding a CCL program. Many of the new checks are whether XINT (x)
5972 fits in int; it doesn't always, on 64-bit hosts. The new version
5973 doesn't catch all possible integer overflows, but it's an
5974 improvement. (Bug#8719)
5976 * alloc.c (make_event_array): Use XINT, not XUINT.
5977 There's no need for unsigned here.
5979 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5980 This follows up to the 2011-05-06 change that substituted uintptr_t
5981 for EMACS_INT. This case wasn't caught back then.
5983 Rework Fformat to avoid integer overflow issues.
5984 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5985 now (part of C89). Include <verify.h>.
5986 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5987 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5988 (Fformat): Avoid the prepass trying to compute sizes; it was only
5989 approximate and thus did not catch overflow reliably. Instead, walk
5990 through the format just once, formatting and computing sizes as we go,
5991 checking for integer overflow at every step, and allocating a larger
5992 buffer as needed. Keep track separately whether the format is
5993 multibyte. Keep only the most-recently calculated precision, rather
5994 than them all. Record whether each argument has been converted to
5995 string. Use EMACS_INT, not int, for byte and char and arg counts.
5996 Support field widths and precisions larger than INT_MAX. Avoid
5997 sprintf's undefined behavior with conversion specifications such as %#d
5998 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5999 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6000 formatting out-of-range floating point numbers with int
6003 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6005 * data.c: Avoid integer truncation in expressions involving floats.
6006 * data.c: Include <intprops.h>.
6007 (arith_driver): When there's an integer overflow in an expression
6008 involving floating point, convert the integers to floating point
6009 so that the resulting value does not suffer from catastrophic
6010 integer truncation. For example, on a 64-bit host (* 4
6011 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6012 Do not rely on undefined behavior after integer overflow.
6014 merge count_size_as_multibyte, parse_str_to_multibyte
6015 * character.c, character.h (count_size_as_multibyte):
6016 Rename from parse_str_to_multibyte; all uses changed.
6017 Check for integer overflow.
6018 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6019 since it's now a duplicate of the other. This is more of
6020 a character than a buffer op, so better that it's in character.c.
6021 * fns.c, print.c: Adjust to above changes.
6023 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6025 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6027 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6029 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6030 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6031 (x_clipboard_manager_save): Now static.
6032 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6034 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6035 (crypto_hash_function): Now static.
6036 Fix pointer signedness problems. Avoid unnecessary initializations.
6038 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6040 * termhooks.h (Vselection_alist): Make it terminal-local.
6042 * terminal.c (create_terminal): Initialize it.
6044 * xselect.c: Support for clipboard managers.
6045 (Vselection_alist): Move to termhooks.h as terminal-local var.
6046 (LOCAL_SELECTION): New macro.
6047 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6048 (symbol_to_x_atom): Remove gratuitous arg.
6049 (x_handle_selection_request, lisp_data_to_selection_data)
6050 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6051 (x_own_selection, x_get_local_selection, x_convert_selection):
6052 New arg, specifying work frame. Use terminal-local Vselection_alist.
6053 (some_frame_on_display): Delete unused function.
6054 (Fx_own_selection_internal, Fx_get_selection_internal)
6055 (Fx_disown_selection_internal, Fx_selection_owner_p)
6056 (Fx_selection_exists_p): New optional frame arg.
6057 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6058 (x_handle_selection_clear): Don't treat other terminals with the
6059 same keyboard specially. Use the terminal-local Vselection_alist.
6060 (x_clear_frame_selections): Use Frun_hook_with_args.
6062 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6064 * xterm.h: Add support for those atoms.
6066 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6068 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6069 (converted_selections, conversion_fail_tag): New global variables.
6070 (x_selection_request_lisp_error): Free the above.
6071 (x_get_local_selection): Remove unnecessary code.
6072 (x_reply_selection_request): Args changed; handle arbitrary array
6073 of converted selections stored in converted_selections.
6074 Separate the XChangeProperty and SelectionNotify steps.
6075 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6076 (x_convert_selection): New function.
6077 (x_handle_selection_event): Simplify.
6078 (x_get_foreign_selection): Don't ignore incoming requests while
6079 waiting for an answer; this will fail when we implement
6080 SAVE_TARGETS, and seems unnecessary anyway.
6081 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6082 (Vx_sent_selection_functions): Doc fix.
6084 2011-05-26 Leo Liu <sdl.web@gmail.com>
6086 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6088 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6090 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6092 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6093 for fringe update if it has periodic bitmap.
6094 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6095 and fringe_bitmap_periodic_p.
6097 * fringe.c (get_fringe_bitmap_data): New function.
6098 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6099 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6100 row. Mark glyph row for fringe update if periodicity changed.
6102 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6103 for fringe update unless it has periodic bitmap.
6105 2011-05-25 Kenichi Handa <handa@m17n.org>
6107 * xdisp.c (get_next_display_element): Set correct it->face_id for
6108 a static composition.
6110 2011-05-24 Leo Liu <sdl.web@gmail.com>
6113 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6115 * fns.c (crypto_hash_function, Fsha1): New function.
6116 (Fmd5): Use crypto_hash_function.
6117 (syms_of_fns): Add Ssha1.
6119 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6121 * gnutls.c: Remove unused macros.
6122 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6123 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6124 Remove macros that are defined and never used.
6125 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6127 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6129 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6130 (Fx_get_selection_internal): Minor cleanup.
6131 (Fx_own_selection_internal): Rename arguments for consistency with
6134 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6136 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6138 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6140 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6142 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6144 * dispnew.c (scrolling_window): Don't exclude the case that the
6145 last enabled row in the desired matrix touches the bottom boundary.
6147 2011-05-21 Glenn Morris <rgm@gnu.org>
6149 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6150 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6151 and add some more files.
6153 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6155 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6156 report_file_error introduced by the change from 2011-05-07.
6158 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6160 * systime.h (Time): Define only if emacs is defined.
6161 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6162 where the include path doesn't have X11/X.h by default. See
6163 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6165 2011-05-20 Kenichi Handa <handa@m17n.org>
6167 * composite.c (find_automatic_composition): Fix previous change.
6169 2011-05-20 Glenn Morris <rgm@gnu.org>
6171 * lisp.mk: New file, split from Makefile.in.
6172 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6173 (shortlisp): Remove.
6174 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6176 2011-05-19 Glenn Morris <rgm@gnu.org>
6178 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6179 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6180 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6181 (lisp): Set the order to that of loadup.el.
6182 (shortlisp): Make it a copy of $lisp.
6183 (SOME_MACHINE_LISP): Remove.
6184 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6185 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6187 2011-05-18 Kenichi Handa <handa@m17n.org>
6189 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6190 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6191 (find_automatic_composition): Mostly rewrite for efficiency.
6193 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6195 * makefile.w32-in: Update dependencies.
6197 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6199 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6200 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6202 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6204 Fix some integer overflow issues, such as string length overflow.
6206 * insdel.c (count_size_as_multibyte): Check for string overflow.
6208 * character.c (lisp_string_width): Check for string overflow.
6209 Use EMACS_INT, not int, for string indexes and lengths; in
6210 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6211 the resulting string length overflows an EMACS_INT; instead,
6212 report a string overflow if no precision given. When checking for
6213 precision exhaustion, use a check that cannot possibly have
6214 integer overflow. (Bug#8675)
6215 * character.h (lisp_string_width): Adjust to new signature.
6217 * alloc.c (string_overflow): New function.
6218 (Fmake_string): Use it. This doesn't change behavior, but saves
6219 a few bytes and will simplify future changes.
6220 * character.c (string_escape_byte8): Likewise.
6221 * lisp.h (string_overflow): New decl.
6223 Fixups, following up to the user-interface timestamp change.
6224 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6225 for UI timestamps, instead of unsigned long.
6226 * msdos.c (mouse_get_pos): Likewise.
6227 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6228 * w32gui.h (Time): Define by including "systime.h" rather than by
6229 declaring it ourselves. (Bug#8664)
6231 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6232 * image.c (clear_image_cache): Likewise.
6234 * term.c (term_mouse_position): Don't assume time_t wraparound.
6236 Be more systematic about user-interface timestamps.
6237 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6238 and sometimes 'EMACS_UINT', to represent these timestamps.
6239 This change causes it to use 'Time' uniformly, as that's what X uses.
6240 This makes the code easier to follow, and makes it easier to catch
6241 integer overflow bugs such as Bug#8664.
6242 * frame.c (Fmouse_position, Fmouse_pixel_position):
6243 Use Time, not unsigned long, for user-interface timestamps.
6244 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6245 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6246 * keyboard.h (last_event_timestamp): Likewise.
6247 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6248 * menu.h (xmenu_show): Likewise.
6249 * term.c (term_mouse_position): Likewise.
6250 * termhooks.h (struct input_event.timestamp): Likewise.
6251 (struct terminal.mouse_position_hook): Likewise.
6252 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6253 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6254 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6255 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6257 * menu.h, termhooks.h: Include "systime.h", for Time.
6259 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6260 Don't assume that the difference between two unsigned long values
6261 can fit into an integer. At this point, we know button_down_time
6262 <= event->timestamp, so the difference must be nonnegative, so
6263 there's no need to cast the result if double-click-time is
6264 nonnegative, as it should be; check that it's nonnegative, just in
6265 case. This bug is triggered when events are more than 2**31 ms
6266 apart (about 25 days). (Bug#8664)
6268 * xselect.c (last_event_timestamp): Remove duplicate decl.
6269 (x_own_selection): Remove needless cast to unsigned long.
6271 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6272 that always fit in int. Use a sentinel instead of a counter, to
6273 avoid a temp and to allay GCC's concerns about possible int overflow.
6274 * frame.h (struct frame): Use int for menu_bar_items_used
6275 instead of EMACS_INT, since it always fits in int.
6277 * menu.c (grow_menu_items): Check for int overflow.
6279 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6281 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6282 Before, the code was not consistent. These values cannot exceed
6283 2**31 - 1 so there's no need to make them unsigned.
6284 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6285 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6286 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6288 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6290 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6291 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6292 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6293 presumably because the widths might not match.
6295 * window.c (size_window): Avoid needless test at loop start.
6297 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6299 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6301 2011-05-12 Drew Adams <drew.adams@oracle.com>
6303 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6305 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6307 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6308 `width' to `bar_area_x' and `bar_area_width', respectively.
6309 (x_scroll_run): Take account of fringe background extension.
6311 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6312 Rename local vars `left' and `width' to `bar_area_x' and
6313 `bar_area_width', respectively.
6314 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6315 background extension.
6317 2011-05-10 Jim Meyering <meyering@redhat.com>
6319 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6321 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6323 * image.c (Finit_image_library): Return t for built-in image types,
6324 like pbm and xbm. (Bug#8640)
6326 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6328 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6330 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6332 * w32console.c (Fset_screen_color): Doc fix.
6333 (Fget_screen_color): New function.
6334 (syms_of_ntterm): Defsubr it.
6336 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6337 unlink the temporary file if Fcall_process didn't create it in the
6339 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6340 child process will be redirected to a file specified with `:file'.
6341 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6342 cue to call_process_cleanup not to close that handle.
6344 2011-05-07 Ben Key <bkey76@gmail.com>
6346 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6347 one of two shell specific rules, either bootstrap-temacs-CMD or
6348 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6349 to the previous implementation of the bootstrap-temacs rule.
6350 The bootstrap-temacs-CMD rule is similar to the previous
6351 implementation of the bootstrap-temacs rule except that it
6352 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6355 These changes, along with some changes to nt/configure.bat,
6356 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6357 earlier fix to add support for --cflags and --ldflags options
6358 that include quotes so that it works whether make uses cmd or
6361 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6363 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6364 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6366 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6367 a string. Handle both cases.
6368 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6369 (Fdbus_register_method): Use Qinvalid_function.
6371 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6373 * makefile.w32-in: Update dependencies.
6374 (LISP_H): Add inttypes.h and stdin.h.
6375 (PROCESS_H): Add unistd.h.
6377 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6379 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6380 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6382 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6384 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6386 * term.c (vfatal): Remove stray call to va_end.
6387 It's not needed and the C Standard doesn't allow it here anyway.
6389 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6390 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6392 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6395 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6397 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6399 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6401 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6403 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6405 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6406 * charset.c (Fdefine_charset_internal): Don't initialize
6407 charset.code_space[15]. The value was garbage, on hosts with
6408 32-bit int (Bug#8600).
6410 * lread.c (read_integer): Be more consistent with string-to-number.
6411 Use string_to_number to do the actual conversion; this avoids
6412 rounding errors and fixes some other screwups. Without this fix,
6413 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6414 (digit_to_number): Move earlier, for benefit of read_integer.
6415 Return -1 if the digit is out of range for the base, -2 if it is
6416 not a digit in any supported base. (Bug#8602)
6418 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6420 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6421 to match comment at start of function. This also removes a
6422 GCC warning about overflow in a 32+64-bit port.
6424 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6426 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6427 Reported by Stefan Monnier in
6428 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6429 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6430 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6432 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6433 (EMACS_UINTPTR): Likewise, with uintptr_t.
6435 * lisp.h: Prefer 64-bit EMACS_INT if available.
6436 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6437 on 32-bit hosts that have 64-bit int, so that they can access
6439 However, temporarily disable this change unless the temporary
6440 symbol WIDE_EMACS_INT is defined.
6442 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6444 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6445 This removes an assumption that EMACS_INT and long are the same
6446 width as pointers. The assumption is true for Emacs porting targets
6447 now, but we want to make other targets possible.
6448 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6449 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6450 In the rest of the code, change types of integers that hold casted
6451 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6452 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6453 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6454 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6455 No need to cast type when ORing.
6456 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6457 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6458 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6459 assume EMACS_INT is the same width as char *.
6460 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6461 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6462 Remove no-longer-needed casts.
6463 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6464 (xg_tool_bar_help_callback, xg_make_tool_item):
6465 Use EMACS_INTPTR to hold an integer
6466 that will be cast to void *; this can avoid a GCC warning
6467 if EMACS_INT is not the same width as void *.
6468 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6469 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6470 (current_message_1, set_message_1):
6471 Use a local to convert to proper width without a cast.
6472 * xmenu.c (dialog_selection_callback): Likewise.
6474 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6475 Also, don't assume VALBITS / RAND_BITS is less than 5,
6476 and don't rely on undefined behavior when shifting a 1 left into
6478 * lisp.h (get_random): Change signature to match.
6480 * lread.c (hash_string): Use size_t, not int, for hash computation.
6481 Normally we prefer signed values; but hashing is special, because
6482 it's better to use unsigned division on hash table sizes so that
6483 the remainder is nonnegative. Also, size_t is the natural width
6484 for hashing into memory. The previous code used 'int', which doesn't
6485 retain enough info to hash well into very large tables.
6486 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6488 * dbusbind.c: Don't possibly lose pointer info when converting.
6489 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6490 Use XPNTR rather than XHASH, so that the high-order bits of
6491 the pointer aren't lost when converting through void *.
6493 * eval.c (Fautoload): Don't double-shift a pointer.
6495 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6497 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6499 * gnutls.c (DEF_GNUTLS_FN):
6500 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6502 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6504 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6507 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6509 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6510 New version that can reserve upto 2GB of heap space.
6512 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6514 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6516 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6518 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6519 `gnutls_certificate_set_x509_key_file'.
6521 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6523 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6524 Update dependencies.
6526 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6528 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6529 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6530 Remove unused parameter `fildes'.
6531 * process.c (read_process_output, send_process): Don't pass it.
6533 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6535 Fix previous change: the library cache is defined in w32.c.
6536 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6537 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6539 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6541 Implement dynamic loading of GnuTLS on Windows.
6543 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6544 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6545 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6548 * gnutls.c (Qgnutls_dll): Define.
6549 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6550 (gnutls_*): Declare function pointers.
6551 (init_gnutls_functions): New function to initialize function pointers.
6552 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6553 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6554 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6555 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6556 (emacs_gnutls_write, emacs_gnutls_read)
6557 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6558 (Fgnutls_available_p): New function.
6559 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6560 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6561 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6563 * image.c: Include w32.h.
6564 (Vimage_type_cache): Delete.
6565 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6566 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6567 (w32_delayed_load): Move to w32.c.
6569 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6571 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6572 (w32_delayed_load): Move from image.c. When loading a library, record
6573 its filename in the :loaded-from property of the library id.
6574 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6575 Initialize and staticpro them.
6576 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6578 * process.c: Include lisp.h before w32.h, not after.
6579 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6580 instead of gnutls_record_check_pending.
6582 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6584 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6586 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6587 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6590 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6592 * xterm.c (x_set_frame_alpha): Do not set property on anything
6593 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6595 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6597 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6599 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6601 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6602 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6603 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6604 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6605 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6606 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6607 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6608 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6609 (Qgnutls_bootprop_callbacks_verify): Make static.
6611 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6613 * callproc.c: Indentation fixup.
6615 * sysdep.c (wait_for_termination_1): Make static.
6616 (wait_for_termination, interruptible_wait_for_termination):
6617 Move after wait_for_termination_1.
6619 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6621 * sysdep.c (interruptible_wait_for_termination): New function
6622 which is like wait_for_termination, but allows keyboard
6625 * callproc.c (Fcall_process): Add (:file "file") as an option for
6627 (Fcall_process_region): Ditto.
6629 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6631 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6632 rather than `XVECTOR (FOO)->size'.
6634 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6635 inttypes.h, as a gnulib replacement is used if it not available in
6638 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6640 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6641 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6642 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6644 * coding.c (coding_alloc_by_realloc): Error out if destination
6645 will grow beyond MOST_POSITIVE_FIXNUM.
6646 (decode_coding_emacs_mule): Abort if there isn't enough place in
6647 charbuf for the composition carryover bytes. Reserve an extra
6648 space for up to 2 characters produced in a loop.
6649 (decode_coding_iso_2022): Abort if there isn't enough place in
6650 charbuf for the composition carryover bytes.
6652 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6654 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6655 aborting when %lld or %lll format is passed.
6656 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6657 %llo or %llx format is passed. (Bug#8545)
6659 * window.c (window_scroll_line_based): Use a marker instead of
6660 simple variables to record original value of point. (Bug#7952)
6662 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6663 produced by %s or %c overflows available buffer space. (Bug#8545)
6665 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6667 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6668 (SIZE_MAX): Move defn after all includes, as they might #define it.
6670 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6672 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6674 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6676 * keyboard.c (Qdelayed_warnings_hook): Define.
6677 (command_loop_1): Run `delayed-warnings-hook'
6678 if Vdelayed_warnings_list is non-nil.
6679 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6680 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6682 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6684 * doprnt.c (doprnt): Don't return value smaller than the buffer
6685 size if the message was truncated. (Bug#8545).
6687 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6689 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6690 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6692 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6694 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6696 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6698 * makefile.w32-in: Update dependencies.
6700 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6702 Improve `doprnt' and its usage. (Bug#8545)
6703 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6704 `format_end'. Remove support for %l as a conversion specifier.
6705 Don't use xrealloc. Improve diagnostics when the %l size modifier
6706 is used. Update the commentary.
6708 * eval.c (verror): Simplify calculation of size_t.
6710 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6713 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6715 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6718 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6720 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6721 This makes this file independent of the recent pseudovector change.
6723 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6725 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6727 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6728 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6729 Remove unused local.
6730 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6732 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6733 GCC 4.6.0 optimizes based on type-based alias analysis.
6734 For example, if b is of type struct buffer * and v of type struct
6735 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6736 != &v->size, and therefore "v->size = 1; b->size = 2; return
6737 v->size;" must therefore return 1. This assumption is incorrect
6738 for Emacs, since it type-puns struct Lisp_Vector * with many other
6739 types. To fix this problem, this patch adds a new type struct
6740 vectorlike_header that documents the constraints on layout of vectors
6741 and pseudovectors, and helps optimizing compilers not get fooled
6742 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6743 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6744 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6746 (XSETPVECTYPE): Rewrite in terms of new macro.
6747 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6748 This is a bit clearer, and further avoids the possibility of
6749 undesirable aliasing.
6750 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6751 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6752 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6753 since Lisp_Subr is a special case (no "next" field).
6754 (ASIZE): Now uses header.size rather than size.
6755 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6756 to avoid the hassle of writing XVECTOR (foo)->header.size.
6757 (struct vectorlike_header): New type.
6758 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6759 object, to help avoid aliasing.
6760 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6761 (SUBRP): Likewise, since Lisp_Subr is a special case.
6762 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6763 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6764 (struct Lisp_Hash_Table): Combine first two members into a single
6765 struct vectorlike_header member. All uses of "size" and "next" members
6766 changed to be "header.size" and "header.next".
6767 * buffer.h (struct buffer): Likewise.
6768 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6769 * frame.h (struct frame): Likewise.
6770 * process.h (struct Lisp_Process): Likewise.
6771 * termhooks.h (struct terminal): Likewise.
6772 * window.c (struct save_window_data, struct saved_window): Likewise.
6773 * window.h (struct window): Likewise.
6774 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6775 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6776 * buffer.c (init_buffer_once): Likewise.
6777 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6779 * process.c (Fformat_network_address): Use local var for size,
6782 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6784 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6785 * data.c (atof): Remove decl; no longer used or needed.
6786 (digit_to_number): Move to lread.c.
6787 (Fstring_to_number): Use new string_to_number function, to be
6788 consistent with how the Lisp reader treats infinities and NaNs.
6789 Do not assume that floating-point numbers represent EMACS_INT
6790 without losing information; this is not true on most 64-bit hosts.
6791 Avoid double-rounding errors, by insisting on integers when
6792 parsing non-base-10 numbers, as the documentation specifies.
6793 * lisp.h (string_to_number): New decl, replacing ...
6794 (isfloat_string): Remove.
6795 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6796 (read1): Do not accept +. and -. as integers; this
6797 appears to have been a coding error. Similarly, do not accept
6798 strings like +-1e0 as floating point numbers. Do not report
6799 overflow for integer overflows unless the base is not 10 which
6800 means we have no simple and reliable way to continue.
6801 Break out the floating-point parsing into a new
6802 function string_to_number, so that Fstring_to_number parses
6803 floating point numbers consistently with the Lisp reader.
6804 (digit_to_number): Move here from data.c. Make it static inline.
6805 (E_CHAR, EXP_INT): Remove, replacing with ...
6806 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6807 (string_to_number): New function, replacing isfloat_string.
6808 This function checks for valid syntax and produces the resulting
6809 Lisp float number too. Rework it so that string-to-number
6810 no longer mishandles examples like "1.0e+". Use strtoumax,
6811 so that overflow for non-base-10 numbers is reported only when
6812 there's no portable and simple way to convert to floating point.
6814 * textprop.c (set_text_properties_1): Rewrite for clarity,
6815 and to avoid GCC warning about integer overflow.
6817 * intervals.h (struct interval): Use EMACS_INT for members
6818 where EMACS_UINT might cause problems. See
6819 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6820 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6821 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6823 (offset_intervals): Tell GCC not to worry about length overflow
6824 when negating a negative length.
6826 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6827 (overrun_check_free): Likewise.
6829 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6830 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6833 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6834 (gnutls_make_error): Rename local to avoid shadowing.
6835 (gnutls_emacs_global_deinit): ifdef out; not used.
6836 (Fgnutls_boot): Use const for pointer to readonly storage.
6837 Comment out unused local. Fix pointer signedness problems.
6839 * lread.c (openp): Don't stuff size_t into an 'int'.
6840 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6841 about possible signed overflow.
6843 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6844 (GDK_KEY_g): Don't define if already defined.
6845 (xg_prepare_tooltip): Avoid pointer signedness problem.
6846 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6848 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6849 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6851 * xfns.c (Fx_window_property): Simplify a bit,
6852 to make a bit faster and to avoid GCC 4.6.0 warning.
6853 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6855 * fns.c (internal_equal): Don't assume size_t fits in int.
6857 * alloc.c (compact_small_strings): Tighten assertion a little.
6859 Replace pEd with more-general pI, and fix some printf arg casts.
6860 * lisp.h (pI): New macro, generalizing old pEd macro to other
6861 conversion specifiers. For example, use "...%"pI"d..." rather
6862 than "...%"pEd"...".
6863 (pEd): Remove. All uses replaced with similar uses of pI.
6864 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6865 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6866 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6867 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6868 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6869 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6870 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6872 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6873 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6874 * print.c (safe_debug_print, print_object): Likewise.
6875 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6877 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6878 avoiding the 0 flag, which is not portable.
6879 * process.c (Fmake_network_process): Use pI to avoid cast.
6880 * region-cache.c (pp_cache): Likewise.
6881 * xdisp.c (decode_mode_spec): Likewise.
6882 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6883 behavior on 64-bit hosts with printf arg.
6884 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6885 (x_stop_queuing_selection_requests): Likewise.
6886 (x_get_window_property): Don't truncate byte count to an 'int'
6889 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6890 here, since it parses constructs like leading '-' and spaces,
6891 which are not wanted; and it overflows with large numbers.
6892 Instead, simply match F[0-9]+, which is what is wanted anyway.
6894 * alloc.c: Remove unportable assumptions about struct layout.
6895 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6896 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6897 (allocate_vectorlike, make_pure_vector): Use the new macros,
6898 plus offsetof, to remove unportable assumptions about struct layout.
6899 These assumptions hold on all porting targets that I know of, but
6900 they are not guaranteed, they're easy to remove, and removing them
6901 makes further changes easier.
6903 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6904 This doesn't fix a bug but makes the code clearer.
6905 (string_overrun_cookie): Now const. Use initializers that
6906 don't formally overflow signed char, to avoid warnings.
6907 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6908 can cause Emacs to crash when string overrun checking is enabled.
6909 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6910 multiple of sizeof (EMACS_INT); it need not be, if
6911 alignof(EMACS_INT) < sizeof (EMACS_INT).
6912 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6914 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6916 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6918 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6920 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6921 supposed to be handshaking. (Bug#8556)
6922 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6924 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6926 * lisp.h (Qdebug): List symbol.
6927 * eval.c (Qdebug): Restore global linkage.
6928 * keyboard.c (debug-on-event): New variable.
6929 (handle_user_signal): Break into debugger when debug-on-event
6930 matches the current signal symbol.
6932 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6934 * alloc.c (check_sblock, check_string_bytes)
6935 (check_string_free_list): Convert to standard C.
6937 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6939 * w32.c (emacs_gnutls_push): Fix typo.
6941 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6943 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6944 "cast to pointer from integer of different size".
6946 Improve doprnt and its use in verror. (Bug#8545)
6947 * doprnt.c (doprnt): Document the set of format control sequences
6948 supported by the function. Use SAFE_ALLOCA instead of always
6951 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6952 is one byte too soon. Don't use xrealloc; instead xfree and
6955 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6957 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6960 * gnutls.c: Renamed global_initialized to
6961 gnutls_global_initialized. Added internals for the
6962 :verify-hostname-error, :verify-error, and :verify-flags
6963 parameters of `gnutls-boot' and documented those parameters in the
6964 docstring. Start callback support.
6965 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6966 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6967 on error. Return error code.
6968 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6969 (emacs_gnutls_read): Likewise.
6970 (Fgnutls_boot): Return handshake error code.
6971 (emacs_gnutls_handle_error): New function.
6972 (wsaerror_to_errno): Likewise.
6974 * w32.h (emacs_gnutls_pull): Add prototype.
6975 (emacs_gnutls_push): Likewise.
6977 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6978 (emacs_gnutls_push): Likewise.
6980 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6982 * process.c (wait_reading_process_output): Check if GnuTLS
6983 buffered some data internally if no FDs are set for TLS
6986 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6987 (LIBS): Link to USER_LIBS.
6988 ($(BLD)/gnutls.$(0)): New target.
6990 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6992 * xdisp.c (handle_single_display_spec): Rename the
6993 display_replaced_before_p argument into display_replaced_p, to
6994 make it consistent with the commentary. Fix typos in the
6997 * textprop.c (syms_of_textprop): Remove dead code.
6998 (copy_text_properties): Delete obsolete commentary about an
6999 interface that was deleted long ago. Fix typos in the description
7002 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7003 to changes in oldXMenu/XMenu.h from 2011-04-16.
7004 <menu_help_message, prev_menu_help_message>: Constify.
7005 (IT_menu_make_room): menu->help_text is now `const char **';
7008 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7009 to changes in oldXMenu/XMenu.h from 2011-04-16.
7010 (struct XMenu): Declare `help_text' `const char **'.
7012 * xfaces.c <Qunspecified>: Make extern again.
7014 * syntax.c: Include sys/types.h before including regex.h, as
7017 * doc.c (get_doc_string): Improve the format passed to `error'.
7019 * doprnt.c (doprnt): Improve commentary.
7021 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7023 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7026 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7027 changes in globals.h immediately force recompilation.
7028 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7029 $(CURDIR)/s/ms-w32.h.
7030 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7032 * character.c (Fchar_direction): Function deleted.
7033 (syms_of_character): Don't defsubr it.
7034 <char-direction-table>: Deleted.
7036 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7038 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7039 * doprnt.c: Include limits.h.
7040 (SIZE_MAX): New macro.
7041 (doprnt): Return a size_t value. 2nd arg is now size_t.
7042 Many local variables are now size_t instead of int or unsigned.
7043 Improve overflow protection. Support `l' modifier for integer
7044 conversions. Support %l conversion. Don't assume an EMACS_INT
7045 argument for integer conversions and for %c.
7047 * lisp.h (doprnt): Restore prototype.
7049 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7052 * Makefile.in (base_obj): Add back doprnt.o.
7054 * deps.mk (doprnt.o): Add back prerequisites.
7055 (callint.o): Depend on character.h.
7057 * eval.c (internal_lisp_condition_case): Include the handler
7058 representation in the error message.
7059 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7060 when breaking from the loop.
7062 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7064 * callint.c (Fcall_interactively): When displaying error message
7065 about invalid control letter, pass the character's codepoint, not
7066 a pointer to its multibyte form. Improve display of the character
7067 in octal and display also its hex code.
7069 * character.c (char_string): Use %x to display the (unsigned)
7070 codepoint of an invalid character, to avoid displaying a bogus
7073 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7074 `error', not SYMBOL_NAME itself.
7076 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7077 character arguments to `error'.
7079 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7080 to `error' in error message about FINAL_CHAR argument. Make sure
7081 FINAL_CHAR is a character, and use %c when it is passed as
7082 argument to `error'.
7084 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7086 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7088 * w32.c: Include <time.h>.
7089 (sys_localtime): New function.
7091 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7093 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7095 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7097 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7099 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7102 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7104 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7105 gl_state.e_property when gl_state.object is Qt.
7107 * insdel.c (make_gap_larger): Remove limitation of buffer size
7110 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7112 * xdisp.c (lookup_glyphless_char_display)
7113 (produce_glyphless_glyph): Handle cons cell entry in
7114 glyphless-char-display.
7115 (Vglyphless_char_display): Document it.
7117 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7118 glyphless-char-display.
7120 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7122 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7124 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7126 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7127 definition for no-X builds.
7129 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7131 Static checks with GCC 4.6.0 and non-default toolkits.
7133 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7135 * process.c (keyboard_bit_set): Define only if SIGIO.
7136 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7137 (send_process): Repair possible setjmp clobbering.
7139 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7141 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7143 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7145 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7146 Define only if needed.
7148 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7149 by pacifying GCC about it. Maybe it's time to retire it?
7150 * xfaces.c (USG, __TIMEVAL__): Likewise.
7152 * dispextern.h (struct redisplay_interface): Rename param
7154 * termhooks.h (struct terminal): Likewise.
7155 * xterm.c (xembed_send_message): Likewise.
7157 * insdel.c (make_gap_smaller): Define only if
7158 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7160 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7163 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7164 so that we aren't warned about unused symbols.
7166 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7168 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7170 * xfns.c (x_real_positions): Mark locals as initialized.
7172 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7174 * xterm.c: Fix problems found by static analysis with other toolkits.
7175 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7176 (x_dispatch_event): Declare static if USE_GTK, and
7177 define if USE_GTK || USE_X_TOOLKIT.
7178 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7179 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7180 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7181 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7183 * xmenu.c (menu_help_callback): Pointer type fixes.
7184 Use const pointers when pointing at readonly data. Avoid pointer
7186 (FALSE): Remove unused macro.
7187 (update_frame_menubar): Remove unused decl.
7189 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7191 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7192 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7193 (single_menu_item): Rename local to avoid shadowing.
7195 * keyboard.c (make_lispy_event): Remove unused local var.
7197 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7198 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7200 * bitmaps: Change bitmaps from unsigned char back to the X11
7201 compatible char. Avoid the old compiler warnings about
7202 out-of-range initializers by using, for example, '\xab' rather
7205 * xgselect.c (xgselect_initialize): Check vs interface
7206 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7208 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7210 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7211 to read-only memory.
7213 * fns.c (vector): Remove; this old hack is no longer needed.
7215 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7217 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7219 * xrdb.c (x_load_resources): Omit unused local.
7221 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7222 (x_window): Rename locals to avoid shadowing.
7223 (USG): Use the kludged USG macro, to pacify gcc.
7225 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7226 (x_term_init): Remove local to avoid shadowing.
7228 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7230 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7231 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7233 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7235 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7237 Fix regex.c, syntax.c and friends for buffers > 2GB.
7238 * syntax.h (struct gl_state_s): Declare character position members
7241 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7243 * textprop.c (verify_interval_modification, interval_of):
7244 Declare arguments EMACS_INT.
7246 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7249 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7251 * indent.c (Fvertical_motion): Local variable it_start is now
7254 * regex.c (re_match, re_match_2, re_match_2_internal)
7255 (bcmp_translate, regcomp, regexec, print_double_string)
7256 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7257 (re_compile_pattern, re_exec): Declare arguments and local
7258 variables `size_t' and `ssize_t' and return values `regoff_t', as
7260 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7261 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7262 <compile_stack_type>: `size' and `avail' are now `size_t'.
7264 * regex.h <regoff_t>: Use ssize_t, not int.
7265 (re_search, re_search_2, re_match, re_match_2): Arguments that
7266 specify buffer/string position and length are now ssize_t and
7267 size_t. Return type is regoff_t.
7269 2011-04-16 Ben Key <bkey76@gmail.com>
7271 * nsfont.m: Fixed bugs in ns_get_family and
7272 ns_descriptor_to_entity that were caused by using free to
7273 deallocate memory blocks that were allocated by xmalloc (via
7274 xstrdup). This caused Emacs to crash when compiled with
7275 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7276 --enable-checking=xmallocoverrun). xfree is now used to
7277 deallocate these memory blocks.
7279 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7281 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7283 emacs_write: Accept and return EMACS_INT for sizes.
7284 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7286 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7287 Accept and return EMACS_INT.
7288 (emacs_gnutls_write): Return the number of bytes written on
7290 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7291 (emacs_read, emacs_write): Remove check for negative size, as the
7292 Emacs source code has been audited now.
7293 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7294 (emacs_read, emacs_write): Use it.
7295 * process.c (send_process): Adjust to the new signatures of
7296 emacs_write and emacs_gnutls_write. Do not attempt to store
7297 a byte offset into an 'int'; it might overflow.
7298 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7300 * sound.c: Don't assume sizes fit in 'int'.
7301 (struct sound_device.period_size, alsa_period_size):
7302 Return EMACS_INT, not int.
7303 (struct sound_device.write, vox_write, alsa_write):
7304 Accept EMACS_INT, not int.
7305 (wav_play, au_play): Use EMACS_INT to store sizes and to
7306 record read return values.
7308 2011-04-15 Ben Key <bkey76@gmail.com>
7310 * keyboard.c (Qundefined): Don't declare static since it is used
7312 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7313 static since they are used in nsfont.m.
7315 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7317 * process.c (Qprocessp): Don't declare static.
7318 * lisp.h (Qprocessp): Declare again.
7320 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7322 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7324 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7326 Improve C-level modularity by making more things 'static'.
7328 Don't publish debugger-only interfaces to other modules.
7329 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7330 (verify_bytepos, count_markers): Move decls to the only modules
7332 * region-cache.h (pp_cache): Likewise.
7333 * window.h (check_all_windows): Likewise.
7334 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7336 * sysdep.c (croak): Now static, if
7337 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7338 * syssignal.h (croak): Declare only if not static.
7340 * alloc.c (refill_memory_reserve): Now static if
7341 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7342 * lisp.h (refill_memory_reserve): Declare only if not static.
7344 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7345 Define only if USE_LUCID.
7347 * xrdb.c (x_customization_string, x_rm_string): Now static.
7349 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7350 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7352 * xdisp.c (draw_row_with_mouse_face): Now static.
7353 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7355 * window.h (check_all_windows): Mark externally visible.
7357 * window.c (window_deletion_count): Now static.
7359 * undo.c: Make symbols static if they're not exported.
7360 (last_undo_buffer, last_boundary_position, pending_boundary):
7363 * textprop.c (interval_insert_behind_hooks): Now static.
7364 (interval_insert_in_front_hooks): Likewise.
7366 * term.c: Make symbols static if they're not exported.
7367 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7368 (max_frame_lines, tty_set_terminal_modes):
7369 (tty_reset_terminal_modes, tty_turn_off_highlight):
7370 (get_tty_terminal): Now static.
7371 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7372 * termhooks.h (term_mouse_moveto): Do not declare if
7374 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7375 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7377 * sysdep.c: Make symbols static if they're not exported.
7378 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7380 (sigprocmask_set, full_mask): Remove; unused.
7381 (wait_debugging): Mark as visible.
7382 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7383 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7385 * syntax.c (syntax_temp): Define only if !__GNUC__.
7387 * sound.c (current_sound_device, current_sound): Now static.
7389 * search.c (searchbufs, searchbuf_head): Now static.
7391 * scroll.c (scroll_cost): Remove; unused.
7392 * dispextern.h (scroll_cost): Remove decl.
7394 * region-cache.h (pp_cache): Mark as externally visible.
7396 * process.c: Make symbols static if they're not exported.
7397 (process_tick, update_tick, create_process, chan_process):
7398 (Vprocess_alist, proc_buffered_char, datagram_access):
7399 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7400 (deactivate_process): Mark defn as static, as well as decl.
7401 * lisp.h (create_process): Remove decl.
7402 * process.h (chan_process, Vprocess_alist): Remove decls.
7404 * print.c: Make symbols static if they're not exported.
7405 (print_depth, new_backquote_output, being_printed, print_buffer):
7406 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7407 (print_interval, print_number_index, initial_stderr_stream):
7409 * lisp.h (Fprinc): Remove decl.
7410 (debug_output_compilation_hack): Mark as externally visible.
7412 * sysdep.c (croak): Move decl from here to syssignal.h.
7413 * syssignal.h (croak): Put it here, so the API can be checked when
7414 'croak' is called from dissociate_if_controlling_tty.
7416 * minibuf.c: Make symbols static if they're not exported.
7417 (minibuf_save_list, choose_minibuf_frame): Now static.
7418 * lisp.h (choose_minibuf_frame): Remove decl.
7420 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7422 * lread.c: Make symbols static if they're not exported.
7423 (read_objects, initial_obarray, oblookup_last_bucket_number):
7425 (make_symbol): Remove; unused.
7426 * lisp.h (initial_obarray, make_symbol): Remove decls.
7428 * keyboard.c: Make symbols static if they're not exported.
7429 (single_kboard, recent_keys_index, total_keys, recent_keys):
7430 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7431 (this_single_command_key_start, echoing, last_auto_save):
7432 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7433 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7434 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7435 (Vlispy_mouse_stem, double_click_count):
7437 (force_auto_save_soon): Define only if SIGDANGER.
7438 (ignore_mouse_drag_p): Now static if
7439 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7440 (print_help): Remove; unused.
7441 (stop_character, last_timer_event): Mark as externally visible.
7442 * keyboard.h (ignore_mouse_drag_p): Declare only if
7443 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7444 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7445 * lisp.h (echoing): Remove decl.
7446 (force_auto_save_soon): Declare only if SIGDANGER.
7447 * xdisp.c (redisplay_window): Simplify code, to make it more
7448 obvious that ignore_mouse_drag_p is not accessed if !defined
7449 USE_GTK && !defined HAVE_NS.
7451 * intervals.c: Make symbols static if they're not exported.
7452 (merge_properties_sticky, merge_interval_right, delete_interval):
7454 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7456 * insdel.c: Make symbols static if they're not exported.
7457 However, leave prepare_to_modify_buffer alone. It's never
7458 called from outside this function, but that appears to be a bug.
7459 (combine_after_change_list, combine_after_change_buffer):
7460 (adjust_after_replace, signal_before_change): Now static.
7461 (adjust_after_replace_noundo): Remove; unused.
7462 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7463 (signal_before_change): Remove decls.
7465 * indent.c (val_compute_motion, val_vmotion): Now static.
7467 * image.c: Make symbols static if they're not exported.
7468 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7470 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7471 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7473 * fringe.c (standard_bitmaps): Now static.
7474 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7476 * frame.c: Make symbols static if they're not exported.
7477 (x_report_frame_params, make_terminal_frame): Now static.
7478 (get_frame_param): Now static, unless HAVE_NS.
7479 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7480 (x_get_resource_string): Remove; not used.
7481 * frame.h (make_terminal_frame, x_report_frame_params):
7482 (x_get_resource_string); Remove decls.
7483 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7484 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7486 * font.c, fontset.c: Make symbols static if they're not exported.
7487 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7488 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7489 * font.c (font_close_object): Now static.
7490 * font.h (font_close_object): Remove.
7491 * fontset.c (FONTSET_OBJLIST): Remove.
7492 (free_realized_fontset) #if-0 the body, which does nothing.
7493 (face_suitable_for_char_p): #if-0, as it's never called.
7494 * fontset.h (face_suitable_for_char_p): Remove decl.
7495 * xfaces.c (face_at_string_position):
7496 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7497 since 0 is always ASCII.
7499 * fns.c (weak_hash_tables): Now static.
7501 * fileio.c: Make symbols static if they're not exported.
7502 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7503 (Vwrite_region_annotation_buffers): Now static.
7505 * eval.c: Make symbols static if they're not exported.
7506 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7507 * lisp.h (backtrace_list): Remove decl.
7509 * emacs.c: Make symbols static if they're not exported.
7510 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7511 (fatal_error_code, fatal_error_signal_hook, standard_args):
7513 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7514 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7515 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7516 * lisp.h (fatal_error_signal_hook): Remove decl.
7517 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7519 * editfns.c: Move a (normally-unused) function to its only use.
7520 * editfns.c, lisp.h (get_operating_system_release): Remove.
7521 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7522 worth the hassle of breaking this out.
7524 * xterm.c: Make symbols static if they're not exported.
7525 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7526 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7527 (x_destroy_window, x_delete_display):
7529 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7530 (x_mouse_leave): Remove; unused.
7531 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7532 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7533 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7535 (x_mouse_leave): Declare only if WINDOWSNT.
7536 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7537 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7540 * ftxfont.c: Make symbols static if they're not exported.
7541 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7543 * font.h (ftxfont_driver): Likewise.
7545 * xfns.c: Make symbols static if they're not exported.
7546 (x_last_font_name, x_display_info_for_name):
7547 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7548 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7549 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7550 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7551 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7552 (last_show_tip_args): Now static.
7553 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7554 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7555 (x_screen_planes): Remove; unused.
7556 * dispextern.h (x_screen_planes): Remove decl.
7558 * dispnew.c: Make symbols static if they're not exported.
7559 * dispextern.h (redraw_garbaged_frames, scrolling):
7560 (increment_row_positions): Remove.
7561 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7562 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7564 (redraw_garbaged_frames): Remove; unused.
7566 * xfaces.c: Make symbols static if they're not exported.
7567 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7569 * xterm.h (defined_color): Remove decls.
7570 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7571 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7572 (menu_face_changed_default, defined_color, free_realized_face):
7573 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7574 (ascii_face_of_lisp_face): Remove; unused.
7576 * xdisp.c: Make symbols static if they're not exported.
7577 * dispextern.h (scratch_glyph_row, window_box_edges):
7578 (glyph_to_pixel_coords, set_cursor_from_row):
7579 (get_next_display_element, set_iterator_to_next):
7580 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7581 (show_mouse_face): Remove decls
7582 * frame.h (message_buf_print): Likewise.
7583 * lisp.h (pop_message, set_message, check_point_in_composition):
7585 * xterm.h (set_vertical_scroll_bar): Likewise.
7586 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7587 (message_buf_print, scratch_glyph_row, displayed_buffer):
7588 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7589 (get_next_display_element, show_mouse_face, window_box_edges):
7590 (frame_to_window_pixel_xy, check_point_in_composition):
7591 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7592 (glyph_to_pixel_coords): Remove; unused.
7594 * dired.c (file_name_completion): Now static.
7596 * dbusbind.c (xd_in_read_queued_messages): Now static.
7598 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7599 * data.c (circular_list_error): Remove.
7601 * commands.h (last_point_position, last_point_position_buffer):
7602 (last_point_position_window): Remove decls.
7603 * keyboard.c: Make these variables static.
7605 * coding.h (coding, code_convert_region, encode_coding_gap):
7607 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7608 (iso_code_class, detect_coding, code_convert_region): Now static.
7609 (encode_coding_gap): Remove; unused.
7611 * chartab.c (chartab_chars, chartab_bits): Now static.
7613 * charset.h (charset_iso_8859_1): Remove decl.
7614 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7617 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7618 * ccl.c (Vccl_program_table): Now static.
7619 (check_ccl_update): Remove; unused.
7621 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7622 * category.h: ... from here.
7623 * category.c (check_category_table, set_category_set): Now static.
7625 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7626 * lisp.h: Remove these decls.
7628 * buffer.c (buffer_count): Remove unused var.
7630 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7631 so that it's not optimized away.
7632 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7633 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7634 exported only to the debugger.
7636 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7637 * atimer.h (run_all_atimers): Remove; not exported.
7639 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7640 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7641 was inaccessible from Lisp.
7642 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7643 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7645 alloc.c: Import and export fewer symbols, and remove unused items.
7646 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7648 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7649 it's not optimized away by whole-program optimization.
7650 (message_enable_multibyte, free_misc): Remove.
7651 (catchlist, handlerlist, mark_backtrace):
7652 Declare only if BYTE_MARK_STACK.
7653 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7654 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7655 (message_enable_multibyte): Remove decl.
7656 (free_misc, interval_free_list, float_block, float_block_index):
7657 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7658 (cons_free_list, last_marked_index):
7660 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7661 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7662 (mark_backtrace): Define only if BYTE_MARK_STACK.
7663 * xdisp.c (message_enable_multibyte): Now static.
7665 Declare Lisp_Object Q* variables to be 'static' if not exported.
7666 This makes it easier for human readers (and static analyzers)
7667 to see whether these variables are used from other modules.
7668 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7669 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7670 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7671 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7672 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7673 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7674 * xmenu.c, xselect.c:
7675 Declare Q* vars static if they are not used in other modules.
7676 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7677 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7678 Remove decls of unexported vars.
7679 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7681 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7683 Make Emacs functions such as Fatom 'static' by default.
7684 This makes it easier for human readers (and static analyzers)
7685 to see whether these functions can be called from other modules.
7686 DEFUN now defines a static function. To make the function external
7687 so that it can be used in other C modules, use the new macro DEFUE.
7688 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7689 (Finit_image_library):
7690 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7691 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7692 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7693 Remove decls, since these functions are now static.
7694 (Funintern, Fget_internal_run_time): New decls, since these functions
7695 were already external.
7697 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7698 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7699 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7700 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7701 * keyboard.c, keymap.c, lread.c:
7702 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7703 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7704 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7705 Mark functions with DEFUE instead of DEFUN,
7706 if they are used in other modules.
7707 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7708 decls for now-static functions.
7709 * buffer.h (Fdelete_overlay): Remove decl.
7710 * callproc.c (Fgetenv_internal): Mark as internal.
7711 * composite.c (Fremove_list_of_text_properties): Remove decl.
7712 (Fcomposition_get_gstring): New forward static decl.
7713 * composite.h (Fcomposite_get_gstring): Remove decl.
7714 * dired.c (Ffile_attributes): New forward static decl.
7715 * doc.c (Fdocumntation_property): New forward static decl.
7716 * eval.c (Ffetch_bytecode): New forward static decl.
7717 (Funintern): Remove extern decl; now in .h file where it belongs.
7718 * fileio.c (Fmake_symbolic_link): New forward static decl.
7719 * image.c (Finit_image_library): New forward static decl.
7720 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7721 * intervals.h (Fprevious_property_change):
7722 (Fremove_list_of_text_properties): Remove decls.
7723 * keyboard.c (Fthis_command_keys): Remove decl.
7724 (Fcommand_execute): New forward static decl.
7725 * keymap.c (Flookup_key): New forward static decl.
7726 (Fcopy_keymap): Now static.
7727 * keymap.h (Flookup_key): Remove decl.
7728 * process.c (Fget_process): New forward static decl.
7729 (Fprocess_datagram_address): Mark as internal.
7730 * syntax.c (Fsyntax_table_p): New forward static decl.
7731 (skip_chars): Remove duplicate decl.
7732 * textprop.c (Fprevious_property_change): New forward static decl.
7733 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7735 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7736 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7738 * editfns.c (Fformat): Remove unreachable code.
7740 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7742 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7745 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7747 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7748 when at ZV. (Bug#8487)
7750 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7752 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7754 * keyboard.c (parse_tool_bar_item): Likewise.
7755 * sound.c (sound_cleanup, alsa_close): Likewise.
7756 * termcap.c (tgetent): Likewise.
7757 * xfns.c (x_default_font_parameter): Likewise.
7758 * xsettings.c (read_and_apply_settings): Likewise.
7760 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7761 (overrun_check_free): Protoize.
7763 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7765 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7766 since callers should never pass a negative size.
7767 Change the signature to match that of plain 'read' and 'write'; see
7768 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7769 * lisp.h: Update prototypes of emacs_write and emacs_read.
7771 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7773 * xdisp.c (redisplay_window): Don't try to determine the character
7774 position of the scroll margin if the window start point w->startp
7775 is outside the buffer's accessible region. (Bug#8468)
7777 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7779 Fix write-region and its subroutines for buffers > 2GB.
7780 * fileio.c (a_write, e_write): Modify declaration of arguments and
7781 local variables to support buffers larger than 2GB.
7782 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7784 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7785 argument, local variables, and return value.
7787 * lisp.h: Update prototypes of emacs_write and emacs_read.
7789 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7791 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7793 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7795 Fix more problems found by GCC 4.6.0's static checks.
7797 * xdisp.c (vmessage): Use a better test for character truncation.
7799 * charset.c (load_charset_map): <, not <=, for optimization,
7800 and to avoid potential problems with integer overflow.
7801 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7802 * casetab.c (set_identity, shuffle): Likewise.
7803 * editfns.c (Fformat): Likewise.
7804 * syntax.c (skip_chars): Likewise.
7806 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7807 This also lets GCC 4.6.0 generate slightly better loop code.
7809 * callint.c (Fcall_interactively): <, not <=, for optimization.
7810 (Fcall_interactively): Count the number of arguments produced,
7811 not the number of arguments given. This is simpler and lets GCC
7812 4.6.0 generate slightly better code.
7814 * ftfont.c: Distingish more carefully between FcChar8 and char.
7815 The previous code passed unsigned char * to a functions like
7816 strlen and xstrcasecmp that expect char *, which does not
7817 conform to the C standard.
7818 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7819 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7820 char * when the C standard requires it.
7822 * keyboard.c (read_char): Remove unused var.
7824 * eval.c: Port to Windows vsnprintf (Bug#8435).
7826 (SIZE_MAX): Define if the headers do not.
7827 (verror): Do not give up if vsnprintf returns a negative count.
7828 Instead, grow the buffer. This ports to Windows vsnprintf, which
7829 does not conform to C99. Problem reported by Eli Zaretskii.
7830 Also, simplify the allocation scheme, by avoiding the need for
7831 calling realloc, and removing the ALLOCATED variable.
7833 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7835 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7836 But keep the doprint source code for now, as we might revamp it
7837 and use it again (Bug#8435).
7838 * lisp.h (doprnt): Remove.
7839 * Makefile.in (base_obj): Remove doprnt.o.
7840 * deps.mk (doprnt.o): Remove.
7842 error: Print 32- and 64-bit integers portably (Bug#8435).
7843 Without this change, on typical 64-bit hosts error ("...%d...", N)
7844 was used to print both 32- and 64-bit integers N, which relied on
7846 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7847 * lisp.h (error, verror): Mark as printf-like functions.
7848 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7849 Report overflow in size calculations when allocating printf buffer.
7850 Do not truncate output string at its first null byte.
7851 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7852 Truncate the output at a character boundary, since vsnprintf does not
7854 * charset.c (check_iso_charset_parameter): Convert internal
7855 character to string before calling 'error', since %c now has the
7857 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7858 overflow when computing char to be passed to 'error'. Do not
7859 pass Lisp_Object to 'error'; pass the integer instead.
7860 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7861 formatted with plain %d.
7863 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7865 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7867 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7869 * xterm.c (x_catch_errors): Remove duplicate declaration.
7871 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7873 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7875 2011-04-10 Jim Meyering <meyering@redhat.com>
7877 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7878 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7879 return ssize_t not "int", and use size_t as the buffer length.
7880 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7881 * gnutls.h: Update declarations.
7882 * process.c (read_process_output): Use ssize_t, to match.
7883 (send_process): Likewise.
7885 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7887 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7889 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7891 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7892 Use unsigned char, to match FcChar8 type definition.
7894 * xterm.c (handle_one_xevent):
7895 * xmenu.c (create_and_show_popup_menu):
7896 * xselect.c (x_decline_selection_request)
7897 (x_reply_selection_request): Avoid type-punned deref of X events.
7899 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7901 Fix some uses of `int' instead of EMACS_INT.
7902 * search.c (string_match_1, fast_string_match)
7903 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7904 (scan_buffer, find_next_newline_no_quit)
7905 (find_before_next_newline, search_command, Freplace_match)
7906 (Fmatch_data): Make some `int' variables be EMACS_INT.
7908 * xdisp.c (display_count_lines): 3rd argument and return value now
7909 EMACS_INT. All callers changed.
7910 (pint2hrstr): Last argument is now EMACS_INT.
7912 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7913 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7914 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7915 (decode_coding_utf_16, decode_coding_emacs_mule)
7916 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7917 (decode_coding_ccl, decode_coding_charset)
7918 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7919 (decode_coding_iso_2022, decode_coding_emacs_mule)
7920 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7921 <char_offset, last_offset>: Declare EMACS_INT.
7922 (encode_coding_utf_8, encode_coding_utf_16)
7923 (encode_coding_emacs_mule, encode_invocation_designation)
7924 (encode_designation_at_bol, encode_coding_iso_2022)
7925 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7926 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7928 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7929 (encode_invocation_designation): Last argument P_NCHARS is now
7931 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7932 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7934 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7937 * ccl.c (Fccl_execute_on_string): Declare some variables
7940 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7942 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7944 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7946 * process.c (Fformat_network_address): Doc fix.
7948 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7950 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7952 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7954 * keyboard.c (read_char): Call Lisp function help-form-show,
7955 instead of using internal_with_output_to_temp_buffer.
7956 (Qhelp_form_show): New var.
7957 (syms_of_keyboard): Use DEFSYM macro.
7959 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7961 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7963 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7965 * process.c (Flist_processes): Remove to Lisp.
7966 (list_processes_1): Delete.
7968 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7970 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7972 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7974 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7976 Fix more problems found by GCC 4.6.0's static checks.
7978 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7980 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7982 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7984 * xdisp.c (vmessage): Mark as a printf-like function.
7986 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7988 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7990 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7991 printf-like functions.
7992 (tiff_load): Add casts to remove these marks before passing them
7993 to system-supplied API.
7995 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7997 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7998 This avoids several warnings with gcc -Wstrict-overflow.
7999 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8000 directly, rather than having caller test rule sign. This avoids
8001 some unnecessary tests.
8002 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8003 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8004 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8006 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8007 (xfont_open): Avoid unnecessary tests.
8009 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8011 * composite.h, composite.c (composition_gstring_put_cache):
8012 Use EMACS_INT, not int, for length.
8014 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8015 breaking out part of COMPOSITION_DECODE_RULE.
8016 (COMPOSITION_DECODE_RULE): Use it.
8017 * composite.c (get_composition_id): Remove unused local vars,
8018 by using the new macro.
8020 * textprop.c (set_text_properties_1): Change while to do-while,
8021 since the condition is always true at first.
8023 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8024 (interval_deletion_adjustment): Return unsigned value.
8027 * process.c (list_processes_1, create_pty, read_process_output):
8028 (exec_sentinel): Remove vars that were set but not used.
8029 (create_pty): Remove unnecessary "volatile"s.
8030 (Fnetwork_interface_info): Avoid possibility of int overflow.
8031 (read_process_output): Do adaptive read buffering even if carryover.
8032 (read_process_output): Simplify nbytes computation if buffered.
8034 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8036 * syntax.c (scan_words): Remove var that was set but not used.
8037 (update_syntax_table): Use unsigned instead of int.
8039 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8040 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8041 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8043 * print.c (print_error_message): Avoid int overflow.
8045 * font.c (font_list_entities): Redo for clarity,
8046 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8048 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8049 (font_score): Avoid potential overflow in diff calculation.
8051 * fns.c (substring_both): Remove var that is set but not used.
8052 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8054 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8056 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8057 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8058 can always succeed if overflow has undefined behavior.
8060 * search.c (boyer_moore, wordify): Remove vars set but not used.
8061 (wordify): Omit three unnecessary tests.
8063 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8064 All callers changed. This avoids the need for an unused var.
8066 * casefiddle.c (casify_region): Remove var that is set but not used.
8068 * dired.c (file_name_completion): Remove var that is set but not used.
8070 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8072 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8073 (Finsert_file_contents): Remove unnecessary code checking fd.
8075 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8076 Check for integer overflow on size calculations.
8078 * buffer.c (Fprevious_overlay_change): Remove var that is set
8081 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8082 Remove vars that are set but not used.
8083 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8084 (timer_check_2): Mark vars as initialized.
8086 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8088 * image.c (lookup_image): Remove var that is set but not used.
8089 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8091 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8092 that are set but not used.
8094 * xfns.c (make_invisible_cursor): Don't return garbage
8095 if XCreateBitmapFromData fails (Bug#8410).
8097 * xselect.c (x_get_local_selection, x_handle_property_notify):
8098 Remove vars that are set but not used.
8100 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8101 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8103 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8104 Remove var that is set but not used.
8105 (scroll_bar_windows_size): Now size_t, not int.
8106 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8109 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8110 (map_tty_color) [!defined MSDOS]: Likewise.
8112 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8114 * coding.c: Remove vars that are set but not used.
8115 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8116 All callers changed.
8117 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8118 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8119 (decode_coding_charset): Remove vars that are set but not used.
8121 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8122 that is set but not used.
8124 * print.c (print_object): Remove var that is set but not used.
8126 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8127 The gnulib version avoids calling malloc in the usual case,
8128 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8129 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8130 * filelock.c (current_lock_owner): Likewise.
8131 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8132 * sysdep.c: Include allocator.h, careadlinkat.h.
8133 (emacs_no_realloc_allocator): New static constant.
8134 (emacs_readlink): New function.
8135 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8136 ../lib/careadlinkat.h.
8138 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8140 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8141 first non-nil return value).
8143 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8145 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8146 if not defined (Bug#8403).
8148 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8150 * xdisp.c (display_count_lines): Remove parameter `start',
8151 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8152 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8153 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8154 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8155 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8156 and thereabouts. All callers changed.
8157 (get_per_char_metric): Remove parameter `f', unused since
8158 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8160 2011-04-02 Jim Meyering <meyering@redhat.com>
8162 do not dereference NULL upon failed strdup
8163 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8164 (ns_get_family): Likewise.
8166 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8168 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8170 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8172 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8175 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8177 Add lexical binding.
8179 * window.c (Ftemp_output_buffer_show): New fun.
8180 (Fsave_window_excursion):
8181 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8183 * lread.c (lisp_file_lexically_bound_p): New function.
8184 (Fload): Bind Qlexical_binding.
8185 (readevalloop): Remove `evalfun' arg.
8186 Bind Qinternal_interpreter_environment.
8187 (Feval_buffer): Bind Qlexical_binding.
8188 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8190 (syms_of_lread): Declare `lexical-binding'.
8192 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8194 * keyboard.c (eval_dyn): New fun.
8195 (menu_item_eval_property): Use it.
8197 * image.c (parse_image_spec): Use Ffunctionp.
8199 * fns.c (concat, mapcar1): Accept byte-code-functions.
8201 * eval.c (Fsetq): Handle lexical vars.
8202 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8203 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8204 (FletX, Flet): Obey lexical binding.
8205 (Fcommandp): Handle closures.
8206 (Feval): New `lexical' arg.
8207 (eval_sub): New function extracted from Feval. Use it almost
8208 everywhere where Feval was used. Look up vars in lexical env.
8210 (Ffunctionp): Move from subr.el.
8211 (Ffuncall): Handle closures.
8212 (apply_lambda): Remove `eval_flags'.
8213 (funcall_lambda): Handle closures and new byte-code-functions.
8214 (Fspecial_variable_p): New function.
8215 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8216 but without exporting it to Lisp.
8218 * doc.c (Fdocumentation, store_function_docstring):
8219 * data.c (Finteractive_form): Handle closures.
8221 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8224 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8226 (exec_byte_code): New function extracted from Fbyte_code to handle new
8227 calling convention for byte-code-functions. Add new byte-codes.
8229 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8231 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8233 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8235 * xdisp.c (redisplay_internal): Fix prototype.
8237 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8239 * xdisp.c (SCROLL_LIMIT): New macro.
8240 (try_scrolling): Use it when setting scroll_limit.
8241 Limit scrolling to 100 screen lines.
8242 (redisplay_window): Even when falling back on "recentering",
8243 position point in the window according to scroll-conservatively,
8244 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8246 (try_scrolling): When point is above the window, allow searching
8247 as far as scroll_max, or one screenful, to compute vertical
8248 distance from PT to the scroll margin position. This prevents
8249 try_scrolling from unnecessarily failing when
8250 scroll-conservatively is set to a value slightly larger than the
8251 window height. Clean up the case of PT below the margin at bottom
8252 of window: scroll_max can no longer be INT_MAX. When aggressive
8253 scrolling is in use, don't let point enter the opposite scroll
8254 margin as result of the scroll.
8255 (syms_of_xdisp) <scroll-conservatively>: Document the
8256 threshold of 100 lines for never-recentering scrolling.
8258 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8260 * dispextern.h (move_it_by_lines):
8261 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8262 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8263 (message_log_check_duplicate): Remove parameters `prev_bol' and
8264 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8265 (redisplay_internal): Remove parameter `preserve_echo_area',
8266 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8268 * indent.c (Fvertical_motion):
8269 * window.c (window_scroll_pixel_based, Frecenter):
8270 Don't pass `need_y_p' to `move_it_by_lines'.
8272 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8274 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8275 steal a few bits to be more compact.
8276 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8277 Remove unneeded casts.
8279 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8281 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8283 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8284 binding" message (bug#7967).
8286 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8288 Fix more problems found by GCC 4.6.0's static checks.
8290 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8291 Remove unused local var.
8293 * editfns.c (Fmessage_box): Remove unused local var.
8295 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8296 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8297 Omit unused local vars.
8298 * window.c (shrink_windows): Omit unused local var.
8299 * menu.c (digest_single_submenu): Omit unused local var.
8300 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8301 Omit unused local var.
8303 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8304 Don't assume string length fits in int.
8305 (keyremap_step, read_key_sequence): Use size_t for sizes.
8306 (read_key_sequence): Don't check last_real_key_start redundantly.
8308 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8309 instead of alloca (Bug#8344).
8311 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8312 (Fbacktrace_frame): Don't assume nframes fits in int.
8314 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8316 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8319 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8321 * cm.c (calccost): Turn while-do into do-while, for clarity.
8323 * keyboard.c (syms_of_keyboard): Use the same style as later
8324 in this function when indexing through an array. This also
8325 works around GCC bug 48267.
8327 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8329 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8331 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8332 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8334 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8335 This avoids undefined behavior on integer overflow, and is a bit
8336 more convenient anyway since it is compared to a size_t variable.
8338 Variadic C functions now count arguments with size_t, not int.
8339 This avoids an unnecessary limitation on 64-bit machines, which
8340 caused (substring ...) to crash on large vectors (Bug#8344).
8341 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8342 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8343 All variadic functions and their callers changed accordingly.
8344 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8345 * data.c (arith_driver, float_arith_driver): Likewise.
8346 * editfns.c (general_insert_function): Likewise.
8347 * eval.c (struct backtrace.nargs, interactive_p)
8348 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8349 (funcall_lambda, mark_backtrace): Likewise.
8350 * fns.c (concat): Likewise.
8351 * frame.c (x_set_frame_parameters): Likewise.
8352 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8353 0 if not found, not -1. All callers changed.
8355 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8356 (stack_copy_size): Now size_t, not int.
8357 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8359 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8361 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8362 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8363 All callers changed.
8365 * lisp.h (multibyte_char_to_unibyte):
8366 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8367 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8368 * character.h (CHAR_TO_BYTE8):
8369 * cmds.c (internal_self_insert):
8370 * editfns.c (general_insert_function):
8371 * keymap.c (push_key_description):
8372 * search.c (Freplace_match):
8373 * xdisp.c (message_dolog, set_message_1): All callers changed.
8375 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8377 * keyboard.c (safe_run_hook_funcall): New function.
8378 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8379 don't set the hook to nil, but remove the offending function instead.
8380 (Qcommand_hook_internal): Remove, unused.
8381 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8382 Vcommand_hook_internal.
8384 * eval.c (enum run_hooks_condition): Remove.
8385 (funcall_nil, funcall_not): New functions.
8386 (run_hook_with_args): Call each function through a `funcall' argument.
8387 Remove `cond' argument, now redundant.
8388 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8389 (Frun_hook_with_args_until_failure): Adjust accordingly.
8390 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8392 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8394 * dispextern.h (string_buffer_position): Remove declaration.
8396 * print.c (strout): Remove parameter `multibyte', unused since
8397 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8399 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8400 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8401 All callers changed.
8403 * w32.c (_wsa_errlist): Use braces for struct initializers.
8405 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8406 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8407 All callers changed.
8408 (string_buffer_position): Likewise. Also, make static (it's never
8409 used outside xdisp.c).
8410 (cursor_row_p): Remove parameter `w', unused since
8411 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8412 (decode_mode_spec): Remove parameter `precision', introduced during
8413 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8414 All callers changed.
8416 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8418 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8420 2011-03-27 Anders Lindgren <andlind@gmail.com>
8422 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8423 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8424 (ns_update_auto_hide_menu_bar): New functions.
8425 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8426 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8427 ns_constrain_all_frames.
8428 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8429 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8431 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8433 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8435 2011-03-27 Glenn Morris <rgm@gnu.org>
8437 * syssignal.h: Replace RETSIGTYPE with void.
8438 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8439 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8440 Replace SIGTYPE with void everywhere.
8441 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8442 * s/template.h (SIGTYPE): Remove commented out definition.
8444 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8446 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8447 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8449 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8451 * w32.c (read_unc_volume): Use parameter `henum', instead of
8452 global variable `wget_enum_handle'.
8454 * keymap.c (describe_vector): Remove parameters `indices' and
8455 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8456 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8458 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8460 * keyboard.c (timer_check): Remove parameter `do_it_now',
8461 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8462 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8463 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8465 * keyboard.c (read_char):
8466 * w32menu.c (w32_menu_display_help):
8467 * xmenu.c (show_help_event, menu_help_callback):
8468 Adjust calls to `show_help_echo'.
8470 * gtkutil.c (xg_maybe_add_timer):
8471 * keyboard.c (readable_events):
8472 * process.c (wait_reading_process_output):
8473 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8475 * insdel.c (adjust_markers_gap_motion):
8476 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8477 (gap_left, gap_right): Don't call it.
8479 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8481 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8482 incurred during fontification.
8484 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8486 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8487 (DEFVAR_PER_BUFFER): Don't pass it.
8489 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8490 (scrolling_window): Don't pass it.
8492 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8494 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8496 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8498 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8499 of variables specific to SELinux and computation of `encoded_absname'.
8501 * image.c (XPutPixel): Remove unused variable `height'.
8503 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8505 * unexw32.c (get_section_info): Remove unused variable `section'.
8507 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8508 (system_process_attributes): Remove unused variable `sess'.
8509 (sys_read): Remove unused variable `err'.
8511 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8512 (w32_wnd_proc): Remove unused variable `isdead'.
8513 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8514 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8515 (x_create_tip_frame): Remove unused variable `tem'.
8517 * w32inevt.c (w32_console_read_socket):
8518 Remove unused variable `no_events'.
8520 * w32term.c (x_draw_composite_glyph_string_foreground):
8521 Remove unused variable `width'.
8523 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8525 * w32term.c (x_set_glyph_string_clipping):
8526 Don't pass uninitialized region to CombineRgn.
8528 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8530 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8531 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8532 (Fx_close_connection): Remove unused variable `i'.
8534 * w32font.c (w32font_draw): Return number of glyphs.
8535 (w32font_open_internal): Remove unused variable `i'.
8536 (w32font_driver): Add missing initializer.
8538 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8539 (fill_in_menu): Remove unused variable `items_added'.
8541 * w32term.c (last_mouse_press_frame): Remove static global variable.
8542 (w32_clip_to_row): Remove unused variable `f'.
8543 (x_delete_terminal): Remove unused variable `i'.
8545 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8546 (NOTHING): Remove unused static global variable.
8547 (uniscribe_check_otf): Remove unused variable `table'.
8548 (uniscribe_font_driver): Add missing initializers.
8550 2011-03-23 Julien Danjou <julien@danjou.info>
8552 * term.c (Fsuspend_tty, Fresume_tty):
8553 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8554 * window.c (temp_output_buffer_show):
8555 * insdel.c (signal_before_change):
8556 * frame.c (Fhandle_switch_frame):
8557 * fileio.c (Fdo_auto_save):
8558 * emacs.c (Fkill_emacs):
8559 * editfns.c (save_excursion_restore):
8560 * cmds.c (internal_self_insert):
8561 * callint.c (Fcall_interactively):
8562 * buffer.c (Fkill_all_local_variables):
8563 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8565 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8566 unconditionally since it does the check itself.
8568 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8570 Fix more problems found by GCC 4.5.2's static checks.
8572 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8573 the first time through the loop, since we know p0 < p1 then.
8574 This also avoids a gcc -Wstrict-overflow warning.
8576 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8577 leading to a memory leak, possible in functions like
8578 load_charset_map_from_file that can allocate an unbounded number
8579 of objects (Bug#8318).
8581 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8582 that could (at least in theory) be that large.
8584 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8585 This is less likely to overflow, and avoids undefined behavior if
8586 overflow does occur. All callers changed. Use strtoul to scan
8587 for the unsigned long integer.
8588 (pint2hrstr): Simplify and tune code slightly.
8589 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8591 * scroll.c (do_scrolling): Work around GCC bug 48228.
8592 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8594 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8595 This also avoids a warning with gcc -Wstrict-overflow.
8596 (validate_x_resource_name): Simplify count usage.
8597 This also avoids a warning with gcc -Wstrict-overflow.
8599 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8602 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8604 * process.c (Fmake_network_process): Use socklen_t, not int,
8605 where POSIX says socklen_t is required in portable programs.
8606 This fixes a porting bug on hosts like 64-bit HP-UX, where
8607 socklen_t is wider than int (Bug#8277).
8608 (Fmake_network_process, server_accept_connection):
8609 (wait_reading_process_output, read_process_output):
8612 * process.c: Rename or move locals to avoid shadowing.
8613 (list_processes_1, Fmake_network_process):
8614 (read_process_output_error_handler, exec_sentinel_error_handler):
8615 Rename or move locals.
8616 (Fmake_network_process): Define label "retry_connect" only if needed.
8617 (Fnetwork_interface_info): Fix pointer signedness.
8618 (process_send_signal): Add cast to avoid pointer signedness problem.
8619 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8620 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8622 Make tparam.h and terminfo.c consistent.
8623 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8624 Include tparam.h instead, since it declares them.
8625 * cm.h (PC): Remove extern decl; tparam.h now does this.
8626 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8627 * terminfo.c: Include tparam.h, to check interfaces.
8628 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8629 (tparam): Adjust signature to match interface in tparam.h;
8630 this removes some undefined behavior. Check that outstring and len
8631 are zero, which they always are with Emacs.
8632 * tparam.h (PC, BC, UP): New extern decls.
8634 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8635 (xftfont_open): Rename locals to avoid shadowing.
8637 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8638 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8639 (OTF_TAG_SYM): Omit macro if not needed.
8640 (ftfont_list): Remove unused local.
8641 (get_adstyle_property, ftfont_pattern_entity):
8642 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8643 Rename locals to avoid shadowing.
8645 * xfont.c (xfont_list_family): Mark var as initialized.
8647 * xml.c (make_dom): Now static.
8649 * composite.c (composition_compute_stop_pos): Rename local to
8651 (composition_reseat_it): Remove unused locals.
8652 (find_automatic_composition, composition_adjust_point): Likewise.
8653 (composition_update_it): Mark var as initialized.
8654 (find_automatic_composition): Mark vars as initialized,
8655 with a FIXME (Bug#8290).
8657 character.h: Rename locals to avoid shadowing.
8658 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8659 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8660 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8661 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8664 * textprop.c (property_change_between_p): Remove; unused.
8666 * intervals.c (interval_start_pos): Now static.
8668 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8670 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8671 Rename locals to avoid shadowing.
8673 * sound.c (wav_play, au_play, Fplay_sound_internal):
8674 Fix pointer signedness.
8675 (alsa_choose_format): Remove unused local var.
8676 (wav_play): Initialize a variable to 0, to prevent undefined
8677 behavior (Bug#8278).
8679 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8681 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8683 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8684 clobbering (Bug#8298).
8685 * sysdep.c (sys_subshell): Likewise.
8686 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8688 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8689 This should get cleaned up, so that child_setup has the
8690 same signature on all platforms.
8692 * callproc.c (call_process_cleanup): Now static.
8693 (relocate_fd): Rename locals to avoid shadowing.
8695 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8697 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8698 not to be necessary, and produces flickering.
8700 2011-03-20 Glenn Morris <rgm@gnu.org>
8702 * config.in: Remove file.
8704 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8706 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8707 are now in src/globals.h.
8708 (syms_of_minibuf): Remove spurious & from previous change.
8710 2011-03-20 Leo Liu <sdl.web@gmail.com>
8712 * minibuf.c (completing-read-function): New variable.
8713 (completing-read-default): Rename from completing-read.
8714 (completing-read): Call completing-read-function.
8716 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8718 * xfaces.c (Fx_load_color_file):
8719 Read color file from absolute filename (bug#8250).
8721 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8723 * makefile.w32-in: Update dependencies.
8725 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8727 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8729 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8731 Fix more problems found by GCC 4.5.2's static checks.
8733 * process.c (make_serial_process_unwind, send_process_trap):
8734 (sigchld_handler): Now static.
8736 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8737 That way, the code declares only the vars that it needs.
8738 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8739 * s/cygwin.h (PTY_ITERATION): Likewise.
8740 * s/darwin.h (PTY_ITERATION): Likewise.
8741 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8743 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8744 * process.c (allocate_pty): Don't declare stb unless it's needed.
8746 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8747 (CONSTANTLIM): Remove; unused.
8748 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8749 Define only if needed.
8751 * unexelf.c (unexec): Name an expression,
8752 to avoid gcc -Wbad-function-cast warning.
8753 Use a different way to cause a compilation error if anyone uses
8754 n rather than nn, a way that does not involve shadowing.
8755 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8757 * deps.mk (unexalpha.o): Remove; unused.
8759 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8760 * unexec.h: New file.
8761 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8762 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8764 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8765 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8766 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8767 Change as necessary to match prototype in unexec.h.
8769 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8771 (back_comment, skip_chars): Mark vars as initialized.
8773 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8774 Rename locals to avoid shadowing.
8776 * lread.c (read1): Rewrite so as not to use empty "else".
8777 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8779 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8781 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8782 warning when compiling print.c.
8784 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8785 instead of using an uninitialized var.
8786 (font_sort_entities): Mark var as initialized.
8788 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8790 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8791 pointers to constants.
8792 (font_parse_fcname): Remove unused vars.
8793 (font_delete_unmatched): Now static.
8794 (font_get_spec): Remove; unused.
8795 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8796 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8797 Rename or move locals to avoid shadowing.
8799 * fns.c (require_nesting_list, require_unwind): Now static.
8800 (Ffillarray): Rename locals to avoid shadowing.
8802 * floatfns.c (domain_error2): Define only if needed.
8803 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8805 * alloc.c (mark_backtrace): Move decl from here ...
8806 * lisp.h: ... to here, so that it can be checked.
8808 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8809 (Fdefvar): Rewrite so as not to use empty "else".
8810 (lisp_indirect_variable): Name an expression,
8811 to avoid gcc -Wbad-function-cast warning.
8812 (Fdefvar): Rename locals to avoid shadowing.
8814 * callint.c (quotify_arg, quotify_args): Now static.
8815 (Fcall_interactively): Rename locals to avoid shadowing.
8816 Use const pointer when appropriate.
8818 * lisp.h (get_system_name, get_operating_system_release):
8819 Move decls here, to check interfaces.
8820 * process.c (get_operating_system_release): Move decl to lisp.h.
8821 * xrdb.c (get_system_name): Likewise.
8822 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8823 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8824 some of which prompt warnings from gcc -Wbad-function-cast.
8825 (Fformat_time_string, Fencode_time, Finsert_char):
8826 (Ftranslate_region_internal, Fformat):
8827 Rename or remove local vars to avoid shadowing.
8828 (Ftranslate_region_internal): Mark var as initialized.
8830 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8833 * lisp.h (eassert): Check that the argument compiles, even if
8834 ENABLE_CHECKING is not defined.
8836 * data.c (Findirect_variable): Name an expression, to avoid
8837 gcc -Wbad-function-cast warning.
8838 (default_value, arithcompare, arith_driver, arith_error): Now static.
8839 (store_symval_forwarding): Rename local to avoid shadowing.
8840 (Fmake_variable_buffer_local, Fmake_local_variable):
8841 Mark variables as initialized.
8842 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8844 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8845 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8846 Rename locals to avoid shadowing.
8847 (mark_stack): Move local variables into the #ifdef region where
8849 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8850 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8852 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8853 (GC_STRING_CHARS): Remove; not used.
8854 (Fmemory_limit): Cast sbrk's returned value to char *.
8856 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8857 avoids undefined behavior in theory.
8859 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8861 Use functions, not macros, for up- and down-casing (Bug#8254).
8862 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8863 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8864 to use the following functions instead of these macros.
8865 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8866 EMACS_INT, since callers assume the returned value fits in int.
8867 (upcase1): Likewise, for UPCASE_TABLE.
8868 (uppercasep, lowercasep, upcase): New static inline functions.
8869 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8870 the race-condition problem in the old DOWNCASE.
8872 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8873 Rename locals to avoid shadowing.
8874 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8875 (regex_compile, re_search_2, re_match_2_internal):
8876 Remove unused local vars.
8877 (FREE_VAR): Rewrite so as not to use empty "else",
8878 which gcc can warn about.
8879 (regex_compile, re_match_2_internal): Mark locals as initialized.
8880 (RETALLOC_IF): Define only if needed.
8881 (WORDCHAR_P): Likewise. This one is never needed, but is used
8882 only in a comment talking about a compiler bug, so put inside
8883 the #if 0 of that comment.
8884 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8885 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8888 * search.c (boyer_moore): Rename locals to avoid shadowing.
8889 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8890 (PREV_CHAR_BOUNDARY): Likewise.
8892 * search.c (simple_search): Remove unused var.
8894 * dired.c (compile_pattern): Move decl from here ...
8895 * lisp.h: ... to here, so that it can be checked.
8896 (struct re_registers): New forward decl.
8898 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8900 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8902 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8903 Rename locals to avoid shadowing.
8904 (Fvertical_motion): Mark locals as initialized.
8906 * casefiddle.c (casify_object, casify_region): Now static.
8907 (casify_region): Mark local as initialized.
8909 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8911 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8912 New macros, so that the caller can use some names other than
8913 gcpro1, gcpro2, etc.
8914 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8916 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8917 argument, for consistency with GCPRO2_VAR, etc: it is now the
8918 prefix of the variable, not the variable itself. All uses
8920 * dired.c (directory_files_internal, file_name_completion):
8921 Rename locals to avoid shadowing.
8923 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8924 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8925 dired.c's scmp function, had undefined behavior.
8926 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8927 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8928 * buffer.h: ... to here, because these macros use current_buffer,
8929 and the new implementation with inline functions needs to have
8930 current_buffer in scope now, rather than later when the macros
8932 (downcase, upcase1): New static inline functions.
8933 (DOWNCASE, UPCASE1): Reimplement using these functions.
8934 This avoids undefined behavior in expressions like
8935 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8936 from race conditions in accessing the global variables
8937 case_temp1 and case_temp2.
8938 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8939 * lisp.h (case_temp1, case_temp2): Remove their decls.
8940 * character.h (ASCII_CHAR_P): Move from here ...
8941 * lisp.h: ... to here, so that the inline functions mentioned
8944 * dired.c (directory_files_internal_unwind): Now static.
8946 * fileio.c (file_name_as_directory, directory_file_name):
8947 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8949 (file_name_as_directory): Use const pointers when appropriate.
8950 (Fexpand_file_name): Likewise. In particular, newdir might
8951 point at constant storage, so make it a const pointer.
8952 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8953 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8955 (Fset_file_times, Finsert_file_contents, auto_save_error):
8956 Rename locals to avoid shadowing.
8958 * minibuf.c (choose_minibuf_frame_1): Now static.
8959 (Ftry_completion, Fall_completions): Rename or remove locals
8962 * marker.c (bytepos_to_charpos): Remove; unused.
8964 * lisp.h (verify_bytepos, count_markers): New decls,
8965 so that gcc does not warn that these functions aren't declared.
8967 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8968 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8969 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8970 (copy_text): Remove unused local var.
8972 * filelock.c (within_one_second): Now static.
8973 (lock_file_1): Rename local to avoid shadowing.
8975 * buffer.c (fix_overlays_before): Mark locals as initialized.
8976 (fix_start_end_in_overlays): Likewise. This function should be
8977 simplified by using pointers-to-pointers, but that's a different
8979 (switch_to_buffer_1): Now static.
8980 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8981 (report_overlay_modification): Rename locals to avoid shadowing.
8983 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8984 Fix pointer signedness issue.
8985 (sys_subshell): Mark local as volatile if checking for lint,
8986 to suppress a gcc -Wclobbered warning that does not seem to be right.
8987 (MAXPATHLEN): Define only if needed.
8989 * process.c (serial_open, serial_configure): Move decls from here ...
8990 * systty.h: ... to here, so that they can be checked.
8992 * fns.c (get_random, seed_random): Move extern decls from here ...
8993 * lisp.h: ... to here, so that they can be checked.
8995 * sysdep.c (reset_io): Now static.
8996 (wait_for_termination_signal): Remove; unused.
8998 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8999 (copy_keymap_item, append_key, push_text_char_description):
9001 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9002 (DENSE_TABLE_SIZE): Remove; unused.
9003 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9004 (describe_map_tree):
9005 Rename locals to avoid shadowing.
9007 * keyboard.c: Declare functions static if they are not used elsewhere.
9008 (echo_char, echo_dash, cmd_error, top_level_2):
9009 (poll_for_input, handle_async_input): Now static.
9010 (read_char, kbd_buffer_get_event, make_lispy_position):
9011 (make_lispy_event, make_lispy_movement, apply_modifiers):
9012 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9013 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9014 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9015 (read_key_sequence, read_char): Mark locals as initialized.
9016 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9018 * keyboard.h (make_ctrl_char): New decl.
9019 (mark_kboards): Move decl here ...
9020 * alloc.c (mark_kboards): ... from here.
9022 * lisp.h (force_auto_save_soon): New decl.
9024 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9025 (DEFINE_DUMMY_FUNCTION): New macro.
9026 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9028 (main): Add casts to avoid warnings
9029 if GCC considers string literals to be constants.
9031 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9033 * dbusbind.c: Pointer signedness fixes.
9034 (xd_signature, xd_append_arg, xd_initialize):
9035 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9036 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9037 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9038 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9040 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9041 if GCC considers string literals to be constants.
9042 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9044 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9046 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9047 (print_preprocess, print_object): New macro to fix last change.
9049 * print.c (print_preprocess): Don't forget font objects.
9051 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9053 * emacs.c (USAGE3): Doc fixes.
9055 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9057 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9060 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9062 * lisp.h (VWindow_system, Qfile_name_history):
9063 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9064 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9065 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9067 * w32select.c: Don't #include "keyboard.h".
9068 (run_protected): Add extern declaration for waiting_for_input.
9070 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9071 * w32console.c (detect_input_pending, read_input_pending)
9072 (encode_terminal_code):
9073 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9074 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9075 (w32_system_caret_y, Qfile_name_history):
9076 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9077 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9078 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9079 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9080 * w32proc.c (Qlocal, report_file_error):
9081 * w32term.c (Vwindow_system, updating_frame):
9082 * w32uniscribe.c (initialized, uniscribe_font_driver):
9083 Remove unneeded extern declarations.
9085 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9087 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9089 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9091 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9092 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9093 These macros can no longer be used for assignment.
9095 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9096 Assign struct members directly, instead of using BUF_BEGV etc.
9097 (record_buffer_markers, fetch_buffer_markers): New functions for
9098 recording and fetching special buffer markers.
9099 (set_buffer_internal_1, set_buffer_temp): Use them.
9101 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9103 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9105 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9106 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9108 * xdisp.c (hscroll_window_tree):
9109 (reconsider_clip_changes): Use PT instead of BUF_PT.
9111 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9113 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9114 $(EMACS_ROOT)/lib/intprops.h.
9116 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9118 Fix more problems found by GCC 4.5.2's static checks.
9120 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9121 to unsigned char * to avoid compiler diagnostic.
9122 (xg_free_frame_widgets): Make it clear that a local variable is
9123 needed only if USE_GTK_TOOLTIP.
9124 (gdk_window_get_screen): Make it clear that this macro is needed
9125 only if USE_GTK_TOOLTIP.
9126 (int_gtk_range_get_value): New function, which avoids a diagnostic
9127 from gcc -Wbad-function-cast.
9128 (xg_set_toolkit_scroll_bar_thumb): Use it.
9129 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9130 diagnostic from gcc -Wbad-function-cast.
9131 (get_utf8_string, xg_get_file_with_chooser):
9132 Rename locals to avoid shadowing.
9133 (create_dialog): Move locals to avoid shadowing.
9135 * xgselect.c (xg_select): Remove unused var.
9137 * image.c (four_corners_best): Mark locals as initialized.
9138 (gif_load): Initialize transparent_p to zero (Bug#8238).
9139 Mark another local as initialized.
9140 (my_png_error, my_error_exit): Mark with NO_RETURN.
9142 * image.c (clear_image_cache): Now static.
9143 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9144 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9145 (x_edge_detection): Remove unnecessary cast that
9146 gcc -Wbad-function-cast diagnoses.
9147 (gif_load): Fix pointer signedness.
9148 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9149 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9151 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9153 Improve quality of tests for time stamp overflow.
9154 For example, without this patch (encode-time 0 0 0 1 1
9155 1152921504606846976) returns the obviously-bogus value (-948597
9156 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9157 reports time overflow. See
9158 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9159 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9160 * editfns.c: Include limits.h and intprops.h.
9161 (TIME_T_MIN, TIME_T_MAX): New macros.
9162 (time_overflow): Move earlier, to before first use.
9163 (hi_time, lo_time): New functions, for an accurate test for
9165 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9166 (Fget_internal_run_time): Don't assume time_t fits in int.
9167 (make_time): Use list2 instead of Fcons twice.
9168 (Fdecode_time): More accurate test for out-of-range times.
9169 (check_tm_member): New function.
9170 (Fencode_time): Use it, to test for out-of-range times.
9171 (lisp_time_argument): Don't rely on undefined left-shift and
9172 right-shift behavior when checking for time stamp overflow.
9174 * editfns.c (time_overflow): New function, refactoring common code.
9175 (Fformat_time_string, Fdecode_time, Fencode_time):
9176 (Fcurrent_time_string): Use it.
9178 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9179 * dired.c (make_time): Move to ...
9180 * editfns.c (make_time): ... here.
9181 * systime.h: Note the move.
9183 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9185 * fringe.c (update_window_fringes): Remove unused variables.
9187 * unexmacosx.c (copy_data_segment): Also copy __got section.
9190 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9192 * termcap.c [MSDOS]: Include "msdos.h".
9193 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9194 Constify `char *' arguments and their references according to
9195 prototypes in tparam.h.
9197 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9199 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9200 Adapt all references accordingly.
9202 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9204 2011-03-11 Tom Tromey <tromey@redhat.com>
9206 * buffer.c (syms_of_buffer): Remove obsolete comment.
9208 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9210 * termhooks.h (encode_terminal_code): Declare prototype.
9212 * msdos.c (encode_terminal_code): Don't declare prototype.
9214 * term.c (encode_terminal_code): Now external again, used by
9215 w32console.c and msdos.c.
9217 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9218 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9220 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9222 Fix some minor problems found by GCC 4.5.2's static checks.
9224 * fringe.c (update_window_fringes): Mark locals as initialized
9226 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9228 * alloc.c (mark_fringe_data): Move decl from here ...
9229 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9230 to check its interface.
9231 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9233 * fontset.c (free_realized_fontset): Now static.
9234 (Fset_fontset_font): Rename local to avoid shadowing.
9235 (fontset_font): Mark local as initialized.
9236 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9238 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9240 * xselect.c (x_disown_buffer_selections): Remove; not used.
9241 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9242 (x_own_selection, Fx_disown_selection_internal): Rename locals
9244 (x_handle_dnd_message): Remove local to avoid shadowing.
9246 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9247 so that the caller can use some name other than gcpro1.
9248 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9249 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9250 (Fx_backspace_delete_keys_p):
9251 Use them to avoid shadowing, and rename vars to avoid shadowing.
9252 (x_decode_color, x_set_name, x_window): Now static.
9253 (Fx_create_frame): Add braces to silence GCC warning.
9254 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9255 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9256 Remove unused locals.
9257 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9258 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9259 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9262 * xterm.h (x_mouse_leave): New decl.
9264 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9265 Remove unused functions.
9266 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9267 (x_calc_absolute_position): Now static.
9268 (XTread_socket): Don't define label "out" unless it's used.
9269 Don't declare local "event" unless it's used.
9270 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9271 unless they are used.
9272 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9273 (x_fatal_error_signal): Remove; not used.
9274 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9275 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9276 (x_error_catcher, x_connection_closed, x_error_handler):
9277 (x_error_quitter, xembed_send_message, x_iconify_frame):
9278 (my_log_handler): Rename locals to avoid shadowing.
9279 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9280 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9282 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9283 Rename or move locals to avoid shadowing.
9284 (tty_defined_color, merge_face_heights): Now static.
9285 (free_realized_faces_for_fontset): Remove; not used.
9286 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9287 does not deduce is never used uninitialized.
9288 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9289 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9291 * terminal.c (store_terminal_param): Now static.
9293 * xmenu.c (menu_highlight_callback): Now static.
9294 (set_frame_menubar): Remove unused local.
9295 (xmenu_show): Rename parameter to avoid shadowing.
9296 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9297 since they might point to immutable storage.
9298 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9299 since it's unused otherwise.
9301 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9302 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9303 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9304 avoids a gcc -Wuninitialized diagnostic.
9305 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9306 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9307 does not deduce are never used uninitialized.
9309 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9311 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9312 * window.c (window_loop, size_window):
9313 (run_window_configuration_change_hook, enlarge_window): Likewise.
9315 * window.c (display_buffer): Now static.
9316 (size_window): Mark variables that gcc -Wuninitialized
9317 does not deduce are never used uninitialized.
9318 * window.h (check_all_windows): New decl, to forestall
9319 gcc -Wmissing-prototypes diagnostic.
9320 * dispextern.h (bidi_dump_cached_states): Likewise.
9322 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9324 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9326 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9327 and to avoid gcc -Wuninitialized warning.
9328 (load_charset_map): Mark variables that gcc -Wuninitialized
9329 does not deduce are never used uninitialized.
9330 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9332 * coding.c (coding_set_source, coding_set_destination):
9333 Use "else { /* comment */ }" rather than "else /* comment */;"
9334 for clarity, and to avoid gcc -Wempty-body warning.
9335 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9336 a block, when the outer 'i' will do.
9337 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9338 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9339 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9340 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9341 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9342 Rename locals to avoid shadowing.
9343 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9344 * coding.c (emacs_mule_char, encode_invocation_designation):
9345 Now static, since they're not used elsewhere.
9346 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9347 (decode_coding_object, encode_coding_object, detect_coding_system):
9348 (decode_coding_emacs_mule): Mark variables that gcc
9349 -Wuninitialized does not deduce are never used uninitialized.
9350 (detect_coding_iso_2022): Initialize a local variable that might
9351 be used uninitialized. Leave a FIXME because it's not clear that
9352 this initialization is needed. (Bug#8211)
9353 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9354 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9355 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9356 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9357 Remove unused macros.
9359 * category.c (hash_get_category_set): Remove unused local var.
9360 (copy_category_table): Now static, since it's not used elsewhere.
9361 * character.c (string_count_byte8): Likewise.
9363 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9364 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9366 * chartab.c (copy_sub_char_table): Now static, since it's not used
9368 (sub_char_table_ref_and_range, char_table_ref_and_range):
9369 Rename locals to avoid shadowing.
9370 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9372 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9373 (BIDI_BOB): Remove unused macro.
9375 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9376 deduce are never used uninitialized.
9377 * term.c (encode_terminal_code): Likewise.
9379 * term.c (encode_terminal_code): Now static. Remove unused local.
9381 * tparam.h: New file.
9382 * term.c, tparam.h: Include it.
9383 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9384 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9385 Move these decls to tparam.h, and make them agree with what
9386 is actually in tparam.c. The previous trick of using incompatible
9387 decls in different modules does not conform to the C standard.
9388 All callers of tparam changed to use tparam's actual API.
9389 * tparam.c (tparam1, tparam, tgoto):
9390 Use const pointers where appropriate.
9392 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9393 * cm.h (struct cm): Likewise.
9394 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9395 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9396 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9397 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9398 (turn_on_face, init_tty): Likewise.
9399 * termchar.h (struct tty_display_info): Likewise.
9401 * term.c (term_mouse_position): Rename local to avoid shadowing.
9403 * alloc.c (mark_ttys): Move decl from here ...
9404 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9406 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9408 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9410 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9412 * search.c (compile_pattern_1): Remove argument regp, unused since
9413 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9414 (compile_pattern): Don't pass it.
9416 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9418 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9419 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9421 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9423 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9425 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9426 gdk_window_get_screen, gdk_window_get_geometry,
9427 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9428 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9429 (xg_get_pixbuf_from_pixmap): New function.
9430 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9431 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9432 Call xg_get_pixbuf_from_pixmap instead of
9433 gdk_pixbuf_get_from_drawable.
9434 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9435 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9436 (xg_check_special_colors): Use GtkStyleContext and its functions
9438 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9439 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9440 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9441 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9442 Call gtk_widget_get_preferred_size.
9443 (xg_frame_resized): gdk_window_get_geometry only takes 5
9445 (xg_win_to_widget, xg_event_is_for_menubar):
9446 Call gdk_x11_window_lookup_for_display.
9447 (xg_set_widget_bg): New function.
9448 (delete_cb): New function.
9449 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9450 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9451 (xg_set_background_color): Call xg_set_widget_bg.
9452 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9453 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9454 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9455 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9457 (update_frame_tool_bar): Call gtk_widget_hide.
9458 (xg_initialize): Use GDK_KEY_g.
9460 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9462 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9464 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9465 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9466 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9468 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9470 * w32xfns.c (select_palette): Check success of RealizePalette against
9471 GDI_ERROR, not zero.
9473 See ChangeLog.11 for earlier changes.
9479 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9481 This file is part of GNU Emacs.
9483 GNU Emacs is free software: you can redistribute it and/or modify
9484 it under the terms of the GNU General Public License as published by
9485 the Free Software Foundation, either version 3 of the License, or
9486 (at your option) any later version.
9488 GNU Emacs is distributed in the hope that it will be useful,
9489 but WITHOUT ANY WARRANTY; without even the implied warranty of
9490 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9491 GNU General Public License for more details.
9493 You should have received a copy of the GNU General Public License
9494 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.