| commit | d858579f7a5dd48c14c2c909d6b9fd6c9866bbfe | |
| author | John Foerch <jjfoerch@earthlink.net> | |
| Wed, 24 Feb 2010 02:40:16 +0000 (23 21:40 -0500) | ||
| committer | John Foerch <jjfoerch@earthlink.net> | |
| Wed, 24 Feb 2010 02:40:16 +0000 (23 21:40 -0500) | ||
| tree | c49a1aa9d8094bd19cb379748a936ef4f4b1a2bc | treesnapshot (tar.gz zip) |
| parent | e7830743440936d7c480fd6c19d9173498347ebf | commitdiff |
session_load: fix error exposed by 6e15c57.. fix parenthesization..
the proximate problem was that correcting (! b instanceof content_buffer)
to (! (b instanceof content_buffer)) caused session_load to bail as soon
as it reached the end of the existing buffers during the window-recycling
loop, whereas before (! b instanceof content_buffer) was always a false
condition.
the ultimate problem was that session_load was coded to skip over special
buffers, skipping the loading of the corresponding session url. (can't
load an url into a special buffer, so don't try to load the url at all)
the fix was to kill all special buffers before the recycling loop, so we
are guaranteed that all buffers are content buffers.
the proximate problem was that correcting (! b instanceof content_buffer)
to (! (b instanceof content_buffer)) caused session_load to bail as soon
as it reached the end of the existing buffers during the window-recycling
loop, whereas before (! b instanceof content_buffer) was always a false
condition.
the ultimate problem was that session_load was coded to skip over special
buffers, skipping the loading of the corresponding session url. (can't
load an url into a special buffer, so don't try to load the url at all)
the fix was to kill all special buffers before the recycling loop, so we
are guaranteed that all buffers are content buffers.
| modules/session.js | diffblobblamehistory |