| commit | a6724a4f0d6dc42d3c529242242ab8bc35767a56 | |
| author | Olly Betts <olly@survex.com> | |
| Mon, 21 Aug 2023 00:08:47 +0000 (21 12:08 +1200) | ||
| committer | Olly Betts <olly@survex.com> | |
| Mon, 21 Aug 2023 00:08:47 +0000 (21 12:08 +1200) | ||
| tree | 31c7c1f54577c0f163740a4f86d18fc8fd6cca27 | treesnapshot (tar.gz zip) |
| parent | ce5bd0c4bf4d6e9f110cad0d6d25ca5a9eb350f6 | commitdiff |
omindex: Fix shell emulation env var corner case
We no longer set environment variables which start with a digit, which
matches shell behaviour and also the existing comment above this code.
Spotted from reading the code - in practice this isn't a case that's
likely to be encountered, and the previous behaviour doesn't appear
to have any security consequences (if an attacker is able to specify the
commands omindex runs to extract text from files then you have a problem
already).
We no longer set environment variables which start with a digit, which
matches shell behaviour and also the existing comment above this code.
Spotted from reading the code - in practice this isn't a case that's
likely to be encountered, and the previous behaviour doesn't appear
to have any security consequences (if an attacker is able to specify the
commands omindex runs to extract text from files then you have a problem
already).
| xapian-applications/omega/runfilter.cc | diffblobblamehistory |