| commit | 44bc9cc264ba13a6033c1145ba2b15f48395356f | |
| author | Doug Torrance <dtorrance@piedmont.edu> | |
| Sat, 18 Apr 2020 18:28:41 +0000 (18 14:28 -0400) | ||
| committer | Carlos R. Mafra <crmafra@gmail.com> | |
| Sat, 18 Apr 2020 18:49:26 +0000 (18 19:49 +0100) | ||
| tree | 91296c970457a6e3c49fa9f9bb394266e6bd262b | treesnapshot (tar.gz zip) |
| parent | dfa92906c0bd8cba4fa5d1ed4e31edc6cdc3ca00 | commitdiff |
Fix various abs() issues.
The abs() function should take an int as argument, but there were
several instances in the code where it was taking an unsigned int or a
double. In these case, we took one of the following approaches:
* If the argument was a double, use fabs() instead.
* If the argument was unsigned and was certainly going to be positive
(i.e,. no subtraction), then drop abs() altogether.
* If the argument was unsigned as result of adding or subtracting signed
and unsigned ints, then we cast all the unsigned ints to signed ints.
The abs() function should take an int as argument, but there were
several instances in the code where it was taking an unsigned int or a
double. In these case, we took one of the following approaches:
* If the argument was a double, use fabs() instead.
* If the argument was unsigned and was certainly going to be positive
(i.e,. no subtraction), then drop abs() altogether.
* If the argument was unsigned as result of adding or subtracting signed
and unsigned ints, then we cast all the unsigned ints to signed ints.
| WPrefs.app/FontSimple.c | diffblobblamehistory | |
| src/menu.c | diffblobblamehistory | |
| src/moveres.c | diffblobblamehistory | |
| src/window.c | diffblobblamehistory | |
| src/xinerama.c | diffblobblamehistory |