Gerald Combs [Mon, 23 Jul 2012 16:46:58 +0000 (23 16:46 -0000)]
Build 1.8.1.
svn path=/trunk-1.8/; revision=43936
Gerald Combs [Mon, 23 Jul 2012 16:46:24 +0000 (23 16:46 -0000)]
Documentation updates for 1.8.1.
svn path=/trunk-1.8/; revision=43935
Gerald Combs [Mon, 23 Jul 2012 16:46:09 +0000 (23 16:46 -0000)]
Fix the library version number.
svn path=/trunk-1.8/; revision=43934
Gerald Combs [Mon, 23 Jul 2012 16:16:03 +0000 (23 16:16 -0000)]
Copy over revisions from the trunk:
------------------------------------------------------------------------
r43850 | jake | 2012-07-19 23:26:35 -0700 (Thu, 19 Jul 2012) | 2 lines
Changed paths:
M /trunk/epan/dissectors/packet-ethertype.c
M /trunk/epan/etypes.h
Add some relevant ethertypes.
------------------------------------------------------------------------
r43868 | wmeier | 2012-07-20 12:09:05 -0700 (Fri, 20 Jul 2012) | 7 lines
Changed paths:
M /trunk/epan/dissectors/packet-bacapp.c
From Lori Tribble:
Attached is a patch which corrects the string construction issue in the
PropertyStates method. This patch also corrects a spelling error for
'utcTimeSyncronization' and adds decode support for this property.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6475#c8
------------------------------------------------------------------------
Update the release notes.
svn path=/trunk-1.8/; revision=43932
Gerald Combs [Sun, 22 Jul 2012 14:34:08 +0000 (22 14:34 -0000)]
[Automatic manuf, services and enterprise-numbers update for 2012-07-22]
svn path=/trunk-1.8/; revision=43912
Guy Harris [Sun, 22 Jul 2012 02:16:45 +0000 (22 02:16 -0000)]
Copy over r43724 from trunk:
------------------------------------------------------------------------
r43724 | pascal | 2012-07-15 08:26:57 -0700 (Sun, 15 Jul 2012) | 3 lines
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7479 :
Provide an empty string when data pointer is not NULL (regression introduced in r43703)
svn path=/trunk-1.8/; revision=43906
Guy Harris [Sun, 22 Jul 2012 01:38:16 +0000 (22 01:38 -0000)]
Copy over r43899 from trunk:
------------------------------------------------------------------------
r43899 | eapache | 2012-07-21 09:29:48 -0700 (Sat, 21 Jul 2012) | 8 lines
Don't throw an assertion if we can't find certain XMPP attributes when
trying to track sessions for iq, jabber, et al. Just return, so we can
dissect whatever attributes we can find. An expert info already gets added
later on.
The other part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7509
svn path=/trunk-1.8/; revision=43905
Guy Harris [Sun, 22 Jul 2012 01:33:42 +0000 (22 01:33 -0000)]
Copy over r43747 from trunk:
------------------------------------------------------------------------
r43747 | darkjames | 2012-07-16 05:09:19 -0700 (Mon, 16 Jul 2012) | 2 lines
proto_tree_add_boolean() takes value not ENC_ flag.
svn path=/trunk-1.8/; revision=43904
Guy Harris [Sun, 22 Jul 2012 01:29:09 +0000 (22 01:29 -0000)]
Copy over revision from trunk:
------------------------------------------------------------------------
r43901 | eapache | 2012-07-21 12:18:12 -0700 (Sat, 21 Jul 2012) | 6 lines
Fix mis-allocated key size as caught by valgrind.
We have to divide the 'length' field to work with guint32 pointer arithmetic,
but we still want to allocate and memcpy the original length value, since
both of those operate in raw bytes, not blocks of sizeof(guint32).
------------------------------------------------------------------------
r43898 | eapache | 2012-07-21 09:10:16 -0700 (Sat, 21 Jul 2012) | 5 lines
The se_tree_* functions are destructive to the key, so save and restore
the key around each call.
Fixes part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7509
svn path=/trunk-1.8/; revision=43903
Pascal Quantin [Sat, 21 Jul 2012 10:13:53 +0000 (21 10:13 -0000)]
Copy over r43883 from trunk:
------------------------------------------------------------------------
r43883 | pascal | 2012-07-21 10:50:32 +0200 (sam. 21 juil. 2012) | 3 lignes
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7508 :
Display snmp.contextName as FT_STRING
------------------------------------------------------------------------
svn path=/trunk-1.8/; revision=43885
Pascal Quantin [Sat, 21 Jul 2012 10:09:16 +0000 (21 10:09 -0000)]
Copy over r43759 from trunk:
------------------------------------------------------------------------
r43759 | pascal | 2012-07-17 09:33:20 +0200 (mar. 17 juil. 2012) | 3 lignes
From Wayne Brassem via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7485 :
Add support for IPv6 over PPP in Jmirror dissector
------------------------------------------------------------------------
svn path=/trunk-1.8/; revision=43884
Guy Harris [Sat, 21 Jul 2012 01:25:56 +0000 (21 01:25 -0000)]
Copy over r43880 from trunk:
------------------------------------------------------------------------
r43880 | guy | 2012-07-20 18:24:54 -0700 (Fri, 20 Jul 2012) | 9 lines
The 32-bit-key tree code assumes that the pointer to the key can be cast
to a pointer to a guint32 and dereferenced. On some platforms, such as
SPARC, this requires that the pointer be aligned on a 4-byte boundary;
there is no guarantee that the data field of an address structure is
aligned on a 4-byte boundary, so allocate a buffer for a copy of that
data and copy the data into it, and free it when we're done with it.
Should fix bug 7501.
svn path=/trunk-1.8/; revision=43881
Guy Harris [Sat, 21 Jul 2012 00:13:17 +0000 (21 00:13 -0000)]
Copy over r43875 from trunk:
------------------------------------------------------------------------
r43875 | guy | 2012-07-20 17:12:21 -0700 (Fri, 20 Jul 2012) | 7 lines
simple_message_box() does not expect Pango markup, so escaping is
not necessary, and just messes up the display.
Fixes bug 7489.
#BACKPORT
svn path=/trunk-1.8/; revision=43876
Gerald Combs [Fri, 20 Jul 2012 18:00:20 +0000 (20 18:00 -0000)]
Copy over r43864 from the trunk:
------------------------------------------------------------------------
r43864 | gerald | 2012-07-20 10:56:16 -0700 (Fri, 20 Jul 2012) | 8 lines
Changed paths:
M /trunk/packaging/nsis/Makefile.nmake
M /trunk/packaging/nsis/wireshark.nsi
According to
http://blogs.msdn.com/b/astebner/archive/2010/10/20/
10078468.aspx
and bug 7507 the Visual C++ 2010 redistributable installer might want
to reboot the system. Tell it not to do that and request a reboot at
the end of the installation process if needed.
------------------------------------------------------------------------
Update the release notes.
svn path=/trunk-1.8/; revision=43865
Guy Harris [Fri, 20 Jul 2012 17:35:49 +0000 (20 17:35 -0000)]
Copy over r43847 from trunk:
------------------------------------------------------------------------
r43847 | guy | 2012-07-19 21:00:29 -0700 (Thu, 19 Jul 2012) | 21 lines
Add a routine that, given a set of packet encapsulation types, returns
the per-file encapsulation type needed to write out a set of packets
with all those encapsulation types. If there's only one such
encapsulation type, that's the type, otherwise WTAP_ENCAP_PER_PACKET is
needed. Use that in wtap_dump_can_write_encaps().
Also use it in cf_save_packets() and cf_export_specified_packets(), so
that we can write out files with WTAP_ENCAP_PER_PACKET as the file
encapsulation type and only one actual per-packet encapsulation type in
some cases where that failed before. This fixes the case that showed up
in bug 7505, although there are other cases where we *could* write out a
capture in a given file format but won't be able to do so; fixing those
will take more work.
#BACKPORT
(Note: this adds a routine to libwiretap, so, when backported, the
*minor* version of the library should be increased. Code that worked
with the version of the library prior to this change will continue to
work, so there's no need to change the *major* version of the library.)
Rev library version stuff according to
http://www.gnu.org/software/libtool/manual/libtool.html#Updating-version-info
which, at least when building for OS X, does the right thing - the
library minor version number in the file name goes from 0 to 1, but the
major version is unchanged.
svn path=/trunk-1.8/; revision=43863
Gerald Combs [Fri, 20 Jul 2012 00:45:59 +0000 (20 00:45 -0000)]
Copy over revisions from the trunk:
------------------------------------------------------------------------
r43661 | etxrab | 2012-07-11 07:40:35 -0700 (Wed, 11 Jul 2012) | 3 lines
Changed paths:
M /trunk/asn1/h248/packet-h248-template.c
M /trunk/epan/dissectors/packet-h248.c
Revert part of revision 43107 which broke sub dissection of
Signal and events as a new tvb wasn't created.
|BASE_EXT_STRING also removed.
------------------------------------------------------------------------
r43662 | etxrab | 2012-07-11 07:41:21 -0700 (Wed, 11 Jul 2012) | 1 line
Changed paths:
M /trunk/epan/dissectors/packet-h248_annex_e.c
failure cause is an OCTET STRING not a string.
------------------------------------------------------------------------
r43668 | pascal | 2012-07-11 13:20:10 -0700 (Wed, 11 Jul 2012) | 3 lines
Changed paths:
M /trunk/epan/dissectors/packet-dvbci.c
From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7468 :
DVB-CI/CI+: fix offset error in operator_info apdu
------------------------------------------------------------------------
r43676 | gerald | 2012-07-11 14:25:42 -0700 (Wed, 11 Jul 2012) | 3 lines
Changed paths:
M /trunk/image/file_dlg_win32.rc
M /trunk/ui/win32/file_dlg_win32.c
MSDN says DIALOG resources are obsolete. Use DIALOGEXes instead. We aren't
adding extra controls to the save dialog any more so remove its template.
------------------------------------------------------------------------
r43763 | darkjames | 2012-07-17 06:01:17 -0700 (Tue, 17 Jul 2012) | 5 lines
Changed paths:
M /trunk/epan/dissectors/packet-ses.c
Fix bug #7488: Unable to correctly identify IEC 61850 MMS packets
In r39066 was added 'final check to see if the next SPDU, if present, is also valid',
but it didn't properly check for tvb length which causes exception if there's no next SPDU.
------------------------------------------------------------------------
Copy over with manual intervention:
------------------------------------------------------------------------
r43790 | etxrab | 2012-07-18 12:44:54 -0700 (Wed, 18 Jul 2012) | 1 line
Changed paths:
M /trunk/ui/gtk/main.c
From Jakub Zawadzki use gtk_box_pack_start isof gtk_container_add fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7377
------------------------------------------------------------------------
Update the release notes.
svn path=/trunk-1.8/; revision=43842
Gerald Combs [Fri, 20 Jul 2012 00:36:09 +0000 (20 00:36 -0000)]
Copy over revisions from the trunk:
------------------------------------------------------------------------
r43443 | pascal | 2012-06-22 13:44:52 -0700 (Fri, 22 Jun 2012) | 3 lines
Changed paths:
M /trunk/epan/dissectors/packet-bootp.c
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7391 :
Do not use same name for filters with incompatible types
------------------------------------------------------------------------
r43448 | pascal | 2012-06-23 07:36:21 -0700 (Sat, 23 Jun 2012) | 2 lines
Changed paths:
M /trunk/epan/dissectors/packet-icmp.c
M /trunk/epan/dissectors/packet-icmpv6.c
M /trunk/epan/dissectors/packet-tcp.c
Do not use same name for filters with incompatible types
------------------------------------------------------------------------
r43474 | pascal | 2012-06-25 04:12:54 -0700 (Mon, 25 Jun 2012) | 2 lines
Changed paths:
M /trunk/epan/dissectors/packet-nas_eps.c
Fix dissection of NAS EPS Service Request message (broken in r42200)
------------------------------------------------------------------------
r43556 | alagoutte | 2012-07-03 05:28:06 -0700 (Tue, 03 Jul 2012) | 10 lines
Changed paths:
M /trunk/epan/dissectors/packet-ieee80211.c
From report of Dennis Mendoza via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7429
Wireshark > 1.4 does not correctly read Association ID for PS Poll packets
Wireless Frame with subtype 0x1a don't interpret the Association ID (always 0).
Fix :
proto_tree_add_uint() wasn't changed to proto_tree_add_item()
#BACKPORT
------------------------------------------------------------------------
r43560 | pascal | 2012-07-03 13:07:53 -0700 (Tue, 03 Jul 2012) | 3 lines
Changed paths:
M /trunk/epan/dissectors/packet-eap.c
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7430 :
Dissection of EAP-SIM and EAP-AKA is broken
------------------------------------------------------------------------
r43576 | darkjames | 2012-07-05 14:09:34 -0700 (Thu, 05 Jul 2012) | 6 lines
Changed paths:
M /trunk/epan/dissectors/packet-nfs.c
Fix bug #7436
offset returned from dissect_nfs_open_claim4, dissect_nfs_openflag4 were different
when we were building tree and where we didn't.
Fix other similar cases.
------------------------------------------------------------------------
r43600 | morriss | 2012-07-07 07:54:14 -0700 (Sat, 07 Jul 2012) | 5 lines
Changed paths:
M /trunk/ui/gtk/main_menubar.c
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7445 :
"Find Next Mark" was duplicated in the Edit menu and "Find Previous Mark" was
missing (the 2nd "Find Next Mark" would, if selected, find the previous mark).
------------------------------------------------------------------------
r43648 | pascal | 2012-07-10 08:43:03 -0700 (Tue, 10 Jul 2012) | 3 lines
Changed paths:
M /trunk/asn1/snmp/packet-snmp-template.c
M /trunk/epan/dissectors/packet-snmp.c
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7438 :
Do not call tvb_ensure_length_remaining on an empty tvb
------------------------------------------------------------------------
Update the release notes.
svn path=/trunk-1.8/; revision=43840
Gerald Combs [Fri, 20 Jul 2012 00:17:42 +0000 (20 00:17 -0000)]
Copy over revisions from the trunk:
------------------------------------------------------------------------
r43784 | rbalint | 2012-07-18 08:14:45 -0700 (Wed, 18 Jul 2012) | 6 lines
Changed paths:
M /trunk/epan/dissectors/packet-ppp.c
Fix crash in PPP dissector
Make sure that there is enough space allocated for PPP encapsulated CRTP
packet's header.
The bug can be triggered on an x86_64 system using the cpature file attached to
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=680056
------------------------------------------------------------------------
Update the release notes.
svn path=/trunk-1.8/; revision=43839
Guy Harris [Wed, 18 Jul 2012 23:45:08 +0000 (18 23:45 -0000)]
Copy over r43812 from trunk:
------------------------------------------------------------------------
r43812 | guy | 2012-07-18 16:44:15 -0700 (Wed, 18 Jul 2012) | 3 lines
Fix non-proto_tree_add_item() calls passing an ENC_ value as the last
argument.
svn path=/trunk-1.8/; revision=43813
Guy Harris [Wed, 18 Jul 2012 23:38:53 +0000 (18 23:38 -0000)]
Copy over r43810 from trunk:
------------------------------------------------------------------------
r43810 | guy | 2012-07-18 16:37:59 -0700 (Wed, 18 Jul 2012) | 3 lines
Fix non-proto_tree_add_item() calls passing an ENC_ value as the last
argument.
svn path=/trunk-1.8/; revision=43811
Guy Harris [Wed, 18 Jul 2012 23:36:30 +0000 (18 23:36 -0000)]
Copy over r43808 from trunk:
------------------------------------------------------------------------
r43808 | guy | 2012-07-18 16:34:59 -0700 (Wed, 18 Jul 2012) | 3 lines
Fix non-proto_tree_add_item() calls passing an ENC_ value as the last
argument.
svn path=/trunk-1.8/; revision=43809
Guy Harris [Wed, 18 Jul 2012 23:31:48 +0000 (18 23:31 -0000)]
Copy over r43806 from trunk:
------------------------------------------------------------------------
r43806 | guy | 2012-07-18 16:30:45 -0700 (Wed, 18 Jul 2012) | 3 lines
Fix non-proto_tree_add_item() calls passing an ENC_ value as the last
argument.
svn path=/trunk-1.8/; revision=43807
Guy Harris [Wed, 18 Jul 2012 23:28:32 +0000 (18 23:28 -0000)]
Copy over r43804 from trunk:
------------------------------------------------------------------------
r43804 | guy | 2012-07-18 16:27:37 -0700 (Wed, 18 Jul 2012) | 3 lines
Fix non-proto_tree_add_item() calls passing an ENC_ value as the last
argument.
svn path=/trunk-1.8/; revision=43805
Guy Harris [Wed, 18 Jul 2012 23:19:39 +0000 (18 23:19 -0000)]
Copy over r43802 from trunk:
------------------------------------------------------------------------
r43802 | guy | 2012-07-18 16:18:01 -0700 (Wed, 18 Jul 2012) | 3 lines
Fix non-proto_tree_add_item() calls passing an ENC_ value as the last
argument.
svn path=/trunk-1.8/; revision=43803
Guy Harris [Wed, 18 Jul 2012 23:14:48 +0000 (18 23:14 -0000)]
Copy over r43800 from trunk:
------------------------------------------------------------------------
r43800 | guy | 2012-07-18 16:06:20 -0700 (Wed, 18 Jul 2012) | 3 lines
Fix a non-proto_tree_add_item() passing an ENC_ value as the last
argument.
svn path=/trunk-1.8/; revision=43801
Guy Harris [Wed, 18 Jul 2012 23:00:46 +0000 (18 23:00 -0000)]
Copy over r43798 from the trunk:
------------------------------------------------------------------------
r43798 | guy | 2012-07-18 15:59:54 -0700 (Wed, 18 Jul 2012) | 3 lines
Fix a non-proto_tree_add_item() passing an ENC_ value as the last
argument.
svn path=/trunk-1.8/; revision=43799
Gerald Combs [Sun, 15 Jul 2012 14:34:01 +0000 (15 14:34 -0000)]
[Automatic manuf, services and enterprise-numbers update for 2012-07-15]
svn path=/trunk-1.8/; revision=43721
Guy Harris [Wed, 11 Jul 2012 03:58:12 +0000 (11 03:58 -0000)]
Copy over r43657 from trunk:
------------------------------------------------------------------------
r43657 | guy | 2012-07-10 20:57:13 -0700 (Tue, 10 Jul 2012) | 14 lines
Don't ask for information about an interface greater than the maximum
interface for which we have information.
Fixes bug 7467.
Should also cause an error message, rather than an unreadable capture
file, to be produced for the cases in bug 7381. (This isn't a fix for
bug 7381; it's arguably an improvement, in the sense that a circuit
breaker tripping or a fuse blowing for a short circuit is an improvement
over a fire starting, but it's not a *fix*, any more than a circuit
break or fuse *fixes* the short circuit.)
svn path=/trunk-1.8/; revision=43658
Guy Harris [Wed, 11 Jul 2012 03:51:22 +0000 (11 03:51 -0000)]
Copy over r43655 from trunk:
------------------------------------------------------------------------
r43655 | guy | 2012-07-10 20:50:28 -0700 (Tue, 10 Jul 2012) | 8 lines
AARGH. There are two lumps of (almost-)identical code to handle
interface information when opening an output file, one of which I fixed
in my previous checkin and the other of which I didn't notice. Shuffle
code around a little bit so that the lumps are identical and then put
them into a common routine (*with* the fix in question).
svn path=/trunk-1.8/; revision=43656
Guy Harris [Tue, 10 Jul 2012 20:00:39 +0000 (10 20:00 -0000)]
Copy over r43652 from trunk:
------------------------------------------------------------------------
r43652 | guy | 2012-07-10 12:59:39 -0700 (Tue, 10 Jul 2012) | 6 lines
Set the time units per second correctly if, in wtap_dump_open_ng(),
we're making a fake interface description (it should match the time
stamp resolution). The dump code for pcap-NG now requires the time
units per second value, as it needs to correctly compute the time stamp
value to write out in an EPB.
svn path=/trunk-1.8/; revision=43653
Guy Harris [Tue, 10 Jul 2012 19:17:01 +0000 (10 19:17 -0000)]
Copy over r43649 from the trunk:
------------------------------------------------------------------------
r43649 | guy | 2012-07-10 12:12:37 -0700 (Tue, 10 Jul 2012) | 10 lines
When writing an EPB, calculate the time stamp based on the resolution
for the interface, not based on the default resolution of 1 microsecond.
Fixes bug 7457.
Fix a comment.
Clean up indentation.
svn path=/trunk-1.8/; revision=43650
Gerald Combs [Sun, 8 Jul 2012 14:33:57 +0000 (8 14:33 -0000)]
[Automatic manuf, services and enterprise-numbers update for 2012-07-08]
svn path=/trunk-1.8/; revision=43612
Guy Harris [Tue, 3 Jul 2012 20:20:37 +0000 (3 20:20 -0000)]
Copy over r43561 from trunk:
------------------------------------------------------------------------
r43561 | guy | 2012-07-03 13:12:50 -0700 (Tue, 03 Jul 2012) | 18 lines
As per Gentoo bug 423743
https://bugs.gentoo.org/show_bug.cgi?id=423743
"The Makefile.am claims including GLIB_LIBS when linking wireshark is
unnecessary, because wireshark links to GTK_LIBS which is a superset.
It is not actually a superset: gmodule is included in GLIB_LIBS but
not in GTK_LIBS (unless accidentally on older glibs/gtks)."
so we must explicitly link with GLIB_LIBS.
Update the comment to reflect that - and to reflect that GTK+ doesn't
necessarily run atop X11 - while we're at it.
Fixes bug 7427.
#BACKPORT
svn path=/trunk-1.8/; revision=43562
Gerald Combs [Sun, 1 Jul 2012 14:34:00 +0000 (1 14:34 -0000)]
[Automatic manuf, services and enterprise-numbers update for 2012-07-01]
svn path=/trunk-1.8/; revision=43552
Bill Meier [Wed, 27 Jun 2012 15:19:24 +0000 (27 15:19 -0000)]
Copy over r43506, r43507 and r43511 from trunk:
------------------------------------------------------------------------
r43506 | wmeier | 2012-06-27 09:37:13 -0400 (Wed, 27 Jun 2012) | 7 lines
From Jakub Zawadzki: Fix "typeahead search broken in Display Filter Expression Window"
Revert SVN #42291.
Fixes Bug #7412: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7412
------------------------------------------------------------------------
r43507 | wmeier | 2012-06-27 09:57:39 -0400 (Wed, 27 Jun 2012) | 7 lines
Fix for "predefined values sometimes missing in Display Filter Expression window.
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7413
Essentially: BASE_CUSTOM was being used as a mask rather than a field value.
------------------------------------------------------------------------
r43511 | wmeier | 2012-06-27 10:58:32 -0400 (Wed, 27 Jun 2012) | 9 lines
Commit file which should have been part of SVN #43506
From Jakub Zawadzki: Fix "typeahead search broken in Display Filter Expression Window"
Revert SVN #42291.
Fixes Bug #7412: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7412
svn path=/trunk-1.8/; revision=43512
Guy Harris [Wed, 27 Jun 2012 05:17:38 +0000 (27 05:17 -0000)]
Copy over r43501 from the trunk:
------------------------------------------------------------------------
r43501 | guy | 2012-06-26 22:13:06 -0700 (Tue, 26 Jun 2012) | 7 lines
Don't supply a fallback error message for pcap_open() unless it actually
fails.
This may clear up the problem most recently reported in bug 7021 after
the crash was fixed, where the capture starts successfully but an error
dialog pops up.
svn path=/trunk-1.8/; revision=43502
Jeff Morriss [Tue, 26 Jun 2012 20:43:55 +0000 (26 20:43 -0000)]
Copy over from trunk:
------------------------------------------------------------------------
r43498 | morriss | 2012-06-26 16:41:28 -0400 (Tue, 26 Jun 2012) | 6 lines
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7406 :
Build the idl2wrs man page (including the HTML version) but don't install
them: a developer might want to read the man page and the Debian development
package wants to install them.
svn path=/trunk-1.8/; revision=43499
Guy Harris [Tue, 26 Jun 2012 04:26:48 +0000 (26 04:26 -0000)]
Copy over r43493 from the trunk:
------------------------------------------------------------------------
r43493 | guy | 2012-06-25 21:26:04 -0700 (Mon, 25 Jun 2012) | 3 lines
Have the toolbar "Save" button just be a "Save" button, working the same
as the File -> Save menu item.
svn path=/trunk-1.8/; revision=43494
Guy Harris [Mon, 25 Jun 2012 18:38:51 +0000 (25 18:38 -0000)]
Copy over r43477 from the trunk:
------------------------------------------------------------------------
r43477 | guy | 2012-06-25 11:37:52 -0700 (Mon, 25 Jun 2012) | 28 lines
Only allow "Save" if
the file has unsaved changes, and we can save it in some format
through Wiretap
or
the file is a temporary file and has no unsaved changes (so that
"saving" it just means copying it).
Only allow "Save As" if
we can save it in some format through Wiretap
or
the file is a temporary file and has no unsaved changes (so that
"saving" it just means copying it).
This means that we don't support using "Save As" for just copying the
file unless we can do that with Wiretap; copying the file byte-for-byte
only works as "saving" if there are no unsaved changes *and* we're
saving it in the same format that it's in *and* we're saving it with the
same form of compression (if any) that it has.
Rename cf_can_save_as() to cf_can_write_with_wiretap() to better reflect
what it really does.
svn path=/trunk-1.8/; revision=43478
Guy Harris [Mon, 25 Jun 2012 17:57:45 +0000 (25 17:57 -0000)]
Copy over r43475 from trunk:
------------------------------------------------------------------------
r43475 | guy | 2012-06-25 10:56:29 -0700 (Mon, 25 Jun 2012) | 3 lines
In the "Save As" dialog box, default to compressed if the file is
compressed and the default file format supports compression.
svn path=/trunk-1.8/; revision=43476
Gerald Combs [Sun, 24 Jun 2012 23:54:26 +0000 (24 23:54 -0000)]
"git describe --tags --abbrev=0" should work now. Use it.
svn path=/trunk-1.8/; revision=43470
Gerald Combs [Sun, 24 Jun 2012 14:33:58 +0000 (24 14:33 -0000)]
[Automatic manuf, services and enterprise-numbers update for 2012-06-24]
svn path=/trunk-1.8/; revision=43453
Guy Harris [Sat, 23 Jun 2012 08:42:29 +0000 (23 08:42 -0000)]
Copy over r43444 from the trunk:
------------------------------------------------------------------------
r43444 | guy | 2012-06-23 01:18:14 -0700 (Sat, 23 Jun 2012) | 8 lines
In the Windows capture file "Save As" dialog code, do the same sort of
checks for the inability to save comments that we do for UN*X. This
should fix bug 7222, although the UI isn't currently as nice, as the
dialog boxes are Windows dialog boxes and we don't set the button labels
to reflect the actual choices being offered to the user. (We may be
able to do that by using template resources to construct the message
boxes.)
svn path=/trunk-1.8/; revision=43445
Gerald Combs [Thu, 21 Jun 2012 19:34:13 +0000 (21 19:34 -0000)]
1.8.0 → 1.8.1.
svn path=/trunk-1.8/; revision=43435
Gerald Combs [Thu, 21 Jun 2012 18:15:02 +0000 (21 18:15 -0000)]
Build 1.8.0.
svn path=/trunk-1.8/; revision=43431
Gerald Combs [Thu, 21 Jun 2012 17:37:00 +0000 (21 17:37 -0000)]
Copy over r43428 from the trunk:
------------------------------------------------------------------------
r43428 | gerald | 2012-06-21 10:35:59 -0700 (Thu, 21 Jun 2012) | 2 lines
Changed paths:
M /trunk/Makefile.nmake
M /trunk/packaging/nsis/Makefile.am
Try to fix tarball compilation on Windows.
------------------------------------------------------------------------
svn path=/trunk-1.8/; revision=43429
Gerald Combs [Thu, 21 Jun 2012 16:30:06 +0000 (21 16:30 -0000)]
Release notes talk pretty one day.
svn path=/trunk-1.8/; revision=43427
Gerald Combs [Thu, 21 Jun 2012 16:26:07 +0000 (21 16:26 -0000)]
Copy over revisions from the trunk:
------------------------------------------------------------------------
r43389 | morriss | 2012-06-19 13:20:18 -0700 (Tue, 19 Jun 2012) | 5 lines
Changed paths:
M /trunk/epan/dissectors/packet-ipv6.c
M /trunk/epan/dissectors/packet-ipv6.h
Correct the IPv6 fragment offset shown in COL_INFO.
Make some Fragment header fields filterable (add_text() -> add_item()).
Display (and make filterable) the reserved octet and bits.
------------------------------------------------------------------------
r43401 | etxrab | 2012-06-20 00:59:20 -0700 (Wed, 20 Jun 2012) | 2 lines
Changed paths:
M /trunk/epan/dissectors/packet-gsm_a_bssmap.c
- In INTERNAL HANDOVER COMMAND Circuit Identity Code is C(Coded optional in WS)
- be_speech_codec ( 3.2.2.104 Speech Codec) did not cover all codecs.
------------------------------------------------------------------------
r43408 | pascal | 2012-06-20 06:37:22 -0700 (Wed, 20 Jun 2012) | 3 lines
Changed paths:
M /trunk/epan/dissectors/packet-gmr1_dtap.c
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7383 :
Put back items into the correct dtap_tree tree and comment pd_tree that is unused for now
------------------------------------------------------------------------
r43409 | pascal | 2012-06-20 06:42:17 -0700 (Wed, 20 Jun 2012) | 2 lines
Changed paths:
M /trunk/epan/dissectors/packet-gmr1_dtap.c
Fix compilation with gcc...
------------------------------------------------------------------------
r43420 | gerald | 2012-06-20 13:44:05 -0700 (Wed, 20 Jun 2012) | 5 lines
Changed paths:
M /trunk/tshark.c
If we're making two passes and we have a display filter applied, create
a protocol tree in process_packet_first_pass(). Otherwise we crash with
ERROR:dfvm.c:434:dfvm_apply: assertion failed: (tree)
------------------------------------------------------------------------
Update the release notes.
svn path=/trunk-1.8/; revision=43426
Jeff Morriss [Wed, 20 Jun 2012 13:35:24 +0000 (20 13:35 -0000)]
Copy over from trunk:
------------------------------------------------------------------------
r43406 | morriss | 2012-06-20 09:30:07 -0400 (Wed, 20 Jun 2012) | 4 lines
Use separate filters for the RTT found on a SACK and the RTT found on a
DATA chunk: having them in both places is helpful when looking at the
messages but having them separate is helpful when graphing the RTTs.
svn path=/trunk-1.8/; revision=43407
Guy Harris [Wed, 20 Jun 2012 05:53:42 +0000 (20 05:53 -0000)]
Copy over r43394 from trunk:
------------------------------------------------------------------------
r43394 | etxrab | 2012-06-19 21:42:55 -0700 (Tue, 19 Jun 2012) | 1 line
MAke it compile by adding discard_comments = FALSE
svn path=/trunk-1.8/; revision=43400
Guy Harris [Wed, 20 Jun 2012 05:52:40 +0000 (20 05:52 -0000)]
Copy over r43302 from trunk:
------------------------------------------------------------------------
r43302 | guy | 2012-06-16 18:50:52 -0700 (Sat, 16 Jun 2012) | 2 lines
Reflect change to wtap_get_savable_file_types.
svn path=/trunk-1.8/; revision=43399
Guy Harris [Wed, 20 Jun 2012 05:48:57 +0000 (20 05:48 -0000)]
Copy over r43397 from trunk:
------------------------------------------------------------------------
r43397 | guy | 2012-06-19 22:48:06 -0700 (Tue, 19 Jun 2012) | 2 lines
Clean up white space (no tabs).
svn path=/trunk-1.8/; revision=43398
Guy Harris [Wed, 20 Jun 2012 04:45:08 +0000 (20 04:45 -0000)]
Copy over r43395 from the trunk:
------------------------------------------------------------------------
r43395 | guy | 2012-06-19 21:44:14 -0700 (Tue, 19 Jun 2012) | 5 lines
Handle the case where the user has added comments to a file that's not
in a format that supports comments and they do a "Save" by popping up a
similar question to the one we pop up in the "Save As" case and, if they
say "choose another format", pop up a "Save As" dialog box.
svn path=/trunk-1.8/; revision=43396
Guy Harris [Wed, 20 Jun 2012 01:13:06 +0000 (20 01:13 -0000)]
Copy over r43392 from trunk:
------------------------------------------------------------------------
r43392 | guy | 2012-06-19 18:11:01 -0700 (Tue, 19 Jun 2012) | 10 lines
If the file has an SHB comment or any packet comments, and the user
tries to do "Save As" in a format for which we don't support comments
(currently, we only support them for pcap-ng), ask whether they want to
discard the comments and save anyway or, *if* the file can be saved in a
format for which we *do* support comments, they want to save the file in
some other format.
Keep a count of packet comments so that we don't have to scan all the
frame_data structures to determine whether we have any comments.
svn path=/trunk-1.8/; revision=43393
Gerald Combs [Tue, 19 Jun 2012 19:53:59 +0000 (19 19:53 -0000)]
Copy over r43387 from the trunk:
------------------------------------------------------------------------
r43387 | gerald | 2012-06-19 12:53:03 -0700 (Tue, 19 Jun 2012) | 5 lines
Changed paths:
M /trunk/wiretap/Makefile.am
M /trunk/wiretap/Makefile.nmake
ascend_scanner.c includes ascend.h. Add corresponding makefile
dependencies, otherwise we might have a race condition when doing
parallel makes. Hopefully this will fix intermitten buildbot failures
we've been getting lately.
------------------------------------------------------------------------
svn path=/trunk-1.8/; revision=43388
Guy Harris [Tue, 19 Jun 2012 19:22:47 +0000 (19 19:22 -0000)]
Copy over r43381 from trunk:
------------------------------------------------------------------------
r43381 | guy | 2012-06-19 12:20:47 -0700 (Tue, 19 Jun 2012) | 5 lines
The GTK+ file chooser already *includes* UI code to ask the user whether
they want to overwrite an existing file; just use that. (The Win32 file
chooser also does that itself.) Just do UI for "do you want to
overwrite this {user-immutable,unwritable} file?".
svn path=/trunk-1.8/; revision=43383
Guy Harris [Tue, 19 Jun 2012 19:22:04 +0000 (19 19:22 -0000)]
Copy over r43380 from the trunk:
------------------------------------------------------------------------
r43380 | guy | 2012-06-19 11:47:22 -0700 (Tue, 19 Jun 2012) | 6 lines
The "save as" dialog is modal, so we don't need to worry about keeping
track of multiple such "save as" windows.
Use modal dialog boxes to report errors, while we're at it. That lets
us keep the dialog open if we get an error.
svn path=/trunk-1.8/; revision=43382
Gerald Combs [Tue, 19 Jun 2012 17:41:23 +0000 (19 17:41 -0000)]
Copy over revisions from the trunk:
------------------------------------------------------------------------
r43343 | tuexen | 2012-06-18 14:50:59 -0700 (Mon, 18 Jun 2012) | 2 lines
Changed paths:
M /trunk/dumpcap.c
Fix compilation on FreeBSD.
------------------------------------------------------------------------
r43345 | etxrab | 2012-06-18 23:08:58 -0700 (Mon, 18 Jun 2012) | 12 lines
Changed paths:
M /trunk/ui/gtk/capture_if_dlg.c
From Pontus Fuchs:
If there are many interfaces the button bar is not visible
unless you manually resize the dialog. On a normal Linux PC
you can easily reach 15-20 interfaces due to USB monitor.
Add a vbox so that you get a scrollbar for the interface table
instead of on the window. This way the button bar is always
visible.
Also increase the default height to handle 20 interfaces.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7379
------------------------------------------------------------------------
r43362 | darkjames | 2012-06-19 07:25:50 -0700 (Tue, 19 Jun 2012) | 4 lines
Changed paths:
M /trunk/epan/dissectors/packet-gsm_sms.c
Fix bug #7378: Wireshark 1.8.0rc1: gsm_a_dtap SMS 7-bit default alphabet regression w.r.t. 1.6.8
proto_item_add_string() can be only used with ASCII strings.
------------------------------------------------------------------------
r43367 | etxrab | 2012-06-19 07:49:12 -0700 (Tue, 19 Jun 2012) | 2 lines
Changed paths:
M /trunk/ui/gtk/CMakeLists.txt
M /trunk/ui/gtk/main_menubar.c
Get rid of the remnats of NEW_MENU_CODE.
It's probably not a good idea to read the menu bar code from file as it causes problems with permissions when Wireshark is run fom build dir.
------------------------------------------------------------------------
r43368 | etxrab | 2012-06-19 07:54:11 -0700 (Tue, 19 Jun 2012) | 1 line
Changed paths:
M /trunk/Makefile.am
M /trunk/packaging/nsis/wireshark.nsi
Don't install main-menubar-ui.xml
------------------------------------------------------------------------
r43370 | morriss | 2012-06-19 08:39:52 -0700 (Tue, 19 Jun 2012) | 9 lines
Changed paths:
M /trunk/Makefile.am
M /trunk/debian/rules
M /trunk/doc/Makefile.am
Don't install idl2wrs except in Debian's special wireshark-dev package.
(Normal Wireshark installations can't be used to develop dissectors so there's
no need to install it or its man page.)
http://www.wireshark.org/lists/wireshark-dev/201206/msg00073.html
(The Debian changes are untested.)
------------------------------------------------------------------------
r43371 | gerald | 2012-06-19 08:44:10 -0700 (Tue, 19 Jun 2012) | 2 lines
Changed paths:
M /trunk/doc/tshark.pod
M /trunk/doc/wireshark-filter.pod
Remove what appears to be an errant vi/vim command and add a newline.
------------------------------------------------------------------------
r43377 | morriss | 2012-06-19 10:32:49 -0700 (Tue, 19 Jun 2012) | 1 line
Changed paths:
M /trunk/packaging/macosx/Scripts/cli-postinstall.sh
M /trunk/packaging/macosx/osx-app.sh
M /trunk/packaging/nsis/Makefile.nmake
Followup to r43370: don't install idl2wrs or its man page.
------------------------------------------------------------------------
svn path=/trunk-1.8/; revision=43378
Gerald Combs [Mon, 18 Jun 2012 20:58:11 +0000 (18 20:58 -0000)]
Use a tag that compiles (r43301).
svn path=/trunk-1.8/; revision=43341
Gerald Combs [Mon, 18 Jun 2012 20:56:26 +0000 (18 20:56 -0000)]
Switch back to interim versions.
svn path=/trunk-1.8/; revision=43340
Gerald Combs [Mon, 18 Jun 2012 18:43:07 +0000 (18 18:43 -0000)]
Build 1.8.0rc2.
svn path=/trunk-1.8/; revision=43337
Gerald Combs [Mon, 18 Jun 2012 17:26:50 +0000 (18 17:26 -0000)]
Copy over revisions from the trunk:
------------------------------------------------------------------------
r43303 | sake | 2012-06-17 02:02:04 -0700 (Sun, 17 Jun 2012) | 3 lines
Changed paths:
M /trunk/epan/dissectors/packet-ssl-utils.c
Fix reading back exported SSL keys. Bug was introduced in r43097.
------------------------------------------------------------------------
r43304 | sake | 2012-06-17 04:30:25 -0700 (Sun, 17 Jun 2012) | 3 lines
Changed paths:
M /trunk/epan/dissectors/packet-dtls.c
M /trunk/epan/dissectors/packet-ssl.c
Enhance dissection of the NewSessionTicket handshake message.
------------------------------------------------------------------------
r43204 | wmeier | 2012-06-11 08:47:50 -0700 (Mon, 11 Jun 2012) | 5 lines
Changed paths:
M /trunk/epan/dissectors/packet-ip.c
M /trunk/epan/dissectors/packet-ip.h
Create dscp_vals_ext value_str_ext (based upon dscp_vals); Use it as appropriate.
Also:
- use val_to_str_const() [instead of val_to_str()] in a few cases;
- do some trivial formatting cleanup.
------------------------------------------------------------------------
r43211 | wmeier | 2012-06-11 12:07:53 -0700 (Mon, 11 Jun 2012) | 3 lines
Changed paths:
M /trunk/epan/dissectors/packet-ip.h
M /trunk/epan/dissectors/packet-megaco.c
M /trunk/epan/dissectors/packet-mpls-pm.c
M /trunk/epan/dissectors/packet-nhrp.h
Use dscp_vals_ext everyplace (instead of dscp_vals);
(dscp_vals is now a static array in packet-ip.c)
------------------------------------------------------------------------
r43221 | jmayer | 2012-06-12 03:38:22 -0700 (Tue, 12 Jun 2012) | 4 lines
Changed paths:
M /trunk/epan/dissectors/packet-ip.c
M /trunk/epan/dissectors/packet-ip.h
M /trunk/epan/dissectors/packet-ipv6.c
Manually revert r41953
BACKPORT to 1.8
------------------------------------------------------------------------
r43222 | jmayer | 2012-06-12 03:44:57 -0700 (Tue, 12 Jun 2012) | 4 lines
Changed paths:
M /trunk/epan/dissectors/packet-ip.c
M /trunk/epan/dissectors/packet-ip.h
M /trunk/epan/dissectors/packet-ipv6.c
Revert r41952
BACKPORT to 1.8
------------------------------------------------------------------------
svn path=/trunk-1.8/; revision=43336
Guy Harris [Mon, 18 Jun 2012 08:35:03 +0000 (18 08:35 -0000)]
Copy over r43330 from trunk:
------------------------------------------------------------------------
r43330 | guy | 2012-06-18 01:30:53 -0700 (Mon, 18 Jun 2012) | 2 lines
Add "simple dialog" routines to pop up modal message boxes.
svn path=/trunk-1.8/; revision=43331
Guy Harris [Mon, 18 Jun 2012 06:00:17 +0000 (18 06:00 -0000)]
Copy over r43327 from trunk:
------------------------------------------------------------------------
r43327 | guy | 2012-06-17 22:59:33 -0700 (Sun, 17 Jun 2012) | 2 lines
Add initialization to squelch compiler warnings.
svn path=/trunk-1.8/; revision=43328
Guy Harris [Mon, 18 Jun 2012 05:58:22 +0000 (18 05:58 -0000)]
Copy over r43325 from the trunk:
------------------------------------------------------------------------
r43325 | guy | 2012-06-17 22:57:26 -0700 (Sun, 17 Jun 2012) | 3 lines
Use the GTK+ message type, not the Wireshark message type, in GTK+
calls.
svn path=/trunk-1.8/; revision=43326
Guy Harris [Sun, 17 Jun 2012 23:30:28 +0000 (17 23:30 -0000)]
Copy over r43323 from the trunk:
------------------------------------------------------------------------
r43323 | guy | 2012-06-17 16:24:06 -0700 (Sun, 17 Jun 2012) | 3 lines
Stuff the "Don't show this message again" checkbox in the dialog's
content area.
svn path=/trunk-1.8/; revision=43324
Guy Harris [Sun, 17 Jun 2012 22:33:11 +0000 (17 22:33 -0000)]
Copy over r43321 from the trunk:
------------------------------------------------------------------------
r43321 | guy | 2012-06-17 15:32:03 -0700 (Sun, 17 Jun 2012) | 5 lines
Add "simple dialog" routines to pop up modal message boxes. Use them in
file.c and routines called from it; non-modal dialogs end up, in some
cases, either hidden, devoid of the input focus and not dismissable, or
both.
svn path=/trunk-1.8/; revision=43322
Gerald Combs [Sun, 17 Jun 2012 17:07:27 +0000 (17 17:07 -0000)]
[Automatic manuf, services and enterprise-numbers update for 2012-06-17]
svn path=/trunk-1.8/; revision=43319
Guy Harris [Sun, 17 Jun 2012 16:54:19 +0000 (17 16:54 -0000)]
Copy over r43317 from the trunk:
------------------------------------------------------------------------
r43317 | guy | 2012-06-17 09:53:31 -0700 (Sun, 17 Jun 2012) | 2 lines
Forgot to use wtap_dump_can_write_encaps()'s final name.
svn path=/trunk-1.8/; revision=43318
Guy Harris [Sun, 17 Jun 2012 16:45:32 +0000 (17 16:45 -0000)]
Copy over r43315 from the trunk:
------------------------------------------------------------------------
r43315 | guy | 2012-06-17 09:44:09 -0700 (Sun, 17 Jun 2012) | 5 lines
Export a wtap_dump_can_write_encaps() routine from Wiretap; it takes a
file type and a GArray of encapsulation types and returns TRUE if a
capture with all those encapsulation types can be written to a file in
that file type and FALSE otherwise. Use it where appropriate.
svn path=/trunk-1.8/; revision=43316
Pascal Quantin [Sun, 17 Jun 2012 16:19:27 +0000 (17 16:19 -0000)]
Copy over revisions from the trunk:
------------------------------------------------------------------------
r43280 | pascal | 2012-06-16 15:09:51 +0200 (sam. 16 juin 2012) | 3 lignes
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7371 :
Add dissection of Release 8 or higher P-GW QoS profile
------------------------------------------------------------------------
r43312 | pascal | 2012-06-17 18:08:43 +0200 (dim. 17 juin 2012) | 2 lignes
Allow future forward compatibility
svn path=/trunk-1.8/; revision=43313
Guy Harris [Sun, 17 Jun 2012 01:47:59 +0000 (17 01:47 -0000)]
Copy over revisions from the trunk:
------------------------------------------------------------------------
r43300 | guy | 2012-06-16 18:32:50 -0700 (Sat, 16 Jun 2012) | 16 lines
Have wtap_get_savable_file_types() take an array of encapsulations and
only return file types that could handle a single file with all those
encapsulations - this means that
1) if there's more then one encapsulation, the file format has
to handle per-packet encapsulation;
2) just because a file format handles per-packet encapsulation,
that doesn't mean that it can handle the *particular* encapsulations
being handed to it.
This fixes some cases where we were claiming that a file could be saved
in a format that doesn't actually support it (e.g., ISDN files being
reported as savable in pcap-NG format - there's no LINKTYPE_ value for
ISDN including B and D channels).
------------------------------------------------------------------------
r43278 | guy | 2012-06-15 16:54:05 -0700 (Fri, 15 Jun 2012) | 7 lines
For a capture file, keep an array of all encapsulation types seen.
Show all of them in the summary dialog; we will be using it in the
future to figure out what capture file formats we can write to (just
because a capture file format supports per-packet encapsulations, that
doesn't mean that it supports *all possible* encapsulations).
svn path=/trunk-1.8/; revision=43301
Guy Harris [Sat, 16 Jun 2012 19:27:24 +0000 (16 19:27 -0000)]
Copy over r43277 from the trunk:
------------------------------------------------------------------------
r43277 | darkjames | 2012-06-15 16:04:59 -0700 (Fri, 15 Jun 2012) | 5 lines
highlight_field: use passed GtkTreeView for proto_tree_draw.
highlight_field() is also called when we open packet in new window and we click some bytes,
it caused redrawing packet details in *main window* but with protocol tree from (possibly) another frame.
svn path=/trunk-1.8/; revision=43289
Guy Harris [Sat, 16 Jun 2012 19:06:37 +0000 (16 19:06 -0000)]
Copy over r43224 from the trunk:
------------------------------------------------------------------------
r43224 | wmeier | 2012-06-12 06:03:05 -0700 (Tue, 12 Jun 2012) | 2 lines
Note that calls to "expert" functions should not be under 'if (tree)'.
svn path=/trunk-1.8/; revision=43287
Guy Harris [Sat, 16 Jun 2012 19:00:58 +0000 (16 19:00 -0000)]
Copy over revisions from the trunk:
------------------------------------------------------------------------
r43173 | cmaynard | 2012-06-08 20:54:29 -0700 (Fri, 08 Jun 2012) | 2 lines
Undo an accidental portion of the last commit.
------------------------------------------------------------------------
r43172 | cmaynard | 2012-06-08 20:41:23 -0700 (Fri, 08 Jun 2012) | 2 lines
Be sure to specify FORMAT_MESSAGE_IGNORE_INSERTS in the dwFlags arg to
all FormatMessage() calls where FORMAT_MESSAGE_FROM_SYSTEM is also
specified. (Ref: http://blogs.msdn.com/b/oldnewthing/archive/2007/11/28/
6564257.aspx)
svn path=/trunk-1.8/; revision=43286
Guy Harris [Sat, 16 Jun 2012 18:35:13 +0000 (16 18:35 -0000)]
Copy over r43198 from the trunk:
------------------------------------------------------------------------
r43198 | etxrab | 2012-06-11 00:14:52 -0700 (Mon, 11 Jun 2012) | 4 lines
From Evan Huus:
Airpcap memory leak.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7352
svn path=/trunk-1.8/; revision=43285
Guy Harris [Sat, 16 Jun 2012 18:28:39 +0000 (16 18:28 -0000)]
Copy over r43191 from the trunk:
------------------------------------------------------------------------
r43191 | cmaynard | 2012-06-10 17:53:23 -0700 (Sun, 10 Jun 2012) | 2 lines
Remove duplicate entry.
svn path=/trunk-1.8/; revision=43284
Guy Harris [Sat, 16 Jun 2012 18:17:12 +0000 (16 18:17 -0000)]
Copy over revisions from the trunk:
------------------------------------------------------------------------
r43252 | guy | 2012-06-13 20:50:39 -0700 (Wed, 13 Jun 2012) | 6 lines
In effect, disable closing the main window while a capture is being
stopped - there's no guaranteed way to make the UI's close button
inactive (on X11, it depends on whether the window manager allows that),
but we can just do nothing and return TRUE from the delete event handler
to ignore the delete event.
------------------------------------------------------------------------
r43251 | guy | 2012-06-13 20:50:28 -0700 (Wed, 13 Jun 2012) | 3 lines
Re-enable the File -> Quit menu item when the capture stops (or is
started again).
------------------------------------------------------------------------
r43250 | guy | 2012-06-13 19:19:46 -0700 (Wed, 13 Jun 2012) | 5 lines
Disable some menu items and toolbar items while we're waiting for a
capture to stop, so that we don't try to quit while we're in the middle
of quitting or try to stop or restart the capture we're in the middle of
stopping.
------------------------------------------------------------------------
r43249 | guy | 2012-06-13 19:11:34 -0700 (Wed, 13 Jun 2012) | 2 lines
No pcap, no capture to stop.
------------------------------------------------------------------------
r43248 | guy | 2012-06-13 18:34:52 -0700 (Wed, 13 Jun 2012) | 5 lines
When stopping the capture before asking whether to save the results, run
the main loop until we're done reading the captured packets. Hopefully
this clears up bug 7318 in Evan Huus's case; I can't reproduce that
myself.
svn path=/trunk-1.8/; revision=43283
Guy Harris [Sat, 16 Jun 2012 17:54:07 +0000 (16 17:54 -0000)]
Copy over r43212 from the trunk:
------------------------------------------------------------------------
r43212 | darkjames | 2012-06-11 12:27:57 -0700 (Mon, 11 Jun 2012) | 4 lines
Fix bug 6917
strtod() is locale-aware, change it to g_ascii_strtod()
svn path=/trunk-1.8/; revision=43282
Guy Harris [Sat, 16 Jun 2012 17:47:18 +0000 (16 17:47 -0000)]
Copy over r43271 from the trunk:
------------------------------------------------------------------------
r43271 | etxrab | 2012-06-15 05:27:21 -0700 (Fri, 15 Jun 2012) | 4 lines
Try to fix pcap-ng - most files created by editcap -c have no IDB
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7350
By using wtap_dump_open_ng() in all places.
svn path=/trunk-1.8/; revision=43281
Anders Broman [Sat, 16 Jun 2012 09:49:13 +0000 (16 09:49 -0000)]
Copy over r43270 from trunk Log: Correct a discrepancy in the specification.
svn path=/trunk-1.8/; revision=43279
Gerald Combs [Fri, 15 Jun 2012 20:45:07 +0000 (15 20:45 -0000)]
Copy over r43228 from the trunk:
------------------------------------------------------------------------
r43228 | morriss | 2012-06-12 18:13:12 -0700 (Tue, 12 Jun 2012) | 6 lines
Changed paths:
M /trunk/doc/README.developer
M /trunk/epan/dissectors/packet-dtls.c
M /trunk/epan/dissectors/packet-ssl.c
M /trunk/epan/libwireshark.def
M /trunk/epan/prefs-int.h
M /trunk/epan/prefs.c
M /trunk/epan/prefs.h
M /trunk/plugins/asn1/packet-asn1.c
M /trunk/plugins/mate/packet-mate.c
M /trunk/ui/gtk/prefs_dlg.c
Create, and start using, file name preferences.
File name preferences are basically just string preferences except that the
GUI will present a "Browse" button that allows the user to go and find the
file s/he wants (rather than having to blindly type in the full path).
------------------------------------------------------------------------
svn path=/trunk-1.8/; revision=43276
Gerald Combs [Fri, 15 Jun 2012 18:18:07 +0000 (15 18:18 -0000)]
Copy over r43274 from the trunk:
------------------------------------------------------------------------
r43274 | gerald | 2012-06-15 11:17:20 -0700 (Fri, 15 Jun 2012) | 4 lines
Changed paths:
M /trunk/Makefile.am
M /trunk/ui/qt/Makefile.am
M /trunk/ui/qt/Makefile.common
Don't install the Qt resource images. They get converted to C arrays in
qrc_*.cpp so they shouldn't be necessary even when we're building and
installing qtshark.
------------------------------------------------------------------------
svn path=/trunk-1.8/; revision=43275
Jakub Zawadzki [Fri, 15 Jun 2012 08:28:47 +0000 (15 08:28 -0000)]
Backport part of r43267 to 1.8
Double registration of yami module cause not calling proto_reg_handoff_yami after changing preferences.
svn path=/trunk-1.8/; revision=43269
Gerald Combs [Thu, 14 Jun 2012 19:50:41 +0000 (14 19:50 -0000)]
Copy over r43264 from the trunk:
------------------------------------------------------------------------
r43264 | gerald | 2012-06-14 12:49:57 -0700 (Thu, 14 Jun 2012) | 2 lines
Changed paths:
M /trunk/packaging/nsis/uninstall.nsi
Add back an absolute path prefix.
------------------------------------------------------------------------
svn path=/trunk-1.8/; revision=43265
Gerald Combs [Thu, 14 Jun 2012 18:54:48 +0000 (14 18:54 -0000)]
Copy over r43261 from the trunk:
------------------------------------------------------------------------
r43261 | gerald | 2012-06-14 11:53:55 -0700 (Thu, 14 Jun 2012) | 2 lines
Changed paths:
M /trunk/packaging/nsis/common.nsh
M /trunk/packaging/nsis/uninstall.nsi
M /trunk/packaging/nsis/wireshark.nsi
M /trunk/packaging/ws-manifest.pl
More NSIS cleanup.
------------------------------------------------------------------------
svn path=/trunk-1.8/; revision=43262
Bill Meier [Thu, 14 Jun 2012 13:43:34 +0000 (14 13:43 -0000)]
Copy over SVN #43226 from trunk
------------------------------------------------------------------------
r43226 | wmeier | 2012-06-12 17:22:46 -0400 (Tue, 12 Jun 2012) | 2 lines
Fix: code under 'if(tree)' (in)directly calls sub-dissector/col_...()/expert...() fcns
------------------------------------------------------------------------
svn path=/trunk-1.8/; revision=43258
Pascal Quantin [Thu, 14 Jun 2012 07:22:14 +0000 (14 07:22 -0000)]
Copy over r43253 from the trunk:
------------------------------------------------------------------------
r43253 | pascal | 2012-06-14 09:14:59 +0200 (jeu., 14 juin 2012) | 3 lines
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7368 :
Identity request, Identity response and Authentication failure message dissection are swapped
------------------------------------------------------------------------
svn path=/trunk-1.8/; revision=43254
Gerald Combs [Wed, 13 Jun 2012 23:05:47 +0000 (13 23:05 -0000)]
Copy over r43246 from the trunk:
------------------------------------------------------------------------
r43246 | gerald | 2012-06-13 16:04:57 -0700 (Wed, 13 Jun 2012) | 2 lines
Changed paths:
M /trunk/packaging/u3/win32/Makefile.nmake
Fix things to match what we're doing in our portableapps counterpart.
------------------------------------------------------------------------
svn path=/trunk-1.8/; revision=43247
Gerald Combs [Wed, 13 Jun 2012 22:29:21 +0000 (13 22:29 -0000)]
Copy over r43244 from the trunk:
------------------------------------------------------------------------
r43244 | gerald | 2012-06-13 15:28:28 -0700 (Wed, 13 Jun 2012) | 3 lines
Changed paths:
M /trunk/packaging/portableapps/win32/Makefile.nmake
M /trunk/packaging/portableapps/win32/makenmake.pl
M /trunk/packaging/u3/win32/Makefile.nmake
M /trunk/packaging/u3/win32/makenmake.pl
M /trunk/packaging/ws-manifest.pl
Don't add uninstall.exe to the U3/PortableApps manifest. Define
STAGING_DIR. Update some makefile dependencies.
------------------------------------------------------------------------
svn path=/trunk-1.8/; revision=43245
Gerald Combs [Wed, 13 Jun 2012 21:04:32 +0000 (13 21:04 -0000)]
Copy over r43239 from the trunk:
------------------------------------------------------------------------
r43239 | gerald | 2012-06-13 14:03:54 -0700 (Wed, 13 Jun 2012) | 3 lines
Changed paths:
M /trunk/packaging/nsis/Makefile.nmake
M /trunk/packaging/nsis/wireshark.nsi
Define STAGING_DIR and use it in various places instead of hard-coding
"..\.." or "..\..\wireshark-gtk2".
------------------------------------------------------------------------
svn path=/trunk-1.8/; revision=43240
Gerald Combs [Wed, 13 Jun 2012 20:12:52 +0000 (13 20:12 -0000)]
Copy over revisions from the trunk:
------------------------------------------------------------------------
r43236 | gerald | 2012-06-13 12:06:27 -0700 (Wed, 13 Jun 2012) | 17 lines
Changed paths:
M /trunk/packaging/nsis/AdditionalTasksPage.ini
M /trunk/packaging/nsis/Makefile.nmake
A /trunk/packaging/nsis/common.nsh
A /trunk/packaging/nsis/uninstall.nsi
M /trunk/packaging/nsis/wireshark.nsi
Move the "uninstall" parts of wireshark.nsi to uninstall.nsi and the
common parts to common.nsh. Creating an installer now requires two
NSIS runs:
- uninstaller.nsi, which creates an installer (uninstall_installer.exe)
that only writes uninstall.exe to ../../wireshark-gtk2.
- wireshark.nsi, which bundles uninstall.exe along with the rest of
our installation files.
If we ever get around to signing our executables this will let us sign
all of them. It also cleans up the .nsi file contents a bit.
Instead of keeping separate list of file extensions, manage them from
a single macro. Print the extensions we register / deregister in the
detail pane.
------------------------------------------------------------------------
r43237 | gerald | 2012-06-13 13:11:41 -0700 (Wed, 13 Jun 2012) | 3 lines
Changed paths:
M /trunk/packaging/nsis/uninstall.nsi
M /trunk/packaging/nsis/wireshark.nsi
Use terminology that conforms better with the MSDN documentation and a
style that conforms better with the rest of the NSIS output.
------------------------------------------------------------------------
svn path=/trunk-1.8/; revision=43238
Gerald Combs [Wed, 13 Jun 2012 19:06:27 +0000 (13 19:06 -0000)]
Move the "uninstall" parts of wireshark.nsi to uninstall.nsi and the
common parts to common.nsh. Creating an installer now requires two
NSIS runs:
- uninstaller.nsi, which creates an installer (uninstall_installer.exe)
that only writes uninstall.exe to ../../wireshark-gtk2.
- wireshark.nsi, which bundles uninstall.exe along with the rest of
our installation files.
If we ever get around to signing our executables this will let us sign
all of them. It also cleans up the .nsi file contents a bit.
Instead of keeping separate list of file extensions, manage them from
a single macro. Print the extensions we register / deregister in the
detail pane.
svn path=/trunk/; revision=43236
Jeff Morriss [Wed, 13 Jun 2012 17:25:16 +0000 (13 17:25 -0000)]
Mark a couple of parameters as unused.
svn path=/trunk/; revision=43235
Bill Meier [Wed, 13 Jun 2012 16:44:06 +0000 (13 16:44 -0000)]
Add a comment as to .bsc files seemingly not usable with VS2010.
svn path=/trunk/; revision=43234
Bill Meier [Wed, 13 Jun 2012 16:19:35 +0000 (13 16:19 -0000)]
Add '*.sbr' to 'clean'
svn path=/trunk/; revision=43233
Bill Meier [Wed, 13 Jun 2012 16:18:38 +0000 (13 16:18 -0000)]
Add a comment as to .bsc files seemingly not usable with VS2010.
svn path=/trunk/; revision=43232
Anders Broman [Wed, 13 Jun 2012 15:27:41 +0000 (13 15:27 -0000)]
From Michael Mann:
length bugfix + proto_tree_add_text() cleanup
Fixed the Web-Cache Identity Info dissection. Also converted many of the
proto_tree_add_text() to "more filterable" APIs.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5141
svn path=/trunk/; revision=43231
Jeff Morriss [Wed, 13 Jun 2012 14:56:33 +0000 (13 14:56 -0000)]
From Michael Mann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3317
Add SSL/TLS support to the POP dissector (functionality copied from the
SMTP dissector).
svn path=/trunk/; revision=43230
Bill Meier [Wed, 13 Jun 2012 14:42:30 +0000 (13 14:42 -0000)]
wireshark.bsc dependencies: fix a typo; add 2 which are missing.
svn path=/trunk/; revision=43229