From 28e7c3b9a93afc0010b5c498e098a49ced458156 Mon Sep 17 00:00:00 2001 From: Roy Shea Date: Mon, 25 Feb 2008 17:41:35 -0800 Subject: [PATCH] qmgr: Implement IBackgroundCopyJob_GetDisplayName with test. --- dlls/qmgr/job.c | 14 ++++++++++++-- dlls/qmgr/tests/job.c | 18 ++++++++++++++++++ 2 files changed, 30 insertions(+), 2 deletions(-) diff --git a/dlls/qmgr/job.c b/dlls/qmgr/job.c index b15f39b89a6..b14783cb2d3 100644 --- a/dlls/qmgr/job.c +++ b/dlls/qmgr/job.c @@ -194,8 +194,18 @@ static HRESULT WINAPI BITS_IBackgroundCopyJob_GetDisplayName( IBackgroundCopyJob* iface, LPWSTR *pVal) { - FIXME("Not implemented\n"); - return E_NOTIMPL; + BackgroundCopyJobImpl *This = (BackgroundCopyJobImpl *) iface; + int n; + + if (!pVal) + return E_INVALIDARG; + + n = (lstrlenW(This->displayName) + 1) * sizeof **pVal; + *pVal = CoTaskMemAlloc(n); + if (*pVal == NULL) + return E_OUTOFMEMORY; + memcpy(*pVal, This->displayName, n); + return S_OK; } static HRESULT WINAPI BITS_IBackgroundCopyJob_SetDescription( diff --git a/dlls/qmgr/tests/job.c b/dlls/qmgr/tests/job.c index 9f216dab72e..65ac06cbe2a 100644 --- a/dlls/qmgr/tests/job.c +++ b/dlls/qmgr/tests/job.c @@ -99,6 +99,23 @@ static void test_GetType(void) ok(type == test_type, "Got incorrect type\n"); } +/* Test that the display name is properly set */ +static void test_GetName(void) +{ + HRESULT hres; + LPWSTR displayName; + + hres = IBackgroundCopyJob_GetDisplayName(test_job, &displayName); + ok(hres == S_OK, "GetName failed: %08x\n", hres); + if(hres != S_OK) + { + skip("Unable to get display name of test_job.\n"); + return; + } + ok(lstrcmpW(displayName, test_displayName) == 0, "Got incorrect type\n"); + CoTaskMemFree(displayName); +} + typedef void (*test_t)(void); START_TEST(job) @@ -106,6 +123,7 @@ START_TEST(job) static const test_t tests[] = { test_GetId, test_GetType, + test_GetName, 0 }; const test_t *test; -- 2.11.4.GIT