From e44a0d6d4dd5237c739e1827d286be180c329d80 Mon Sep 17 00:00:00 2001 From: Chris Robinson Date: Fri, 9 Mar 2007 05:47:37 -0800 Subject: [PATCH] quartz: Check allocation failure and clear memory in DSound Renderer. --- dlls/quartz/dsoundrender.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/dlls/quartz/dsoundrender.c b/dlls/quartz/dsoundrender.c index fe6152fcb66..67ab55065d8 100644 --- a/dlls/quartz/dsoundrender.c +++ b/dlls/quartz/dsoundrender.c @@ -316,18 +316,23 @@ HRESULT DSoundRender_create(IUnknown * pUnkOuter, LPVOID * ppv) return CLASS_E_NOAGGREGATION; pDSoundRender = CoTaskMemAlloc(sizeof(DSoundRenderImpl)); + if (!pDSoundRender) + return E_OUTOFMEMORY; + ZeroMemory(pDSoundRender, sizeof(DSoundRenderImpl)); pDSoundRender->lpVtbl = &DSoundRender_Vtbl; pDSoundRender->IBasicAudio_vtbl = &IBasicAudio_Vtbl; pDSoundRender->refCount = 1; InitializeCriticalSection(&pDSoundRender->csFilter); pDSoundRender->state = State_Stopped; - pDSoundRender->pClock = NULL; - pDSoundRender->init = FALSE; - pDSoundRender->started = FALSE; - ZeroMemory(&pDSoundRender->filterInfo, sizeof(FILTER_INFO)); pDSoundRender->ppPins = CoTaskMemAlloc(1 * sizeof(IPin *)); + if (!pDSoundRender->ppPins) + { + DeleteCriticalSection(&pDSoundRender->csFilter); + CoTaskMemFree(pDSoundRender); + return E_OUTOFMEMORY; + } /* construct input pin */ piInput.dir = PINDIR_INPUT; -- 2.11.4.GIT