From 525a5510d15952cb388cd124ca8d226aeaa081d6 Mon Sep 17 00:00:00 2001 From: Marcus Meissner Date: Wed, 28 Jan 2009 23:25:16 +0100 Subject: [PATCH] msxml3: Handle get_element returning NULL (Coverity). --- dlls/msxml3/element.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/dlls/msxml3/element.c b/dlls/msxml3/element.c index f4793958f8a..4f0bce93acc 100644 --- a/dlls/msxml3/element.c +++ b/dlls/msxml3/element.c @@ -644,6 +644,7 @@ static HRESULT WINAPI domelem_getElementsByTagName( { domelem *This = impl_from_IXMLDOMElement( iface ); LPWSTR szPattern; + xmlNodePtr element; HRESULT hr; TRACE("(%p)->(%s,%p)\n", This, debugstr_w(bstrName), resultList); @@ -654,7 +655,11 @@ static HRESULT WINAPI domelem_getElementsByTagName( lstrcpyW(szPattern+3, bstrName); TRACE("%s\n", debugstr_w(szPattern)); - hr = queryresult_create(get_element(This), szPattern, resultList); + element = get_element(This); + if (!element) + hr = E_FAIL; + else + hr = queryresult_create(element, szPattern, resultList); HeapFree(GetProcessHeap(), 0, szPattern); return hr; -- 2.11.4.GIT