From 9b3b9a1060231cbe3c65d6edb06bc06275a58e7c Mon Sep 17 00:00:00 2001 From: Rob Shearman Date: Tue, 10 Nov 2009 23:01:51 +0000 Subject: [PATCH] advapi32: Fix CheckTokenMembership test on Windows. --- dlls/advapi32/tests/security.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/dlls/advapi32/tests/security.c b/dlls/advapi32/tests/security.c index b8d6e19a936..eaa9e2c4c07 100644 --- a/dlls/advapi32/tests/security.c +++ b/dlls/advapi32/tests/security.c @@ -3206,7 +3206,7 @@ static void test_CheckTokenMembership(void) { PTOKEN_GROUPS token_groups; DWORD size; - HANDLE token; + HANDLE process_token, token; BOOL is_member; BOOL ret; DWORD i; @@ -3216,9 +3216,12 @@ static void test_CheckTokenMembership(void) win_skip("CheckTokenMembership is not available\n"); return; } - ret = OpenProcessToken(GetCurrentProcess(), TOKEN_QUERY, &token); + ret = OpenProcessToken(GetCurrentProcess(), TOKEN_DUPLICATE|TOKEN_QUERY, &process_token); ok(ret, "OpenProcessToken failed with error %d\n", GetLastError()); + ret = DuplicateToken(process_token, SecurityImpersonation, &token); + ok(ret, "DuplicateToken failed with error %d\n", GetLastError()); + /* groups */ ret = GetTokenInformation(token, TokenGroups, NULL, 0, &size); ok(!ret && GetLastError() == ERROR_INSUFFICIENT_BUFFER, @@ -3244,10 +3247,19 @@ static void test_CheckTokenMembership(void) ret = pCheckTokenMembership(token, token_groups->Groups[i].Sid, &is_member); ok(ret, "CheckTokenMembership failed with error %d\n", GetLastError()); - ok(is_member, "CheckTokenMembership should have detected sid as member"); + ok(is_member, "CheckTokenMembership should have detected sid as member\n"); + + ret = pCheckTokenMembership(process_token, token_groups->Groups[i].Sid, &is_member); +todo_wine { + ok(!ret && GetLastError() == ERROR_NO_IMPERSONATION_TOKEN, + "CheckTokenMembership with process token %s with error %d\n", + ret ? "succeeded" : "failed", GetLastError()); + ok(!is_member, "CheckTokenMembership should have cleared is_member\n"); +} HeapFree(GetProcessHeap(), 0, token_groups); CloseHandle(token); + CloseHandle(process_token); } START_TEST(security) -- 2.11.4.GIT