From 712b33c171e1049f94a5cc5b48a5da1aa94bfadb Mon Sep 17 00:00:00 2001
From: Daniel Lehman <dlehman25@gmail.com>
Date: Wed, 15 Nov 2023 23:21:59 -0800
Subject: [PATCH] msxml4/tests: Add tests for default namespace.

---
 dlls/msxml4/tests/domdoc.c | 26 ++++++++++++++++++++++----
 1 file changed, 22 insertions(+), 4 deletions(-)

diff --git a/dlls/msxml4/tests/domdoc.c b/dlls/msxml4/tests/domdoc.c
index 1784804c0c6..530a481679f 100644
--- a/dlls/msxml4/tests/domdoc.c
+++ b/dlls/msxml4/tests/domdoc.c
@@ -67,6 +67,7 @@ static void test_namespaces_as_attributes(void)
         const WCHAR *uris[3];
         const WCHAR *texts[3];
         const WCHAR *xmls[3];
+        BOOL todo;
     };
     static const struct test tests[] =
     {
@@ -99,6 +100,17 @@ static void test_namespaces_as_attributes(void)
             { L"nshref" },              /* text */
             { L"xmlns:ns=\"nshref\"" }, /* xml */
         },
+        /* default namespace */
+        {
+            L"<a xmlns=\"nshref\" />", 1,
+            { L"xmlns" },               /* nodeName */
+            { L"xmlns" },               /* prefix */
+            { L"" },                    /* baseName */
+            { L"" },                    /* namespaceURI */
+            { L"nshref" },              /* text */
+            { L"xmlns=\"nshref\"" },    /* xml */
+            TRUE,                       /* todo */
+        },
         /* no properties or namespaces */
         {
             L"<a />", 0,
@@ -125,7 +137,7 @@ static void test_namespaces_as_attributes(void)
         ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
 
         node = NULL;
-        hr = IXMLDOMDocument2_selectSingleNode(doc, _bstr_(L"a"), &node);
+        hr = IXMLDOMDocument2_get_firstChild(doc, &node);
         ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
 
         hr = IXMLDOMNode_get_attributes(node, &map);
@@ -145,7 +157,9 @@ static void test_namespaces_as_attributes(void)
         {
             item = NULL;
             hr = IXMLDOMNamedNodeMap_get_item(map, i, &item);
+            todo_wine_if(test->todo)
             ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+            if (hr != S_OK) continue;
 
             str = NULL;
             hr = IXMLDOMNode_get_nodeName(item, &str);
@@ -157,8 +171,10 @@ static void test_namespaces_as_attributes(void)
             hr = IXMLDOMNode_get_prefix(item, &str);
             if (test->prefixes[i])
             {
-                ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
-                ok(!lstrcmpW(str, test->prefixes[i]), "got %s\n", wine_dbgstr_w(str));
+                /* MSXML4 can report different results with different service packs */
+                ok(hr == S_OK || broken(hr == S_FALSE), "Unexpected hr %#lx.\n", hr);
+                ok(!lstrcmpW(str, test->prefixes[i]) || broken(!str),
+                   "got %s\n", wine_dbgstr_w(str));
                 SysFreeString(str);
             }
             else
@@ -166,8 +182,10 @@ static void test_namespaces_as_attributes(void)
 
             str = NULL;
             hr = IXMLDOMNode_get_baseName(item, &str);
+            /* MSXML4 can report different results with different service packs */
             ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
-            ok(!lstrcmpW(str, test->basenames[i]), "got %s\n", wine_dbgstr_w(str));
+            ok(!lstrcmpW(str, test->basenames[i]) || broken(!lstrcmpW(str, L"xmlns")),
+                "got %s\n", wine_dbgstr_w(str));
             SysFreeString(str);
 
             str = NULL;
-- 
2.11.4.GIT