From 461ce6e4a28d1afb28a88861fa2143d0ac8919d0 Mon Sep 17 00:00:00 2001 From: Rob Shearman Date: Wed, 13 Feb 2008 12:35:13 +0000 Subject: [PATCH] ole32: Fix potential NULL dereference of qiresults in ClientIdentity_QueryMultipleInterfaces. This could happen if proxy_manager_get_remunknown returns S_FALSE, so fix the check of the return code to match that below. --- dlls/ole32/marshal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/ole32/marshal.c b/dlls/ole32/marshal.c index 32dadb1e308..dd292be3b3c 100644 --- a/dlls/ole32/marshal.c +++ b/dlls/ole32/marshal.c @@ -279,7 +279,7 @@ static HRESULT WINAPI ClientIdentity_QueryMultipleInterfaces(IMultiQI *iface, UL /* get IRemUnknown proxy so we can communicate with the remote object */ hr = proxy_manager_get_remunknown(This, &remunk); - if (hr == S_OK) + if (SUCCEEDED(hr)) { hr = IRemUnknown_RemQueryInterface(remunk, ipid, NORMALEXTREFS, nonlocal_mqis, iids, &qiresults); -- 2.11.4.GIT