From 2e32c0c6572a0da72164196715781940c38aa352 Mon Sep 17 00:00:00 2001 From: Marcus Meissner Date: Sun, 21 Aug 2016 20:38:18 +0200 Subject: [PATCH] winemenubuilder: Avoid double free (Coverity). Signed-off-by: Marcus Meissner Signed-off-by: Alexandre Julliard --- programs/winemenubuilder/winemenubuilder.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/programs/winemenubuilder/winemenubuilder.c b/programs/winemenubuilder/winemenubuilder.c index 2b7340fe995..e0c6ba2ecd5 100644 --- a/programs/winemenubuilder/winemenubuilder.c +++ b/programs/winemenubuilder/winemenubuilder.c @@ -1005,13 +1005,8 @@ static HRESULT write_native_icon(IStream *iconStream, ICONDIRENTRY *pIconDirEntr position.QuadPart = 0; hr = IStream_Seek(iconStream, position, STREAM_SEEK_SET, NULL); - if (FAILED(hr)) - goto end; - hr = convert_to_native_icon(iconStream, &nIndex, 1, &CLSID_WICPngEncoder, icon_name, szFileName); - -end: - HeapFree(GetProcessHeap(), 0, pIconDirEntry); - return hr; + if (FAILED(hr)) return hr; + return convert_to_native_icon(iconStream, &nIndex, 1, &CLSID_WICPngEncoder, icon_name, szFileName); } static WCHAR* assoc_query(ASSOCSTR assocStr, LPCWSTR name, LPCWSTR extra) -- 2.11.4.GIT