| commit | ea032bb7f8daddfe308f86f52c54db5f657b658a | |
| author | Gerald Pfeifer <gerald@pfeifer.com> | |
| Tue, 28 Jan 2020 21:40:25 +0000 (28 22:40 +0100) | ||
| committer | Alexandre Julliard <julliard@winehq.org> | |
| Wed, 29 Jan 2020 19:32:03 +0000 (29 20:32 +0100) | ||
| tree | 2471db74c0f64ab148f1443d7ff1b61e17cc3089 | treesnapshot (tar.gz zip) |
| parent | 23de061d2f8347d8131909bc137c9b4a536d58e9 | commitdiff |
msi: Properly declare variables in msi/tests/utils.h as extern.
Omitting the extern storage qualifier when declaring a global variable in
a header file is mistake. If that header is included by several files it
results in multiple definitions of the same variable (unless -fcommon is
specified or assumed, the latter being the case for GCC 9.x and earlier).
This fixes building with GCC 10.
Signed-off-by: Gerald Pfeifer <gerald@pfeifer.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
Omitting the extern storage qualifier when declaring a global variable in
a header file is mistake. If that header is included by several files it
results in multiple definitions of the same variable (unless -fcommon is
specified or assumed, the latter being the case for GCC 9.x and earlier).
This fixes building with GCC 10.
Signed-off-by: Gerald Pfeifer <gerald@pfeifer.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
| dlls/msi/tests/utils.h | diffblobblamehistory |