winecrt0: Remove free_delay_imports.
commitb5d3759fc5852f083632792d6213f54151a6467a
authorKevin Puetz <PuetzKevinA@JohnDeere.com>
Wed, 31 Aug 2022 14:53:17 +0000 (31 09:53 -0500)
committerAlexandre Julliard <julliard@winehq.org>
Wed, 31 Aug 2022 16:32:13 +0000 (31 18:32 +0200)
tree0ff1f4c2eead536356c0bd873b044f2c7ad792d6
parentaeb97373882b2d2e830158392b12f1382cbd5aeb
winecrt0: Remove free_delay_imports.

MSVC's delayimp.lib does not actually free delayload dependencies.
winecrt0's attempt to do so from ELF __attribute__((destructor))
is unnecessary and potentially harmful:

- When triggered naturally via LdrUnloadDll, this leads to recursive calls
  to FreeLibrary, violating free_lib_count and missing DLL_PROCESS_DETACH
- when triggered by glibc's _dl_fini (at process exit), it leads to
  use-after-free of the TEB (GetCurrentThreadID after the main thread is no longer Win32)
  via  FreeLibrary -> LdrLdrUnloadDll -> RtlEnterCriticalSection( &loader_section )
- double-free of the library itself, since the DLL_PROCESS_DETACH has
  already been handled by LdrShutdownProcess
- Race against wineserver sending a SIGKILL from process_killed,
  since all Win32 threads of the process have exited

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53032
dlls/winecrt0/delay_load.c