| commit | 72c0c88f2a5c9b52bb01f7981c0894a47efa55f3 | |
| author | Jinoh Kang <jinoh.kang.kr@gmail.com> | |
| Sat, 22 Oct 2022 12:25:37 +0000 (22 21:25 +0900) | ||
| committer | Alexandre Julliard <julliard@winehq.org> | |
| Mon, 24 Oct 2022 09:17:39 +0000 (24 11:17 +0200) | ||
| tree | 443abe0762b4f7325c31468f4d5b5465a93a917c | treesnapshot (tar.gz zip) |
| parent | 7abca9742a9410447636e0222e36d214449c90dd | commitdiff |
gdiplus: Replace GpImage's busy flag with SRWLOCK.
Today, the image_unlock() helper function has a data race due to
non-atomic write to GpImage's 'busy' flag which is accessible by other
threads. Also, it lacks a release fence, which means that other threads
can observe the unlocked (busy = 0) state too early when the current
thread unlocks the image; specifically, the write to the 'busy' field of
the GpImage can be reordered before the last read/write to any other
fields of the same GpImage.
Fix this by replacing the 'busy' field of GpImage with SRWLOCK.
Today, the image_unlock() helper function has a data race due to
non-atomic write to GpImage's 'busy' flag which is accessible by other
threads. Also, it lacks a release fence, which means that other threads
can observe the unlocked (busy = 0) state too early when the current
thread unlocks the image; specifically, the write to the 'busy' field of
the GpImage can be reordered before the last read/write to any other
fields of the same GpImage.
Fix this by replacing the 'busy' field of GpImage with SRWLOCK.
| dlls/gdiplus/gdiplus_private.h | diffblobblamehistory | |
| dlls/gdiplus/image.c | diffblobblamehistory |