| commit | b0fb75ad5c8ca205396d7a493c9be5a5da802747 | |
| author | Dan Carpenter <error27@gmail.com> | |
| Fri, 14 May 2010 14:48:28 +0000 (14 16:48 +0200) | ||
| committer | Takashi Iwai <tiwai@suse.de> | |
| Mon, 17 May 2010 06:09:51 +0000 (17 08:09 +0200) | ||
| tree | 11c6eaf8454e4755cc5b7a4f49becdb97af672d9 | treesnapshot (tar.gz zip) |
| parent | 89485d4931769d40353ea49bff1596accff8f06e | commitdiff |
ALSA: es1688: add pedantic range checks
Smatch complains that if (dev == SNDRV_CARDS) we're one past the end of
the array. That's unlikely to happen in real life, I suppose.
Also smatch complains about "strcpy(card->shortname, pcm->name);"
The "pcm->name" buffer is 80 characters and "card->shortname" is 32
characters. If you follow the call paths it turns out we never actually
use more than 16 characters so it's not a problem. But anyway, let's
make it easy for people auditing this in the future.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Smatch complains that if (dev == SNDRV_CARDS) we're one past the end of
the array. That's unlikely to happen in real life, I suppose.
Also smatch complains about "strcpy(card->shortname, pcm->name);"
The "pcm->name" buffer is 80 characters and "card->shortname" is 32
characters. If you follow the call paths it turns out we never actually
use more than 16 characters so it's not a problem. But anyway, let's
make it easy for people auditing this in the future.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
| sound/isa/es1688/es1688.c | diffblobblamehistory |