| commit | 86e4754ac8fde9a9c913571016bc31257aa2e195 | |
| author | Julia Lawall <julia@diku.dk> | |
| Mon, 29 Mar 2010 05:34:46 +0000 (29 05:34 +0000) | ||
| committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | |
| Wed, 7 Apr 2010 08:00:44 +0000 (7 18:00 +1000) | ||
| tree | c96a3df8769e488a6a03e40c330e9cacc872045a | treesnapshot (tar.gz zip) |
| parent | f6d8c8bb1d360272d795927d39f3d2c5934e77d9 | commitdiff |
powerpc/pmac: Add missing unlocks in error path
In some error handling cases the lock is not unlocked.
A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r exists@
expression E1;
identifier f;
@@
f (...) { <+...
* spin_lock_irqsave (E1,...);
... when != E1
* return ...;
...+> }
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
In some error handling cases the lock is not unlocked.
A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r exists@
expression E1;
identifier f;
@@
f (...) { <+...
* spin_lock_irqsave (E1,...);
... when != E1
* return ...;
...+> }
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
| drivers/macintosh/macio-adb.c | diffblobblamehistory | |
| drivers/macintosh/smu.c | diffblobblamehistory |