| commit | 7f14daa19ea36b200d237ad3ac5826ae25360461 | |
| author | Petr Vandrovec <petr@vandrovec.name> | |
| Fri, 13 Oct 2006 02:13:16 +0000 (13 04:13 +0200) | ||
| committer | Linus Torvalds <torvalds@g5.osdl.org> | |
| Fri, 13 Oct 2006 15:13:34 +0000 (13 08:13 -0700) | ||
| tree | a123fefbb13871de2bc30fff49a4418b48a38732 | treesnapshot (tar.gz zip) |
| parent | 12e36b2f41b6cbc67386fcb9c59c32a3e2033905 | commitdiff |
[PATCH] Get core dump code to work...
The file based core dump code was broken by pipe changes - a relative
llseek returns the absolute file position on success, not the relative
one, so dump_seek() always failed when invoked with non-zero current
position.
Only success/failure can be tested with relative lseek, we have to trust
kernel that on success we've got right file offset. With this fix in
place I have finally real core files instead of 1KB fragments...
Signed-off-by: Petr Vandrovec <petr@vandrovec.name>
[ Cleaned it up a bit while here - use SEEK_CUR instead of hardcoding 1 ]
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
The file based core dump code was broken by pipe changes - a relative
llseek returns the absolute file position on success, not the relative
one, so dump_seek() always failed when invoked with non-zero current
position.
Only success/failure can be tested with relative lseek, we have to trust
kernel that on success we've got right file offset. With this fix in
place I have finally real core files instead of 1KB fragments...
Signed-off-by: Petr Vandrovec <petr@vandrovec.name>
[ Cleaned it up a bit while here - use SEEK_CUR instead of hardcoding 1 ]
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| fs/binfmt_elf.c | diffblobblamehistory |