TCP: Fix TCP handling of SACK in bidirectional flows
commit3198d0f16dec0c87071cf26f3f11af9c8f0a009b
authorIlpo Järvinen <ilpo.jarvinen@helsinki.fi>
Thu, 30 Aug 2007 04:21:05 +0000 (30 06:21 +0200)
committerAdrian Bunk <bunk@stusta.de>
Mon, 24 Sep 2007 21:02:47 +0000 (24 23:02 +0200)
tree4fe6063703d512c44d18e8700d55c6cb5a7ffe0c
parent725ad2a8f1358bff885414f5e91d253c99921ddc
TCP: Fix TCP handling of SACK in bidirectional flows

It's possible that new SACK blocks that should trigger new LOST
markings arrive with new data (which previously made is_dupack
false). In addition, I think this fixes a case where we get
a cumulative ACK with enough SACK blocks to trigger the fast
recovery (is_dupack would be false there too).

I'm not completely pleased with this solution because readability
of the code is somewhat questionable as 'is_dupack' in SACK case
is no longer about dupacks only but would mean something like
'lost_marker_work_todo' too... But because of Eifel stuff done
in CA_Recovery, the FLAG_DATA_SACKED check cannot be placed to
the if statement which seems attractive solution. Nevertheless,
I didn't like adding another variable just for that either... :-)

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Adrian Bunk <bunk@kernel.org>
net/ipv4/tcp_input.c