netfilter: h323: bug in parsing of ASN1 SEQOF field
commit2db1ad7f3cd1f9f08c92d06f832529267043f21c
authorDavid Sterba <dsterba@suse.cz>
Mon, 4 Apr 2011 13:21:02 +0000 (4 15:21 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 14 Apr 2011 23:53:08 +0000 (14 16:53 -0700)
tree360d00f0b38c1aea56ecb30e561cb903bf85fda5
parentf4f0cb8d0e023a274834aed9430a520de10bacbf
netfilter: h323: bug in parsing of ASN1 SEQOF field

commit b4232a22776aa5d063f890d21ca69870dbbe431b upstream.

Static analyzer of clang found a dead store which appears to be a bug in
reading count of items in SEQOF field, only the lower byte of word is
stored. This may lead to corrupted read and communication shutdown.

The bug has been in the module since it's first inclusion into linux
kernel.

[Patrick: the bug is real, but without practical consequence since the
 largest amount of sequence-of members we parse is 30.]

Signed-off-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/netfilter/nf_conntrack_h323_asn1.c