From 085ebbd3934e4475b6c437b4155e669d247b2bdf Mon Sep 17 00:00:00 2001
From: Thomas Zander <Thomas.Zander@Trolltech.com>
Date: Thu, 1 May 2008 00:57:55 +0200
Subject: [PATCH] Proper reporting on changes with unparsable args

---
 Changes.cpp | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/Changes.cpp b/Changes.cpp
index 93c40a5..e8c4d2d 100644
--- a/Changes.cpp
+++ b/Changes.cpp
@@ -101,15 +101,21 @@ AbstractCommand::ReturnCodes Changes::run()
 
     // now we have to use the rest of the arguments the user passed.
     int index = 0;
+    QStringList unknownArguments;
     foreach (QString arg, args->arguments()) {
-        if (! usedArguments.contains(index++))
+        if (! usedArguments.contains(index++)) {
             arguments << arg;
+            unknownArguments << arg;
+        }
     }
 
     GitRunner runner(git, arguments);
     ReturnCodes rc = runner.start(GitRunner::WaitForStandardOutput);
     if (rc) {
-        // TODO proper reporting
+        Logger::error() << "Vng failed: Unknown branch or revision: ";
+        foreach(QString arg, unknownArguments)
+           Logger::error() <<  "`" << arg << "' ";;
+       Logger::error() <<  endl;
         return rc;
     }
     if (shouldUsePager())
-- 
2.11.4.GIT