| commit | 0484db2cb1906908d510d1dca49da0de46e88309 | |
| author | Erwan Tulou <erwan10@videolan.org> | |
| Thu, 6 May 2010 18:09:25 +0000 (6 20:09 +0200) | ||
| committer | Jean-Baptiste Kempf <jb@videolan.org> | |
| Sun, 9 May 2010 21:37:11 +0000 (9 23:37 +0200) | ||
| tree | 60fa9c798268ea1775bcbc9573678a687bf13d3d | treesnapshot (tar.gz zip) |
| parent | 6788907a9e48575c2a5412dc96e20c4f873551be | commitdiff |
skins2: fix skins crashing when playlist is flat
m_firstPos (iterator associated to a stl list container) is not guaranteed to be valid (the associated item may have been deleted). Up to vlc1.0, this was no problem, because deleting an item was also buggy (a no-op). From vlc1.1 on, m_firstPos must now be recomputed to ensure it keeps on pointing to a valid item in all cases.
start for instance a playlist with the 'Dragon' skin as a test case.
This was pointed out by colt45 (from the forum)
(cherry picked from commit 1ef175cb28927f1ad01acabaf6e09936c451dc60)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
m_firstPos (iterator associated to a stl list container) is not guaranteed to be valid (the associated item may have been deleted). Up to vlc1.0, this was no problem, because deleting an item was also buggy (a no-op). From vlc1.1 on, m_firstPos must now be recomputed to ensure it keeps on pointing to a valid item in all cases.
start for instance a playlist with the 'Dragon' skin as a test case.
This was pointed out by colt45 (from the forum)
(cherry picked from commit 1ef175cb28927f1ad01acabaf6e09936c451dc60)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
| modules/gui/skins2/controls/ctrl_tree.cpp | diffblobblamehistory |