From d8519941343e02688431fb296e1bfe0843e7e3ef Mon Sep 17 00:00:00 2001 From: Steve Lhomme Date: Tue, 1 Aug 2017 10:25:43 +0200 Subject: [PATCH] dxva2_deinterlace: fix potential double free when there are errors Signed-off-by: Jean-Baptiste Kempf --- modules/video_output/win32/dxva2_deinterlace.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/modules/video_output/win32/dxva2_deinterlace.c b/modules/video_output/win32/dxva2_deinterlace.c index f516e16042..1d5b301e19 100644 --- a/modules/video_output/win32/dxva2_deinterlace.c +++ b/modules/video_output/win32/dxva2_deinterlace.c @@ -351,10 +351,6 @@ static int Open(vlc_object_t *obj) if (FAILED(hr)) goto error; - CoTaskMemFree(processorGUIDs); - picture_Release(dst); - IDirectXVideoProcessorService_Release(processor); - sys->hdecoder_dll = hdecoder_dll; sys->d3d9_dll = d3d9_dll; sys->decoder_caps = best_caps; @@ -378,6 +374,10 @@ static int Open(vlc_object_t *obj) goto error; } + CoTaskMemFree(processorGUIDs); + IDirectXVideoProcessorService_Release(processor); + picture_Release(dst); + filter->fmt_out.video = out_fmt; filter->pf_video_filter = Deinterlace; filter->pf_flush = Flush; -- 2.11.4.GIT