From 8cc427c799140d71c761d1b29727dd2cf73e62ed Mon Sep 17 00:00:00 2001 From: =?utf8?q?Filip=20Ros=C3=A9en?= Date: Tue, 7 Feb 2017 02:35:46 +0100 Subject: [PATCH] packetizer/h264: fix resource deallocation during Close The previous loop condition suffers from an off-by-one error, meaning that the last resource in p_sys->pp_sps and p_sys->pp_pps would never be released if populated. fixes #17987 Signed-off-by: Jean-Baptiste Kempf --- modules/packetizer/h264.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/packetizer/h264.c b/modules/packetizer/h264.c index 1b455af479..4d2db65f76 100644 --- a/modules/packetizer/h264.c +++ b/modules/packetizer/h264.c @@ -330,12 +330,12 @@ static void Close( vlc_object_t *p_this ) if( p_sys->p_frame ) block_ChainRelease( p_sys->p_frame ); - for( i = 0; i < H264_SPS_ID_MAX; i++ ) + for( i = 0; i <= H264_SPS_ID_MAX; i++ ) { if( p_sys->pp_sps[i] ) block_Release( p_sys->pp_sps[i] ); } - for( i = 0; i < H264_PPS_ID_MAX; i++ ) + for( i = 0; i <= H264_PPS_ID_MAX; i++ ) { if( p_sys->pp_pps[i] ) block_Release( p_sys->pp_pps[i] ); -- 2.11.4.GIT