input: remove input_LegacyVarStop
commit4e2718218848e689aa41d13822cd3b0b5ab67c4f
authorThomas Guillem <thomas@gllm.fr>
Thu, 12 Jul 2018 16:27:33 +0000 (12 18:27 +0200)
committerThomas Guillem <thomas@gllm.fr>
Thu, 12 Jul 2018 16:48:44 +0000 (12 18:48 +0200)
treeb652172cd64013326a3f8001f2c4541e94b858ee
parent1e82322d41bb1439a127db5842abd6bf50675ae8
input: remove input_LegacyVarStop

This code path is way too racy (even before
2ef7696e96f5c55a4801335820c79df7f1a52fd0): input_priv(p_input)->i_title is not
protected and the variables were not cleaned if i_title changed from 1 to 0.

This function was useless anyway since it was always called before
input_Close() that destroyed the input thread object and all variables /
callbacks.
include/vlc_input.h
lib/media_player.c
modules/services_discovery/podcast.c
src/input/var.c
src/input/vlm.c
src/libvlccore.sym
src/playlist/thread.c