| commit | 4c75da934016f67a9bc6334e67959b3615ee6c6d | |
| author | Lyndon Brown <jnqnfe@gmail.com> | |
| Sat, 5 Sep 2020 18:10:53 +0000 (5 19:10 +0100) | ||
| committer | Pierre Lamot <pierre@videolabs.io> | |
| Fri, 25 Sep 2020 07:13:13 +0000 (25 09:13 +0200) | ||
| tree | e205c3efcd51596318be929d7b1316bfa8121204 | treesnapshot (tar.gz zip) |
| parent | 609bd6453d0f03b1e923b4afeb550c570b52f800 | commitdiff |
qt: fix incorrect param type
which was causing a whole bunch of "'< 0' is always false" warnings.
review of the original fix ([1]) indicated that in fact the parameter was
wrong rather than the checks within the function being out of step with
the final design of the function interface, since apparently callers
are in fact passing in a signed index, where a negative represents an
invalid index which the function is expected to handle appropriately.
[1]: https://mailman.videolan.org/pipermail/vlc-devel/2020-September/137711.html
Co-authored-by: Pierre Lamot <pierre@videolabs.io>
Signed-off-by: Pierre Lamot <pierre@videolabs.io>
which was causing a whole bunch of "'< 0' is always false" warnings.
review of the original fix ([1]) indicated that in fact the parameter was
wrong rather than the checks within the function being out of step with
the final design of the function interface, since apparently callers
are in fact passing in a signed index, where a negative represents an
invalid index which the function is expected to handle appropriately.
[1]: https://mailman.videolan.org/pipermail/vlc-devel/2020-September/137711.html
Co-authored-by: Pierre Lamot <pierre@videolabs.io>
Signed-off-by: Pierre Lamot <pierre@videolabs.io>