Do not expose the volume paths to the clients

VDSM should not expose such a low level information to the clients.

Change-Id: Ieea2caa1acda090793b70e8c2610e10135a9ec44

Do not lock the image when preparing the VM path

Since the resource manager scope is local there is no need for a VM
to take an exclusive lock on the images: in fact the SPM running on
an other machine could still manipulate such images.

Change-Id: I4b5cb55a868cb9bf5a720610273af139ee858a1a

Avoid to activate parent volume on cloning

The benefit is that we can now create new snapshot volumes without
looking at the parent. This is indispensable for live snapshots since
the parent volume is in use by the VM.

In this patch:
* Do not activate the parent volume on cloning (it could be in use
  by the VM), the only information needed is the size and it can be
  provided as additional parameter in qemu-img
* Do not change the volume permission to read-only when setting the
  parent to "internal" (it could be in use by the VM)

Change-Id: I8a7d488da5ab0c27fc2e083976d4bc44e6f810e3

Naming conventions in Image._baseRawVolumeMerge temp files changed.

This change is required for succesful recovery of interrrupted
merge flows.
After a failed merger of volUUID, no future merges of it can take
place until the _MERGE volume is removed.
This is intentional in order to protect user data.

Change-Id: Ic4263f649e1936fcc1ccb7d5c094e9894f02fcd4
Reviewed-on: http://gerrit.ovirt.org/445
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Remove unnecessary produces from Image.merge() auxiliary functions.

Change-Id: I257bcededb50105496087d3547d95a8b2f14f7b3
Reviewed-on: http://gerrit.ovirt.org/444
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Image.getSubChain: avoid unnecessary productions of all kinds.

Change-Id: I83cf010cf54d34fd1ca7406c508503fcc3e72e0a
Reviewed-on: http://gerrit.ovirt.org/443
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Produce the SD in FileVolume.getAllChildrenList() once

Change-Id: I732b5c67d605bbf394e05b67a3c8b80336dd3871
Reviewed-on: http://gerrit.ovirt.org/442
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Split deletedVolumeName functionality

Change-Id: Icbf24988a4367fa806f4c4c41519314daf0f6dab
Reviewed-on: http://gerrit.ovirt.org/441
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

vdsm.spec.in: Requires: tree

vdsm-sosplugin.py requires the /usr/bin/tree command.

Change-Id: Ifed7b5beab38241bb9d1c6b046784307e89e2134
Reviewed-on: http://gerrit.ovirt.org/555
Tested-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>

storage/misc.py: Add validation to oVirt Node

Check if /etc/ovirt-node-image-release exists too

Change-Id: Ie35f84712b9165428506798d534fdce8ed2c01af
Reviewed-on: http://gerrit.ovirt.org/453
Tested-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>

Set drive's name during Drive initialization

Change-Id: I2b3d93ddb8fbf81ff98e90ab96fc9a16bac94644
Reviewed-on: http://gerrit.ovirt.org/408
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

caps.py: include oVirt Node to OSName

Add oVirt Node as a supported

Change-Id: I8e59867abaf4cd6e9f142356b05fca15992ae300
Reviewed-on: http://gerrit.ovirt.org/454
Tested-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>

deployUtil: isOvirt() check oVirt release

Adding support to isOvirt() to validate oVirt Node

Change-Id: I5ada58298552a316f71ed2b99b1fbced48ceee67
Reviewed-on: http://gerrit.ovirt.org/452
Tested-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>

InvalidParameterException() takes two args

Change-Id: Id725f20ecf2836ab73bb8ae28ed0550574365fe7
Reviewed-on: http://gerrit.ovirt.org/432
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

BZ#754445 - Separate granting from callback emitting

Granting has to happen inside the request transaction to prevent races
with cancel\timeouts. The callback is code that the subsystem does not
know anything about. For that reason it is crucial to run the callback
outside of the lock scope. To keep both demands I split up emit() from
grant().

Change-Id: Ic12d170e64399e37a555960c03804778ad7d053b
Reviewed-on: http://gerrit.ovirt.org/254
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

deployUtil.py.in:  add support to restart vdsmd

vdsm-complete script define reboot() which uses deployUtil.setService("vdsmd", "restart")
However, deployUtil.setService() just execute the validation for initd
script (/etc/init.d/vdsmd), if the distro doesn't contain this file it fails
and do not execute the restart action.

Since vdsm.spec specify that if it's not RHEL we should use systemd,
this patch includes the validation for systemd vdsmd service.

Change-Id: I7c9d6e1aefa93e9fff067bf1153c0f555d247c64
Reviewed-on: http://gerrit.ovirt.org/492
Tested-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>

BZ#745510 Additional rpm fixes required by fedora

In this patch:
* Use a standard name for the polkit macro
* The _unitdir macro requires the systemd-units package
* Do not ship the vdsm configuration file on rhel
* Update the project URL
* Fix typo: bootstrap

Change-Id: I7bfeddd1558d391762425ad07ecd3942b802f6c0
Reviewed-on: http://gerrit.ovirt.org/467
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Add Shahar to AUTHORS

Change-Id: I78887ec98e6a1fcc8af1cdcda1eadcc646641380
Reviewed-on: http://gerrit.ovirt.org/477
Reviewed-by: Igor Lvovsky <ilvovsky@redhat.com>
Tested-by: Shahar Havivi <shavivi@redhat.com>
Reviewed-by: Shahar Havivi <shavivi@redhat.com>

Remove checkImage

This API function is unused and is based on buggy functions with outdated semantics.

Change-Id: I691cbc8e92b048a0c803851596f9579ded2b1e4e
Reviewed-on: http://gerrit.ovirt.org/426
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Remove checkDomain().

This API function is unused and is based on buggy functions with outdated semantics.

Change-Id: Ie063eb81dfdae630d6d47dc6fcea90b055b5bae6
Reviewed-on: http://gerrit.ovirt.org/425
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

The configuration values must be strings

The configuration values must be strings to avoid errors such as:

  TypeError: argument of type 'int' is not iterable
  (ConfigParser.py:586)

Apparently the value for vm_sample_disk_latency_interval was the only
one not respecting this rule.

Change-Id: Id51af12b809906848f9dfbde17c42ce56b887772
Reviewed-on: http://gerrit.ovirt.org/459
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Reviewed-by: Igor Lvovsky <ilvovsky@redhat.com>
Tested-by: Igor Lvovsky <ilvovsky@redhat.com>

BZ#745510 Fedora rpmlint fixes

In this patch:
* Remove shebang from the non-script python files
* Require iscsi-initiator-utils >= 6.2.0.872-14 (BZ#442980)
* Move the lvm rules to the appropriate path
* Use the %ghost keyword for the /var/run paths
* vdsm-libvirt-logrotate doesn't need to be executable
* Require only the saslpasswd2 binary instead of the sasl package

Change-Id: Id619ee8bb200df7cf460a869e2dac7702cf436dd
Reviewed-on: http://gerrit.ovirt.org/261
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Revise the release versioning

In this patch:
* revise the release versioning according to fedora guidelines

Change-Id: I1f7b267a3ea9f415219fec0d45d4e4dad8eadb70
Reviewed-on: http://gerrit.ovirt.org/218
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Clean up the config.py format

Change-Id: I8408613487ee5f4a5cd6e79c83fc7178a869abb5
Reviewed-on: http://gerrit.ovirt.org/294
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Substitute the vdsm paths directly in config.py

Change-Id: Ib4e63b13266daa9be3b37c7b648b57210d853cf1
Reviewed-on: http://gerrit.ovirt.org/293
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Simplify the vdsm.conf.sample generation

Change-Id: I2aeab057d45b81e0ff5bbd919f98be2b732982c5
Reviewed-on: http://gerrit.ovirt.org/292
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Add PolicyKit support to access libvirt

The best approach upstream is installing vdsm limiting the changes of
the system settings.
The PolicyKit authentication (chosen by default by libvirt) is allowing
us to manage the vm's without setting up a password.

Change-Id: Ia781accc36d9d9a8e6b49099dc5126aa557831a3
Reviewed-on: http://gerrit.ovirt.org/322
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

BZ#756693 Handle destroyed VMs in handleStatsException

After issuing a shutdown/detroy command to a VM, VDSM should expect it
to disappear and not report an error.

Change-Id: I0c1a9abe69c61702ff21f41ce60079998b02d165
Reviewed-on: http://gerrit.ovirt.org/392
Tested-by: Haim Ateya <hateya@redhat.com>
Reviewed-by: Igor Lvovsky <ilvovsky@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>

Adding hooks to VDSM

New custom hooks:
directlun, fileinject, hugepages qos, smartcard,
floppy, isolatedprivatevlan, pincpu, smbios, hostusb, numa,
promisc, scratchpad, sriov, vmdisk

Change-Id: I6f36456a1d9907a96e82790e7b73a24bd640b78f
Reviewed-on: http://gerrit.ovirt.org/366
Tested-by: Shahar Havivi <shavivi@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>

Use the vdsm user and group macro consistently

Change-Id: Id12c093cdc01ab3dbfac36eaf1ab18f48ff5b5a8
Reviewed-on: http://gerrit.ovirt.org/386
Reviewed-by: Saggi Mizrahi <smizrahi@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

BZ#756686 - Avoid looking for suddenly disappeared VMs.

Change-Id: I6a29cfb60c68fcc81aaf56ddec107f3a9e1fdb20
Reviewed-on: http://gerrit.ovirt.org/383
Tested-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Haim Ateya <hateya@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>

Remove checkPool.

Change-Id: I2aaed1fa0d273491a6503f9be3d821a9c47c2a9b
Reviewed-on: http://gerrit.ovirt.org/424
Reviewed-by: Saggi Mizrahi <smizrahi@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Add an initial systemd service file for vdsm-reg

Change-Id: I7b93375bc780ad9304ef5184746a568b066a564c
Reviewed-on: http://gerrit.ovirt.org/321
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Add an initial systemd service file for vdsmd

Change-Id: I839e23126c7cd9814fd8ebdd18aa9067649915d4
Reviewed-on: http://gerrit.ovirt.org/262
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Fix distcheck and gitignore for vdsm-faqemu

Change-Id: I649fb189c22b5b80a74b2439226a7e7ecef8d993
Reviewed-on: http://gerrit.ovirt.org/391
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

fix faqemu for fedora host

Instead of hacking qemu-kvm under libvirt, use libvirt's domxml <emulator> tag.

Change-Id: I8efc37c9dd63b482a7791f64e27fd864f303d4c0
Reviewed-on: http://gerrit.ovirt.org/324
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Do not attempt to configure the iscsid service

Using an old rhel6 iscsid.conf file to overwrite any upstream system
configuration is not recommended.
According to BZ#499222 we just needed to set the node.startup parameter
to "manual". That can be accomplished using:

 # iscsiadm -m node -p <ip:port> [-I <iqn>] \
            -o update -n node.startup -v manual

Change-Id: I2dc0cc114fcc660d8b6b35e6654dfb2592eeb000
Reviewed-on: http://gerrit.ovirt.org/305
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Related to BZ#755596 - Minor Image.merge() cleanup.

Change-Id: Ieceb5819575e980e647a819d5ca1b6f42e27752f
Reviewed-on: http://gerrit.ovirt.org/316
Reviewed-by: Igor Lvovsky <ilvovsky@redhat.com>
Tested-by: Rami Vaknin <rvaknin.redhat.com@gmail.com>

Related to BZ#755596 - Remove unused Task.removeRecovery()

This function is unused and does not write to the disk.

Change-Id: Iad55ed6353a2536163ec1170f4129144760b6369
Reviewed-on: http://gerrit.ovirt.org/315
Reviewed-by: Igor Lvovsky <ilvovsky@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Related BZ#755596 - Remove illegal volume marking rollback.

Change-Id: I335511836ffc3962a8b3d3a02b3debf52a98b0ec
Reviewed-on: http://gerrit.ovirt.org/317
Reviewed-by: Igor Lvovsky <ilvovsky@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

BZ#755596 - Persist clearRecoveries().

Change-Id: I4c0a52da9e6065ae7a361be1a45caa1d0d9fde3f
Reviewed-on: http://gerrit.ovirt.org/303
Reviewed-by: Igor Lvovsky <ilvovsky@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Use the defined constants in iscsi.py

Change-Id: I3f2b9f8f846729bd62bbd17660ff1a197b311956
Reviewed-on: http://gerrit.ovirt.org/354
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Reviewed-by: Igor Lvovsky <ilvovsky@redhat.com>
Tested-by: Federico Simoncelli <fsimonce@redhat.com>

Use the nodiscard option at mkfs time

Change the mkfs option according to the warning message:

 $ mkfs -q -j -K <dev>
 Warning: -K option is deprecated and should not be used anymore.
          Use '-E nodiscard' extended option instead!

Change-Id: I5621bd39e17ecb43b7dd7fb1255c7cd914fd4083
Reviewed-on: http://gerrit.ovirt.org/337
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Use exception from libvirt and not from libvirtvm

Change-Id: I16db730519a76bda7a86fd4c2217cb44073974c7
Reviewed-on: http://gerrit.ovirt.org/353
Tested-by: Dan Kenigsberg <danken@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>

Fix error message in StoragePool.connect

String formatting has precedence over concatenation:

 File "/usr/share/vdsm/storage/sp.py", line 681, in connect
   (hostID, self.spUUID, self._poolsTmpDir))
 TypeError: not all arguments converted during string formatting

Removing the addition and continuing the string on a new line fixes
the problem.

Change-Id: I49579fdb673da57a47cc2fd8a76d0bf72b06bb0e
Reviewed-on: http://gerrit.ovirt.org/356
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Make /var/lib/vdsm read and write, otherwise it will break vdsm_reg.

Error message during oVirt node installation:

MainThread::DEBUG::2011-11-17
11:00:57,778::deployUtil::853::root::makeBridge Failed to del existing
bridge. out= err=INFO:root:Removing bridge breth0 with vlan=None,
bonding=None, nics=['eth0']. options={'nics': ['eth0'], 'bonding': '',
'vlan': ''}
WARNING:root:
Traceback (most recent call last):
File "/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main
File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code
File "/usr/share/vdsm/configNetwork.py", line 900, in <module>
File "/usr/share/vdsm/configNetwork.py", line 875, in main
File "/usr/share/vdsm/configNetwork.py", line 555, in delNetwork
File "/usr/share/vdsm/configNetwork.py", line 277, in removeNic
File "/usr/share/vdsm/configNetwork.py", line 153, in _backup
File "/usr/share/vdsm/configNetwork.py", line 200, in _persistentBackup
OSError: [Errno 30] Read-only file system: '/var/lib/vdsm/netconfback/

Change-Id: Ibbfd6eed420e4892263d924700b781e1a471e264
Reviewed-on: http://gerrit.ovirt.org/301
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Reviewed-by: Douglas Schilling Landgraf <dougsland@redhat.com>

vm.py: drop never-used Driver.bus

Change-Id: I56aa3c22ff60c0231e8cb2053d6a02b251824b01
Reviewed-on: http://gerrit.ovirt.org/302
Reviewed-by: Igor Lvovsky <ilvovsky@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

BZ#753625 honor displayNetwork again

added libvirt-network support for add/del network,
and on vdsm startup add libvirt-network to each local
network

Change-Id: Ia403496b2df9800ad027b0bab48f4eed4e75c2de
Reviewed-on: http://gerrit.ovirt.org/255
Tested-by: Shahar Havivi <shavivi@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>

Avoid unnecesary produce-invalidate-produce on SD conf changes.

Change-Id: If5165b92974145bcd26ca50648a65a6bfe282eb6
Reviewed-on: http://gerrit.ovirt.org/213
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Fix: HSM should not write metadata (*BlkSize)

Change-Id: I96fdbc69071d014c7443abce61f7601ea593a378
Reviewed-on: http://gerrit.ovirt.org/201
Reviewed-by: Federico Simoncelli <fsimonce@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Fix StoragePool.extendSD definition

Change-Id: I88990efe2892cac3651fe849399db7a4aab1f18f
Reviewed-on: http://gerrit.ovirt.org/204
Reviewed-by: Igor Lvovsky <ilvovsky@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

spec: require xz explicitly

Our logrotate configurations explicitly state xz crompression. It would
be more polite for the spec to state that, and not rely on libvirt's xz
requirement.

Change-Id: Id22fd6e4fc61b6ca18f5d17afa5c3d27c0837ee0
Reviewed-on: http://gerrit.ovirt.org/258
Tested-by: Doron Fediuck <dfediuck@redhat.com>
Reviewed-by: Doron Fediuck <dfediuck@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>

BZ#737340 Use the new migrateToURI2 API

Change-Id: Ia8a65bab6bfa2415ed8255915b084f1205f61bce
Reviewed-on: http://gerrit.ovirt.org/205
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

BZ#754054 bootstrap: report success first, reboot later

v2: flush stdout before reboot

Change-Id: I6c0a7329f64f6b7c5110b250dc6715fd1ce6a7c6
Reviewed-on: http://gerrit.ovirt.org/232
Tested-by: Haim Ateya <hateya@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>

Strip the trailing newline from libvirt password

In this patch:
* read only the first line of the file containing the libvirt password
* strip the trailing newline

Change-Id: Ib2e5fe67384e15dd96b45b9ff890ecdd9ed4233e
Reviewed-on: http://gerrit.ovirt.org/216
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Adding shared raw disk feature.

Arbitrary disks can be added as local VM drives.
Use
drive=GUID:<guid>,
or
drive=UUID:<uuid>,
Note the mandatory ','

Change-Id: Ib417bd6423773db382826d6255e8cbeafd333116
Reviewed-on: http://gerrit.ovirt.org/212
Tested-by: Dan Kenigsberg <danken@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>

BZ#745510 Fedora RPM revisions

In this patch:
* use %global instead of %define
* use Requires instead of Conflicts for selinux-policy-targeted
* do not modify the sudoers file (we should not try to override
  a sysadmin custom configuration or misconfiguration)
* fix a build warning for deployUtil.py
* fix the libvirt_password path when uninstalling

Change-Id: I67e25b5dcbb63b49e9470f2b5736e0eec8a4742a
Reviewed-on: http://gerrit.ovirt.org/210
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Generalize _parseDriveSpec dictionaries.

parseDriveSpec() accepts now any keys.
Capable of manage only one key:value, pair as drive= parameter.
The comma is required for dicts, for one key:value too.

Change-Id: I24350c099a92923323a221c909c53855a2906ece
Reviewed-on: http://gerrit.ovirt.org/211
Reviewed-by: Igor Lvovsky <ilvovsky@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

init.d/vdsmd: look for initctl where it is expected

It may be better to have a vdsmd.in.in game, but let's fix the
regression first.

Change-Id: I699d943a545256a147c6a1d534dfb787bf726db4
Reviewed-on: http://gerrit.ovirt.org/198
Reviewed-by: Federico Simoncelli <fsimonce@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

BZ#751977 - Raise if VG remove fails.

Change-Id: I0185493e9fcd59fe20f01c8fbf071f098b5c8b59
Reviewed-on: http://gerrit.ovirt.org/215
Tested-by: Dan Kenigsberg <danken@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>

Rename variables that look like their pointing to a domain

Change-Id: I93c2a70323ca1da7d03fdb530325936c359e324e
Reviewed-on: http://gerrit.ovirt.org/189
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Fix __cleanupStoragePool()

Change-Id: I5ff24dde33e5a73fab4ab3c848d18071643af3a8
Reviewed-on: http://gerrit.ovirt.org/188
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Revert change of except to finally in StoragePool.create().

We need the id set for the entire scope. In StoragePool.attachSD() we
take another clustered lock and we need the field set.

Change-Id: I0f3495b56dc294c174fa53e17a5498cfe176d5a8
Reviewed-on: http://gerrit.ovirt.org/207
Tested-by: Dan Kenigsberg <danken@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>

Fixed missing parameter when raising exception in resource owner

Change-Id: I36d47587429f57ddb769cd6245c22a8ee50aeedb
Reviewed-on: http://gerrit.ovirt.org/206
Tested-by: Dan Kenigsberg <danken@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>

dir is a builtin, overriding it is not nice

Change-Id: I292cd9d5b47bb1051b765c02b55f351807316ea7
Reviewed-on: http://gerrit.ovirt.org/187
Reviewed-by: Igor Lvovsky <ilvovsky@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Fixed device mapper failing on partition check for non dm devices

Change-Id: I9b4713d7e0ee04722e82887378f448243241c631
Reviewed-on: http://gerrit.ovirt.org/186
Reviewed-by: Igor Lvovsky <ilvovsky@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Clean SPM leftovers on HSM init

Change-Id: I76ddf65d56a152ac8c15b2bb771a39365ea79437
Reviewed-on: http://gerrit.ovirt.org/196
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Remove redundant StoragePool.spmStarted state.

Change-Id: I47f29d14bd63e9190a94b455711e23d800575f24
Reviewed-on: http://gerrit.ovirt.org/180
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Cleanup StoragePool.create()

(Incomplete) cleanup without functional effects.
Change-Id: Ic5ea012da9393ac24dd2ec17c570a653a2ea9bfc
Reviewed-on: http://gerrit.usersys.redhat.com/1122
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

MSD and version mandatory when calling StoragePool.refresh()

Change-Id: I51b7c818fd785eed0281cb75ee831fc15d458a40
Reviewed-on: http://gerrit.usersys.redhat.com/1121
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Fix attachStorageDomain logic.

Change-Id: I445431274563a3fadd78da06affd40adc6135e40
Reviewed-on: http://gerrit.usersys.redhat.com/1120
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Add libvirt password as config file

Change-Id: I23d2ac1f9d558840dd0ac511db5bde0bac32c2b5
Reviewed-on: http://gerrit.usersys.redhat.com/1052
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

betterThreading.Event is never used; drop it.

betterThreading was initially conceived to be a drop-in replacement of
threading.py. However, once we opted for mokey-patching threading.py
instead, betterThreading.Event has become redundant.

Change-Id: Ifa3035ad0df880682f3e81d34751977e677e5133
Reviewed-on: http://gerrit.usersys.redhat.com/1075
Reviewed-by: Federico Simoncelli <fsimonce@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Related to BZ#744704 - Do not stop SPM task if in 'racquiring' state

Change-Id: I36459bea9cfe9b095f2cfb8d88cc142d248c77a4
Reviewed-on: http://gerrit.usersys.redhat.com/1042
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

BZ#744704 - Fix rollback support for complex tasks

Change-Id: Ie36ac02475f3f6438a63fbcbd26730862216cebd
Reviewed-on: http://gerrit.usersys.redhat.com/1041
Tested-by: Dan Kenigsberg <danken@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>

BZ#746766 deployUtil: restorecon on created ~/.ssh/ dir

Change-Id: Ia5399d98f983a56db70bc23785648bf28e461128
Reviewed-on: http://gerrit.usersys.redhat.com/1100
Reviewed-by: Igor Lvovsky <ilvovsky@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Async tasks should be saved in 'tasks' directory on master domain but not in 'hsm-tasks'

Change-Id: Id2c72c0a8a817a44e41285b77f4df23680c90b9d
Reviewed-on: http://gerrit.usersys.redhat.com/1090
Reviewed-by: Saggi Mizrahi <smizrahi@redhat.com>
Tested-by: Igor Lvovsky <ilvovsky@redhat.com>

Related to BZ#682513: spec: require mke2fs with -K

Change-Id: Ifafd3eea31c9a5bbe00d64bb3988b5876f4e1c9e
Reviewed-on: http://gerrit.usersys.redhat.com/1099
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Correct the variable name from VDSM-BIN to VDSM-REG-BIN in vdsm-reg script

Change-Id: I029d2295f2691855fa2b6d426e44f1e30838477c
Reviewed-on: http://gerrit.usersys.redhat.com/1096
Reviewed-by: Igor Lvovsky <ilvovsky@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

BZ#751629 - Avoid migrate master if MSD is obsolete.

In addition deactivate the (block) domain if it's unreloadable.

Change-Id: I995b86f62ee9026875b966d66f216d295aac9eba
Reviewed-on: http://gerrit.usersys/1091
Reviewed-by: Ayal Baron
Tested-by: Haim Ateya <hateya@redhat.com>
Reviewed-by: Igor Lvovsky <ilvovsky@redhat.com>

vds_bootstrap: fix usage string

Change-Id: I8950764778dc61d04caeed4c74e792d52bba3378
Reviewed-on: http://gerrit.usersys.redhat.com/982
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

fix typo in trying to copy iscsid.conf template

Change-Id: I211a97dbd4c945e3ff30d4b42d072fd7d92761c2
Reviewed-on: http://gerrit.usersys.redhat.com/1088
Tested-by: Dan Kenigsberg <danken@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>

Fixed SPM_mailbox attribute errror

Change-Id: Id3ccdf040248fee90c70803c6f0bf758e41d8568
Reviewed-on: http://gerrit.usersys.redhat.com/1079
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

BZ#749151 revive Vm ticket just before migration

We set a new expiry time on the spice password of the source qemu. That is
copied to the destination qemu as migration begins. We thus give spice client
two minutes to connect to destination to facilitate seamless migration.

v2:
- revive password only when spice client is connected
- revive password, do not remove it completely

v3:
- do not disconnect current client while reviving password.

Change-Id: Ibc7c0347354cf8f943c787dd621ce7b0eb78ef55
Reviewed-on: http://gerrit.usersys.redhat.com/1086
Reviewed-by: Igor Lvovsky <ilvovsky@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Revert "BZ#727602 setVmTicket: never expire ticket"

This reverts commit fd1f8a7a117067f1733898734b1c97bdf75d18bd.

Conflicts:

vdsm/libvirtvm.py

Change-Id: I7624e614576903e39ca0947a4f536433db944332
Reviewed-on: http://gerrit.usersys.redhat.com/1085
Reviewed-by: Igor Lvovsky <ilvovsky@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>

Move iscsid.conf template outside of the source file

Change-Id: I59ab2a951ddf15941218524ad7eb5bf94295023e
Reviewed-on: http://gerrit.usersys.redhat.com/1034
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

BZ#733000 vdsmd: upstart hates soflinks

Copy libvirt's upstart job definition instead of linking it.

Change-Id: I5c4f2a9c312c0f4fca984ff9bf07fac754bc6481
Reviewed-on: http://gerrit.usersys.redhat.com/1062
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

isMounted() now handles / at end of export in certain distros

Change-Id: I1cbba23b8a2d89a037ba809a86591ab33239ce24
Reviewed-on: http://gerrit.usersys.redhat.com/1072
Reviewed-by: Igor Lvovsky <ilvovsky@redhat.com>
Tested-by: Haim Ateya <hateya@redhat.com>
Reviewed-by: Saggi Mizrahi <smizrahi@redhat.com>

Changed default bridge name to engine

Change-Id: Iad298199b273753f921a2abfef16567d3e5a6033
Reviewed-on: http://gerrit.usersys.redhat.com/1071
Reviewed-by: Igor Lvovsky <ilvovsky@redhat.com>
Reviewed-by: Saggi Mizrahi <smizrahi@redhat.com>
Tested-by: Saggi Mizrahi <smizrahi@redhat.com>

Fixed reconstruct master

Change-Id: Ic7aa064dc07f2b26b3681be52a07901da197200b
Reviewed-on: http://gerrit.usersys.redhat.com/1070
Reviewed-by: Igor Lvovsky <ilvovsky@redhat.com>
Reviewed-by: Saggi Mizrahi <smizrahi@redhat.com>
Tested-by: Saggi Mizrahi <smizrahi@redhat.com>

Fix missing arg in sp.StoragePool() call.

Fix reconstruct master flow.

Change-Id: I00668572ca1aa4484171049393d4788046707c71
Reviewed-on: http://gerrit.usersys.redhat.com/1068
Tested-by: Dan Kenigsberg <danken@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>

Fix unsecured on forceFreeSpm().

Change-Id: I4d224cd739e3bd13c5bcd9a8ed17818b8211187f
Reviewed-on: http://gerrit.usersys.redhat.com/1067
Tested-by: Dan Kenigsberg <danken@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>

Fix lock release and reversed SPM logic.

Change-Id: I3e2335163e45dc601d6779b45beb03d67e997692
Reviewed-on: http://gerrit.usersys.redhat.com/1066
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

configure.ac: find scsi_id on Fedora 16, too.

Change-Id: Ic2b276931ddb31d01f7438928f931e3b951d3b56
Reviewed-on: http://gerrit.usersys.redhat.com/1065
Tested-by: Haim Ateya <hateya@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>

Add the systemd support for bootstrap

Change-Id: I118256a15ddf442dc96168ab04db5b89627c83e3
Reviewed-on: http://gerrit.usersys.redhat.com/1043
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

RPM changes for Fedora

Change-Id: I5cc880f8579b254f49981d88f4045ac124559458
Reviewed-on: http://gerrit.usersys.redhat.com/1023
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Recreate the run paths when needed

On some systems the run directory might be mounted as tmpfs (eg: on
Fedora). The daemon will refuse to start at next reboot if the paths
aren't recreated.

Change-Id: I6eee71ce11e47a64bf825089445d6ef4ec504d82
Reviewed-on: http://gerrit.usersys.redhat.com/1030
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Convert the OrderedDict from namedtuple._asdict()

Since python 2.7 the namedtuple._asdict() method returns an
OrderedDict, therefore we need to convert it to a regular
dictionary before marshalling it on xmlrpc.

Change-Id: I5582f77fbfc6961dcada3f733cb9353dee53cf53
Reviewed-on: http://gerrit.usersys.redhat.com/1029
Reviewed-by: Igor Lvovsky <ilvovsky@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

Related to 726960 - Restore higher version check.

This check was removed in commit 85b58b7d9 since the manager
can't send a lower pool version number.
In spite of this some tests stress this condition.
Restoring it in order to fix tests results.

Change-Id: I9c7258361589fac7dc94361b88cabdf73cf48a83
Reviewed-on: http://gerrit.usersys.redhat.com/927
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>

use correct path for fencing agent

There's probably a nicer way to do it with autoconf, avoiding
os.path.dirname. Comments appreciated.

Change-Id: I346c8667ba3f822546f28c4f0edbdb6443d293f5
Reviewed-on: http://gerrit.usersys.redhat.com/1059
Reviewed-by: Saggi Mizrahi <smizrahi@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Tested-by: Dan Kenigsberg <danken@redhat.com>