| commit | b3fc500a9f881b31fd178d15b604d890fed7cf96 | |
| author | Julian Seward <jseward@acm.org> | |
| Fri, 17 Aug 2018 07:31:37 +0000 (17 09:31 +0200) | ||
| committer | Julian Seward <jseward@acm.org> | |
| Fri, 17 Aug 2018 07:31:37 +0000 (17 09:31 +0200) | ||
| tree | 8fe9c515b183ad2c2354ebddb1f55f52cca30069 | treesnapshot (tar.gz zip) |
| parent | c263702101c7be87efb5a5144718fa6245a69e19 | commitdiff |
Fix 388174 - valgrind with Wine quits with "Assertion 'cfsi_fits' failed"
In check_CFSI_related_invariants, this commit improves the check for invariant
(2), which, as noted in an existing comment, "might need to be improved".
Instead of assuming that the CFSI range fits entirely into one "rx" mapping,
check that it is covered by the union of all the "rx" mappings we have. This
is the correct check. The previous check was observed to have failed as below
for at least some Clang generated objects (possibly in conjunction with lld as
the linker.)
valgrind: m_debuginfo/debuginfo.c:717 (check_CFSI_related_invariants): Assertion 'cfsi_fits' failed.
In check_CFSI_related_invariants, this commit improves the check for invariant
(2), which, as noted in an existing comment, "might need to be improved".
Instead of assuming that the CFSI range fits entirely into one "rx" mapping,
check that it is covered by the union of all the "rx" mappings we have. This
is the correct check. The previous check was observed to have failed as below
for at least some Clang generated objects (possibly in conjunction with lld as
the linker.)
valgrind: m_debuginfo/debuginfo.c:717 (check_CFSI_related_invariants): Assertion 'cfsi_fits' failed.
| coregrind/m_debuginfo/debuginfo.c | diffblobblamehistory |