From e503abb729687d1a36b95ed2794f54452189c858 Mon Sep 17 00:00:00 2001 From: Igor Kozhukhov Date: Sat, 1 Nov 2014 18:30:03 +0400 Subject: [PATCH] 5278 cleanup gcc warnings for cmd/ps Reviewed by: Gary Mills Reviewed by: Keith Wesolowski Reviewed by: Josef 'Jeff' Sipek Reviewed by: Andy Stormont Approved by: Dan McDonald --- usr/src/cmd/ps/Makefile.com | 2 -- usr/src/cmd/ps/ps.c | 4 ++-- usr/src/cmd/ps/ucbps.c | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/usr/src/cmd/ps/Makefile.com b/usr/src/cmd/ps/Makefile.com index 48e187ef48..aa7a2bec45 100644 --- a/usr/src/cmd/ps/Makefile.com +++ b/usr/src/cmd/ps/Makefile.com @@ -34,8 +34,6 @@ SRCS= $(OBJS:%.o=../%.c) include ../../Makefile.cmd CFLAGS += $(CCVERBOSE) -CERRWARN += -_gcc=-Wno-parentheses -CERRWARN += -_gcc=-Wno-uninitialized LDLIBS += -lproject .KEEP_STATE: diff --git a/usr/src/cmd/ps/ps.c b/usr/src/cmd/ps/ps.c index 0a43a92fcb..78dabbccfe 100644 --- a/usr/src/cmd/ps/ps.c +++ b/usr/src/cmd/ps/ps.c @@ -911,7 +911,7 @@ stdmain(int argc, char **argv) } /* for each active process --- */ - while (dentp = readdir(dirp)) { + while ((dentp = readdir(dirp)) != NULL) { if (dentp->d_name[0] == '.') /* skip . and .. */ continue; if (print_proc(dentp->d_name) == 0) @@ -1659,7 +1659,7 @@ print_field(psinfo_t *psinfo, struct field *f, const char *ttyp) char *cp; int length; ulong_t mask; - char c, *csave; + char c = '\0', *csave = NULL; int zombie_lwp; zombie_lwp = (Lflg && psinfo->pr_lwp.pr_sname == 'Z'); diff --git a/usr/src/cmd/ps/ucbps.c b/usr/src/cmd/ps/ucbps.c index 67ca1629d7..3110e95313 100644 --- a/usr/src/cmd/ps/ucbps.c +++ b/usr/src/cmd/ps/ucbps.c @@ -396,7 +396,7 @@ ucbmain(int argc, char **argv) psname[pdlen++] = '/'; /* for each active process --- */ - while (dentp = readdir(dirp)) { + while ((dentp = readdir(dirp)) != NULL) { int psfd; /* file descriptor for /proc/nnnnn/psinfo */ int asfd; /* file descriptor for /proc/nnnnn/as */ -- 2.11.4.GIT