From d65dfb0a6855414a1ff916b896e8be0fbe0d212a Mon Sep 17 00:00:00 2001 From: Toomas Soome Date: Sat, 1 Jul 2017 10:36:52 +0300 Subject: [PATCH] 8499 ficl: this statement may fall through Reviewed by: Yuri Pankov Reviewed by: Marcel Telka Reviewed by: Jason King Approved by: Robert Mustacchi --- usr/src/common/ficl/emu/loader_emu.c | 1 + usr/src/common/ficl/float.c | 4 ++-- usr/src/common/ficl/primitives.c | 3 +++ usr/src/common/ficl/vm.c | 1 + 4 files changed, 7 insertions(+), 2 deletions(-) diff --git a/usr/src/common/ficl/emu/loader_emu.c b/usr/src/common/ficl/emu/loader_emu.c index 67b631cf4d..d109016176 100644 --- a/usr/src/common/ficl/emu/loader_emu.c +++ b/usr/src/common/ficl/emu/loader_emu.c @@ -1146,6 +1146,7 @@ command_help(int argc, char *argv[]) switch (argc) { case 3: subtopic = strdup(argv[2]); + /* FALLTHROUGH */ case 2: topic = strdup(argv[1]); break; diff --git a/usr/src/common/ficl/float.c b/usr/src/common/ficl/float.c index 3442259f59..02f64b8c9b 100644 --- a/usr/src/common/ficl/float.c +++ b/usr/src/common/ficl/float.c @@ -294,7 +294,7 @@ ficlVmParseFloatNumber(ficlVm *vm, ficlString s) if (c == '+') { break; } - /* Note! Drop through to FPS_ININT */ + /* FALLTHROUGH */ /* * Converting integer part of number. * Only allow digits, decimal and 'E'. @@ -339,7 +339,7 @@ ficlVmParseFloatNumber(ficlVm *vm, ficlString s) } else if (c == '+') { break; } - /* Note! Drop through to FPS_INEXP */ + /* FALLTHROUGH */ /* * Processing the exponent part of number. * Only allow digits. diff --git a/usr/src/common/ficl/primitives.c b/usr/src/common/ficl/primitives.c index c8b9829705..63ec19c377 100644 --- a/usr/src/common/ficl/primitives.c +++ b/usr/src/common/ficl/primitives.c @@ -417,9 +417,11 @@ ficlPrimitiveSprintf(ficlVm *vm) case 'x': case 'X': base = 16; + /* FALLTHROUGH */ case 'u': case 'U': unsignedInteger = 1; /* true */ + /* FALLTHROUGH */ case 'd': case 'D': { int integer; @@ -437,6 +439,7 @@ ficlPrimitiveSprintf(ficlVm *vm) case '%': source = format; actualLength = 1; + /* FALLTHROUGH */ default: continue; } diff --git a/usr/src/common/ficl/vm.c b/usr/src/common/ficl/vm.c index a284008deb..1917d3fd90 100644 --- a/usr/src/common/ficl/vm.c +++ b/usr/src/common/ficl/vm.c @@ -147,6 +147,7 @@ RUNTIME_FIXUP: case ficlInstructionBranchParenWithCheck: /* preoptimize where we're jumping to */ ficlVmOptimizeJumpToJump(vm, destination); + /* FALLTHROUGH */ case ficlInstructionBranchParen: destination++; destination += *(ficlInteger *)destination; -- 2.11.4.GIT