From 0716b62f878e855b94635ef4793ef5f7f2abb8e4 Mon Sep 17 00:00:00 2001 From: Josef 'Jeff' Sipek Date: Fri, 31 Oct 2014 20:50:13 -0400 Subject: [PATCH] 5256 document some nonsensical code in the px driver Reviewed by: Marcel Telka Approved by: Robert Mustacchi --- usr/src/uts/sun4/io/px/px_debug.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/usr/src/uts/sun4/io/px/px_debug.c b/usr/src/uts/sun4/io/px/px_debug.c index 6d94288615..4eea5eb9e8 100644 --- a/usr/src/uts/sun4/io/px/px_debug.c +++ b/usr/src/uts/sun4/io/px/px_debug.c @@ -255,6 +255,10 @@ px_dbg_attach(dev_info_t *dip, ddi_softint_handle_t *dbg_hdl) int size = px_dbg_msg_size; /* Check if px_dbg_msg_size is ^2 */ + /* + * WARNING: The bellow statement makes no sense. If size is + * not a power of 2, it will set size to zero. + */ size = !ISP2(size) ? ((size | ~size) + 1) : size; px_dbg_msg_size = size; px_dbg_qmask = size - 1; -- 2.11.4.GIT