| commit | 74643ae415938b8aea314a50a809d18970eaac00 | |
| author | Lauri Tirkkonen <lotheac@iki.fi> | |
| Wed, 14 Jun 2017 10:41:13 +0000 (14 13:41 +0300) | ||
| committer | Lauri Tirkkonen <lotheac@iki.fi> | |
| Tue, 20 Jun 2017 13:42:48 +0000 (20 16:42 +0300) | ||
| tree | 9104081fb1dcd3ee0a14eff8ef4e627914a0d9d5 | treesnapshot (tar.gz zip) |
| parent | d05cb5dde0990e56e1a38bb045d034cd48c7890a | commitdiff |
tcp: remove _iss_incr tunable
It was introduced in illumos bug #917 in an attempt to address an issue
where high connection rates with the same connection-id tuple could
cause the new connection's ISN to not be greater than the old one
(breaking the connection reincarnation from TIME_WAIT heuristics).
However this does not apply to us since commit
915cb3b310e9b3a87ab2b352b22f57c23b34f41d; per RFC6528 we use a separate
ISN space for each (outgoing) connection-id tuple.
In fact the proposed algorithm in RFC6528 does not include the
per-connection component (ISS_INCR) at all, but mentions that
"Berkeley-derived kernels" used a per-second and a per-connection
component. Because we call gethrtime for each new outgoing connection,
the additional per-connection component should not be necessary.
It was introduced in illumos bug #917 in an attempt to address an issue
where high connection rates with the same connection-id tuple could
cause the new connection's ISN to not be greater than the old one
(breaking the connection reincarnation from TIME_WAIT heuristics).
However this does not apply to us since commit
915cb3b310e9b3a87ab2b352b22f57c23b34f41d; per RFC6528 we use a separate
ISN space for each (outgoing) connection-id tuple.
In fact the proposed algorithm in RFC6528 does not include the
per-connection component (ISS_INCR) at all, but mentions that
"Berkeley-derived kernels" used a per-second and a per-connection
component. Because we call gethrtime for each new outgoing connection,
the additional per-connection component should not be necessary.
| include/inet/tcp_impl.h | diffblobblamehistory | |
| include/inet/tcp_stack.h | diffblobblamehistory | |
| kernel/net/tcp/tcp.c | diffblobblamehistory | |
| kernel/net/tcp/tcp_tunables.c | diffblobblamehistory |