| commit | e4256da292f9626d7dfca60e08f65651a0a9139a | |
| author | Eric Wong <normalperson@yhbt.net> | |
| Sat, 14 Nov 2009 00:23:19 +0000 (14 00:23 +0000) | ||
| committer | Eric Wong <normalperson@yhbt.net> | |
| Sat, 14 Nov 2009 01:08:24 +0000 (13 17:08 -0800) | ||
| tree | 5d90f73ce87cb5771f1f1f7bac007185028e80ea | treesnapshot (tar.gz zip) |
| parent | 1b7b4d160610dd538eee624ef8eb8c6ed301a2b5 | commitdiff |
raise Unicorn::ClientShutdown if client aborts in TeeInput
Leaving the EOFError exception as-is bad because most
applications/frameworks run an application-wide exception
handler to pretty-print and/or log the exception with a huge
backtrace.
Since there's absolutely nothing we can do in the server-side
app to deal with clients prematurely shutting down, having a
backtrace does not make sense. Having a backtrace can even be
harmful since it creates unnecessary noise for application
engineers monitoring or tracking down real bugs.
Leaving the EOFError exception as-is bad because most
applications/frameworks run an application-wide exception
handler to pretty-print and/or log the exception with a huge
backtrace.
Since there's absolutely nothing we can do in the server-side
app to deal with clients prematurely shutting down, having a
backtrace does not make sense. Having a backtrace can even be
harmful since it creates unnecessary noise for application
engineers monitoring or tracking down real bugs.
| lib/unicorn.rb | diffblobblamehistory | |
| lib/unicorn/tee_input.rb | diffblobblamehistory | |
| test/unit/test_server.rb | diffblobblamehistory |