| commit | 795c3527337ff4f03ae6db08c5df01141565ed96 | |
| author | Eric Wong <normalperson@yhbt.net> | |
| Tue, 26 Nov 2013 01:55:51 +0000 (26 01:55 +0000) | ||
| committer | Eric Wong <normalperson@yhbt.net> | |
| Tue, 26 Nov 2013 01:55:51 +0000 (26 01:55 +0000) | ||
| tree | e26599887a2b1b54ae92c33642d2cbf1f8c15225 | treesnapshot (tar.gz zip) |
| parent | aaa75bdcdf782ef7332dba20fc4eb43517e6453c | commitdiff |
always write PID file early for compatibility
This reduces the window for a non-existent PID for folks who monitor
PIDs (not a great idea anyways). Unfortunately, this change also brings
us back to the case where having a PID later (for other process monitors)
is beneficial but more unicorn releases exist where we write the PID
early.
Thanks to Jimmy Soho for reporting this issue.
ref: <CAHStS5gFYcPBDxkVizAHrOeDKAkjT69kruFdgaY0CbB+vLbK8Q@mail.gmail.com>
This partially reverts 7d6ac0c17eb29a00a5b74099dbb3d4d015999f27
Folks: please monitor your app with HTTP requests rather than checking
processes, a stuck/wedged Ruby VM is still a running one.
This reduces the window for a non-existent PID for folks who monitor
PIDs (not a great idea anyways). Unfortunately, this change also brings
us back to the case where having a PID later (for other process monitors)
is beneficial but more unicorn releases exist where we write the PID
early.
Thanks to Jimmy Soho for reporting this issue.
ref: <CAHStS5gFYcPBDxkVizAHrOeDKAkjT69kruFdgaY0CbB+vLbK8Q@mail.gmail.com>
This partially reverts 7d6ac0c17eb29a00a5b74099dbb3d4d015999f27
Folks: please monitor your app with HTTP requests rather than checking
processes, a stuck/wedged Ruby VM is still a running one.
| lib/unicorn/http_server.rb | diffblobblamehistory |