| commit | 3d22c178d766d0601b75f5c0de7ee0696745c41c | |
| author | Eric Wong <normalperson@yhbt.net> | |
| Fri, 13 Feb 2009 08:08:33 +0000 (13 00:08 -0800) | ||
| committer | Eric Wong <normalperson@yhbt.net> | |
| Fri, 13 Feb 2009 08:08:33 +0000 (13 00:08 -0800) | ||
| tree | 4d0f7d3f6d689b13686861ddc496c4a35286f160 | treesnapshot (tar.gz zip) |
| parent | 0bd2bf7c438eb4394b7a66ca0999ab896beccf95 | commitdiff |
Remove tempfile reuse from HttpRequest, upload tests
Tempfile reuse was over-engineered and the problem was not
nearly as big a problem as initially thought.
Additionally, it could lead to a subtle bug in an applications
that link(2)s or rename(2)s the temporary file to a permanent
location _without_ closing it after the request is done.
Applications that suffer from the problem of directory bloat are
still free to modify ENV['TMPDIR'] to influence the creation of
Tempfiles.
Tempfile reuse was over-engineered and the problem was not
nearly as big a problem as initially thought.
Additionally, it could lead to a subtle bug in an applications
that link(2)s or rename(2)s the temporary file to a permanent
location _without_ closing it after the request is done.
Applications that suffer from the problem of directory bloat are
still free to modify ENV['TMPDIR'] to influence the creation of
Tempfiles.
| README | diffblobblamehistory | |
| lib/unicorn/http_request.rb | diffblobblamehistory | |
| test/unit/test_upload.rb | [new file with mode: 0644] | blob |