| commit | fb3704b45982e6a97dbad4e2d6e9cf7ba8fd1151 | |
| author | Nick Mathewson <nickm@torproject.org> | |
| Wed, 9 Dec 2020 18:10:53 +0000 (9 13:10 -0500) | ||
| committer | George Kadianakis <desnacked@riseup.net> | |
| Wed, 13 Jan 2021 13:23:27 +0000 (13 15:23 +0200) | ||
| tree | c88820b2837804cfd8825048073915b74928c042 | treesnapshot (tar.gz zip) |
| parent | 2bfb76b927111824a2051d09b1f5542ee58e2a6f | commitdiff |
New consensus method to find bwweightscale & maxunmeasuredbw correctly.
Our original code for parsing these parameters out of our list of
parameters pre-dated us having the
dirvote_get_intermediate_param_value() function... and it was buggy.
Specifically, it would reject any " ... K=V ..." value
where there were additional unconverted characters after the V, and
use the default value instead,
We haven't run into this yet because we've never voted for
bwweightscale to be anything besides the default 10000, or
maxunmeasuredbw to be anything besides the default 20.
This requires a new consensus method because it is a change in how
consensuses are computed.
Fixes bug 19011; bugfix on 0.2.2.10-alpha.
Our original code for parsing these parameters out of our list of
parameters pre-dated us having the
dirvote_get_intermediate_param_value() function... and it was buggy.
Specifically, it would reject any " ... K=V ..." value
where there were additional unconverted characters after the V, and
use the default value instead,
We haven't run into this yet because we've never voted for
bwweightscale to be anything besides the default 10000, or
maxunmeasuredbw to be anything besides the default 20.
This requires a new consensus method because it is a change in how
consensuses are computed.
Fixes bug 19011; bugfix on 0.2.2.10-alpha.
| changes/bug19011 | [new file with mode: 0644] | blob |
| src/feature/dirauth/dirvote.c | diffblobblamehistory | |
| src/feature/dirauth/dirvote.h | diffblobblamehistory | |
| src/test/test_dirvote.c | diffblobblamehistory |