conn: Remove assert on new listener connection when retrying
commitea339227c27c03d7ced9e526d9e945708f432b22
authorDavid Goulet <dgoulet@torproject.org>
Tue, 1 Sep 2020 13:54:48 +0000 (1 09:54 -0400)
committerDavid Goulet <dgoulet@torproject.org>
Tue, 1 Sep 2020 14:01:21 +0000 (1 10:01 -0400)
tree8db66c7981ea66f71f9c6da92e19c6a4fdca7abf
parent72484a4953d744754b3b6b025242ef668e3f017a
conn: Remove assert on new listener connection when retrying

Opening a new listener connection can fail in many ways like a bind()
permission denied on a low port for instance.

And thus, we should expect to handle an error when creating a new one instead
of assert() on it.

To hit the removed assert:

  ORPort 80
  KeepBindCapabilities 0

Start tor. Then edit torrc:

  ORPort <some-IP>:80

HUP tor and the assert is hit.

Fixes #40073

Signed-off-by: David Goulet <dgoulet@torproject.org>
changes/ticket40073 [new file with mode: 0644]
src/core/mainloop/connection.c