Remove defensive assertion in `relay_key_is_unavailable_()`.
commit87fb8b641769688c88a6a23ed286ca44bfd989c1
authorAlexander Færøy <ahf@torproject.org>
Wed, 30 Aug 2023 12:43:21 +0000 (30 14:43 +0200)
committerAlexander Færøy <ahf@torproject.org>
Tue, 12 Sep 2023 14:42:35 +0000 (12 16:42 +0200)
tree7f912edf6053dffdba31508e26cda231d8b1da3c
parentd6c89b1ae1b18cc3cae42638d7bbe1edd7e35715
Remove defensive assertion in `relay_key_is_unavailable_()`.

This patch removes a call to `tor_assert_nonfatal_unreached()` in
`relay_key_is_unavailable_()` that is only called when Tor is compiled
without relay support.

Unfortunately, the non-fatal assertion causes a BUG log
message to appear for clients when they start up without relay support
for each CPU worker we spawn. This makes it spotting issues during
bootstrap harder particularly for our iOS developers.

Since the call sites to `get_master_identity_key()` handles `NULL`
values already, we do not think this will be an issue later on.

Reported by Benjamin Erhart (@tla) from Guardian Project.

Fixes tpo/core/tor#40848.
changes/ticket40848 [new file with mode: 0644]
src/feature/relay/routerkeys.h