relay: Avoid a directory early fetch
commit39d0f69dfee86c4f8703094990d3169fb20614f3
authorDavid Goulet <dgoulet@torproject.org>
Tue, 23 Feb 2021 14:37:17 +0000 (23 09:37 -0500)
committerDavid Goulet <dgoulet@torproject.org>
Tue, 23 Feb 2021 14:49:45 +0000 (23 09:49 -0500)
tree5b01dbd2a73e5a0f43586eeaa861f6263c893458
parentbc21ed32903459c53599ee03605e8d23bf42ffe9
relay: Avoid a directory early fetch

The directory_fetches_from_authorities() is used to know if a client or relay
should fetch data from an authority early in the boot process.

We had a condition in that function that made a relay trigger that fetch if it
didn't know its address (so we can learn it). However, when this is called,
the address discovery has not been done yet so it would always return true for
a relay.

Furthermore, it would always trigger a log notice that the IPv4 couldn't be
found which was inevitable because the address discovery process has not been
done yet (done when building our first descriptor).

It is also important to point out that starting in 0.4.5.1-alpha, asking an
authority for an address is done during address discovery time using a one-hop
circuit thus independent from the relay deciding to fetch or not documents
from an authority.

Small fix also is to reverse the "IPv(4|6)Only" flag in the notice so that if
we can't find IPv6 it would output to use IPv4Only.

Fixes #40300

Signed-off-by: David Goulet <dgoulet@torproject.org>
changes/ticket40300
src/feature/dirclient/dirclient_modes.c
src/feature/relay/relay_find_addr.c
src/feature/relay/relay_find_addr.h
src/test/test_config.c