conn: Stop writing when our write bandwidth limist is exhausted
commit2000d04cb67fa1ee88105e61666dceba40b8c368
authorDavid Goulet <dgoulet@torproject.org>
Wed, 17 Oct 2018 16:25:12 +0000 (17 12:25 -0400)
committerDavid Goulet <dgoulet@torproject.org>
Wed, 17 Oct 2018 16:25:12 +0000 (17 12:25 -0400)
tree985e6798894c1642e1a1bab97378cc74336412f5
parentb5731cdf2ecdf0662de7268d95aa67cfaca92b6e
conn: Stop writing when our write bandwidth limist is exhausted

Commit 488e2b00bf881b97bcc8e4bbe304845ff1d79a03 introduced an issue, most
likely introduced by a bad copy paste, that made us stop reading on the
connection if our write bandwidth limit was reached.

The problem is that because "read_blocked_on_bw" was never set, the connection
was never reenabled for reading.

This is most likely the cause of #27813 where bytes were accumulating in the
kernel TCP bufers because tor was not doing reads. Only relays with
RelayBandwidthRate would suffer from this but affecting all relays connecting
to them. And using that tor option is recommended and best practice so many
many relays have it enabled.

Fixes #28089.
changes/ticket28089 [new file with mode: 0644]
src/or/connection.c