svn/apache.git
4 years agoOn all branches:master-passphrasemaster-passphrase
Stefan Hett [Sun, 22 Apr 2018 14:47:13 +0000 (22 14:47 +0000)]
On all branches:

.: Removed redundant SVN properties

git-svn-id: https://svn.apache.org/repos/asf/subversion/branches/master-passphrase@1829788 13f79535-47bb-0310-9956-ffa450edef68

5 years agoOn branch 'master-passphrase':
C. Michael Pilato [Wed, 12 Oct 2016 19:52:11 +0000 (12 19:52 +0000)]
On branch 'master-passphrase':

* BRANCH-README
  bus_factor++

git-svn-id: https://svn.apache.org/repos/asf/subversion/branches/master-passphrase@1764531 13f79535-47bb-0310-9956-ffa450edef68

9 years agoOn the 'master-passphrase' branch:
C. Michael Pilato [Fri, 24 May 2013 17:21:00 +0000 (24 17:21 +0000)]
On the 'master-passphrase' branch:

* subversion/include/svn_auth.h
  Comment formatting change only.

git-svn-id: https://svn.apache.org/repos/asf/subversion/branches/master-passphrase@1486123 13f79535-47bb-0310-9956-ffa450edef68

9 years agoSync the 'master-passphrase' branch up with recent (and, uh, not-so-recent)
C. Michael Pilato [Fri, 10 May 2013 14:58:47 +0000 (10 14:58 +0000)]
Sync the 'master-passphrase' branch up with recent (and, uh, not-so-recent)
trunk changes.  (Merged /subversion/trunk:r1451629-1481020)

git-svn-id: https://svn.apache.org/repos/asf/subversion/branches/master-passphrase@1481041 13f79535-47bb-0310-9956-ffa450edef68

9 years agoFix issue 4365, multi-threaded svnserve pool memory use after clear.
Philip Martin [Fri, 10 May 2013 13:57:47 +0000 (10 13:57 +0000)]
Fix issue 4365, multi-threaded svnserve pool memory use after clear.

* subversion/svnserve/svnserve.c
  (struct shared_pool_t): New.
  (attach_shared_pool, release_shared_pool): New.
  (struct serve_thread_t): Replace pool with shared_pool.
  (serve_thread): Use and release shared pool.
  (main): Setup and release shared pool.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1481010 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* tools/buildbot/slaves/bb-openbsd/svncheck.sh: Revert changes from r1480393,
Stefan Sperling [Fri, 10 May 2013 09:58:56 +0000 (10 09:58 +0000)]
* tools/buildbot/slaves/bb-openbsd/svncheck.sh: Revert changes from r1480393,
   the problem has been fixed in the buildbot master config (see infra
   repository r861433).

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480972 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* subversion/tests/libsvn_fs/fs-test.c
Stefan Sperling [Fri, 10 May 2013 09:45:01 +0000 (10 09:45 +0000)]
* subversion/tests/libsvn_fs/fs-test.c
  (filename_trailing_newline): Update synopsis of issue #4340 in comment.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480968 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* subversion/tests/libsvn_repos/repos-test.c
Stefan Sperling [Fri, 10 May 2013 09:43:54 +0000 (10 09:43 +0000)]
* subversion/tests/libsvn_repos/repos-test.c
  (filename_with_control_chars): Update synopsis of issue #4340 in comment.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480966 13f79535-47bb-0310-9956-ffa450edef68

9 years agoMerge a no-longer-useful error construction helper function into its only
Julian Foad [Thu, 9 May 2013 21:23:22 +0000 (9 21:23 +0000)]
Merge a no-longer-useful error construction helper function into its only
remaining caller.

* subversion/libsvn_repos/delta.c
  (not_a_dir_error): Delete.
  (svn_repos_dir_delta2): Write the equivalent error return in-line here.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480780 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.h
Paul Burba [Thu, 9 May 2013 20:36:32 +0000 (9 20:36 +0000)]
* subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.h
  (ruby/io.h): Include the appropriate Ruby header if using Ruby 1.9 and
   thus avoid the 'use "ruby/io.h" instead of "rubyio.h"' warning.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480765 13f79535-47bb-0310-9956-ffa450edef68

9 years agoAnother Ruby 1.9 fix for Windows.
Paul Burba [Thu, 9 May 2013 18:49:32 +0000 (9 18:49 +0000)]
Another Ruby 1.9 fix for Windows.

* subversion/bindings/swig/ruby/test/windows_util.rb
  (SvnTestUtil.Windows.SetupEnvironment.gen_make_opts): String objects in 1.9
   no longer have the to_a method, so use a workaround that works for both
   1.9 and 1.8.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480738 13f79535-47bb-0310-9956-ffa450edef68

9 years agoMore cleanup to issue #4355 'svn_client_log5 broken with multiple
Paul Burba [Thu, 9 May 2013 16:58:17 +0000 (9 16:58 +0000)]
More cleanup to issue #4355 'svn_client_log5 broken with multiple
revisions which span a rename' fix in r1478220.

Suggested by: cmpilato, julianfoad

* subversion/libsvn_client/log.c

  (svn_client_log5): Fix typo in doc string.  We know what size the output
   array will be, so just initialize it to that size.  Remove an unnecessary
   dereference.

  (convert_opt_rev_array_to_rev_range_array): Replace memcmp comparison of
   two structures with proper member-wise comparison.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480723 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* CHANGES: Tweak 1.8.0 entries related to svnauthz.
Stefan Sperling [Thu, 9 May 2013 15:56:14 +0000 (9 15:56 +0000)]
* CHANGES: Tweak 1.8.0 entries related to svnauthz.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480700 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* CHANGES
C. Michael Pilato [Thu, 9 May 2013 15:46:12 +0000 (9 15:46 +0000)]
* CHANGES
  Record 1.8.0 changes from the -r1214773:1182978 range.  Also, fix the
  statement which notes the introduction of FSv2 to point out that this
  is a private API only.  (We may wish to simply strike the item altogether.)

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480698 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* tools/buildbot/slaves/bb-openbsd/svnclean.sh: Fix for 1.8.x, and also for
Stefan Sperling [Thu, 9 May 2013 15:26:38 +0000 (9 15:26 +0000)]
* tools/buildbot/slaves/bb-openbsd/svnclean.sh: Fix for 1.8.x, and also for
   1.9.x and 1.10.x so we won't have to fix it again for a couple of years.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480688 13f79535-47bb-0310-9956-ffa450edef68

9 years agoClarify doc strings related to conflicts.
Julian Foad [Thu, 9 May 2013 15:15:28 +0000 (9 15:15 +0000)]
Clarify doc strings related to conflicts.

* subversion/include/svn_wc.h
  (svn_wc_create_conflict_result): Be explicit about the 'save_merged'
    field. Remove wording that may be read as documenting what a future
    implementation will do with any new fields, since we don't need to say
    this until it happens and the way it was described here is not
    necessarily exactly what we would want to do. (All we really promise is
    that it will behave in a backward compatible manner, and that's an
    implicit promise across all of our APIs.)

* subversion/libsvn_wc/conflicts.h
  (svn_wc__conflict_create_markers): Clarify.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480681 13f79535-47bb-0310-9956-ffa450edef68

9 years agoFactor out some common code in conflict handling.
Julian Foad [Thu, 9 May 2013 14:56:12 +0000 (9 14:56 +0000)]
Factor out some common code in conflict handling.

* subversion/libsvn_wc/conflicts.c
  (merge_showing_conflicts): New function, factored out ...
  (eval_text_conflict_func_result,
   resolve_text_conflict_on_node): ... of these two functions.
    Also note that these two functions are redundantly similar.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480670 13f79535-47bb-0310-9956-ffa450edef68

9 years agoIf a merged property value exists, make the 'dc' conflict prompt option use
Stefan Sperling [Thu, 9 May 2013 14:51:35 +0000 (9 14:51 +0000)]
If a merged property value exists, make the 'dc' conflict prompt option use
the merged value as 'mine' for display. Else, users might get confused if
they edit a property, run 'dc', and see the value from before the edit.

* subversion/svn/conflict-callbacks.c
  (show_prop_conflict, merge_prop_conflict): Add merged_abspath parameter.
   Use it as 'my' version if non-NULL.
  (edit_prop_conflict): For now, pass NULL for the merged file to
   merge_prop_conflict(), so that repeated edits always start with
   the same original values. This behaviour can be reconsidered later.
  (handle_prop_conflict): Pass the path to the merged file, which might be
   NULL, to show_prop_conflict().

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480669 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* subversion/svn/conflict-callbacks.c
Stefan Sperling [Thu, 9 May 2013 14:28:50 +0000 (9 14:28 +0000)]
* subversion/svn/conflict-callbacks.c
  (handle_prop_conflict): Don't allow 'r' to be used if no merged property
   value exists yet. Fix indentation while here.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480664 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* subversion/svn/conflict-callbacks.c
Stefan Sperling [Thu, 9 May 2013 14:18:35 +0000 (9 14:18 +0000)]
* subversion/svn/conflict-callbacks.c
  (svn_cl__conflict_func_interactive): Indentation fix.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480655 13f79535-47bb-0310-9956-ffa450edef68

9 years agoAdd new commands to the interactive conflict prompt which allow users to
Stefan Sperling [Thu, 9 May 2013 14:04:58 +0000 (9 14:04 +0000)]
Add new commands to the interactive conflict prompt which allow users to
edit conflicted properties and use the result to resolve the property conflict.

This adds new commands to the property conflict prompt: 'edit' and 'resolved'

* subversion/svn/conflict-callbacks.c
  (merge_prop_conflict): New, split off from show_prop_conflict().
  (show_prop_conflict): Reimplement as a wrapper around merge_prop_conflict().
  (open_editor): Accept a 'merged_file' path instead of a conflict descriptor
   which contains a merged_file path. No other information from the conflict
   descriptor was used, and this interface change allows open_editor() to be
   reused more easily.
  (edit_prop_conflict): New. Runs an external editor to edit the conflicted
   property value.
  (prop_conflict_options): Add 'edit' and 'resolved' parameters.
  (handle_text_conflict): Adjust for open_editor() interface change.
  (handle_prop_conflict): Handle the newly added options. Only show the
   'resolved' option after the user has used 'edit' to edit the property.
   This function now needs a result pool to ensure that the merged file
   will have sufficient lifetime and won't disappear from disk too early.
  (conflict_func_interactive): Pass a result pool to handle_prop_conflict().

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480642 13f79535-47bb-0310-9956-ffa450edef68

9 years agoFix a bug where the conflict resolver ignored the merged value provided
Stefan Sperling [Thu, 9 May 2013 14:04:46 +0000 (9 14:04 +0000)]
Fix a bug where the conflict resolver ignored the merged value provided
by the conflict resolution callback, for both text and property conflicts.

* subversion/libsvn_wc/conflicts.c
  (resolve_text_conflict_on_node): Add 'merged_file' parameter. Use the merged
    file as resolution source if it was provided and the user picked the
    'choose_merged' conflict choice.
  (resolve_prop_conflict_on_node): As above, but here we also need to add a
   'conflicted_propname' parameter which indicates which conflicted property
   the user is resolving, so we can apply the merged value to it.
  (svn_wc__mark_resolved_text_conflict,
   svn_wc__mark_resolved_prop_conflicts): Make these callers pass values for
   the new parameters such that no change in behaviour occurs.
  (conflict_status_walker): Pass the merged_file from the conflict callback
   result to resolve_text_conflict_on_node()/resolve_prop_conflict_on_node().
   This function still ignores the 'save_merge' boolean provided by the
   conflict callback, which will need to be fixed later.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480641 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* CHANGES: Remove an item from the 1.8 list which was merged to 1.7.
Stefan Sperling [Thu, 9 May 2013 13:32:09 +0000 (9 13:32 +0000)]
* CHANGES: Remove an item from the 1.8 list which was merged to 1.7.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480626 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* CHANGES: minor formatting fixes in revision enumerations
Stefan Fuhrmann [Thu, 9 May 2013 13:24:04 +0000 (9 13:24 +0000)]
* CHANGES: minor formatting fixes in revision enumerations

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480622 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* CHANGES: add missing changes identified by reviewing the 2nd batch
Stefan Fuhrmann [Thu, 9 May 2013 13:18:36 +0000 (9 13:18 +0000)]
* CHANGES: add missing changes identified by reviewing the 2nd batch
  (r1182975) from http://wiki.apache.org/subversion/Svn18Change

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480620 13f79535-47bb-0310-9956-ffa450edef68

9 years agoSimplify some conflict resolution code in libsvn_wc.
Stefan Sperling [Thu, 9 May 2013 13:09:42 +0000 (9 13:09 +0000)]
Simplify some conflict resolution code in libsvn_wc.

Remove the resolve_conflict_on_node() helper function, which was a thin
wrapper around three other functions for resolving text, prop, and tree
conflicts. Which of the other functions was called could be controlled
by the caller with a set of boolean parameters. Because every caller was
setting only one of these boolean parameters, the case where multiple
wrapped functions are called never occurred. So the abstraction provided
by resolve_conflict_on_node() is not necessary.

Adjust all callers of resolve_conflict_on_node() to call the appropriate
text/prop/tree function directly. This will also make it easier in the future
to add specific functionality to resolution of text, prop, or tree conflicts,
without having to pass data through the resolve_conflict_on_node() wrapper.

No functional change.

* subversion/libsvn_wc/conflicts.c
  (resolve_text_conflict_on_node,
   resolve_prop_conflict_on_node,
   resolve_tree_conflict_on_node): Merge code from resolve_conflict_on_node()
    into these functions, and adjust their interfaces so that former callers
    of resolve_conflict_on_node() can easily make use of these functions.
  (resolve_conflict_on_node): Remove.
  (svn_wc__mark_resolved_text_conflict,
   svn_wc__mark_resolved_prop_conflicts,
   conflict_status_walker): Switch callers from resolve_conflict_on_node()
    to the more specific functions, as appropriate.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480616 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* CHANGES: typo
Stefan Sperling [Thu, 9 May 2013 11:48:20 +0000 (9 11:48 +0000)]
* CHANGES: typo

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480596 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* CHANGES: add missing changes identified by reviewing the first batch
Stefan Fuhrmann [Thu, 9 May 2013 11:26:05 +0000 (9 11:26 +0000)]
* CHANGES: add missing changes identified by reviewing the first batch
  (r1157389) from http://wiki.apache.org/subversion/Svn18Change

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480592 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* CHANGES: add my larger FSFS and svnserve related items
Stefan Fuhrmann [Thu, 9 May 2013 10:54:24 +0000 (9 10:54 +0000)]
* CHANGES: add my larger FSFS and svnserve related items

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480588 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* subversion/libsvn_wc/diff_editor.c
Julian Foad [Wed, 8 May 2013 21:57:44 +0000 (8 21:57 +0000)]
* subversion/libsvn_wc/diff_editor.c
  (wrap_dir_added): Correct the order of two unused parameters, to prevent
    future confusion.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480479 13f79535-47bb-0310-9956-ffa450edef68

9 years agoFallout from the wc-collate-branch merge.
Branko Cibej [Wed, 8 May 2013 21:01:01 +0000 (8 21:01 +0000)]
Fallout from the wc-collate-branch merge.
  - Rename the utf8proc .c files to .c.inline to prevent them from
    being built out-of-line on Winodws. This is a temporary measure
    until the windows project file generator is fixed.
  - Fixed crashes in utf-test.

* subversion/libsvn_subr/utf8proc/utf8proc_data.c.inline:
   Renamed from utf8proc_data.c
* subversion/libsvn_subr/utf8proc/utf8proc.c:
   Renamed from utf8proc.c, and updated the _data include.
* build.conf (private-includes): Update with the above changes.

* subversion/libsvn_subr/utf8proc.c: Update utf8proc.c.inline include.
  (encode_ucs4_string, svn_utf__glob): Ensure that membufs have enough
   space when appending data to them.
* subversion/tests/libsvn_subr/utf-test.c
  (test_utf_collated_compare, test_utf_pattern_match): Actually conform
   to the svn_utf__normcomp and svn_utf__glob prototypes.
  (test_funcs): Fix docstring of test_utf_pattern_match.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480456 13f79535-47bb-0310-9956-ffa450edef68

9 years agoFollow-up to r1442063: Fix broken ruby bindings build on Windows.
Paul Burba [Wed, 8 May 2013 20:35:42 +0000 (8 20:35 +0000)]
Follow-up to r1442063: Fix broken ruby bindings build on Windows.

r1442063 turned the Windows compiler warning C4204 "nonstandard extension
used : non-constant aggregate initializer" into an error.  The Ruby bindings
uses a few such offending initializers and thus needs some minor tweaks to
be build again.

* subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c
  (rb_set_pool_if_swig_type_object,
   r2c_hash,
   invoke_callback): Declare and initialize arrays/structs in separate
   statements.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480442 13f79535-47bb-0310-9956-ffa450edef68

9 years agoClarify doc strings.
Julian Foad [Wed, 8 May 2013 19:51:37 +0000 (8 19:51 +0000)]
Clarify doc strings.

* subversion/include/svn_io.h
  (svn_io_open_uniquely_named): Clarify that the 'delete_when'
    parameter doesn't only have an effect when its value is 'on close',
    and that 'on pool cleanup' refers to the result pool.
  (svn_io_open_unique_file3,
   svn_stream_open_unique): Clarify that 'delete on pool cleanup'
    refers to the result pool.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480426 13f79535-47bb-0310-9956-ffa450edef68

9 years agoFix a dormant pool usage bug that I introduced in r1149264 and
Julian Foad [Wed, 8 May 2013 19:27:35 +0000 (8 19:27 +0000)]
Fix a dormant pool usage bug that I introduced in r1149264 and
partially fixed in r1159672. The current callers were all safe.

* subversion/libsvn_client/repos_diff.c
  (get_file_from_ra): Allocate the checksum result in 'fb->pool', not in
    'scratch_pool'.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480416 13f79535-47bb-0310-9956-ffa450edef68

9 years agoChange functions merged from the wc-collate-branch to our
Branko Cibej [Wed, 8 May 2013 19:08:14 +0000 (8 19:08 +0000)]
Change functions merged from the wc-collate-branch to our
customary output-parameters-first style.

* subversion/include/private/svn_utf_private.h
  (svn_utf__normcmp, svn_utf__glob): Here.
* subversion/libsvn_subr/utf8proc.c
  (decompose_normalized, svn_utf__normcmp, svn_utf__glob): And here.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480413 13f79535-47bb-0310-9956-ffa450edef68

9 years agoRuby 1.9 compatibility fix.
Paul Burba [Wed, 8 May 2013 19:07:44 +0000 (8 19:07 +0000)]
Ruby 1.9 compatibility fix.

* subversion/bindings/swig/ruby/test/util.rb
  (util.rb): Explicitly state that the cwd should be searched
   when requiring "svn/util".  Ruby 1.9 no longer includes the cwd in the
   load path.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480412 13f79535-47bb-0310-9956-ffa450edef68

9 years agoReintegrate wc-collate-path branch to trunk.
Branko Cibej [Wed, 8 May 2013 18:56:18 +0000 (8 18:56 +0000)]
Reintegrate wc-collate-path branch to trunk.

* subversion/libsvn_subr/sqlite.c: Protect changes related to working copy
  database functionality with #ifdef SVN_UNICODE_NORMALIZATION_FIXES.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480406 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* tools/dev/buildbot/slaves/bb-openbsd/svncheck.sh: Run RA-local tests only.
Stefan Sperling [Wed, 8 May 2013 18:28:09 +0000 (8 18:28 +0000)]
* tools/dev/buildbot/slaves/bb-openbsd/svncheck.sh: Run RA-local tests only.
   Perhaps this will fix the constant backlog this bot is suffering from.
   It keeps building very outdated revisions and is thus rather useless.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480393 13f79535-47bb-0310-9956-ffa450edef68

9 years agoProperly detect Ruby 1.9 on Windows.
Paul Burba [Wed, 8 May 2013 16:40:36 +0000 (8 16:40 +0000)]
Properly detect Ruby 1.9 on Windows.

* build/generator/gen_win.py:
  (WinGeneratorBase._find_ruby): Pass the -W0 option to ruby.exe to stifle
   the warning about Config being deprecated and that RbConfig should be
   used.  Ruby just uses RbConfig anyway.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480344 13f79535-47bb-0310-9956-ffa450edef68

9 years agoSync wc-collate-path branch with trunk up to r1480292.wc-collate-pathwc-collate-path
Branko Cibej [Wed, 8 May 2013 14:34:57 +0000 (8 14:34 +0000)]
Sync wc-collate-path branch with trunk up to r1480292.

git-svn-id: https://svn.apache.org/repos/asf/subversion/branches/wc-collate-path@1480294 13f79535-47bb-0310-9956-ffa450edef68

9 years agoWork around a problem on older OS X systems: sqlite3.c includes
Branko Cibej [Wed, 8 May 2013 01:52:16 +0000 (8 01:52 +0000)]
Work around a problem on older OS X systems: sqlite3.c includes
<libkern/OSAtomic.h>, which uses 'inline' and thus cannot be compiled
with -std=c89 that we are using for all files.

* subversion/libsvn_subr/sqlite3wrapper.c
  (toplevel): Define 'inline' as '__inline__' (which gcc accepts even in c89
   mode) during a pre-emptive inclusion of <libkern/OSAtomic.h>.
* subversion/tests/libsvn_wc/wc-queries-test.c
  (toplevel): Likewise.

Patch by: mattiase

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480149 13f79535-47bb-0310-9956-ffa450edef68

9 years agoFix swig perl bindings on Windows.
Ben Reser [Tue, 7 May 2013 22:15:52 +0000 (7 22:15 +0000)]
Fix swig perl bindings on Windows.

* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c
  (svn_swig_pl_array_to_apr_array_revision_range): Include a return to avoid
    Visual Studio erroring out saying that some code paths the function doesn't
    return a value.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480119 13f79535-47bb-0310-9956-ffa450edef68

9 years agoSpell-check translated error messages.
Daniel Shahaf [Tue, 7 May 2013 21:13:09 +0000 (7 21:13 +0000)]
Spell-check translated error messages.

* subversion/include/svn_error_codes.h
  SVN_ERR_NO_APR_MEMCACHE):
* subversion/libsvn_client/add.c
  (mkdir_urls):
* subversion/libsvn_client/merge.c
  (check_repos_match, get_wc_explicit_mergeinfo_catalog, do_file_merge):
* subversion/libsvn_client/ra.c
  (push_wc_prop):
* subversion/libsvn_ra_serf/serf.c
  (load_http_auth_types):
    Copyedit some error strings.

* subversion/libsvn_subr/cache-membuffer.c
  (svn_cache__membuffer_cache_create):
    Don't try to translate the string "OOM".

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480082 13f79535-47bb-0310-9956-ffa450edef68

9 years agoLatest clang does not emit errors about unknown warning options,
Branko Cibej [Tue, 7 May 2013 21:11:27 +0000 (7 21:11 +0000)]
Latest clang does not emit errors about unknown warning options,
but it does spam the compile output with warnings. Silence those
warnings.

* build/ac-macros/compiler.m4
  (SVN_CC_MODE_SETUP): Add -Wno-unknown-warning-option to default C flags.
  (SVN_CXX_MODE_SETUP): Likewise for default C++ flags.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480080 13f79535-47bb-0310-9956-ffa450edef68

9 years agoCheck compiler flags one at a time, otherwise one unsupported flag can
Branko Cibej [Tue, 7 May 2013 21:07:35 +0000 (7 21:07 +0000)]
Check compiler flags one at a time, otherwise one unsupported flag can
invalidate others that are supported.

* configure.ac (--enable-optimization): Issue separate checks for
   -Wno-clobbered and -flto because SVN_CFLAGS_ADD_IFELSE does
   not treat its parameter as a list of options.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480077 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* subversion/po/sv.po: Typo fixed in msgid.
Mattias Engdegard [Tue, 7 May 2013 20:31:19 +0000 (7 20:31 +0000)]
* subversion/po/sv.po: Typo fixed in msgid.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480062 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* subversion/svnmucc/svnmucc.c: Fix typo in help text.
Mattias Engdegard [Tue, 7 May 2013 20:00:50 +0000 (7 20:00 +0000)]
* subversion/svnmucc/svnmucc.c: Fix typo in help text.

Approved by: danielsh

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480054 13f79535-47bb-0310-9956-ffa450edef68

9 years agoFix some build issues with support projects failing due to shared intermediate
Ben Reser [Tue, 7 May 2013 18:37:21 +0000 (7 18:37 +0000)]
Fix some build issues with support projects failing due to shared intermediate
build directories.

* tools/dev/build-svn-deps-win.pl:
  (build_openssl): Remove some tabs on some comment lines.
  (build_httpd): Use a different backup dir for disabling the
    manifest for ApacheMonitor project so it does not conflict
    with the TrackFileAccess change.  Add the support directory
    to the list of directories that we disable file access tracking
    on.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1480009 13f79535-47bb-0310-9956-ffa450edef68

9 years agoSync wc-collate-path branch with trunk up to r1479898.
Branko Cibej [Tue, 7 May 2013 13:26:25 +0000 (7 13:26 +0000)]
Sync wc-collate-path branch with trunk up to r1479898.

git-svn-id: https://svn.apache.org/repos/asf/subversion/branches/wc-collate-path@1479901 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* subversion/svnlook/svnlook.c
Stefan Sperling [Tue, 7 May 2013 13:16:39 +0000 (7 13:16 +0000)]
* subversion/svnlook/svnlook.c
  (print_tree): Sort directory entries to provide stable output even with
    unstable APR hash order.

Found by: Ursula Schädel

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1479896 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* tools/dev/build-svn-deps-win.pl: Bump ZLIB version to 1.2.8
Ben Reser [Mon, 6 May 2013 23:33:12 +0000 (6 23:33 +0000)]
* tools/dev/build-svn-deps-win.pl: Bump ZLIB version to 1.2.8

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1479723 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* subversion/po/sv.po: Update Project-Id-Version to 1.9.
Mattias Engdegard [Mon, 6 May 2013 22:18:21 +0000 (6 22:18 +0000)]
* subversion/po/sv.po: Update Project-Id-Version to 1.9.

Suggested by: danielsh

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1479700 13f79535-47bb-0310-9956-ffa450edef68

9 years agoFix an interactive conflict resolution problem triggered by r1477876.
Julian Foad [Mon, 6 May 2013 15:32:18 +0000 (6 15:32 +0000)]
Fix an interactive conflict resolution problem triggered by r1477876.

* subversion/svn/conflict-callbacks.c
  (conflict_func_interactive): Don't assume it's a text conflict
    whenever the node kind is 'file', as that could be a property
    conflict, so check that the conflict kind is 'text'.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1479605 13f79535-47bb-0310-9956-ffa450edef68

9 years agoMake svn_client_log5() callable from the Perl bindings.
Roderich Schupp [Mon, 6 May 2013 13:23:33 +0000 (6 13:23 +0000)]
Make svn_client_log5() callable from the Perl bindings.

* subversion/bindings/swig/svn_client.i:
  Make the rule for "apr_array_header_t *REVISION_RANGE_LIST" visible
  from Perl, too.

* subversion/bindings/swig/include/svn_containers.swg:
  Add an in typemap for "apr_array_header_t *REVISION_RANGE_LIST".

* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c,
  subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h:
  Add the corresponding conversion function
  svn_swig_pl_array_to_apr_array_revision_range() and its helper
  convert_pl_revision_range(). The latter needs a modified
  svn_swig_pl_set_revision() that doesn't croak() it it can't convert
  its value parameter.

* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c,
  subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h:
  Add a boolean parameter croak_on_error to svn_swig_pl_set_revision()
  (croak_on_error=TRUE gives the old behaviour). Return NULL if
  croak_on_error is FALSE and value can't be converted.

* subversion/bindings/swig/include/svn_types.swg:
  Use svn_swig_pl_set_revision() with croak_on_error=TRUE in
  the in typemap for svn_opt_revision_t.

* subversion/bindings/swig/perl/native/Client.pm:
  Add log5 to the list of functions wrapped.

* subversion/bindings/swig/perl/native/Core.pm:
  Add class magic and documentation for svn_opt_revision_range_t.
  Add documentation for svn_opt_revision_t.

* subversion/bindings/swig/perl/native/t/3client.t:
  Add tests for SVN::Client->log5() with different forms of
  the revision_ranges parameter.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1479563 13f79535-47bb-0310-9956-ffa450edef68

9 years agoAdd an in typemap for PROPHASH to the Perl bindings.
Roderich Schupp [Mon, 6 May 2013 12:16:21 +0000 (6 12:16 +0000)]
Add an in typemap for PROPHASH to the Perl bindings.

* subversion/bindings/swig/include/svn_containers.swg:
  Add the typemap.

* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c,
  subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h:
  Add the corresponding conversion function svn_swig_pl_hash_to_prophash()
  and the single-item conversion helper convert_pl_svn_string_t().

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1479540 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* tools/dev/remove-trailing-whitespace.sh: Fix typo in comment.
Daniel Shahaf [Sun, 5 May 2013 16:25:24 +0000 (5 16:25 +0000)]
* tools/dev/remove-trailing-whitespace.sh: Fix typo in comment.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1479350 13f79535-47bb-0310-9956-ffa450edef68

9 years agoUnbreak 'make clean-ctypes-python'.
Daniel Shahaf [Sun, 5 May 2013 14:27:37 +0000 (5 14:27 +0000)]
Unbreak 'make clean-ctypes-python'.

* Makefile.in
  (CTYPES_BUILD_OUTPUTS): Remove.
  (clean-ctypes-python): Hardcode its value.  This fixes some quoting issues.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1479329 13f79535-47bb-0310-9956-ffa450edef68

9 years agoSilence 'make -s clean'.
Daniel Shahaf [Sun, 5 May 2013 14:11:27 +0000 (5 14:11 +0000)]
Silence 'make -s clean'.

Since distutils spam stdout with "I'm running!" and stderr with "I can't remove
a file because it doesn't exist!", just work around them altogether and don't
clean ctypes if they hadn't been built.

* Makefile.in
  (CTYPES_BUILD_OUTPUTS): New
  (clean-ctypes-python): Only run setup.py if a built output exists.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1479326 13f79535-47bb-0310-9956-ffa450edef68

9 years agoSilence 'make -s clean'.
Daniel Shahaf [Sun, 5 May 2013 13:57:03 +0000 (5 13:57 +0000)]
Silence 'make -s clean'.

* subversion/bindings/ctypes-python/setup.py
  (clean.run): Reduce the log level for not being able to remove
    a non-existent file.  (There is a similar case in distutils itself.)

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1479323 13f79535-47bb-0310-9956-ffa450edef68

9 years agoSilence 'make -s distclean'.
Daniel Shahaf [Sun, 5 May 2013 13:47:04 +0000 (5 13:47 +0000)]
Silence 'make -s distclean'.

* Makefile.in
  (fast-clean): Don't print directory names as we go through them.  Perhaps
    this was necessary in 2001 when this code was added (r839402) to show
    we are not stalled, but the reason no longer holds today, and this reduces
    the noise in 'make -s'.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1479321 13f79535-47bb-0310-9956-ffa450edef68

9 years agoEliminate a build warning.
Daniel Shahaf [Sun, 5 May 2013 13:24:37 +0000 (5 13:24 +0000)]
Eliminate a build warning.

* Makefile.in
  (check-clean): Only find subversion/tests/cmdline/svn-test-work if it exists.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1479320 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* tools/dev/unix-build/Makefile.svn: Use 'make clean-swig' to remove
Stefan Sperling [Sun, 5 May 2013 13:15:34 +0000 (5 13:15 +0000)]
* tools/dev/unix-build/Makefile.svn: Use 'make clean-swig' to remove
   pre-generated swig files. Previously, the 'make extraclean-swig'
   target was used for this but that target was removed in r1301760.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1479319 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* subversion/po/sv.po: Fix bracketing and punctuation typos.
Mattias Engdegard [Sun, 5 May 2013 10:20:50 +0000 (5 10:20 +0000)]
* subversion/po/sv.po: Fix bracketing and punctuation typos.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1479277 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* subversion/po/sv.po: Fix bad spacing (found by Per Larsson)
Mattias Engdegard [Sun, 5 May 2013 09:31:30 +0000 (5 09:31 +0000)]
* subversion/po/sv.po: Fix bad spacing (found by Per Larsson)

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1479268 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* tools/dist/backport.pl
Daniel Shahaf [Sat, 4 May 2013 11:14:36 +0000 (4 11:14 +0000)]
* tools/dist/backport.pl
  (main): Add comments support.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1479077 13f79535-47bb-0310-9956-ffa450edef68

9 years agoUpdate the Swedish translation with new translations, updated and
Mattias Engdegard [Sat, 4 May 2013 11:10:54 +0000 (4 11:10 +0000)]
Update the Swedish translation with new translations, updated and
corrected existing strings, removal of obsolete strings, and an
updated vocabulary.

* subversion/po/sv.po: Bring translation up to date.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1479076 13f79535-47bb-0310-9956-ffa450edef68

9 years agoFix release.py create-tag command to deal with version svn_version.h.dist files.
Ben Reser [Fri, 3 May 2013 23:48:21 +0000 (3 23:48 +0000)]
Fix release.py create-tag command to deal with version svn_version.h.dist files.

Follow up to r1464654 apparently missed this case.

* tools/dist/release.py:
  (create_tag): Add the version number to the source of the svn_version.h
    file name.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1479012 13f79535-47bb-0310-9956-ffa450edef68

9 years agoSimplify some log code. A follow-up to r1478220.
Julian Foad [Fri, 3 May 2013 22:46:42 +0000 (3 22:46 +0000)]
Simplify some log code.  A follow-up to r1478220.

* subversion/libsvn_client/log.c
  (resolve_wc_opt_revs,
   resolve_wc_head_revs,
   resolve_wc_date_revs): Delete.
  (convert_opt_rev_array_to_rev_range_array): Remove the RA session outputs
    and instead take an existing session as input. Resolve revision numbers
    by calling svn_client__get_revision_number() directly instead of using
    the functions mentioned above.
  (svn_client_log5): Always open an RA session before calling
    convert_opt_rev_array_to_rev_range_array(), instead of possibly opening
    a session afterwards or not depending on what that function did.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1478998 13f79535-47bb-0310-9956-ffa450edef68

9 years agoA small bit of issue #4351 'improve automatic merge performance' work: Avoid
Paul Burba [Fri, 3 May 2013 21:50:52 +0000 (3 21:50 +0000)]
A small bit of issue #4351 'improve automatic merge performance' work: Avoid
one to two network roundtrips to get the *same* mergeinfo catalogs while
calculating automatic merges.

* subversion/include/private/svn_client_private.h

  (svn_client__mergeinfo_log): New, wrapper around
   svn_client_mergeinfo_log2().

* subversion/libsvn_client/merge.c

  (short_circuit_mergeinfo_log): Wrap svn_client__mergeinfo_log instead of
   svn_client_mergeinfo_log2 (yes, it's a wrapper of a wrapper).  Add a
   in/out parameter for the target's mergeinfo catalog.

  (find_last_merged_location): Update calls to short_circuit_mergeinfo_log().
   On the first call, let the callee get the target's mergeinfo catalog.  On
   the second call, pass the callee the target's mergeinfo catalog, thus
   preventing it from asking the repository the same question twice.

* subversion/libsvn_client/mergeinfo.c

  (svn_client__mergeinfo_log): New, but mostly the old implementation of
   svn_client_mergeinfo_log2().

  (svn_client_mergeinfo_log2): Now just a wrapper around
   svn_client__mergeinfo_log().

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1478987 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* get-deps.sh: Add a comment encouraging modifiers to keep the file portable.
Ben Reser [Fri, 3 May 2013 19:55:27 +0000 (3 19:55 +0000)]
* get-deps.sh: Add a comment encouraging modifiers to keep the file portable.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1478951 13f79535-47bb-0310-9956-ffa450edef68

9 years agoBump tool versions for 1.8.x and trunk to the current stable versions.
Ben Reser [Fri, 3 May 2013 19:38:27 +0000 (3 19:38 +0000)]
Bump tool versions for 1.8.x and trunk to the current stable versions.

* tools/dist/release.py:
  (tool_versions): For trunk and 1.8 bump autoconf to 2.69, libtool to 2.4.2,
    and swig to 2.0.9.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1478948 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* CHANGES
C. Michael Pilato [Fri, 3 May 2013 18:22:47 +0000 (3 18:22 +0000)]
* CHANGES
  De-capitalize an entry.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1478898 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* CHANGES
C. Michael Pilato [Fri, 3 May 2013 18:22:21 +0000 (3 18:22 +0000)]
* CHANGES
  De-capitalize an entry.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1478897 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* subversion/include/svn_config.h
C. Michael Pilato [Fri, 3 May 2013 17:06:06 +0000 (3 17:06 +0000)]
* subversion/include/svn_config.h
  (SVN_CONFIG_OPTION_DIFF_IGNORE_CONTENT_TYPE): Move to the right vertical
    location in the file.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1478873 13f79535-47bb-0310-9956-ffa450edef68

9 years agoImplement a new 'diff-ignore-content-type' runtime configuration
C. Michael Pilato [Fri, 3 May 2013 14:55:55 +0000 (3 14:55 +0000)]
Implement a new 'diff-ignore-content-type' runtime configuration
variable which saves folks from having to include --force when trying
to see differences of binary files.  This is handy when Subversion is
configured via 'diff-cmd' to use an external diff tool that can handle
binary diffs.

NOTE: This option is parsed in 'svn' (not down in the client layer)
      and used to control an existing boolean function parameter.

* subversion/include/svn_config.h
  (SVN_CONFIG_OPTION_DIFF_IGNORE_CONTENT_TYPE): New configuration
    token #define.

* subversion/svn/diff-cmd.c
  (svn_cl__diff): Check the runtime configuration area to see if diff
    operations should ignore the content-type of files.

* subversion/libsvn_subr/config_file.c
  (svn_config_ensure): Add runtime configuration file template matter
    for the new 'diff-ignore-content-type' option.

* subversion/tests/cmdline/diff_tests.py
  (diff_force): Tweak this test to try the new runtime config option
    as well as '--force', verifying that both allow the display of
    binary diffs.

* CHANGES
  Note this change.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1478826 13f79535-47bb-0310-9956-ffa450edef68

9 years agoFix a copy-pasted docstring.
Daniel Shahaf [Fri, 3 May 2013 00:08:51 +0000 (3 00:08 +0000)]
Fix a copy-pasted docstring.

* subversion/include/svn_repos.h
  (svn_repos_notify_t.warning): Remove a sentence that doesnt make sense for
    an enum- (rather than svn_error_t *) typed member.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1478617 13f79535-47bb-0310-9956-ffa450edef68

9 years agoUnbreak the build.
Daniel Shahaf [Thu, 2 May 2013 23:36:33 +0000 (2 23:36 +0000)]
Unbreak the build.

* build/generator/gen_base.py
  (write_errno_table): Change an assertion that doesn't hold on the buildbot to
    an informative message.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1478608 13f79535-47bb-0310-9956-ffa450edef68

9 years agoSupport symbolic names for APR error codes, too.
Daniel Shahaf [Thu, 2 May 2013 23:30:02 +0000 (2 23:30 +0000)]
Support symbolic names for APR error codes, too.

* build/generator/gen_base.py
  (GeneratorBase.write_errno_codes): Parse aprerr.txt into errorcode.inc.

* subversion/libsvn_subr/error.c
  (svn_error_symbolic_name): Use svn__apr_errno (from errorcode.inc).

* tools/dev/which-error.py
  (get_errors): Add a cross-reference comment.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1478606 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* tools/dev/aprerr.txt: Add a comment describing purpose of this file.
Daniel Shahaf [Thu, 2 May 2013 23:00:28 +0000 (2 23:00 +0000)]
* tools/dev/aprerr.txt: Add a comment describing purpose of this file.

* tools/dev/which-error.py
  (get_errors): Ignore that comment when parsing.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1478597 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* subversion/po/sv.po: run po-update in anticipation of an update.
Mattias Engdegard [Thu, 2 May 2013 21:37:19 +0000 (2 21:37 +0000)]
* subversion/po/sv.po: run po-update in anticipation of an update.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1478574 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* COMMITTERS: Add myself as a sv.po translator.
Mattias Engdegard [Thu, 2 May 2013 20:48:10 +0000 (2 20:48 +0000)]
* COMMITTERS: Add myself as a sv.po translator.

Approved by: cmpilato, breser

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1478526 13f79535-47bb-0310-9956-ffa450edef68

9 years agoRemove a dead initialization, followup to r1478220.
Ben Reser [Thu, 2 May 2013 18:03:39 +0000 (2 18:03 +0000)]
Remove a dead initialization, followup to r1478220.

* subversion/libsvn_client/log.c
  (run_ra_get_log): Move segment_url into the only block it is used and remove
    an initialization that never gets used.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1478465 13f79535-47bb-0310-9956-ffa450edef68

9 years agoFollow-up to issue #4355 'svn_client_log5 broken with multiple revisions
Paul Burba [Wed, 1 May 2013 22:36:55 +0000 (1 22:36 +0000)]
Follow-up to issue #4355 'svn_client_log5 broken with multiple revisions
which span a rename' fix in r1478220 -- remove some cruft.

* subversion/libsvn_client/log.c

  (resolve_wc_opt_revs): Remove a stray bit of commented debugging code.

  (svn_client_log5): Remove an unused local variable.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1478221 13f79535-47bb-0310-9956-ffa450edef68

9 years agoFix (hopefully for the last time) issue #4355 'svn_client_log5 broken with
Paul Burba [Wed, 1 May 2013 22:27:31 +0000 (1 22:27 +0000)]
Fix (hopefully for the last time) issue #4355 'svn_client_log5 broken with
multiple revisions which span a rename' and refactor the aforementioned
API, which was a bit of an unwieldy beast.

* subversion/include/private/svn_client_private.h

  (svn_client__resolve_rev_and_url): "New", but actually just the old
   libsvn_client/ra.c:resolve_rev_and_url().

* subversion/libsvn_client/log.c

  (assert.h): New include.

  (resolve_log_targets,
   find_youngest_and_oldest_revs,
   resolve_wc_opt_revs,
   resolve_wc_head_revs,
   resolve_wc_date_revs,
   rev_range_t,
   convert_opt_rev_array_to_rev_range_array,
   compare_rev_to_segment,
   run_ra_get_log): New.

  (svn_client_log5): Refactor this into the new helpers above.  Beyond the
   simple refactoring, this function now uses
   svn_client__repos_location_segments() to get the history spanning the
   requested log revisions and then uses this history to handle issue #4355.
   Credit cmpilato and rhhijben with this idea, see
   http://svn.haxx.se/dev/archive-2013-04/0474.shtml

* subversion/libsvn_client/ra.c

  (resolve_rev_and_url): Convert from static to svn_client private function,
   renaming from this to...

  (svn_client__resolve_rev_and_url): ...this.

* subversion/tests/cmdline/authz_tests.py

  (authz_log_and_tracing_test): Tweak expected error to account for new
   svn_client_log5 implementation.

* subversion/tests/cmdline/log_tests.py

  (log_multiple_revs_spanning_rename): Remove XFail decorator.  Tweak
   comments re failure status.  Add a required 'svn update' for testing
   log with WC target.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1478220 13f79535-47bb-0310-9956-ffa450edef68

9 years agoAdd a test for correct retrieval of property conflict descriptions. This
Julian Foad [Wed, 1 May 2013 13:55:31 +0000 (1 13:55 +0000)]
Add a test for correct retrieval of property conflict descriptions.  This
catches the node-kind bug that was fixed in r1477876.

* subversion/tests/libsvn_wc/conflict-data-test.c
  (compare_file_content,
   compare_prop_conflict,
   test_prop_conflict_baton_t,
   create_prop_conflict_skel,
   prop_conflict_cb): New
  (test_prop_conflicts): New test.
  (test_funcs): Run it.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1478001 13f79535-47bb-0310-9956-ffa450edef68

9 years agoTidy some test code, prior to extending it.
Julian Foad [Wed, 1 May 2013 00:49:24 +0000 (1 00:49 +0000)]
Tidy some test code, prior to extending it.

* subversion/tests/libsvn_wc/conflict-data-test.c
  (ASSERT_INT_EQ, ASSERT_STR_EQ): New macros; the first one gives much more
    useful debug output when it fails than a simple assert(a == b) does.
  (compare_version, compare_conflict): Swap the 'actual' and 'expected'
    arguments to match the way SVN_TEST_STRING_ASSERT has them ('actual'
    first), so that error messages from SVN_TEST_STRING_ASSERT make sense.
    Use the new macros.
  (test_read_write_tree_conflicts): Adjust callers.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1477891 13f79535-47bb-0310-9956-ffa450edef68

9 years agoFix a bug whereby a property conflict description always reported 'unknown'
Julian Foad [Tue, 30 Apr 2013 23:39:52 +0000 (30 23:39 +0000)]
Fix a bug whereby a property conflict description always reported 'unknown'
for the node kind.  This was a regression from 1.7.  This was not visible
from the command-line client.

* subversion/libsvn_wc/conflicts.c
  (read_prop_conflict_descs): Take the node kind as a parameter and use it
    it instead of setting the field to 'unknown'.
  (svn_wc__read_conflicts): Pass the node kind for a property conflict, when
    possible.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1477876 13f79535-47bb-0310-9956-ffa450edef68

9 years agoFactor out some conflict description code. No functional change.
Julian Foad [Tue, 30 Apr 2013 21:42:08 +0000 (30 21:42 +0000)]
Factor out some conflict description code. No functional change.

* subversion/libsvn_wc/conflicts.c
  (resolve_text_conflict): Don't create create a conflict description here,
    take it as a parameter instead.
  (read_text_conflict_desc): New function, factored out of two places.
  (read_tree_conflict_desc): Renamed from 'setup_tree_conflict_desc'. Take
    the conflict skel and parse two parameters from it, so the two callers
    don't have to.
  (read_prop_conflict_descs): Renamed from 'read_prop_conflicts' for
    consistency.
  (svn_wc__conflict_invoke_resolver): Simplify by using the refactored code.
  (svn_wc__read_conflicts): Simplify by using the refactored code, and track
    the rename.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1477845 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* subversion/libsvn_wc/conflicts.c
Julian Foad [Tue, 30 Apr 2013 21:38:58 +0000 (30 21:38 +0000)]
* subversion/libsvn_wc/conflicts.c
  (svn_wc__conflict_invoke_resolver): Destroy the iterpool after use, to
    conform to our normal pattern.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1477843 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* get-deps.sh
Ben Reser [Tue, 30 Apr 2013 17:24:11 +0000 (30 17:24 +0000)]
* get-deps.sh
  (ZLIB):  Update zlib version number.
  (get_zlib): Modify tar command and file extension.

Patch by: Gabriela Gibson <gabriela.gibson{_AT_}gmail.com>
(modified by breser to not use GNU tar options)

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1477730 13f79535-47bb-0310-9956-ffa450edef68

9 years ago* get-deps.sh: Set svn:eol-style property to native.
Ben Reser [Tue, 30 Apr 2013 17:18:10 +0000 (30 17:18 +0000)]
* get-deps.sh: Set svn:eol-style property to native.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1477729 13f79535-47bb-0310-9956-ffa450edef68

9 years agoIn the fsfsfixer contrib script, tweak the usage message and and error
Julian Foad [Tue, 30 Apr 2013 16:47:23 +0000 (30 16:47 +0000)]
In the fsfsfixer contrib script, tweak the usage message and and error
message for clarity.

* contrib/server-side/fsfsfixer/fixer/fix-rev.py
  (fix_one_error): Clarify that the real problem is the script doesn't
    recognize the error message.

* contrib/server-side/fsfsfixer/fix-repo
  (USAGE): Clarify.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1477721 13f79535-47bb-0310-9956-ffa450edef68

9 years agoIn the 'fsfsfixer' script, change the default configuration from 'not
Julian Foad [Tue, 30 Apr 2013 16:30:20 +0000 (30 16:30 +0000)]
In the 'fsfsfixer' script, change the default configuration from 'not
sharded' to 'sharded 1000', to match virtually all real repositories.

* contrib/server-side/fsfsfixer/fixer/find_good_id.py
  Remove the sharding config from here, and import settings from
  'fixer_config.py' instead, to keep all of the user settings together.

* contrib/server-side/fsfsfixer/fixer/fixer_config.py
  Add a 'REVS_PER_SHARD' configuration setting here, set to 1000.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1477715 13f79535-47bb-0310-9956-ffa450edef68

9 years agoClarify the doxygen documentation for the semantics of the @a sep_chars
Gabriela Gibson [Tue, 30 Apr 2013 14:02:29 +0000 (30 14:02 +0000)]
Clarify the doxygen documentation for the semantics of the @a sep_chars
parameter.

* subversion/include/svn_string.h
  (svn_cstring_split): Clarify doxygen comment.

Suggested by: danielsh
Approved by: danielsh

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1477635 13f79535-47bb-0310-9956-ffa450edef68

9 years agoCherry-pick merge r458643 from branches/cache-server to /trunk
Stefan Fuhrmann [Tue, 30 Apr 2013 10:34:26 +0000 (30 10:34 +0000)]
Cherry-pick merge r458643 from branches/cache-server to /trunk
(this accidentally didn't get included into the r1476664 merge).

Not intended for 1.8 back-port.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1477540 13f79535-47bb-0310-9956-ffa450edef68

9 years agoNote a limitation of a maintainer-mode feature.
Daniel Shahaf [Mon, 29 Apr 2013 22:37:26 +0000 (29 22:37 +0000)]
Note a limitation of a maintainer-mode feature.

* build/generator/gen_base.py
  (GeneratorBase.write_errno_table): Add comment pointing out a limitation.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1477393 13f79535-47bb-0310-9956-ffa450edef68

9 years agoRemove a generated file.
Daniel Shahaf [Mon, 29 Apr 2013 22:32:36 +0000 (29 22:32 +0000)]
Remove a generated file.

* build/generator/templates/build-outputs.mk.ezt
  (EXTRACLEAN_FILES): Remove errorcode.inc, generated by gen_base.py.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1477386 13f79535-47bb-0310-9956-ffa450edef68

9 years agoFollowup to r14613282:
Daniel Shahaf [Mon, 29 Apr 2013 21:44:50 +0000 (29 21:44 +0000)]
Followup to r14613282:

* subversion/libsvn_wc/props.c
  (validate_eol_prop_against_file): Cater for translation extractor limitations.

Suggested by: mattiase

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1477359 13f79535-47bb-0310-9956-ffa450edef68

9 years agoFactor out some repeated code.
Julian Foad [Mon, 29 Apr 2013 19:43:37 +0000 (29 19:43 +0000)]
Factor out some repeated code.

* subversion/libsvn_wc/conflicts.c
  (remove_artifact_file_if_exists): New function, factored out ...
  (resolve_text_conflict_on_node,
   resolve_prop_conflict_on_node): ... from here.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1477294 13f79535-47bb-0310-9956-ffa450edef68

9 years agoUpdate WIN32 code following r1475772
Philip Martin [Mon, 29 Apr 2013 13:35:28 +0000 (29 13:35 +0000)]
Update WIN32 code following r1475772

* subversion/libsvn_subr/config.c
  (read_all): Call non-deprecated function.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1477056 13f79535-47bb-0310-9956-ffa450edef68