From 6929b259b8ec11031d67b9cbe9f4dc8833700f19 Mon Sep 17 00:00:00 2001
From: Anthony Parsons <ant@specialops.ath.cx>
Date: Tue, 8 Nov 2005 20:37:48 +0000
Subject: [PATCH] HTML optimised: usernames are only linked first time they're
 shown on the page.

---
 index.php              | 24 +++++++++++++-----------
 lib/class.anonuser.php | 22 +++++++++++++++-------
 lib/class.authuser.php | 20 ++++++++++++++++----
 3 files changed, 44 insertions(+), 22 deletions(-)

diff --git a/index.php b/index.php
index e0bcd0a..e38768a 100644
--- a/index.php
+++ b/index.php
@@ -19,12 +19,18 @@ switch ( $user->boardlist_layout ) {
 
 $list = $DB->query('SELECT `userid`, `alias` FROM `users`
 					WHERE `last_active_date` > UNIX_TIMESTAMP() - 600
-					ORDER BY `alias` ASC');
-$count = $list->num_rows;
+					ORDER BY `last_active_date` ASC LIMIT 30');
+
+if ( 30 == $list->num_rows )
+	list($count) = $DB->query('SELECT COUNT(*) FROM `users`
+						   WHERE `last_active_date` > UNIX_TIMESTAMP() - 600')->fetch_row();
+else
+	$count = $list->num_rows;
+
 
 $onlinestring = ( $count == 1 ?
-				'There is <a href="userlist?show=online">%d user online</a>' :
-				'There are <a href="userlist?show=online">%d users online</a>' );
+				'There is <a href="userlist?show=online">%d user online</a>: ' :
+				'There are <a href="userlist?show=online">%d users online</a>: ' );
 ?>
 
 <h2 id="boardlist-stats">Statistics</h2>
@@ -32,14 +38,10 @@ $onlinestring = ( $count == 1 ?
 <ul class="content" id="boardlist-foot">
 	<li><?php printf($onlinestring, $count);
 
-if ( $count < 30 && $count > 0 ) {
-	list($id, $n) = $list->fetch_row();
-	echo ': ',$user->namelink($id, $n);
-
-	while ( list($id, $n) = $list->fetch_row() )
-		echo ', ',$user->namelink($id, $n);
+if ( $count > 0 ) {
+	$list = $user->fillnamecache($list);
+	echo implode(', ', $list);
 }
-else echo '.';
 
 echo
 	'</li>
diff --git a/lib/class.anonuser.php b/lib/class.anonuser.php
index 53d4448..ad86565 100644
--- a/lib/class.anonuser.php
+++ b/lib/class.anonuser.php
@@ -36,7 +36,7 @@ class anonuser
 		if ( array_key_exists($varname, $this->attrcache) ) {
 			return $this->attrcache[$varname];
 		} else
-			throw new OutOfBoundsException('Error in $user->_get('.$varname.'): attribute not available.');
+			throw new OutOfBoundsException('Error in user->__get('.$varname.'): attribute not available.');
 	}
 
 	function userheader()
@@ -49,6 +49,7 @@ class anonuser
 			foreach ( $this->userlinks as $text => $href )
 				echo '	<li><a href="',$href,'">',$text,"</a></li>\n";
 			echo "</ul>\n";
+
 			$GLOBALS['page']->headers |= page::Userheader;
 		}
 	}
@@ -57,12 +58,19 @@ class anonuser
 	{
 		if ( empty($this->namecache[$id]) ) {
 			if ( $name === null )
-				$this->namecache[$id] = $GLOBALS['DB']->query('SELECT `alias` FROM `users` WHERE `userid` = '.$id)
-													  ->fetch_object()->alias;
-			else
-				$this->namecache[$id] = $name;
-		}
-		return $this->namecache[$id];
+				list($name) = $GLOBALS['DB']->query('SELECT `alias` FROM `users`
+													 WHERE `userid` = '.$id)->fetch_row();
+
+			return ($this->namecache[$id] = $name);
+		} else
+			return $this->namecache[$id];
+	}
+
+	function fillnamecache(mysqli_result $rows)
+	{
+		while ( list($a, $b) = $rows->fetch_row() )
+			$this->namecache[$a] = $c[$a] = $b;
+		return $c;
 	}
 
 	function fdate($timestamp)
diff --git a/lib/class.authuser.php b/lib/class.authuser.php
index 82e2af9..6665cdc 100644
--- a/lib/class.authuser.php
+++ b/lib/class.authuser.php
@@ -117,12 +117,24 @@ class authuser extends reguser
 	{
 		if ( empty($this->namecache[$id]) ) {
 			if ( $name === null )
-				list($this->namecache[$id]) = $GLOBALS['DB']->query('SELECT `alias` FROM `users`
-																	 WHERE `userid` = '.$id)->fetch_row();
+				list($name) = $GLOBALS['DB']->query('SELECT `alias` FROM `users`
+													 WHERE `userid` = '.$id)->fetch_row();
+
+			$this->namecache[$id] = $name;
+			return sprintf('<a id="u%d" href="user?id=%1$d">%2$s</a>', $id, $name);
+		} else
+			return $this->namecache[$id];
+	}
+
+	function fillnamecache(mysqli_result $rows)
+	{
+		while ( list($a, $b) = $rows->fetch_row() ) {
+			if ( empty($this->namecache[$a]) )
+				($this->namecache[$a] = $b) && $c[$a] = sprintf('<a id="u%d" href="user?id=%1$d">%2$s</a>', $a, $b);
 			else
-				$this->namecache[$id] = $name;
+				$c[$a] = $this->namecache[$a];
 		}
-		return '<a href="user?id='.$id.'">'.$this->namecache[$id].'</a>';
+		return $c;
 	}
 
 	// timrod sucks cats
-- 
2.11.4.GIT