From f4a04cd3a9af6e97c8e5292a0956abecb0c47d4d Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Wed, 25 Feb 2009 08:54:50 +0300 Subject: [PATCH] remove unneeded calls to __use_cond_true_states(); set_true_false_state() already sets the cur_states to the true state. Signed-off-by: Dan Carpenter --- smatch_conditions.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/smatch_conditions.c b/smatch_conditions.c index eac650b2..327785f3 100644 --- a/smatch_conditions.c +++ b/smatch_conditions.c @@ -158,11 +158,8 @@ static void handle_logical(struct expression *expr) split_conditions(expr->left); - if (is_logical_and(expr)) { - __use_cond_true_states(); - } else { + if (!is_logical_and(expr)) __use_cond_false_states(); - } __save_pre_cond_states(); __push_cond_stacks(); @@ -194,7 +191,6 @@ static void handle_select(struct expression *expr) split_conditions(expr->conditional); __save_false_states_for_later(); - __use_cond_true_states(); if (known_condition_true(expr->cond_true)) { __split_expr(expr->cond_true); @@ -206,7 +202,6 @@ static void handle_select(struct expression *expr) if (known_condition_false(expr->cond_false)) { __pop_pre_cond_states(); - __use_cond_true_states(); return; } -- 2.11.4.GIT