From c8f7453339058d94135783a4ee7983076d96c3aa Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Wed, 7 May 2014 16:06:58 +0300 Subject: [PATCH] rosenberg: refactor match_copy_to_user() I will use this function differently in later patches so it needs a refactor. Signed-off-by: Dan Carpenter --- check_rosenberg.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/check_rosenberg.c b/check_rosenberg.c index a801d24b..3e5a3a98 100644 --- a/check_rosenberg.c +++ b/check_rosenberg.c @@ -239,12 +239,8 @@ out: return printed; } -static void match_copy_to_user(const char *fn, struct expression *expr, void *_arg) +static void check_was_initialized(struct expression *data) { - int arg = PTR_INT(_arg); - struct expression *data; - - data = get_argument_from_call_expr(expr->args, arg); data = strip_expr(data); if (!data) return; @@ -264,6 +260,15 @@ static void match_copy_to_user(const char *fn, struct expression *expr, void *_a check_members_initialized(data); } +static void match_copy_to_user(const char *fn, struct expression *expr, void *_arg) +{ + int arg = PTR_INT(_arg); + struct expression *data; + + data = get_argument_from_call_expr(expr->args, arg); + check_was_initialized(data); +} + static void db_param_cleared(struct expression *expr, int param, char *key, char *value) { while (expr->type == EXPR_ASSIGNMENT) -- 2.11.4.GIT