From a29a9d1426a7611ef568336a54a23520a650de82 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Fri, 15 Jul 2016 13:24:17 +0300 Subject: [PATCH] comparison: add a FIXME regarding a bug I noticed I noticed a bug when I went to commit this... :/ Signed-off-by: Dan Carpenter --- smatch_comparison.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/smatch_comparison.c b/smatch_comparison.c index 310f2844..b6e58c37 100644 --- a/smatch_comparison.c +++ b/smatch_comparison.c @@ -1843,6 +1843,12 @@ static void print_return_comparison(int return_id, char *return_ranges, struct e continue; snprintf(right_buf, sizeof(right_buf), "$%d%s", right_param, tmp_name + 1); + /* + * FIXME: this should reject $ type variables (as + * opposed to $->foo type). Those should come from + * smatch_param_compare_limit.c. + */ + snprintf(info_buf, sizeof(info_buf), "%s %s", show_special(data->comparison), right_buf); sql_insert_return_states(return_id, return_ranges, PARAM_COMPARE, left_param, left_buf, info_buf); -- 2.11.4.GIT