From 729902a182c8ffae448ea0d6b457d0dfae598ad2 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Tue, 21 Jan 2014 14:26:50 +0300 Subject: [PATCH] helper: NULL dereference in get_member_name() Just add a check to prevent the NULL dereference. I'm not sure exactly why it happens. It's rare. Signed-off-by: Dan Carpenter --- smatch_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/smatch_helper.c b/smatch_helper.c index c7b58b00..c9e6fbce 100644 --- a/smatch_helper.c +++ b/smatch_helper.c @@ -511,7 +511,7 @@ char *get_member_name(struct expression *expr) } END_FOR_EACH_PTR_REVERSE(tmp); return NULL; } - if (!sym->ident) + if (!sym->ident || !expr->member) return NULL; snprintf(buf, sizeof(buf), "(struct %s)->%s", sym->ident->name, expr->member->name); return alloc_string(buf); -- 2.11.4.GIT