2 * sparse/check_locking.c
4 * Copyright (C) 2009 Dan Carpenter.
6 * Licensed under the Open Software License version 1.1
11 * This test checks that locks are held the same across all returns.
13 * Of course, some functions are designed to only hold the locks on success.
14 * Oh well... We can rewrite it later if we want.
19 #include "smatch_slist.h"
21 static const char *lock_funcs
[] = {
27 "_spin_lock_irqsave_nested",
34 "_write_lock_irqsave",
43 static const char *unlock_funcs
[] = {
45 "_spin_unlock_irqrestore",
50 "_read_unlock_irqrestore",
54 "_write_unlock_irqrestore",
62 /* These are return 1 if they aquire the lock */
63 static const char *conditional_funcs
[] = {
68 "generic__raw_read_trylock",
74 "__raw_write_trylock",
75 "__raw_write_trylock",
80 /* These functions return 0 on success and negative on failure */
81 static const char *reverse_cond_funcs
[] = {
84 "mutex_lock_interruptible",
85 "mutex_lock_interruptible_nested",
86 "mutex_lock_killable",
87 "mutex_lock_killable_nested",
91 /* todo still need to handle__raw_spin_is_locked */
98 static struct locked_call lock_needed
[] = {
99 {"tty_ldisc_ref_wait", "tty_ldisc_lock"},
104 static struct tracker_list
*starts_locked
;
105 static struct tracker_list
*starts_unlocked
;
107 struct locks_on_return
{
109 struct tracker_list
*locked
;
110 struct tracker_list
*unlocked
;
112 DECLARE_PTR_LIST(return_list
, struct locks_on_return
);
113 static struct return_list
*all_returns
;
119 static struct smatch_state
*get_start_state(struct sm_state
*sm
)
124 if (in_tracker_list(starts_locked
, sm
->name
, my_id
, sm
->sym
))
126 if (in_tracker_list(starts_unlocked
, sm
->name
, my_id
, sm
->sym
))
128 if (is_locked
&& is_unlocked
)
137 static struct smatch_state
*unmatched_state(struct sm_state
*sm
)
142 static char *get_lock_name(struct expression
*expr
, void *data
)
144 struct expression
*lock_expr
;
147 return alloc_string((char *)data
);
149 lock_expr
= get_argument_from_call_expr(expr
->args
, 0);
150 return get_variable_from_expr(lock_expr
, NULL
);
154 static void match_lock_func(const char *fn
, struct expression
*expr
, void *data
)
159 lock_name
= get_lock_name(expr
, data
);
162 sm
= get_sm_state(lock_name
, my_id
, NULL
);
164 add_tracker(&starts_unlocked
, lock_name
, my_id
, NULL
);
165 if (sm
&& slist_has_state(sm
->possible
, &locked
))
166 smatch_msg("error: double lock '%s'", lock_name
);
167 set_state(lock_name
, my_id
, NULL
, &locked
);
168 free_string(lock_name
);
171 static void match_unlock_func(const char *fn
, struct expression
*expr
,
177 lock_name
= get_lock_name(expr
, data
);
180 sm
= get_sm_state(lock_name
, my_id
, NULL
);
182 add_tracker(&starts_locked
, lock_name
, my_id
, NULL
);
183 if (sm
&& slist_has_state(sm
->possible
, &unlocked
))
184 smatch_msg("error: double unlock '%s'", lock_name
);
185 set_state(lock_name
, my_id
, NULL
, &unlocked
);
186 free_string(lock_name
);
189 static void match_lock_failed(const char *fn
, struct expression
*expr
, void *data
)
194 lock_name
= get_lock_name(expr
, data
);
197 sm
= get_sm_state(lock_name
, my_id
, NULL
);
199 add_tracker(&starts_unlocked
, lock_name
, my_id
, NULL
);
200 set_state(lock_name
, my_id
, NULL
, &unlocked
);
201 free_string(lock_name
);
204 static void match_lock_aquired(const char *fn
, struct expression
*expr
, void *data
)
209 lock_name
= get_lock_name(expr
, data
);
212 sm
= get_sm_state(lock_name
, my_id
, NULL
);
214 add_tracker(&starts_unlocked
, lock_name
, my_id
, NULL
);
215 if (sm
&& slist_has_state(sm
->possible
, &locked
))
216 smatch_msg("error: double lock '%s'", lock_name
);
217 set_state(lock_name
, my_id
, NULL
, &locked
);
218 free_string(lock_name
);
221 static void match_lock_needed(const char *fn
, struct expression
*expr
,
224 struct smatch_state
*state
;
227 state
= get_state((char *)data
, my_id
, NULL
);
228 if (state
== &locked
)
230 fn_name
= get_variable_from_expr(expr
->fn
, NULL
);
232 smatch_msg("Internal error.");
235 smatch_msg("error: %s called without holding '%s' lock", fn_name
,
237 free_string(fn_name
);
240 static void match_locks_on_non_zero(const char *fn
, struct expression
*expr
,
246 lock_name
= get_lock_name(expr
, data
);
249 sm
= get_sm_state(lock_name
, my_id
, NULL
);
251 add_tracker(&starts_unlocked
, lock_name
, my_id
, NULL
);
252 set_true_false_states(lock_name
, my_id
, NULL
, &locked
, &unlocked
);
253 free_string(lock_name
);
256 static struct locks_on_return
*alloc_return(int line
)
258 struct locks_on_return
*ret
;
260 ret
= malloc(sizeof(*ret
));
263 ret
->unlocked
= NULL
;
267 static void check_possible(struct sm_state
*sm
)
269 struct sm_state
*tmp
;
274 FOR_EACH_PTR(sm
->possible
, tmp
) {
275 if (tmp
->state
== &locked
)
277 if (tmp
->state
== &unlocked
)
279 if (tmp
->state
== &start_state
) {
280 struct smatch_state
*s
;
282 s
= get_start_state(tmp
);
285 else if (s
== &unlocked
)
290 if (tmp
->state
== &undefined
)
291 undef
= 1; // i don't think this is possible any more.
292 } END_FOR_EACH_PTR(tmp
);
293 if ((islocked
&& isunlocked
) || undef
)
294 smatch_msg("warn: '%s' is sometimes locked here and "
295 "sometimes unlocked.", sm
->name
);
298 static void match_return(struct statement
*stmt
)
300 struct locks_on_return
*ret
;
301 struct state_list
*slist
;
302 struct sm_state
*tmp
;
304 ret
= alloc_return(get_lineno());
306 slist
= get_all_states(my_id
);
307 FOR_EACH_PTR(slist
, tmp
) {
308 if (tmp
->state
== &locked
) {
309 add_tracker(&ret
->locked
, tmp
->name
, tmp
->owner
,
311 } else if (tmp
->state
== &unlocked
) {
312 add_tracker(&ret
->unlocked
, tmp
->name
, tmp
->owner
,
314 } else if (tmp
->state
== &start_state
) {
315 struct smatch_state
*s
;
317 s
= get_start_state(tmp
);
319 add_tracker(&ret
->locked
, tmp
->name
, tmp
->owner
,
322 add_tracker(&ret
->unlocked
, tmp
->name
,
323 tmp
->owner
, tmp
->sym
);
327 } END_FOR_EACH_PTR(tmp
);
329 add_ptr_list(&all_returns
, ret
);
332 static void print_inconsistent_returns(struct tracker
*lock
,
333 struct smatch_state
*start
)
335 struct locks_on_return
*tmp
;
338 printf("%s +%d %s(%d) ", get_filename(), get_lineno(), get_function(), get_func_pos());
339 printf("warn: inconsistent returns %s:", lock
->name
);
342 FOR_EACH_PTR(all_returns
, tmp
) {
343 if (in_tracker_list(tmp
->unlocked
, lock
->name
, lock
->owner
, lock
->sym
))
345 if (in_tracker_list(tmp
->locked
, lock
->name
, lock
->owner
, lock
->sym
)) {
348 printf("%d", tmp
->line
);
351 if (start
== &locked
) {
354 printf("%d", tmp
->line
);
356 } END_FOR_EACH_PTR(tmp
);
358 printf(") unlocked (");
360 FOR_EACH_PTR(all_returns
, tmp
) {
361 if (in_tracker_list(tmp
->unlocked
, lock
->name
, lock
->owner
, lock
->sym
)) {
364 printf("%d", tmp
->line
);
367 if (in_tracker_list(tmp
->locked
, lock
->name
, lock
->owner
, lock
->sym
)) {
370 if (start
== &unlocked
) {
373 printf("%d", tmp
->line
);
375 } END_FOR_EACH_PTR(tmp
);
379 static void check_returns_consistently(struct tracker
*lock
,
380 struct smatch_state
*start
)
382 int returns_locked
= 0;
383 int returns_unlocked
= 0;
384 struct locks_on_return
*tmp
;
386 FOR_EACH_PTR(all_returns
, tmp
) {
387 if (in_tracker_list(tmp
->unlocked
, lock
->name
, lock
->owner
,
389 returns_unlocked
= tmp
->line
;
390 else if (in_tracker_list(tmp
->locked
, lock
->name
, lock
->owner
,
392 returns_locked
= tmp
->line
;
393 else if (start
== &locked
)
394 returns_locked
= tmp
->line
;
395 else if (start
== &unlocked
)
396 returns_unlocked
= tmp
->line
;
397 } END_FOR_EACH_PTR(tmp
);
399 if (returns_locked
&& returns_unlocked
)
400 print_inconsistent_returns(lock
, start
);
403 static void check_consistency(struct symbol
*sym
)
410 FOR_EACH_PTR(starts_locked
, tmp
) {
411 if (in_tracker_list(starts_unlocked
, tmp
->name
, tmp
->owner
,
413 smatch_msg("error: locking inconsistency. We assume "
414 "'%s' is both locked and unlocked at the "
417 } END_FOR_EACH_PTR(tmp
);
419 FOR_EACH_PTR(starts_locked
, tmp
) {
420 check_returns_consistently(tmp
, &locked
);
421 } END_FOR_EACH_PTR(tmp
);
423 FOR_EACH_PTR(starts_unlocked
, tmp
) {
424 check_returns_consistently(tmp
, &unlocked
);
425 } END_FOR_EACH_PTR(tmp
);
429 static void clear_lists(void)
431 struct locks_on_return
*tmp
;
433 free_trackers_and_list(&starts_locked
);
434 free_trackers_and_list(&starts_unlocked
);
436 FOR_EACH_PTR(all_returns
, tmp
) {
437 free_trackers_and_list(&tmp
->locked
);
438 free_trackers_and_list(&tmp
->unlocked
);
440 } END_FOR_EACH_PTR(tmp
);
441 __free_ptr_list((struct ptr_list
**)&all_returns
);
444 static void match_func_end(struct symbol
*sym
)
446 check_consistency(sym
);
450 void check_locking(int id
)
455 add_unmatched_state_hook(my_id
, &unmatched_state
);
456 add_hook(&match_return
, RETURN_HOOK
);
457 add_hook(&match_func_end
, END_FUNC_HOOK
);
459 for (i
= 0; lock_funcs
[i
]; i
++) {
460 add_function_hook(lock_funcs
[i
], &match_lock_func
, NULL
);
462 add_function_hook("lock_kernel", &match_lock_func
, (void *)"kernel");
463 for (i
= 0; unlock_funcs
[i
]; i
++) {
464 add_function_hook(unlock_funcs
[i
], &match_unlock_func
, NULL
);
466 add_function_hook("unlock_kernel", &match_unlock_func
, (void *)"kernel");
467 for (i
= 0; i
< sizeof(lock_needed
)/sizeof(struct locked_call
); i
++) {
468 add_function_hook(lock_needed
[i
].function
, &match_lock_needed
,
469 (void *)lock_needed
[i
].lock
);
472 for (i
= 0; conditional_funcs
[i
]; i
++) {
473 add_conditional_hook(conditional_funcs
[i
],
474 &match_locks_on_non_zero
, NULL
);
477 for (i
= 0; reverse_cond_funcs
[i
]; i
++) {
478 return_implies_state(reverse_cond_funcs
[i
], whole_range
.min
, -1,
479 &match_lock_failed
, NULL
);
480 return_implies_state(reverse_cond_funcs
[i
], 0, 0,
481 &match_lock_aquired
, NULL
);