From eb770f35d837c7b6bc5e1bf40b5762a3afd172c3 Mon Sep 17 00:00:00 2001 From: Stefan Becker Date: Mon, 4 Feb 2013 10:35:06 +0200 Subject: [PATCH] Fix #3603228: Crash on 1.14.1 when connecting to server Add NULL-pointer checks in process_get_av_edge_credentials_response(). --- src/core/sipe-media.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/core/sipe-media.c b/src/core/sipe-media.c index d1ab7785..213ea7fb 100644 --- a/src/core/sipe-media.c +++ b/src/core/sipe-media.c @@ -1287,12 +1287,16 @@ process_get_av_edge_credentials_response(struct sipe_core_private *sipe_private, relay->hostname = sipe_xml_data(node); node = sipe_xml_child(item, "udpPort"); - relay->udp_port = atoi(tmp = sipe_xml_data(node)); - g_free(tmp); + if (node) { + relay->udp_port = atoi(tmp = sipe_xml_data(node)); + g_free(tmp); + } node = sipe_xml_child(item, "tcpPort"); - relay->tcp_port = atoi(tmp = sipe_xml_data(node)); - g_free(tmp); + if (node) { + relay->tcp_port = atoi(tmp = sipe_xml_data(node)); + g_free(tmp); + } relays = g_slist_append(relays, relay); -- 2.11.4.GIT