From d2e2477fc29b89e49e0fa4aae1cc512f48d12a10 Mon Sep 17 00:00:00 2001 From: Stefan Becker Date: Thu, 4 Jun 2009 08:08:23 +0300 Subject: [PATCH] Fix double free and potential memory leak in previous commit --- src/sipe.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/sipe.c b/src/sipe.c index 2bfc53b3..dc850fc7 100755 --- a/src/sipe.c +++ b/src/sipe.c @@ -3056,7 +3056,6 @@ static void process_incoming_invite(struct sipe_account_data *sip, struct sipmsg newHeader = g_strdup_printf("%s;tag=%s", oldHeader, newTag); sipmsg_remove_header(msg, "To"); sipmsg_add_header(msg, "To", newHeader); - g_free(oldHeader); g_free(newHeader); from = parse_from(sipmsg_find_header(msg, "From")); @@ -3075,11 +3074,15 @@ static void process_incoming_invite(struct sipe_account_data *sip, struct sipmsg //session->dialog->theirtag = find_tag(sipmsg_find_header(msg, "From")); //session->dialog->theirepid = sipmsg_find_part_of_header(sipmsg_find_header(msg, "From"), "epid=", NULL, NULL); - if (!(session->dialog->ourtag)) { session->dialog->ourtag = newTag; } + if (!session->dialog->ourtag) { + session->dialog->ourtag = newTag; + newTag = NULL; + } } } else { purple_debug_info("sipe", "process_incoming_invite, failed to find or create IM session\n"); } + g_free(newTag); //ms-text-format: text/plain; charset=UTF-8;msgr=WAAtAE0...DIADQAKAA0ACgA;ms-body=SGk= ms_text_format = sipmsg_find_header(msg, "ms-text-format"); -- 2.11.4.GIT