| commit | d168c8b57033d695e1eca20bc97b89977ca06f47 | |
| author | pier11 <pier11@kinozal.tv> | |
| Mon, 20 Jul 2009 10:09:55 +0000 (20 11:09 +0100) | ||
| committer | pier11 <pier11@kinozal.tv> | |
| Mon, 20 Jul 2009 10:09:55 +0000 (20 11:09 +0100) | ||
| tree | f8ce6e5fb42ea6a8c65dcfdaa25a32d111ec354e | treesnapshot (tar.gz zip) |
| parent | 45bb84e56dcc0470166aec1e20d23125b327f911 | commitdiff |
fixed stealth bug when action payload got freed
behind the scene. This behaviour is not always needed.
Now it is turned on only if destroy function is provided explicitly.
Even g_free.
Initial bug was that contact can not be removed as the procedure could not
find buddy in sip->buddies. Because hashtable keys were freed by destroy
function of scheduled action. Which in turn was scheduled with the key ref as payload.
It could be fixed by copying the key string, but pieces exist when payload is
entire session. It does not make sense to copy it, neither free it after.
behind the scene. This behaviour is not always needed.
Now it is turned on only if destroy function is provided explicitly.
Even g_free.
Initial bug was that contact can not be removed as the procedure could not
find buddy in sip->buddies. Because hashtable keys were freed by destroy
function of scheduled action. Which in turn was scheduled with the key ref as payload.
It could be fixed by copying the key string, but pieces exist when payload is
entire session. It does not make sense to copy it, neither free it after.
| src/sipe.c | diffblobblamehistory |